Commit Graph

9837 Commits

Author SHA1 Message Date
tim peng
57d730d6a2 Merge "Tapping on Play media can have up to a 1 minute delay" into rvc-dev am: 765b71b9e8 am: 7e20068916 am: cbc6848340 am: 4431af9316
Change-Id: Id15a5b44913dc070c9924d09cc742e416224fa26
2020-04-14 04:30:31 +00:00
tim peng
0776ae9642 Merge "Output switcher subtitle modification" into rvc-dev am: 2c9d412ba2 am: 3d75454911 am: 2105141fe8 am: 7b33d011e1
Change-Id: Ie1813961b78ae310608984753943bc035e3c9636
2020-04-14 03:27:32 +00:00
tim peng
765b71b9e8 Merge "Tapping on Play media can have up to a 1 minute delay" into rvc-dev 2020-04-14 03:10:16 +00:00
tim peng
2c9d412ba2 Merge "Output switcher subtitle modification" into rvc-dev 2020-04-14 01:56:06 +00:00
TreeHugger Robot
6a8435f520 Merge "[Wi-Fi] Fix NetworkRequestErrorDialogFragment exception when rotation" into rvc-dev am: dccb008642 am: e75fc6dfd0 am: 01db83e657 am: cf86f89fa7
Change-Id: I5f82a3545dba7d88325e0036e68e71beb7a2f260
2020-04-13 13:54:29 +00:00
TreeHugger Robot
dccb008642 Merge "[Wi-Fi] Fix NetworkRequestErrorDialogFragment exception when rotation" into rvc-dev 2020-04-13 12:21:54 +00:00
Tim Peng
eb0531f0df Output switcher subtitle modification
-Change from null to "Switch output"
-Update test case

Bug: 153834179
Test: make -j42 RunSettingsRoboTests
Change-Id: I184e78292e982f8a93b74612331a1d2cab28d07a
2020-04-13 11:49:18 +00:00
TreeHugger Robot
385f660e36 Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev am: 678529b68b am: 2344d9540f am: 7f3fbd7733 am: 786aa6b3e8
Change-Id: Ie7f836576b5fcb0d6c09e86b4d44abddc2256ace
2020-04-13 09:30:29 +00:00
TreeHugger Robot
678529b68b Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev 2020-04-13 07:57:28 +00:00
Arc Wang
4601d62089 [Wi-Fi] Fix NetworkRequestErrorDialogFragment exception when rotation
When rotating an androidx fragment, it uses default constructor
to instantiate the new fragment instance. Every androidx fragment
should not set private scope to it's default constructor.

Bug: 153824549
Test: make RunSettingsRoboTests ROBOTEST_FILTER=NetworkRequestErrorDialogFragmentTest
Change-Id: Ie1be0e033aa85d37cb4d85193b05beab72d4d8e7
2020-04-13 14:59:49 +08:00
Tim Peng
cfd862db37 Tapping on Play media can have up to a 1 minute delay
-Set Output Switcher activity in PendingIntent
-Broadcast is super lagged right after reboot
-Not to send broadcast to itself in order to launch Output Switcher
-Add test case

Bug: 152909957
Test: make -j42 RunSettingsRoboTests
Change-Id: I17280a3bb9e47aa6050cfaf1463c780cd9849ad7
2020-04-13 14:44:53 +08:00
TreeHugger Robot
f044ae9bce Merge "Fix NFC UI is not available when switching to 2nd user" into rvc-dev am: c56bcb5e7f am: a287641adf am: b4b63b60b9 am: 83646cd7fc
Change-Id: If1cb9c424658b44ad5f3ddf2e56730973de3ee12
2020-04-13 03:58:44 +00:00
Robert Luo
afb01f12cd Fix NFC UI is not available when switching to 2nd user
Bug: 152581438
Test: (1) make -j42 RunSettingsRoboTests (2) check NFC UI and function work as 2nd user
Change-Id: Ibf0346b992406c1d6329580083c1cd49180376cf
2020-04-12 15:27:18 +08:00
Joshua Duong
0f3eba36f2 [adbwifi] Add qstile for wireless debugging.
Bug: 153275926

Test: make RunSettingsRoboTests ROBOTEST_FILTER=WirelessDebuggingTest
Change-Id: I6b381a7e29beec5c9c345b374e127caabdb674db
(cherry picked from commit 0c23d39f94)
Exempt-From-Owner-Approval: cherry-pick
2020-04-10 19:12:40 +00:00
Bonian Chen
bafd78f16b Merge "[Settings] Avoid rename inactive subscription from NullPointerException" into rvc-dev am: e18904daab am: b72aa1c03a am: 5a45c3ff77 am: cddf1f341b
Change-Id: I4bfced32a89efbd085c55c5cdb139c2d53838f5b
2020-04-10 14:05:43 +00:00
Yanting Yang
b7e1ececea Fix breadcrumb of search results provided by Settings
1. Settings Search need Settings to provide custom site map pairs to
build up full breadcrumb for the search results from below pages.
- PowerUsageAdvanced
- RecentLocationRequestSeeAllFragment
- UsbDetailsFragment
- UserBackupSettingsActivity

2. Update the screen title of Backup raw index data from Settings to
Backup to display correct breadcrumb in Settings Search.

Bug: 147851992
Bug: 151206664
Fixes: 152368059
Test: visual and robotests
Change-Id: Iaebab8d549bba6be7623708f9833349654e7f2a7
2020-04-10 20:56:39 +08:00
Bonian Chen
cad93df0a4 [Settings] Avoid rename inactive subscription from NullPointerException
1. Init instance before accessing it
2. Re-enable test case

Bug: 147321836
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=RenameMobileNetworkDialogFragmentTest
Change-Id: Ifc245bec739b4c81d2cee04b091bcdb54d567d4a
(cherry picked from commit 1b71b5e601)
2020-04-10 18:05:17 +08:00
TreeHugger Robot
299d1afb5b Merge "[adbwifi] Add qstile for wireless debugging." 2020-04-10 09:03:01 +00:00
Joshua Duong
0c23d39f94 [adbwifi] Add qstile for wireless debugging.
Bug: 153275926

Test: make RunSettingsRoboTests ROBOTEST_FILTER=WirelessDebuggingTest
Change-Id: I6b381a7e29beec5c9c345b374e127caabdb674db
2020-04-09 22:06:31 -07:00
Fabian Kozynski
0ba807a267 Merge "Added settings screens for Power Menu" into rvc-dev am: 4d02f7b2e2 am: 03fcf4849a am: 553666ff75 am: b86716bf98
Change-Id: I6b492d6c196bb55d1a716131580568c31c8c51c7
2020-04-09 18:12:14 +00:00
Oscar Shu
ce32ed2e5b Merge "Add dev option for enhanced mac randomization" into rvc-dev am: a6eedbf350 am: b210bd43fc am: 92a71c6591 am: 821b8f2240
Change-Id: I098f898e94f23f53c10be02ec2b7619a1c425be8
2020-04-09 18:10:05 +00:00
Fabian Kozynski
4d02f7b2e2 Merge "Added settings screens for Power Menu" into rvc-dev 2020-04-09 17:58:44 +00:00
Oscar Shu
a6eedbf350 Merge "Add dev option for enhanced mac randomization" into rvc-dev 2020-04-09 17:50:58 +00:00
Minche Li
3dfc187e33 Merge "Applies magnification capability settings key" 2020-04-09 04:37:41 +00:00
mincheli
c419cc6804 Applies magnification capability settings key
Bug: 144327603
Test: make RunSettingsRoboTests
Change-Id: I45cfc9ce646c8d0c9aaaeaa1cb073fb2ae1ec3de
2020-04-09 01:25:26 +00:00
Goven Liu
c8cc5d0bbe Merge "[Wi-Fi] Use getUriHelpString() result to judge if Settings APP should register the help button click event and file related intent if need." into rvc-dev am: 5a8e9e452a am: e5153b50f6 am: 67f7f28b2b am: 46b44a95c7
Change-Id: Ib7291dd2b494b9426fd60c446d9f3162628268d5
2020-04-08 23:23:39 +00:00
Goven Liu
5a8e9e452a Merge "[Wi-Fi] Use getUriHelpString() result to judge if Settings APP should register the help button click event and file related intent if need." into rvc-dev 2020-04-08 22:37:35 +00:00
TreeHugger Robot
d2774334aa Merge "Update display logic for no shared data." into rvc-dev am: e886ef9e9a am: b0171b6a58 am: b7c70e141a am: 3803f40c26
Change-Id: If8e743b89bcfee32ab087fd0a0514aa7afe17c19
2020-04-08 16:07:22 +00:00
TreeHugger Robot
e886ef9e9a Merge "Update display logic for no shared data." into rvc-dev 2020-04-08 15:11:37 +00:00
Bonian Chen
f1b3461c3e Merge "[Settings] Code refactor" into rvc-dev am: c1b20e631a am: 18997b6dae am: 2bf2b760dc am: 36fe9c2169
Change-Id: Ibb047e96a4396c9140937d879e96a3d7123b6e5b
2020-04-08 12:59:59 +00:00
Bonian Chen
c1b20e631a Merge "[Settings] Code refactor" into rvc-dev 2020-04-08 12:12:04 +00:00
TreeHugger Robot
acf8fc5939 Merge "[Wi-Fi] Fix TalkBack focus lost in SavedAccessPointsWifiSettings2" into rvc-dev am: 1e49ff8ba7 am: 800cc2c277 am: 506a2394d0 am: 4621014df5
Change-Id: I58a4484659736ed5541ee26fc7fc794436c590e3
2020-04-08 08:17:51 +00:00
TreeHugger Robot
1e49ff8ba7 Merge "[Wi-Fi] Fix TalkBack focus lost in SavedAccessPointsWifiSettings2" into rvc-dev 2020-04-08 07:23:53 +00:00
Bonian Chen
6ce37e3f53 [Settings] Code refactor
Remove unused inport and adjust the import sequence.

Bug: 150352656
Test: build pass
Change-Id: Ifd1e37e56d0b0ae1d5b31723b8545ae95e707a66
2020-04-08 14:26:46 +08:00
govenliu
a82d2c8a88 [Wi-Fi] Use getUriHelpString() result to judge if Settings APP should register the help button click event and file related intent if need.
The Openroaming help button should show only when the getHelpUriString() value is not null, and need to handle the click event in Settings APP.

Bug: 146669261
Test: Adjust unit test cases:
      1. make RunSettingsRoboTests ROBOTEST_FILTER=WifiEntryPreferenceTest
      2. make RunSettingsRoboTests ROBOTEST_FILTER=WifiSettings2Test
Change-Id: I27a717c3014b01cc464908bac56f64bd08aa5da3
2020-04-08 13:41:15 +08:00
tim peng
e1c7ec38a9 Merge "Settings crashed by a null worker" into rvc-dev am: e189ac522e am: 3ffe34a48b am: 91c389b9a2 am: 100703a82b
Change-Id: Iac371239bf42a390ab76143bbbc6765a0d9bf03c
2020-04-08 04:24:40 +00:00
tim peng
60aa5b2569 Merge "Transferring to a cast device should not close the output switcher" into rvc-dev am: f1f7b861d9 am: f8d7c09e36 am: 38315ae8af am: 4aa0d4d13a
Change-Id: I660e65161451a83241c9d67d66ff7dc626860194
2020-04-08 04:24:20 +00:00
Arc Wang
067757f8d9 [Wi-Fi] Fix TalkBack focus lost in SavedAccessPointsWifiSettings2
PreferenceGroup in a controller is not in a RecyclerView,
TalkBack loses focus after PreferenceGroup#removeAll.

To fix it, only add/remove the preference if it's necessary.

Bug: 153278854
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SavedAccessPointsPreferenceController2Test
Change-Id: Ie9ad5481c33865dce2b7db04d0f969b1f49b80e1
2020-04-08 11:58:27 +08:00
tim peng
e189ac522e Merge "Settings crashed by a null worker" into rvc-dev 2020-04-08 03:18:31 +00:00
tim peng
f1f7b861d9 Merge "Transferring to a cast device should not close the output switcher" into rvc-dev 2020-04-08 03:18:09 +00:00
Tim Peng
6fb4059944 Transferring to a cast device should not close the output switcher
-Close panel only when on pause and stop
-Transfer device would set the play state to "STATE_NONE"
-Add test case

Bug: 152632226
Test: make -j42 RunSettingsRoboTests
Change-Id: Ibf6ce1454b1d5bf3facc07abec15b8735029f2cf
2020-04-07 08:02:30 +00:00
Tim Peng
2f87c336da Settings crashed by a null worker
-Add worker checker
-Add test case

Bug: 153356562
Test: make -j42 RunSettingsRoboTests
Change-Id: I129ff63a48b3785aacc846fe1dd67a926a8e5e1f
2020-04-07 07:48:38 +00:00
Jason Chiu
191ed35ee6 Merge "Refine metrics log in infrastructure" into rvc-dev am: 4edb83b260 am: 664adc4691 am: 33f64102b4 am: 6d921190fd
Change-Id: I40b519f1950f5053bade9df2b2daa44291ac4863
2020-04-07 07:27:18 +00:00
Jason Chiu
4edb83b260 Merge "Refine metrics log in infrastructure" into rvc-dev 2020-04-07 06:33:30 +00:00
Jason Chiu
819abf7f87 Refine metrics log in infrastructure
- Add interfaces to set/get metrics category in BasePreferenceController
  for descendants having a chance to get it.
- Set metrics category in DashboardFragment
- Automatically log metrics in onPreferenceChange of
  TogglePreferenceController
- Add support for TwoStateButtonPreference in TogglePreferenceController
  to make the preference generic

Bug: 137559984
Test: robotest
Change-Id: Ia7e0d24a3db1991b18e0286d9894570fa71247a3
2020-04-07 14:08:39 +08:00
Automerger Merge Worker
2e4a95b227 Merge "Merge "Add a developer setting for conversation enforcement" into rvc-dev am: 76b55e0b0a am: 7008d7a192" into rvc-d1-dev-plus-aosp am: 875b001eb3 am: 88171420fe
Change-Id: I8ba0367c9bc155e9968d31440df2d29731d88c1f
2020-04-07 04:48:36 +00:00
Zhen Zhang
dfed682e47 Fix advanced preferences behavior in AllInOneTetherSettings am: b1d19a8b35 am: 0ea7803c18 am: 8e541c6272 am: 77f2676d44
Change-Id: I31ac25ad4dd95ee19904c628b79811a9d87ec871
2020-04-07 04:40:53 +00:00
Varun Shah
2aeedcde21 Update display logic for no shared data.
When there is no shared data, instead of showing an empty list view,
the developer option's summary is updated.

Additionally, for the two shared data screens, added the back button to
the action bar so that it matches the other screens in the Settings app.

Also, implemented PreferenceControllerMixin for the
SharedDataPreferenceController so that the dev option shows up in
settings search.

Bug: 153079829
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: I6ec5c35fc262dc27a383af8e2593be5b349ee85f
2020-04-06 20:58:11 -07:00
TreeHugger Robot
76b55e0b0a Merge "Add a developer setting for conversation enforcement" into rvc-dev 2020-04-07 03:47:02 +00:00
Zhen Zhang
b1d19a8b35 Fix advanced preferences behavior in AllInOneTetherSettings
In AllInOneTetherSettings, advanced preferences should not be hidden
again after user have expanded them.

Bug: 151954343
Test: CodeInspectionTest; AllInOneTetherSettingsTest; manually test oberved advanced preferences won't be hidden.
Change-Id: If2c7d99b7dcac4149f065eca73022a582924c90b
2020-04-06 19:14:41 +00:00