The root cause of crash bug #27749932 is that the state mismatch between
when a Loader is created and when the Loader object finishes background
task. We can easily reproduce this crash by:
1. Pair two hardware keyboard A and B.
2. Open Physical Keyboard settings.
3. Press the power button to turn off the display.
4. Move keyboard A far away so that it is unpaired.
5. Press the power button to turn on the display.
6. Unlock the device.
One of the reasons PhysicalKeyboardFragment was unstable is that loader
ID reuse. PhysicalKeyboardFragment starts background data loading
because of many events such as #onResume() and #onInputDeviceAdded() but
there are chances that loader ID was reused because we specified
hardware keyboard device index as the loader ID. This was dangerous
also because device index can change when a device is added and removed.
With his CL each loader object has an unique ID and
PhysicalKeyboardFragment keeps tracking the list of active Loader IDs
only from which PhysicalKeyboardFragment should accept data.
Also, this CL removes dependencies on PhysicalKeyboardFragment from each
loader object so that we can have a clear boundary of responsibility
between data loader and data consumer.
Bug: 27749932
Change-Id: I53fcb2426d028a492c775bb2b4ec6a5419e33bb4
When RTL language is set, the edit-photo popup window
on user profile info is not shown fully.
The popup window should be aligned with the anchor.
Bug: 27955356
Change-Id: Ic9b9eb935e1a88800b008bcf0157b40a49502206
InputMethodAndSubtypeUtil#saveInputMethodSubtypeList() has a bug that
it saves implicitly enabled subtypes when "Use system languages" is
checked. Implicitly enabled subtypes are transient data and the system
should have only a null data (0) in the persistent strage. The root
cause of this bug is that the method in question has not checked whether
the preference item is in enabled (not grayed-out). If it is
grayed-out, its checked state does not mean that the user manually
checked that subtype but it is just an indicator for the user.
The strange UI jank when dismissing InputMethodAndSubtypeEnabler is one
of the victim of the above bug because we have worked around it by
actually changing checked state before calling the method in question.
With this CL we no longer need to update preference items in
InputMethodAndSubtypeEnabler#onPause().
Bug: 27867966
Change-Id: Ifc291d77ea41a988438765b9ba16bc5d18a15e1b
am: a2dda41
* commit 'a2dda4122bb73f49fcd118a712c1aa61a303c11b':
Fixes graybar as status bar and unshifts header view.
Change-Id: I29cc18ed77ea763385a9a96281da302d4d6c0185
am: e20deea
* commit 'e20deea7112a17ac4799f6924cddc27b4678f791':
Prevents users from being added if device is not provisioned
Change-Id: Ieb663a2741bce75cd9cebed08f36801a36958e83
All settings preferences related to credentials of any kind should be
stopped by this user restriction.
Bug: 26879958
Change-Id: I983c6e58081bd4022bb006942499cba4b74954e7
am: 6d6ea3f
* commit '6d6ea3fe0a9aae6159b3eda197cd1d660135c413':
Use same task for Settings>Users and EmergencyInfo
Change-Id: Ifc596101c4392bb76f2d6038c364560ebc42fefa
am: b1d7142
* commit 'b1d7142cb21de23ec9c1dddb824405bf252bffed':
Show notification when failing to turn on always-on vpn
Change-Id: I76c5ad7c545294edfeb533148ba85cdcdc41dc58
am: 69446e8
* commit '69446e80ab95f7d01b7612a02ae35e75d9b5c609':
Fix categeries being read out on settings dashboard
Change-Id: Ifd3c3ad560969b58557acd86a98eb299d65a4385
am: 04f10a5
* commit '04f10a5eb53bb1ed3d70574102b94b17e075132d':
Fix cell data preference in single sim case
Change-Id: I08d74e06819a2d0487149af5bfa40a6124b3100c
- Notification icon is Settings icon
- VpnName is obtained as the same way as AppPreference
- Post notification as the current user with PendingIntent to VpnSettings to parent user
- Auto-cancel when user taps on the notification
- This implementation posts notification only when the failure happens sychronously
(Assume ConnectivityService only unset always-on package immediately after calling setAlwaysOnVpnPackageForUser)
Bug:27374485
Change-Id: I0aee38498c8cc300dd8eb9687adcae5f9dc4f8af
am: 5ffbf2e
* commit '5ffbf2e39d8ce5bb4f1256564fe060534541c710':
Remove gear icon from InputMethodPreference.
Update title to "Add or edit virtual keyboards".
Change-Id: Ideeeb1062a62ed77a7d178c80469effa0c3ade7c
am: ca1abaa
* commit 'ca1abaa9531523d413830f6763963450ba494f8f':
Fix crashing of font size settings screen due to the timing of initialization of ExploreByTouchHelper Bug: 27674946
Change-Id: I885d01786f73ad794e4e1793390f7dd826b695e9
am: 9856531
* commit '9856531b450b6bdc73f0d8f4416661c10d4560ec':
Change the dialog text in USB device tyep chooser.
Change-Id: Ided54b1ce7d00dcdf028b1d0724eae117a0f4f64
StickyHeaderListView will not layout all the way to the top of the screen
if fitsSystemWindows is true.
bug:27875272
Change-Id: I4150dc183778284df2f07f3a6220e0c0b2607774
