Commit Graph

5027 Commits

Author SHA1 Message Date
David Liu
033080b61d Fix toolbar keyboard navigation and touch.
- toolbar default has touchscreenBlocksFocus enabled which make toolbar not focusable when touch screen present. Explicitly set touchscreenBlocksFocus to false make the toolbar can be focus when keyboard navigation.
- Remove focusableInTouchMode which breaks normal touch control. Read https://android-developers.googleblog.com/2008/12/touch-mode.html for more details.

Fix: 327025582
Fix: 324420544
Test: manual test with keyboard and touch navigation

Change-Id: I6cad869e3a51926405a6f3ae894daa5416050bf8
(cherry picked from commit 9b63fbb772)
2024-03-15 06:40:57 +00:00
Chelsea Hao
7eb6df8ee7 Merge "[Audiosharing] Remove audio streams from settings." into main 2024-03-04 02:33:18 +00:00
Shaowei Shen
627d7202fd Merge "[Physical Keyboard Setting] Update layout for one pane land screen" into main 2024-02-29 19:18:31 +00:00
shaoweishen
6c02c6ab25 [Physical Keyboard Setting] Update layout for one pane land screen
If device is one pane and is land orientation, set new layout for it to
match with UX markup, this change will not effect on tablet, which is
two pane setting.

Bug: 325878673
Test: verify on device
Screenshot: https://screenshot.googleplex.com/BkETMhqp9GXM3cc.png
Change-Id: I066c3d782a2de8993a3fe9632676b67c2203d638
2024-02-29 07:31:21 +00:00
Marcus Ge
747d0afa21 Merge changes I69049a13,I7fcc01b8 into main
* changes:
  [Accessibility] Migrate high text contrast under feature flag
  [Accessibility] Add contrast control screen UI and setup entry point
2024-02-28 19:38:27 +00:00
Joseph Vincent
3454f304a2 Merge changes Ic53c42ec,I91e3591c into main
* changes:
  Update illustrations in private space setup and settings
  Change to add temp GAIA education screen and swap account and lock flow
2024-02-28 09:29:00 +00:00
chelseahao
e44cf95424 [Audiosharing] Remove audio streams from settings.
Bug: 324023639
Test: manual
Change-Id: Id1e69422200fdc4b02ac8789ab9370d3ea0448c1
2024-02-28 16:50:45 +08:00
josephpv
0809d4dee7 Update illustrations in private space setup and settings
Recording link : b/326391912#comment3
https://drive.google.com/file/d/1Rykqy8iugvVNiE8uW2tgAlFhAypGxhdN/view?usp=drive_link

Bug: 326391912
Test: Manual
Change-Id: Ic53c42ec87fde4f1b8c38634e1e2927b235ff2a3
2024-02-28 06:47:49 +00:00
josephpv
c1fd5ad1ec Change to add temp GAIA education screen and swap account and lock flow
The change does below things:
- Interchange account and lock setup in PS setup
- After profile creation checks if network is present and starts new
  GAIA education screen
  If network is not present on device skips account login and shows lock setup screen.
- Adds a temp GAIA education screen before starting of account login which can skip to
  lock setup or start account login

Recording link : b/326389818#comment5
Screenshot : go/ss/7qWLUF4WDHFBQzi.png
go/ss/A8EvoCFJwihaTQP.png

Bug: 326389818
Test: Manual
Change-Id: I91e3591c60aae22fc10058fb94dcb624573d2e37
2024-02-28 06:46:49 +00:00
Jason Hsu
429291b70a Merge changes Id1ed4455,I73e62733 into main
* changes:
  Make Preferences more visible with colored rounded rectangle background and an arrow icon
  Provides BackgroundPreference that can set background statically or dynamically
2024-02-28 04:01:06 +00:00
marcusge
cddd7b3660 [Accessibility] Add contrast control screen UI and setup entry point
Bug: 241805782
Test: atest, local raven device
Screenshot: attached on bug
Flag: aconfig
com.android.settings.accessibility.enable_color_contrast_control

Change-Id: I7fcc01b822b460c6585c41a5831575ba0ffbcc93
2024-02-27 23:36:52 +00:00
Yiyi Shen
57e70a7523 Merge "[Audiosharing] Clean up audio sharing from Settings" into main 2024-02-27 03:57:40 +00:00
Joseph Vincent
a6b7dff37b Merge "Change for private space intro screen string changes" into main 2024-02-26 20:24:46 +00:00
josephpv
2a431fe8d9 Change for private space intro screen string changes
This includes below changes based on latest UX mocks
- Changes the strings and icon in the intro screen
- Updates the title in Auto advance screens

Recording link : b/326391690#comment4
Screenshots:
go/ss/9xbZP5Lp8j9yh6m.png
go/ss/pvKMNdgu6yt2Xtr.png

Bug: 326391690
Test: Manual, verify the strings are updated as in Mocks
Change-Id: I714919ac1f3d45fa0007395bd17cfb340874ed5a
2024-02-26 14:26:33 +00:00
Yiyi Shen
dd7626f55b [Audiosharing] Clean up audio sharing from Settings
Bug: 324023639
Test: atest
Change-Id: Ie73790442f39af60b125bbd48182a700bb0b290a
2024-02-26 17:24:53 +08:00
jasonwshsu
d23c2867c6 Make Preferences more visible with colored rounded rectangle background and an arrow icon
Bug: 320709814
Test: atest ArrowPreferenceTest
Change-Id: Id1ed44554010ae0df901cceba2624a1b56661df6
2024-02-26 05:57:11 +00:00
jasonwshsu
6dc0e30b56 Provides BackgroundPreference that can set background statically or dynamically
Bug: 320709814
Test: atest BackgroundPreferenceTest
Change-Id: I73e62733e6afd032ce980a4d6db0f4ca4573e770
2024-02-26 05:56:47 +00:00
Rafael Higuera Silva
be3a609c25 Merge "Add new dialogue when user is going to delete sim that use RAC." into main 2024-02-26 04:09:19 +00:00
Rafael Higuera Silva
736df6d2ef Add new dialogue when user is going to delete sim that use RAC.
Test: make
Bug: 316419093
Change-Id: Iaed54afa7cfd20c1dd6adbd4d50f54cab3da095d
2024-02-23 23:11:56 +00:00
David Liu
55969e59c1 [Two-pane] Fix keyboard navigation issue, searchbar not able to be selected.
- make search toolbar focusable
- set next tab navigation element to homepage_container

Bug: 324420544
Test: manual
Change-Id: I2783b7540d954f7adf64c6ac3e90d91c196646c5
2024-02-20 23:20:30 +00:00
David Liu
f1c1e011b2 Merge "Fix keyboard navigation issue, searchbar not able to be selected." into main 2024-02-16 23:26:45 +00:00
David Liu
9489a97754 Fix keyboard navigation issue, searchbar not able to be selected.
- make search toolbar focusable
- set next tab navigation element to homepage_container

Bug: 324420544
Test: manual

Change-Id: I991390e9d980092dfe11b15dcb81563ed3b0d4d1
2024-02-16 19:09:58 +00:00
Joshua Mccloskey
1c711222f9 Merge "Adding more biometric screenshot tests" into main 2024-02-15 17:17:51 +00:00
Joshua McCloskey
d92faeb1cf Adding more biometric screenshot tests
Test: atest FingerprintEnrollIntroScreenshotTest FingerprintEnrollFindSensorScreenshotTest FingerprintEnrollEnrollingScreenshotTest
Bug: 297083009
Change-Id: I11df6fbaefa9d333dcfe803577947a4be7af9882
2024-02-13 18:59:46 +00:00
josephpv
e9f3a0925b Add illustration to final screen in PS setup and update existing illustrations.
Screenshots:
- go/ss/9KhqUSezFKHnyys.png

Recording link:
- b/321694009#comment2

Bug: 323156268
Bug: 321694009
Test: Verified manually
Change-Id: Ib8abc080f31cad0a9be3b73a1694be744c108a06
2024-02-13 18:27:17 +00:00
josephpv
7ff2ab0df1 Update with latest icon in private space setup flow screens
Screenshots:
go/ss/9gaHk7iCpTVxi9S.png
go/ss/4s6vqq3RTvExK6b.png
go/ss/7uhBhrtU69E4SKv.png
go/ss/A3B98AiPBWPXtNA.png

Bug: 325043422
Test: Manual
Change-Id: I37b0707617287745239517a3113ef248f721c3f8
2024-02-13 15:02:20 +00:00
Yiyi Shen
ac869a57ad Merge "[Audiosharing] Avoid dialog flickering for same bt device group." into main 2024-02-06 06:26:30 +00:00
Yiyi Shen
10bddfd334 [Audiosharing] Avoid dialog flickering for same bt device group.
Before this change, the dialog will dismiss and show up again if the
second bud of the same group is connected.

In this change, StopDialog and JoinDialog will only update the message
and event listener when the dialog is triggered by another device with the same group id or the new bt device with different group id. (No dismiss and show); DisconnectDialog will only dismiss and show again when a new bt device with different group id is connected and update the event listener when another device with the same group id connected.

Also dismiss the dialog when the triggering device disconnect or join
the sharing.

Test: atest
Bug: 305620450
Change-Id: I798812101cefb24185d76d56f78eae27712dd7a6
2024-02-06 11:52:58 +08:00
josephpv
e1a2c82db3 Add Private space Delete settings page inside PS settings page
Contains implementation of settings page for Delete private space
controller inside private space settings page.
- On selecting to delete private space displays list of account signed in
to private profile and deletes the private space after authentication.
- Shows a toast message after private space is deleted

- Adds dependency for setupdesgin loading layout to show a loading
  screen while deletion of private space is in progress.

Recording Link : b/318383729
go/ss/4Aq3rmbSGHMHesK.png

Bug: 318383729
Test: atest DeletePrivateSpaceControllerTest

Change-Id: Ia1730915e2469b47823c507f9ef6cd8f63c99baf
2024-01-31 19:29:13 +00:00
chelseahao
8b5da73e4d [Audiosharing] Some UI tweaks (e.g, sort by RSSI)
Bug: 308368124
Test: manual
Change-Id: Ie066077f6ef47a57b9fb1c85bc7200498dcae093
2024-01-26 16:46:23 +08:00
Hakjun Choi
4b80409474 Merge "Add Satellite Messaging activity" into main 2024-01-24 01:31:30 +00:00
Hakjun Choi
2f57f53831 Add Satellite Messaging activity
Add satellite messaging activity into Settings for carrier satellite
service

Bug: 319035517
Test: manual
1. Set CarrierConfig Key KEY_SATELLITE_ATTACH_SUPPORTED_BOOL as false then verify satellite messaging menu is not shwon from
   Settings > Network & internet > SIMs > test sim
2. Set CarrierConfig key KEY_SATELLITE_ATTACH_SUPPORTED_BOOL as true
3. Insert test SIM
3. Get into to Settings > Network & internet > SIMs > test sim > verify Satellite messaging is shown
4. Verify whether descriptions are as directed. icons are as directed.
5. Add satellite messaging does not work when click
6. Invoke web browser with test website when click 'More about satellite messaging'
7. Replace SIM of which MCC/MNC is not test sim
8. verify no action happen when click 'More about satellite messaging'

Change-Id: Iee8fad58b41cbca34f373d2a9df1d074c447cfb1
2024-01-23 07:49:00 +00:00
Haijie Hong
9f5cb5cf0e Add talkback and fix touch area of phonebook sharing toggle
Bug: 318788906
Bug: 318787744
Test: atest BluetoothPairingDialogTest
Change-Id: I168a900cc4a66ae69b300f8fa806e3a612f4f310
2024-01-22 07:08:07 +00:00
Becca Hughes
87117b0183 Merge "Add buttons for new settings design" into main 2024-01-19 22:05:14 +00:00
Becca Hughes
782fcb9bd5 Add buttons for new settings design
This adds a new class called PrimaryProviderPreference
which is responsible for laying out the old cog view if
the feature is disabled and the new button view if it
is enabled.

Screenshots:
https://hsv.googleplex.com/5109836204212224
https://hsv.googleplex.com/5574754636398592
https://hsv.googleplex.com/6737135727017984

Change-Id: I1ad0c59a4afc5be3694b499f66bbd7306dfbee69
Test: Manual test with flag on + off & unit tests
Bug: 300979487
2024-01-19 19:42:14 +00:00
Charlotte Lu
628ebac9e2 Add WEP warning.
Test: Visual Test
Fix: 318797664
Change-Id: Id713ddf2d805b7ce47fe1e620a3273b86cdb3dfe
2024-01-19 04:12:59 +00:00
SongFerng Wang
7e2fc39678 Merge "Remove the phone number at Rename page" into main 2024-01-17 09:08:49 +00:00
SongFerngWang
4366ceea15 Remove the phone number at Rename page
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: Build pass
Change-Id: I6e77f2a8858e17e3e56c01769e6eb5b4fd478a04
2024-01-17 15:11:55 +08:00
Wu Ahan
a3e5036311 Merge "Add SfpsRestToUnlockFeature to FingerprintFeatureProvider" into main 2024-01-17 02:30:11 +00:00
Angela Wang
3c71a5ff22 Merge changes from topic "ha-new-pairing" into main
* changes:
  New hearing device pairing page (2/2): MFi devices
  New hearing device pairing page (1/2)
2024-01-16 09:41:37 +00:00
Angela Wang
3e9f1ff659 New hearing device pairing page (1/2)
Rewrite a new hearing device pairing page with update UI for "See more
devices".

Bug: 307473972
Test: atest HearingDevicePairingFragmentTest
Test: flip the flag com.android.settings.flags.new_hearing_device_pairing_page && atest HearingAidPairingDialogFragmentTest AddDevicePreferenceControllerTest
Change-Id: Ic60601905e3d0d7d7c5b1ef9733652118a211f1d
2024-01-16 03:49:34 +00:00
Wu Ahan
a9913cb74c Add SfpsRestToUnlockFeature to FingerprintFeatureProvider
Bug: 296179618
Test: manually
Test: SettingsUnitTests
Change-Id: I452610e2c2b36f56dc4ade1cea1a15fdc088211f
2024-01-16 02:15:33 +00:00
Chun-Ku Lin
0552c18287 Fix text color contrast issue on Caption size and style screen
Use the same textAppearance as the one defined in
preset_picker_item.xml, which is used by the Edge type dialog on the
same screen and doesn't have text color contrast issue.

Bug: 319742556
Flag: EXEMPT (simple bug fix)
Test: Manually by using Accessibility Scanner

Change-Id: If078ce1daf8ba0b3cb6ffef860ff39e995d7446a
2024-01-12 23:32:52 +00:00
Edgar Wang
a27ea5b128 Update Personal dictionary layout to fix A11y issue
- update padding
- update text color
- update editbox height

Bug: 317848523
Bug: 317850573
Bug: 317848597

Test: visual
Change-Id: Idbe09fe6e197d7f70d438cb1f62f8ccc6e6a4eb2
2024-01-11 12:58:11 +00:00
Treehugger Robot
a5e48292a7 Merge "Implemented nested scrolling parent in TextReadingPreviewPager" into main 2024-01-09 01:16:08 +00:00
Chun-Ku Lin
ed3d2f9171 Implemented nested scrolling parent in TextReadingPreviewPager
Flag: N/A
Bug: 317947238
Test: manual

Change-Id: I173881b84d5c5ff81c15a80a4de65fda59f5bf65
2024-01-08 22:07:56 +00:00
Weng Su
dea44ebf7b Merge "Set minHeight of the password field in Shared Hotspot" into main 2024-01-08 05:56:25 +00:00
Weng Su
3eb9757623 Set minHeight of the password field in Shared Hotspot
- Set minHeight to @dimen/min_tap_target_size(48dp)

Fix: 318617636
Test: unit test
make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.dpp

Change-Id: I794862bac82eb37b168263e2e472cba26ba34647
2024-01-05 19:12:15 +08:00
Chaohui Wang
df5c4f69a8 Fix DataUsageSummaryPreferenceController ANR
By off load data loading to background.

Fix: 295260929
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ib2ef19301b1e97af8a7f3861829779c3b70da4a4
2024-01-05 16:07:28 +08:00
shaoweishen
5446813ac5 [PK Setting] Refine layout for Keyboard review
1. add background for keyboard review
2. add text for showing selected keyboard's name

Test: Verified on device
Bug: 305588594
Change-Id: Icf0f2b7798cc5cbddefc1b3a95480b48271b276f
2023-12-19 09:41:17 +00:00