Commit Graph

56684 Commits

Author SHA1 Message Date
tom hsu
b91d21ba76 Add strings for NTN connection manual type
Flag: EXEMPT bug fix
Fix: b/397958254
Test: Manual test. see b/397958254#comment10
Change-Id: Ibcd3511edee9b3203c6c0cad68e0988b4b621b39
2025-02-25 04:33:00 -08:00
Chaohui Wang
ceea22c012 Merge "Override isSpaExpressiveEnabled in Settings" into main 2025-02-23 22:17:05 -08:00
Chaohui Wang
04c7e27a73 Override isSpaExpressiveEnabled in Settings
Into SettingsSpaEnvironment.

Bug: 386013400
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Test: visual - expressive can enabled for spa in Settings
Change-Id: I5225948c733a57855168a3e633fc4fbd4dd6f89a
2025-02-24 12:08:27 +08:00
Treehugger Robot
93ff3c4f7a Merge "Do not set title description for Confirm Activity" into main 2025-02-23 20:04:58 -08:00
Shaowei Shen
49859abb4b Merge "[Physical Keyboard] Update Input Setting Dialog" into main 2025-02-22 02:36:32 -08:00
Yuhan Yang
664df0f4cc Update autoclick shortcut searchable
Add autoclick shortcut to search index when
enable_autoclick_indicator flag is enabled.
Hide it when the flag is off.

Bug: 397719419
Test: atest ToggleAutoclickPreferenceFragmentTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ib6d25067d024ff0dbea64d17d38fc544c615db97
2025-02-21 22:36:53 +00:00
Yuhan Yang
4d52d72337 Only create shortcut preference when no existing shortcut found
Update onCreateView in AccessibilityShortcutPreferenceFragmen
so it only create a new shortcutPreference when no existing
shortcut preference is found.

Bug: 397719419
Test: Manually verified on test devices
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ic4747240cfd3d48fd97c61fd0b15d44f6ba5cf0a
2025-02-21 22:36:53 +00:00
Owner Cleanup Bot
b22cebe941 Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/sim/OWNERS" into main am: f16b9f85a1 am: 1a2021fe66
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3499870

Change-Id: I56dd62f3b24da922af1292bfdf47868c111bda8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-21 12:10:18 -08:00
Owner Cleanup Bot
73df0ba4a4 Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/deviceinfo/OWNERS" into main am: 0d7517c021 am: 62651fd633
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3497484

Change-Id: I66b2f7fba0b38d099f2ea86ea64da2358d7e1439
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-21 12:09:31 -08:00
Owner Cleanup Bot
840197127e Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/datausage/OWNERS" into main am: f7457e99a2 am: 01d42a8f16
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3497483

Change-Id: Ic41a7de069977b7c8109438c9f9a081769133a44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-21 12:08:09 -08:00
Owner Cleanup Bot
f16b9f85a1 Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/sim/OWNERS" into main 2025-02-21 11:15:59 -08:00
Yuhan Yang
7c467be118 Merge "Add autoclick shortcut to a11y autoclick settings" into main 2025-02-21 11:15:54 -08:00
Owner Cleanup Bot
0d7517c021 Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/deviceinfo/OWNERS" into main 2025-02-21 11:13:55 -08:00
Owner Cleanup Bot
f7457e99a2 Merge "[owners] Remove bonianchen@google.com from src/com/android/settings/datausage/OWNERS" into main 2025-02-21 11:13:51 -08:00
Matthew DeVore
bdd9cca602 Merge changes I550fc918,I16b3ae92 into main
* changes:
  Disable mirror toggle if feature turned off
  Use PrefRefresh for Preference caching
2025-02-21 08:59:44 -08:00
Jason Hsu
d879711020 Merge "Fix default microphone for calls sometimes not work and not show UI" into main 2025-02-21 08:44:13 -08:00
Matthew DeVore
6edab7d35f Disable mirror toggle if feature turned off
If the content mode management feature is disabled, the mirror display
toggle should be disabled, and instead reflect the inverse of the
"force desktop on external displays" system property.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: manual with and without toggle user-changeable
Bug: b/396116157
Change-Id: I550fc918aaebab7129a559c0e49b88c8da7bc00d
2025-02-21 09:43:11 -06:00
Matthew DeVore
c37fc8b827 Use PrefRefresh for Preference caching
Refactor a couple of fields to use PrefRefresh for caching instead
instead of fields. This makes us construct PrefRefresh for display
categories, which we hadn't been doing before, and was causing
b/397466966. This also limits the tests' dependency on implementation.

We had been using fields for caching Preference objects, which doesn't
account for the same preference being needed for each display.
PrefRefresh is a more flexible mechanism for recycling View objects and
it largely makes the fields obsolete.

The reuse* methods (previously get*Preference) can actually be inlined
now that tests aren't calling into them, but to keep the diff easy to
review I left them as separate methods.

Because @NonNull doesn't actually do anything, and is considered the
default, I neglected to add them to new arguments, and deleted them from
lines I modified.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: ExternalDisplayPreferenceFragmentTest.java
Test: with fragment visible, plug-in and activate a new physical display with the Mirror prompt
Test: with topology disabled, verify footer is shown with and without a display attached
Bug: b/397466966
Bug: b/397591022
Change-Id: I16b3ae925ca3d9d79471fd5df00b571ae3fc696f
2025-02-21 09:43:10 -06:00
Owner Cleanup Bot
71eb73374c Merge "[owners] Remove arcwang@google.com from src/com/android/settings/wifi/OWNERS" into main am: 0997a62f67 am: 1ea637ca4b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3503652

Change-Id: I76b8d66fbadbfea1eea66239af526feafb7ddaa3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-21 07:09:39 -08:00
lbill
0a46950939 Do not set title description for Confirm Activity
The Confirm Lock Activity for Auto-Confirm feature announce
redundant description after confirm the PIN/Password in the
Click Toggle CUJ.
1. The title won't be present on the Confirm Lock
2. Set title for Confirm Lock breaks the a11y requirement

Flag: EXEMPT for fixing a11y bug
Bug: 384628809
Test: Manual enable a11y talkback, go to Settings > Security & Privacy
> Device unlock > Screen lock > Settings > Auto-confirm unlock toggle
> input PIN/Password to dismiss the confirm lock activity
> Ensure no redundant title description announced by talkback

Change-Id: I95fc03aae4fb5dc7500cc18c383dff62b95bc3f1
2025-02-21 03:20:08 -08:00
Treehugger Robot
17dc54c62c Merge "Talkback shouldn't announce in list numbers." into main 2025-02-21 02:23:53 -08:00
danielwbhuang
508567edd8 Talkback shouldn't announce in list numbers.
These pages shouldn't announce in list numbers when use Talkback.
1. TemperatureUnitFragment
2. MeasurementSystemItemFragment
3. FirstDayOfWeekItemFragment

Bug: 385671217
Flag: EXEMPT bug fix
Test: test on real devices
Change-Id: Ib691947c3b34cd59e29ed2fd173a77633c5115b5
2025-02-21 01:19:05 -08:00
Tom Hsu
3c1e8e19cb Merge "Make Satellite UI updatable during receiving callback" into main 2025-02-20 23:27:01 -08:00
shaoweishen
4da457f8a9 [Physical Keyboard] Update Input Setting Dialog
1. update button style to use custom one
2. use scrollview so it won't be truncated in shorter screen

Bug:389973784
Flag: com.android.settings.keyboard.keyboard_and_touchpad_a11y_new_page_enabled
Test: atest
packages/apps/Settings/tests/robotests/src/com/android/settings/inputmethod/

Change-Id: I57765e88751b6090606d56bbe2335813ef7fd2fc
2025-02-21 07:10:40 +00:00
Yiyi Shen
788fc20626 Merge "[Audiosharing] Adopt fallback API when developer preview on" into main 2025-02-20 23:01:25 -08:00
Ze Li
025fff5a85 Merge "[Battery refactor] Move stylus related functions to BluetoothUtils as util functions." into main 2025-02-20 21:36:37 -08:00
Treehugger Robot
6df46b06a7 Merge "Fix mobile data in Settings is not disable under satellite session" into main 2025-02-20 20:05:18 -08:00
tom hsu
2a91e80acc Fix mobile data in Settings is not disable under satellite session
Flag: EXEMPT bug fix
Bug: b/386424636
Test: atest pass
Change-Id: I8d28419f295b172c2929acca5f5896aa4deeb09c
2025-02-21 02:48:55 +00:00
Daniel Norman
165f4ea76e feat(expressive): Add new magnification banner for expressive design
Fix: 378876803
Flag: EXEMPT custom flagging helpers from Settings and Setup
Test: observe new image; see bug screenshots
Change-Id: I3654563352e223af1a0d679318da45da2b4bc8be
2025-02-20 16:00:04 -08:00
Treehugger Robot
69c4f2dff0 Merge "Make ColorAndMotionFragment fully in Catalyst" into main 2025-02-20 12:39:07 -08:00
Riley Jones
e6b7908366 Merge "Revert "Left & Right buttons for Display size & text preview"" into main 2025-02-20 12:38:24 -08:00
jasonwshsu
691a3fd641 Fix default microphone for calls sometimes not work and not show UI
Root Cause: Only setMicrophonePreferredForCalls and show UI to current device, but audioManager
might hold other device in the same set

Solution: setMicrophonePreferredForCalls to whole device set and also check if any address in device
set contain in audioManager GET_DEVICES_INPUTS list

Bug: 392902067
Test: atest BluetoothDetailsHearingDeviceInputRoutingControllerTest
Flag: EXEMPT bugfix
Change-Id: Ic5846de26df4a8db67fa8efcf474fa4509f7918a
2025-02-21 04:10:03 +08:00
Daniel Norman
b1691756e2 Revert "Left & Right buttons for Display size & text preview"
This reverts commit 30e63f6178.

Reason for revert: Can cause crash for some users?

Change-Id: I4b4e71157b668bbf4320a610ad14ddd10f2eade3
2025-02-20 11:26:35 -08:00
Yuhan Yang
0516a06a02 Add autoclick shortcut to a11y autoclick settings
Add a shortcut row that toggles floating icon and pops edit
shortcut type dialog.

Screencast:
 - autoclick indicator flag on:
   go/njiwntmwmjuwnzu2ote1mnw2m2nhmzflzi0znq
 - autoclick indicator flag off:
   go/screenshot-anpqrzv6ewplyjs

Bug: 397719419
Test: Manually verified on test devices
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: I5f0b51adfaea5c3f8b077af07f34f61d78cb34ac
2025-02-20 18:19:23 +00:00
Owner Cleanup Bot
a25b7045e9 [owners] Remove arcwang@google.com from src/com/android/settings/wifi/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy.  We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain.  It can always be
reverted if needed.

If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.

See the owner's recent review activity for context:
https://android-review.googlesource.com/q/arcwang@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ib6ec33ee0331fef36c7c048be5b588e275e8de4d
2025-02-20 07:50:43 -08:00
Treehugger Robot
1d8a9df2eb Merge "Change range of battery saver schedule seekbar" into main am: a9d0f2b261 am: bec906daaa
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3494973

Change-Id: I800977e4a6e005169c346e41b5958cd6cddc4baa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-20 04:36:04 -08:00
Treehugger Robot
540361621a Merge "Fixed crash issues in Emergency Callback Mode" into main 2025-02-20 03:35:54 -08:00
Treehugger Robot
a9d0f2b261 Merge "Change range of battery saver schedule seekbar" into main 2025-02-20 03:22:43 -08:00
Jason Chang
5cf92e60c2 Merge "Fix for checking SUW/Setting Expressive style API" into main 2025-02-20 02:56:42 -08:00
Treehugger Robot
acd833886f Merge "Persist dev option reboot dialog on rotation." into main 2025-02-20 02:37:32 -08:00
Weng Su
af065146d5 Fixed crash issues in Emergency Callback Mode
- Avoid using controllers when Catalyst design is enabled

Bug: 394015881
Flag: EXEMPT bugfix
Test: Manual testing
  atest NetworkDashboardFragmentTest
Change-Id: I4393be5e76c0328f2a53f1d828814491991557f1
2025-02-20 18:24:16 +08:00
Treehugger Robot
3fc8745924 Merge "Fix the animation in the “How to set up Face Unlock” page can’t be paused or hidden." into main 2025-02-20 02:01:52 -08:00
tom hsu
d5548d1463 Make Satellite UI updatable during receiving callback
- Refactor code
 - Make Satellite category be updatable by callback.

Flag: EXEMPT bug fix
Fix: b/396233604
Fix: b/382664790
Test: atest pass
Change-Id: I893030005ae5af1403557f7bd22e8cdaf038ffcf
2025-02-20 09:34:45 +00:00
Jason Chang
b5857a7af9 Fix for checking SUW/Setting Expressive style API
Flag: EXEMPT use SUW/Settings Expressive style API to check

Bug: 394223273

Test: build and manually check the UI and its behaviors
Change-Id: Iecbe443a20c4a228a6bd14fd061b0a731fbbd95a
2025-02-20 09:29:21 +00:00
alinazaidi
cf33160dc5 Persist dev option reboot dialog on rotation.
Use a ViewModel to store reboot dialog fragment state on rotations.

Test: locally verified rotations on few dev options that use the reboot fragment
Test: atest
com.android.settings.development.RebootConfirmationDialogFragmentTest
--iterations 25 (Passed)
Bug: 356273849
Flag: EXEMPT bug fix

Change-Id: I154170ea5fa91bcbec32af43853c5f99f8e8253d
2025-02-20 01:25:12 -08:00
Jason Chang
90802728ae Fix the animation in the “How to set up Face Unlock” page can’t
be paused or hidden.

Handling the Lottie onClick event to pause/resume the animation.

Flag: EXEMPT bug-fix

Bug: 378585895

Test: local build and verify to pause / resume lottie animation.
Change-Id: I36ff303dcdb994fb5ad9d90957d9a3e8534c3634
2025-02-20 08:43:18 +00:00
Henrik Baard
37bf0fbe57 Change range of battery saver schedule seekbar
The minimum value which can be set as trigger for
Battery saver was changed from 10% -> 20% however the
settings UI was not aligned with this change.

ref: b0fe225 Update the battery saver scheduler minimum level

Update the UI to align with the minimum trigger
level.

Bug: 396444535
Test: manual, check minimum seekbar value after reboot.
Test: atest BatterySaverScheduleSeekBarControllerTest
Change-Id: I4baa766ff1cb78ce656ae340ce930094b9e124e0
2025-02-20 09:13:39 +01:00
Ze Li
6a29b1c779 [Battery refactor] Move stylus related functions to BluetoothUtils as util functions.
Test: com.android.settings.bluetooth.BluetoothDeviceDetailsFragment, com.android.settings.connecteddevice.stylus.StylusDevicesControllerTest
Bug: 397847825
Flag: EXEMPT utils function
Change-Id: I6819844cd686fe29b8b1c760c3e4035787a2b903
2025-02-20 15:35:01 +08:00
tom hsu
58f40ebc7b Fix crash due to display name is not set to View.
Flag: EXEMPT bug fix
Fix: b/396700275
Fix: b/396606595
Test: manual test
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:04006ccb4867a17e7e59c64327d102e9b30af5f9)
Merged-In: I2a70c4e31c182f99cc4fb3da93ce7911da005429
Change-Id: I2a70c4e31c182f99cc4fb3da93ce7911da005429
2025-02-19 19:18:06 -08:00
Angela Wang
57032340db Merge "Add ambient volume control related logs in Settings" into main 2025-02-19 18:03:48 -08:00