Commit Graph

52582 Commits

Author SHA1 Message Date
lindatseng
cf9fcd654a Merge "Fix crash on panel rotation" into qt-dev
am: 9141f02f94

Change-Id: If6acc9a77472f1534d040100a91f6b104842cc9b
2019-05-13 14:46:35 -07:00
joshmccloskey
51243e30b0 Reduced next button enabled delay to 8 seconds
Test: It builds.
Bug: 132636805
Change-Id: I6250f842e86c2ab809be803b599a994af6f25af3
2019-05-13 14:42:37 -07:00
Mehdi Alizadeh
36f32a46ca Refactors the System Navigation settings page
Bug: 130915285
Bug: 128855215
Bug: 127718810
Bug: 129115299
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest

Change-Id: If11e1fe4bf150d2dd9578f731e71abf6b74f5d90
2019-05-13 14:31:20 -07:00
Mehdi Alizadeh
815ed755c3 Update strings for System Navigation settings page
Bug: 130437843
Bug: 128522050
Test: Manual test to verify the right strings in settings app
Change-Id: Id6e589d896be34c98fded3b3fff897840e9d3f4f
2019-05-13 14:31:20 -07:00
TreeHugger Robot
9141f02f94 Merge "Fix crash on panel rotation" into qt-dev 2019-05-13 21:13:14 +00:00
Antony Sargent
7d8f015151 Strings for "Data during calls" preference
In some dual-SIM cases, when you have an active voice call using a SIM
that isn't the default one for mobile data, you may not get data
connectivity at all (from any other SIM) due to technical limitations in
the telephony stack. This preference will allow the user to leave data
off for a SIM, but opt in to have data become active only during calls.

Bug: 132114205
Test: n/a
Change-Id: I3e7cdaedd8b685e0fe65221d94f5b426bc95942e
2019-05-13 14:03:48 -07:00
Colin Cross
946a0fd964 Convert Settings to Android.bp
See build/soong/README.md for more information.

Test: m checkbuild
Test: m RunSettingsRoboTests-jacoco
Change-Id: I267534c095c30833f77273dbdb1893b7830ed45d
2019-05-13 13:42:01 -07:00
Colin Cross
807e861105 Use if instead of switch for resources
Converting to Soong will move some code from directly compiled
into the app to compiled into an Android library and then
shared between the app and the tests.  This will cause resource
IDs in the library to become non-final, which means they can
no longer be used in case statements.  Convert affect case
statements to if blocks.

Test: m RunSettingsRoboTests
Change-Id: I25742a374f06d3fa4decbfc0d223a350acc50881
2019-05-13 13:42:01 -07:00
Lei Yu
22a9f539e9 Use NetworkTemplate to query data
So virtual carrier can get correct data with merged subscriberIds

Bug: 120566366
Test: RunSettingsLibRoboTests
Change-Id: I02abed77dffb55ef49fe0c4142f6f5b4a42ebe52
2019-05-13 13:04:46 -07:00
lindatseng
943d649f73 Fix crash on panel rotation
Should force PanelFragment creation on rotation change.

Change-Id: If2ccae7dbc4278103c95621743570b37113746f7
Fix: 132587339
Test: Manual
2019-05-13 19:48:59 +00:00
Jason Chiu
90cb5628bb Merge "Fix automatically directing the user to the captive portal in Wi-Fi Slice" into qt-dev
am: 6a3eb31763

Change-Id: I40edb775bb09083110767745728356aa7c639d47
2019-05-13 12:05:11 -07:00
TreeHugger Robot
6a3eb31763 Merge "Fix automatically directing the user to the captive portal in Wi-Fi Slice" into qt-dev 2019-05-13 18:58:44 +00:00
Mady Mellor
34fa757cc9 Merge "Move feature-level Bubble setting into developer options; default to off" into qt-dev
am: 240b227e1f

Change-Id: I899722a6df929c4093a5a74447eb25a610c80308
2019-05-13 11:38:26 -07:00
Mady Mellor
240b227e1f Merge "Move feature-level Bubble setting into developer options; default to off" into qt-dev 2019-05-13 18:18:31 +00:00
Zhi An Ng
3a6d75d7fa Merge "Update string description in SAW unsupported screen" into qt-dev
am: 516bdc20fb

Change-Id: Ie6513a8cb03fa8789ad5d70d9a6d6c14dcb4cf67
2019-05-13 10:13:32 -07:00
Fan Zhang
c2a85a374d Make subsettings display edge-to-edge
Fixes: 132182711
Test: visual
Change-Id: I3b0635cba359f74d463c2360323d80c5c9533228
2019-05-13 10:07:13 -07:00
andychou
9ac6d81177 Fix IMEI information can't display without pSIM inserted
When no SIM, we can't get active subscription info.
So current code will not create TelephonyManager and cause IMEI not
retrieved.
Create TelephonyManager with default if no subscription info.

Bug: 132215720
Test: test with SIM and without SIM to check SIM status UI and atest ImeiInfoDialogControllerTest pass
Change-Id: Iaeb932ea66a6bee77136251941cca657984e456f
2019-05-14 00:55:47 +08:00
Zhi An Ng
516bdc20fb Merge "Update string description in SAW unsupported screen" into qt-dev 2019-05-13 16:52:22 +00:00
Arc Wang
bdd68115dd Merge "Fix Wi-Fi QR code scanner height at 360dp" into qt-dev
am: 26ff84d3f4

Change-Id: Ia21d3201d854c44f1372616981df855cf2ba5781
2019-05-13 00:25:49 -07:00
TreeHugger Robot
26ff84d3f4 Merge "Fix Wi-Fi QR code scanner height at 360dp" into qt-dev 2019-05-13 07:10:11 +00:00
Tim Peng
a60471e1e5 Hide audio switcher entry-point in the volume slice when in call
am: c007158819

Change-Id: I76265d9eccf5174df500c4c1518af6d3c1fc2cad
2019-05-12 19:09:24 -07:00
Tim Peng
c007158819 Hide audio switcher entry-point in the volume slice when in call
- update test case

Bug: 132385707
Test: make -j42 RunSettingsRoboTests
Change-Id: Ibfd12e75f584b6884d1025018772ac9c19673156
2019-05-13 01:38:39 +00:00
Bill Yi
30715db85a [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-dev
am: 0abec2cc56 -s ours
am skip reason: subject contains skip directive

Change-Id: I82105c48c3cecc5c985a4d7b3049226b77180763
2019-05-12 09:50:39 -07:00
TreeHugger Robot
0abec2cc56 Merge "Import translations. DO NOT MERGE" into qt-dev 2019-05-12 16:41:32 +00:00
Bill Yi
8ca57ab57a Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: If3dd5a2b6dfd25ecbd48c4870499f9ed5228a014
2019-05-12 06:01:13 -07:00
Hai Shalom
44926a0160 Merge "[WPA3] Fix connectivity issues with PSK-SAE Transtion mode" into qt-dev
am: b2fcb7825e

Change-Id: If02ef643c1903f447231215aaacd807e3f345311
2019-05-11 20:00:37 -07:00
TreeHugger Robot
b2fcb7825e Merge "[WPA3] Fix connectivity issues with PSK-SAE Transtion mode" into qt-dev 2019-05-12 02:43:06 +00:00
Kevin Chyn
f4099a8f84 Merge "Propagate intent extras and finish activity properly" into qt-dev
am: 7ac16f152e

Change-Id: I5bc447218d41fc098ea489c5fb8defdf5381f88d
2019-05-10 21:49:42 -07:00
Kevin Chyn
7ac16f152e Merge "Propagate intent extras and finish activity properly" into qt-dev 2019-05-11 04:31:14 +00:00
Jason Chiu
2c3e6c6434 Fix automatically directing the user to the captive portal in Wi-Fi Slice
The feature failed after the CL "Force the adapter to rebind cards with
a toggle".

Because toggle slices have been forced to rebind after starting another
activity and when any slice is updating. This unpins Wi-Fi slice and
stops WifiScanWorker and then clears the saved clicked network.

Solution:
1. Change ConnectToWifiHandler from activity to receiver and send
   broadcasts to it with FLAG_RECEIVER_FOREGROUND, so Wi-Fi slice won't
   be forced to rebind.
2. Seperate Wi-Fi scan worker and contextual Wi-Fi scan worker. Keep the
   original logic for the generic one, and then add the logic below to
   the contextual one.
3. Do not clear the saved clicked network when slice is unppined because
   it happens frequently in contextual homepage.
4. Introduce a static long in ContextualWifiScanWorker that updates once
   in every visible UI session. A session is when the screen is visible
   to user.
5. Use session token to determine whether auto-starting captive portal
   is needed.

Fixes: 128056349
Test: robotest, visual in homepage and network panel
Change-Id: I9e03c379806e124fa7253b2a635574b2433f6afc
2019-05-11 03:26:57 +00:00
Raff Tsai
b202df4422 Merge "Log ACTION_CONTEXTUAL_CARD_SHOW in different place" into qt-dev
am: 42aac32823

Change-Id: I82dc550b23c6fc11fff350c7c72f0154985a62f6
2019-05-10 19:50:15 -07:00
joshmccloskey
87dbedb514 Merge "Fixed spacing on Intro & Edu screens" into qt-dev
am: 806c65ca17

Change-Id: Iaa76703169d28f8ab6cfa1e8eee2b9c6efeadfb7
2019-05-10 19:46:59 -07:00
TreeHugger Robot
42aac32823 Merge "Log ACTION_CONTEXTUAL_CARD_SHOW in different place" into qt-dev 2019-05-11 02:27:24 +00:00
Kevin Chyn
acb113b06a Propagate intent extras and finish activity properly
Bug: 131861430

Test: Builds
Change-Id: I7e831f74f1e55026b9343a4c4f47c9f5adc316e6
2019-05-10 18:58:13 -07:00
TreeHugger Robot
806c65ca17 Merge "Fixed spacing on Intro & Edu screens" into qt-dev 2019-05-11 01:40:56 +00:00
joshmccloskey
2e70232caf Re-enable continue button for accessibility flow
Test: Removed userdata, went to education flow, enabled accessibility
and confirmed the next button was re-enabled
Fixes: 132463368

Change-Id: I7cd78d606fa4c191b44199a0d143b56b33be4fa4
2019-05-10 17:59:25 -07:00
Fan Zhang
0a29fb054e Clean up before making all setting page render edge-to-edge
am: 9db66a562c

Change-Id: I70c7fa7dc398e1d95d44453e9b3a3a7812b0205d
2019-05-10 17:28:08 -07:00
Raff Tsai
3d2655c100 Log ACTION_CONTEXTUAL_CARD_SHOW in different place
Fixes: 132396134
Test: robolectric
Change-Id: I7d46df15fbc42838da0fa53f4db7e1aa026c3174
2019-05-11 08:28:08 +08:00
joshmccloskey
fe6784b57d Fixed spacing on Intro & Edu screens
Test: It builds.
Fixes: 132370812
Change-Id: I7bfa8a7eae91ad9b0fc9b19c9a6bc019f884e729
2019-05-11 00:11:02 +00:00
Mady Mellor
32fa736dd6 Move feature-level Bubble setting into developer options; default to off
Functionality:
* Moves feature-level setting into developer settings (apps section)
* Adds bubbles in developer options under "apps" section
* Configures the app-specific bubble toggle in notifications settings
  to be hidden / shown based on the developer setting
* Configures the channel-specific bubble toggle in notification channel
  settings to be hidden / shown based on the developer setting

Tests:
* Anything that might be assuming that it's globally enabled now has
  a bit to enable it globally in that test
* There is a logic change now where the app-level setting would be available
  even if off globally, now that is not true -- if it's off globally the
  app-level is no longer available
* Adds tests for the developer setting

Test: make -j40 RunSettingsRoboTests ROBOTEST_FILTER="Bubble"
Bug: 131845765
Change-Id: I5f6bf74e5ada3fc023571825cca10d7bddc60e6e
2019-05-10 15:41:06 -07:00
Mill Chen
7aa0ab732b Merge "Update listDivider for PreferenceFragmentCompat" into qt-dev
am: dcf21d4bd6

Change-Id: Id8c580a230520479170816acb39db669ece39f25
2019-05-10 14:47:19 -07:00
Fan Zhang
9db66a562c Clean up before making all setting page render edge-to-edge
These classes are casting view to LinearLayout unnecessarily. Later we
might change the root view away from LinearLayout. The cast will cause
crash.

Bug: 132182711
Test: go through SUW.
Change-Id: Iea31882f8edea0c87ef8e95b4da9b6bffa8ea7d0
2019-05-10 21:27:05 +00:00
Fan Zhang
b104df9efc Merge "Updating animation asset" into qt-dev
am: 5dd9850bf3

Change-Id: I2d4ee02ba3aa983e36e96bef614c51dd725a824d
2019-05-10 13:49:47 -07:00
Brad Ebinger
96af57b47f Merge "Resolve the SIM call manager per subId" into qt-dev
am: 1350309ecc

Change-Id: I3d5c730efde6c0a8a1ecdba4e70793696ad7a598
2019-05-10 13:39:57 -07:00
TreeHugger Robot
dcf21d4bd6 Merge "Update listDivider for PreferenceFragmentCompat" into qt-dev 2019-05-10 20:38:20 +00:00
Fan Zhang
5dd9850bf3 Merge "Updating animation asset" into qt-dev 2019-05-10 20:24:59 +00:00
Brad Ebinger
1350309ecc Merge "Resolve the SIM call manager per subId" into qt-dev 2019-05-10 20:17:38 +00:00
Brad Ebinger
9761dd4634 Merge "Allow SimDialogActivity to be started for result" into qt-dev
am: d204d6c33f

Change-Id: Ib448a6901581294050fc988ed9c16f7e93066860
2019-05-10 13:12:21 -07:00
Hai Shalom
3fc9dc3ada [WPA3] Fix connectivity issues with PSK-SAE Transtion mode
Fix two reported issues regarding PSK-SAE transition mode:
1. When phone supports SAE, creating a manual saved network with PSK
and manually connecting would cause the phone to connect but Settings
does not display any connected AP. Phone would not autoconnect.
2. When phone doesn't support SAE, phone cannot connect to an AP in
PSK-SAE Transition mode because the framework always targets the highest
security.

Bug: 132278271
Test: Connect to WPA2 network
Test: Connect to WPA3 network (w/capable phone)
Test: Connect to WPA2/3 Transition w/SAE capable phone
Test: Connect to WPA2/3 Transition w/SAE not-capable phone
Change-Id: I371bcb4b2cccfc8684ecb5db3a768524f7354598
2019-05-10 12:59:23 -07:00
Brad Ebinger
d204d6c33f Merge "Allow SimDialogActivity to be started for result" into qt-dev 2019-05-10 19:42:55 +00:00