Commit Graph

1782 Commits

Author SHA1 Message Date
TreeHugger Robot
c74577eacf Merge "Revert "Add divider line in Preference for scan QR code button and share hotspot button"" 2019-03-22 08:18:16 +00:00
Arc Wang
8040f4c59f Revert "Add divider line in Preference for scan QR code button and share hotspot button"
This reverts commit 890f3a4340.

Reason for revert: I find a UI defect in this fix.

Change-Id: Icdbb1d2b5319636b8c4c54bcdc0fc3562585a15a
2019-03-22 05:36:59 +00:00
TreeHugger Robot
5ccefd53d1 Merge "Check if enrolled Wi-Fi network is reachable in WifiManager#connect onSuccess callback" 2019-03-22 05:36:45 +00:00
TreeHugger Robot
3a00f3bf81 Merge "Add keywords for wifi slice" 2019-03-22 03:42:17 +00:00
Arc Wang
7599de43f7 Check if enrolled Wi-Fi network is reachable in WifiManager#connect onSuccess callback
WifiManager#connect may callback onSuccess even if the Wi-Fi network is not reachable,
it confuses users.

In onSuccess callback, if the Wi-Fi network is unreachable, shows error message.

Bug: 127980127
Test: manual test
Change-Id: I503d6c77c1f1fcab3a1240d904f1c60aaef63aa1
2019-03-22 10:48:27 +08:00
Arc Wang
d2405c7328 Merge "Improve Wi-Fi Easy Connect lock screen UI information" 2019-03-22 02:19:48 +00:00
Cosmo Hsieh
aaf6e03499 Merge "[Network Connection] Don't dismiss dialog when touching outside of dialog" 2019-03-22 01:45:53 +00:00
Mill Chen
a77a05d5ae Add keywords for wifi slice
Wifi slice didn't have a bunch of keywords for search, so users have to
type full matched text to search for wifi setting. We added keywords for
wifi slice to fix it, in which keywords are defined in strings.xml.

Fixes: 109922806
Test: rebuild
Change-Id: Ibe3b65c186cf6f43ae744c1f478d8985e270374c
2019-03-21 17:21:33 -07:00
Jason Chiu
b056c3a2b6 Show connecting and connected messages on the header subtext of Wi-Fi slice
Fixes: 128631698
Test: robotest
Change-Id: I1ea2a65d09eca9b3dd06f56c4ae69ef7f68ffd86
2019-03-21 18:49:09 +08:00
TreeHugger Robot
b9e6f894c3 Merge "Add divider line in Preference for scan QR code button and share hotspot button" 2019-03-21 06:26:27 +00:00
Arc Wang
abfd8ab726 Improve Wi-Fi Easy Connect lock screen UI information
1. Change lock screen title and remove description
2. In QR code generator screen, change summary and show password under QR code picture

Bug: 128920152
Bug: 128576809
Test: manual test
Change-Id: Id096d7f417308df14ffe50c618644750aa991df8
2019-03-21 14:09:22 +08:00
TreeHugger Robot
4a6b8a608c Merge "[Network Connection] Implement Unavailable callback when the user cancels" 2019-03-21 05:48:17 +00:00
cosmohsieh
3babe9e908 [Network Connection] Don't dismiss dialog when touching outside of
dialog

To Improve user experience, prevent dialog dismissing from touching outside
of the dialog

Bug: 128877712
Test: atest NetworkRequestDialogFragment
Change-Id: Idfa90c3647f5cf766aaa63fdb8a829fec5db5934
2019-03-21 13:22:36 +08:00
Arc Wang
890f3a4340 Add divider line in Preference for scan QR code button and share hotspot button
Bug: 128940862
Test: manual test
Change-Id: If576f0840cc8924b63348f04fe12c3a0d4edcb89
2019-03-21 10:48:55 +08:00
Lucas Lin
f32823bc6d Merge "Modify dialog message for partial connectivity" 2019-03-21 02:34:03 +00:00
cosmohsieh
5944fa9427 [Network Connection] Implement Unavailable callback when the user cancels
UI should invoke NetworkRequestUserSelectionCallback.reject() callback when the user clicks cancel.

Bug: 128876386
Test: atest NetworkRequestDialogFragment
Change-Id: Ia5faedf8cc7113a602a4cda10b3252d02c3c8876
2019-03-21 09:37:49 +08:00
Cosmo Hsieh
64df6a3073 Merge "[Network Connection] Implement new UI changing" 2019-03-20 04:34:25 +00:00
TreeHugger Robot
85c5d73145 Merge "Improve UX of WifiDppChooseSavedWifiNetworkFragment" 2019-03-20 04:07:02 +00:00
lucaslin
7335c594be Modify dialog message for partial connectivity
In some networks, network validation may only get success
result for http probe but fail result for https probe.
For this kind of network, it may still work at some websites
or apps, but user didn't know about that. In order to fix this
issue, we will check if network has partial connectivity and
notify user to make a choice if they want to use this partial
connectivity or not.

Bug: 113450764
Bug: 128489091
Test: 1. Build pass.
      2. make -j44 RunSettingsRoboTests
      ROBOTEST_FILTER=WifiDetailPreferenceControllerTest
      3. Change captive_portal_https_url to https://invalid.com
      to simulate partial connectivity.

Change-Id: I0e87f6f2ede173f45a7b6fcf842b4f9a83d8efa1
2019-03-20 11:41:21 +08:00
Arc Wang
d0ceb83c95 Improve UX of WifiDppChooseSavedWifiNetworkFragment
In WifiDppChooseSavedWifiNetworkFragment, it does not show the saved Wi-Fi
network which is not reachable, users may be confused about why their saved
Wi-Fi network not on the list. This change shows saved networks regardless
of signal reachable or not.

Fix WifiDppChooseSavedWifiNetworkFragment UI overlap problem, remove redundant
ScrollView and adjust ConstraintLayout parameters.

Bug: 124129645
Test: manual test
Change-Id: I86637e8722bb8f40a3b995a617dc1e22b2ae324a
2019-03-20 10:06:40 +08:00
Arc Wang
e4359a9eee Merge "Fix Wi-Fi Easy Connect buttons UI defects" 2019-03-20 01:53:24 +00:00
Clown SHEN
9187906493 Merge "Display more information on network detail page" 2019-03-19 17:37:26 +00:00
Arc Wang
baf002d61a Fix Wi-Fi Easy Connect buttons UI defects
1. Apply attr/colorAccent to button icons for theme UI control
2. Apply attr/selectableItemBackground for button tapping ripple effect
3. Use ConstraintLayout to separate ssid EditText and scan button
4. Remove ButtonPreference and add AddNetworkPreference.
   ButtonPreference's naming and design look like a general purpose UI
   component but it's not. This change refactors the code.
5. In AddNetworkPreference, use settingslib layout file
   'preference_access_point' to fix UI alignment problems.

Bug: 126964552
Bug: 125434239
Bug: 126762937

Test: manual test
      atest com.android.settings.wifi.WifiSettingsTest
Change-Id: Ib899a1e10f96bb8427ff00d6b5dfca37a0642c44
2019-03-19 16:27:04 +08:00
cosmohsieh
b795dcbcd1 [Network Connection] Implement new UI changing
1. Change title to multi-lines display
2. Add "SingleSpecifiedSSID" mode, will have connect button
3. Don't pop error dialog, if there is connection failure. Let user
retry.
4. Hide progress icon if list item exists

Bug: 128586511
Test: atest NetworkRequestDialogFragmentTest
Change-Id: Icc560e4882fbcd941574e44690a27d5082a7c4c7
2019-03-19 10:15:33 +08:00
Jason Chiu
d4ab14969f Merge "Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice" 2019-03-18 10:13:56 +00:00
Jason Chiu
4e42f53896 Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice
- AccessPoint treats connected and connecting as equal so slice doesn't
refresh in this case
- Add a new method to determine if two lists are the same in SliceBackgroundWorker
- WifiScanWorker overrides this method to check the access point states

Fixes: 123941320
Test: robotest
Change-Id: I78d610da4b6b1d40f5785ba6701fb71b987fe31c
2019-03-18 16:01:48 +08:00
Hall Liu
c776acee06 Merge "Base implementation of WFC disclaimer UI" 2019-03-15 22:57:06 +00:00
TreeHugger Robot
a63fd33c0b Merge "Tie ContextualWifiSlice to UI instead of garbage collector" 2019-03-15 21:41:29 +00:00
clownshen
7fe8f92846 Display more information on network detail page
For connected network, show all information at detail page. For
disconnected network, show signal strength, Mac address, etc.

Bug: 124707751
Test: atest
Test: manual test
Change-Id: I401621abf9bba5dc7900b47a811d595adc906c13
2019-03-15 19:40:26 +08:00
manabu, shimoda
9fae73915c Base implementation of WFC disclaimer UI
Test: manual - Check that no error occurred when changing the wifi
calling settings to turn on.
Test: auto - Passed WifiCallingSettingsForSubTest,
WifiCallingDisclaimerFragmentTest and DisclaimerItemListAdapterTest.
Bug: 67872298

Change-Id: I789f530d3e16baa6e56feaa4269f6696976f747e
2019-03-14 14:58:20 -07:00
Fan Zhang
4cb2727989 Tie ContextualWifiSlice to UI instead of garbage collector
- Introduce a static long in SliceFeatureProvider that updates once
  every "session". A session is when user is in an UI (screen rotation,
  going to subpage, etc does not break the continuation of session).

- Use session token in ContextualWifiSlice to determine when to refresh,
  instead of relying on WeakHashMap from CustomSliceManager.
  WeakHashMap can be cleaned up at any time by gc so it doesn't match
  what we want on the UI.

- Also as a side fix, merged CustomSliceManager into
  SliceFeatureProvider.

Fixes: 123937830
Test: robo
Change-Id: I199bceceb208b99a32f3f08e624787b5a03e73a9
2019-03-14 14:45:59 -07:00
Oscar Shu
f6d9989a91 Merge "Change feature flag to correct flag" 2019-03-14 20:12:41 +00:00
Cosmo Hsieh
135d90ac9b Merge "[Passpointv2] Implement DataUsage header for Wi-Fi detail fragment" 2019-03-14 10:10:54 +00:00
cosmohsieh
976995fa36 [Passpointv2] Implement DataUsage header for Wi-Fi detail fragment
Change header to a data usage chart of the specified Wi-Fi network.

Bug: 124700353
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings
Change-Id: Ide08ffd5e97ced5fe54707562690155414598dac
2019-03-14 16:41:08 +08:00
xshu
900465fde7 Change feature flag to correct flag
Sorry, I provided the wrong flag that was supposed to be fore p2p MAC
randomization. Changing to the correct flag now.

Bug: 127817791
Test: compile
Change-Id: I46828e17411372c5e347b4fd17d853fe95f024a4
2019-03-13 16:37:25 -07:00
Fan Zhang
2014d16e46 Fix robotests
Fixes: 128536554
Test: rerun robotests
Change-Id: Ife81f9d161fc416a63a9b2f04ce2ae4f9a1e74db
2019-03-13 14:31:43 -07:00
Salvador Martinez
f087a4cf60 Merge "Remove airplane mode restriction on hotspot" 2019-03-12 18:27:36 +00:00
Hall Liu
843290ccb8 Merge "Add description for Wi-Fi calling mode" 2019-03-12 01:40:43 +00:00
TreeHugger Robot
08a2a8183e Merge changes I54a3f033,I2e894501
* changes:
  Fix [a11y] Wi-Fi Easy Connect Talkback issues
  Support to share Wi-Fi hotspot via QR code
2019-03-12 00:42:40 +00:00
Kazuya Ohshiro
c449048ac1 Add description for Wi-Fi calling mode
Replace the view of dialog with custom view that adds description
as summary.

Test: manual
Bug: 34793636
Change-Id: If9792b0a35c59c1260176b4b2c62107861de73b5
2019-03-11 13:21:51 -07:00
Quang Luong
252ae8bed0 Merge "Use getTitle() for AccessPoint display name" 2019-03-11 19:46:03 +00:00
Salvador Martinez
b94251ad07 Remove airplane mode restriction on hotspot
This isn't needed anymore since we support this now.

Test: robotests
Bug: 111681176
Change-Id: I0292f0a38347e4fa3414170e0351a53f5997a192
2019-03-08 16:34:57 -08:00
TreeHugger Robot
aa4748d0a1 Merge "[MAC Randomization] Align feature flag to global flag as framework" 2019-03-09 00:25:44 +00:00
Quang Luong
0df143834a Use getTitle() for AccessPoint display name
Instead of getSsidStr(), AccessPoint display names should use
getTitle() to accomodate Passpoint networks which use a provider
name instead of a single ssid. This change allows the provider
name to be displayed in the network details page, the long
press wifi dialog, and the config editing dialog.

Bug: 118705403
Test: atest WifiSettingsTest
Change-Id: I930d6218c7e464ad20c0c61130e0cb9ce315d9a2
2019-03-08 14:42:29 -08:00
TreeHugger Robot
2f825120b0 Merge "Remove settings gear icon from connected network in Wi-Fi slice" 2019-03-08 16:28:54 +00:00
Jason Chiu
ec5ace3e19 Remove settings gear icon from connected network in Wi-Fi slice
- remove the gear icon from the active access point
- do not show any icon for the active access point

Fixes: 126458943
Test: robotest
Change-Id: Ibb57c6e1e1840e54266b49e0f092839a9c145187
2019-03-08 15:00:16 +08:00
cosmohsieh
fb6b71e2d3 [MAC Randomization] Align feature flag to global flag as framework
Removed feature flag and change to check global flag as framework MAC
randomization api does.

Bug: 127817791
Test: atest WifiPrivacyPreferenceControllerTest
Change-Id: I6d5f67d45c9bdbfb47cddfc402d13627dc5a8a6e
2019-03-08 13:38:27 +08:00
Arc Wang
70e3580f5d Fix [a11y] Wi-Fi Easy Connect Talkback issues
1. Remove android:contentDescription from ButtonPreference layout file
   'wifi_button_preference_widget.xml' because it should be a more
   general purpose component. Add ButtonPreference#setButtonContentDescription
   for this change.
2. Add a LinearLayout to group title & summary for better Talkback UX
3. Set android:contentDescription for Wi-Fi enrollee scan button
4. setTitle for Talkback actionbar back button of WifiDppQrCodeGeneratorFragment &
   WifiDppQrCodeScannerFragment
5. Auto trigger Talkback to speak title & summary in WifiDppAddDeviceFragment &
   WifiDppChooseSavedWifiNetworkFragment
6. Auto trigger Talkback to speak summary change in WifiDppAddDeviceFragment
7. Auto trigger Talkback to speak error message in WifiDppQrCodeScannerFragment

Bug: 126007405
Bug: 124424996
Bug: 124424445
Test: manual test

Change-Id: I54a3f033bb8871c47be12115ae8f97691fd83302
2019-03-08 12:05:50 +08:00
Arc Wang
b249fb7d13 Support to share Wi-Fi hotspot via QR code
1. QR code scanner (Wi-Fi Easy Connect) does not support sharing Wi-Fi hotspot
   at current stage
2. Wi-Fi hotspot QR code button only shows when Wi-Fi hotspot is enabled
3. The QR code has the security string "WPA" for hotspot's WPA2_PSK

Bug: 123151660
Test: atest WifiTetherSSIDPreferenceControllerTest
            WifiQrCodeTest WifiDppConfiguratorActivityTest
            WifiDppEnrolleeActivityTest
            WifiDppQrCodeGeneratorFragmentTest
            WifiDppQrCodeScannerFragmentTest
            WifiNetworkListFragmentTest
            WifiDppChooseSavedWifiNetworkFragmentTest

Change-Id: I2e89450180b82cc841ee3b15be52bfc6f9f6164d
2019-03-08 11:48:12 +08:00
clownshen
0a7e2c0383 [Passpointv2] Provide two views for saved networks
List all passpoint network under "Subscriptions" view and others under
"Wi-Fi networks".

Bug: 116362877
Test: hard code verify subscribed network
Change-Id: I9750e9964e8b5affc2e91ea86a058c3ba65b3588
2019-03-07 07:59:58 +00:00