Commit Graph

139365 Commits

Author SHA1 Message Date
Sunny Shao
458ed92600 Handle the Edge to Edge problem
- Fix the navigation bar overlapped problem in sub-pages.
- Use a workaround solution to handle Homepage statusbar problem.

Bug: 328622648
Fixes: 330217912
Test: manual test
Change-Id: I67a65e2af10def84bf743d4d3cd0047098423ffe
2024-03-21 19:04:58 +08:00
Fan Wu
e2b861dce0 Re-enable failed test in FactoryResetPreferenceControllerTest
Bug: 314930928

Test: atest
Change-Id: Icb93a6e01310172d6f51fe332c2ea4cdf6b0c1c5
2024-03-21 19:00:06 +08:00
Chaohui Wang
f091754518 Merge "Fix readOnlyApnFields not applied" into main 2024-03-21 09:52:41 +00:00
hoffc
ef2e171b50 Settings: Fix force close for telephony callback exceeding limitation
When sub info changed, new telephony callback will be registered but old telephony callback not un-registered. Finally result in force close for registered telephony callback count exceeding its allowed.

No need to re-registered the telephony callback for one sub if registered.

Bug: 328716180

Change-Id: Ia0c3b311b5b5cc77f061d81ec21250abde2fa9f4
2024-03-21 17:32:13 +08:00
Fan Wu
9997df38d3 Fix test failures under settings/wallpaper
Bug: 315124270

Test: atest
Change-Id: I95a87c3644880ba29d310b45142c3c1d20870cdf
2024-03-21 16:41:57 +08:00
Chaohui Wang
54b03da369 Fix readOnlyApnFields not applied
Some enabled not set correctly.

Remove the enabled values, and check readOnlyApnFields directly to fix.

Fix: 330566517
Test: manual with carrier config KEY_READ_ONLY_APN_FIELDS_STRING_ARRAY
Test: unit test
Change-Id: Ifd6d4a0d9a96a900c9d124c9e357562e84bbc6c7
2024-03-21 16:32:38 +08:00
Charlotte Lu
f30692550a Merge "Add certificate summary." into main 2024-03-21 07:48:25 +00:00
mxyyiyi
ff3786f451 Fix talkback focus on "Less than a min"
- update text "min" to "minute"

Fix: 317140357
Test: manual
Change-Id: Iad1b72064f1b17c9d1ef4ed02b3d2de280d5449c
2024-03-21 15:04:13 +08:00
Xinyi Mao
4e56242991 Merge "Update percentage symbol from western sign to arabic sign" into main 2024-03-21 06:41:15 +00:00
Charlotte Lu
9578b97212 Add certificate summary.
Test: Manual
Fix: 330651393
Change-Id: I98ecf675edead58b5ffa525aa65aceabf1d701c4
2024-03-21 13:48:30 +08:00
Jason Jeremy Iman
34805e23bb arc: Use ChromeOS host's IP address for WiFi ADB
Wireless debugging in ARC shows guest IP address
which is not routable from the local network for
other devices.

This patch updates the shown IP address to host's
IP address. This allows clients to know the correct
IP address to connect to.

The IP address used is taken from wifi IP of the
host set in a property:
'vendor.arc.net.ipv4.host_wifi_address'.

ARC R patch: ag/12907009

Bug: 169703040
Bug: 315430652
Test: Manually tested for ARC on tm-arc.
Change-Id: Ib66e84872d9004fa3a946f1af9a774709d048f5a
2024-03-21 05:26:55 +00:00
mxyyiyi
8ce68baa24 Update percentage symbol from western sign to arabic sign
(https://screenshot.googleplex.com/ALgEzpDKG4BMBB4)

Fix: 322855881
Test: manual
Change-Id: I1335996814a1b80006481f52201a107144497859
2024-03-21 12:09:55 +08:00
Edgar Wang
26a5c73dc7 Listen Developer option enable state
- When developer option disabled, any page in Developer option
  should be closed.

Bug: 293894425
Test: manual

Change-Id: I392b122e885118770be1af2b51c0c7ef92279e1b
2024-03-21 04:08:08 +00:00
Chaohui Wang
dd5b4d3d31 Merge "Add BootBroadcastReceiver required permissions" into main 2024-03-21 03:35:57 +00:00
Treehugger Robot
cc8c5c8600 Merge "Fix concurrent issue" into main 2024-03-21 03:35:00 +00:00
Samridhi
f08b53d6da Add order to display settings
Test: MANUAL
Bug: 329276386
Change-Id: I245d1e765659873074ed889f32ec4e2e6999eb73
2024-03-21 03:17:35 +00:00
Daniel Norman
88feeec3c1 Merge "Remove usages of bugfix flag cleanup_accessibility_warning_dialog." into main 2024-03-20 17:49:34 +00:00
josephpv
6a3bd88078 Add message in dialog shown on choosing separate private space lock
Change to add message in the dialog shown on selecting to choose a new
profile lock for private space.

screenshot : go/ss/ASkBCFJuCzp7dkf.png

Bug: 330218365
Test: Manual. Diaog shown as per UX mock
Change-Id: I17f4d7ebf515dc7c95fcae7a5ec5edeb9918ded3
2024-03-20 17:28:45 +00:00
Joseph Vincent
e6a759303c Merge "Update strings in private space hide when locked settings page" into main 2024-03-20 17:28:21 +00:00
Fiona Campbell
9c50f2c61d Merge "Ensure only either RBC or even dimmer can be on" into main 2024-03-20 16:08:54 +00:00
Manish Singh
c1a314b2c9 Statically inlcude the frameworks flags lib
Bug: 329914404
Bug: 329738797
Test: build
Change-Id: I12c94e298d9fa69e509c0c57ac5d7d7040b04b04
2024-03-20 15:45:44 +00:00
Fiona Campbell
9a71b86c42 Ensure only either RBC or even dimmer can be on
Not Both

Even dimmer is the successor to RBC, so we shouldn't enable both
simultaneously, they are not compatible

Bug: 179428400
Test: manual, atest DisplayServiceTests
Change-Id: I18d5a9c7418b8141afd4b67d121a96cb50ba5274
2024-03-20 11:07:16 +00:00
tomhsu
55899976e9 Fix concurrent issue
- Add a thread lock

Fix: 286495550
Test: make pass
Change-Id: I72877551bda18cf93734d270770a0bd53bab465b
2024-03-20 08:29:43 +00:00
Lynn Yeh
d47736635b Merge "Fix toolbar keyboard navigation and touch." into 24D1-dev am: 4115a9a278
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26569576

Change-Id: Iec0817e8ed90a995f04c586008f53e65c6986c41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-20 08:11:38 +00:00
Lynn Yeh
4115a9a278 Merge "Fix toolbar keyboard navigation and touch." into 24D1-dev 2024-03-20 07:56:36 +00:00
Andy Wickham
cc10abe1c2 Merge "Allows for system navigation settings to be added dynamically." into main 2024-03-20 03:00:10 +00:00
Daniel Norman
8ce099c2cd Remove usages of bugfix flag cleanup_accessibility_warning_dialog.
Flag has been in Trunkfood for over a month.

Includes one mechanical refactor to move a method from a now-removed
file into a private method in the class that uses it: createDisableDialog

(This flag guarded a preliminary cleanup and minor bug fix for
b/303511250, but the actual feature for b/303511250 is tracked in a
different flag 'skip_accessibility_warning_dialog_for_trusted_services')

Bug: 303511250
Test: existing tests in Presubmit (no change to behavior)
Change-Id: Iccf439adb2806e988310f503fb3891a6bd022054
2024-03-19 23:05:07 +00:00
Manish Singh
b41979a012 Merge "Don't show private accounts when locked" into main 2024-03-19 18:09:25 +00:00
josephpv
4cebe66d71 Update strings in private space hide when locked settings page
Recording link:
b/330221666#comment2
screenshot :
go/ss/Ja2xyxVm4wjDF6P.png
go/ss/56Kujyq6WfBLtHG.png
go/ss/9wvcJTXnarizyU5.png

Bug: 330221666
Bug: 330327338

Test: Manual. Verified strings are updated as per UX mocks
Change-Id: I053bd2558503eb58fcf196eb0988bfa007583704
2024-03-19 17:05:28 +00:00
Richard MacGregor
1b9988e77f Merge "Update screenshare protection strings" into main 2024-03-19 16:41:32 +00:00
Treehugger Robot
937693d538 Merge "Add new Cellular Network Security page" into main 2024-03-19 16:15:32 +00:00
Manish Singh
e157ba8f39 Rename the name of private profile creation from Settings
Bug: 324844478
Test: manual
Change-Id: I9d2a2e3a2aa73e3eeea4fd08c45c9f9d654ea5d4
2024-03-19 15:52:27 +00:00
Joseph Vincent
6ec3ac32a5 Merge "To skip face enrollment for PS unlock setup based on intent extra" into main 2024-03-19 13:28:10 +00:00
josephpv
f9bc323633 To skip face enrollment for PS unlock setup based on intent extra
For private space lock setup as part of both PS setup and separate lock
form private space settings we need to show only traditional unlock
factors and Fingerprint but not show Face enrolment even on devices
where Face unlock is supported by hardware.
Once LSKF is enrolled it should be followed by Fingerprint enrollment
flow and after that Face enrollment should not be shown and exit lock
setup flow.

Currently for separate profile lock setup ACTION_SET_NEW_PASSWORD intent
is used in private space setup.
With this intent the options of LSKF+fingerprint+Face is shown in
devices supporting both fingerprint and face hardware. After the LSKF
ennrollment BiometricEnrollActivity is started which continues with
fingerprint and Face enrollment.

With this change we are passing an extra along with the intent to enroll
fingerprint only. Based on the intent extra value if set even if hardware
support exists the lock enrollment for the profile will support only
LSKF and fingerprint enrollment but not start Face enrollment.

User will still have the option to enroll Face from the dedicated settings
entrypoint in private space settings.

Recording link : b/323839067#comment4

Bug: 323839067
Test: Manual, verified option for face enrollment is shown or not shown
based on the intent extra. When extra is not passed the behaviour will be
default.

Change-Id: Idf92084052e02df9ca89f288c618796750e563e6
2024-03-19 11:58:08 +00:00
Chaohui Wang
732636cbd5 Merge "Refactor AutomaticDataSwitchingPreference" into main 2024-03-19 11:14:25 +00:00
Manish Singh
bb8652e1e8 Merge "Update Trusted credentials page for private profile" into main 2024-03-19 10:01:26 +00:00
Manish Singh
acafaf94b9 Merge "Support private profile in spinner adapters" into main 2024-03-19 09:54:58 +00:00
Haijie Hong
ba80f1934e Merge "Add event for Spatial Audio toggle in Settings" into main 2024-03-19 09:52:01 +00:00
Aleksandr Lukin
b30a1fc098 Merge "Add strings for Documents&Other split" into main 2024-03-19 08:26:49 +00:00
Haijie Hong
b2d6c06c5c Add event for Spatial Audio toggle in Settings
Bug: 322279959
Test: atest BluetoothDetailsSpatialAudioControllerTest
Change-Id: Id0a3e4c0bcdce80c25326c83db7913a51462ef58
2024-03-19 15:29:45 +08:00
Chaohui Wang
bfd8a517be Refactor AutomaticDataSwitchingPreference
Split into AutomaticDataSwitchingPreference.kt, and use
isMobileDataPolicyEnabledFlow.

Bug: 329061940
Test: manual - Set Automatic data switching
Test: unit test
Change-Id: I878ed70328307c0a5dba6dfb461ff5a85efbcf88
2024-03-19 14:17:20 +08:00
Chaohui Wang
a3507d535f Fix APN network type not updated
The issue is caused by SettingsDropdownCheckBox's interface is updated,
but ApnNetworkTypeCheckBox not updated.

Update ApnNetworkTypeCheckBox to fix.

Bug: 329547692
Test: manual - update network type
Test: unit test
Change-Id: I4a5a1ad7d9d97960799f5ba0d89b5178ce410b6e
2024-03-19 13:59:11 +08:00
Vincent Wang
3a12c7b18b [automerger skipped] Merge "Show calibtation result in FingerprintSettings & EnrollEnrolling if results are available" into 24D1-dev am: 177867af12 -s ours
am skip reason: Merged-In I006db64f001fb70d2bb294a15a2d3efc77e2da25 with SHA-1 6666bb97b4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26617943

Change-Id: Id96b4a611af9849c04376767f8400897b2805157
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-19 05:52:53 +00:00
Vincent Wang
e44054ba34 [automerger skipped] Show calibtation result in FingerprintSettings & EnrollEnrolling am: 118abc5568 -s ours
am skip reason: Merged-In I006db64f001fb70d2bb294a15a2d3efc77e2da25 with SHA-1 6666bb97b4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26617943

Change-Id: Icd3e1b340bebfa8c0a2fabc63add1f594a3b30b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-19 05:52:48 +00:00
Vincent Wang
177867af12 Merge "Show calibtation result in FingerprintSettings & EnrollEnrolling if results are available" into 24D1-dev 2024-03-19 05:37:39 +00:00
George Chang
8c6ba30e3c [automerger skipped] Merge "Revert "settings(dev): Remove NFC stack logging control"" into 24D1-dev am: 1df6f6a976 -s ours
am skip reason: Merged-In I3c6026e230c7d35f04d9771442fadbf040a84b94 with SHA-1 a5bd1cf34f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26593227

Change-Id: If4990b8214acadce90f73274ba735c1a0a6d88c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-19 05:25:29 +00:00
George Chang
5004b19a2d [automerger skipped] Revert "settings(dev): Remove NFC stack logging control" am: b5d57eaa58 -s ours
am skip reason: Merged-In I3c6026e230c7d35f04d9771442fadbf040a84b94 with SHA-1 a5bd1cf34f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26593227

Change-Id: I03265d2076c67b8d7be8dfb1caa473a77fd545f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-19 05:25:20 +00:00
George Chang
1df6f6a976 Merge "Revert "settings(dev): Remove NFC stack logging control"" into 24D1-dev 2024-03-19 05:06:34 +00:00
Ze Li
29168c0d3e Merge "[ConnectedDevicePage] Add setup to fix testing fail." into main 2024-03-19 05:05:40 +00:00
Vincent Wang
118abc5568 Show calibtation result in FingerprintSettings & EnrollEnrolling
if results are available

Bug: b/326155807
Test: Enroll multiple fingerprints and check if
        calibration isn't triggered.

Change-Id: I006db64f001fb70d2bb294a15a2d3efc77e2da25
Merged-In: I006db64f001fb70d2bb294a15a2d3efc77e2da25
2024-03-19 02:32:58 +00:00