Commit Graph

19683 Commits

Author SHA1 Message Date
jeffreyhuang
f74a2575a9 isAvailable is true by default in dev options
- isAvailable() is defaulted to return true for all developer options
 preferences
 - child controllers should override for custom hiding logic

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I89921f801c25e74bf78d02c55b5f34cf1d464cd0
2017-09-28 18:19:43 -07:00
Jeffrey Huang
ae6c29d10f Merge "Introduce ShowSurfaceUpdatesPreferenceController" 2017-09-28 22:46:35 +00:00
Eric Schwarzenbach
c03bd8f86f Fix "Add Network" button on SavedAccessPoints page.
Fix merge conflict.

The old onSubmit was a no-op. It now correctly pipes onSubmit to
WifiManager#save() with the new WifiConfiguration. On successful save,
it displays the new network in the list, and on failure, it displays a
toast indicating that the save action failed. Adds a test for the
WifiDialog behaviors on this page.

Bug: 66177765
Test: make RunSettingsRoboTests, manual - tested with Wifi enabled and
disabled, and with networks that were visible and not.
Change-Id: I27446aa49bc9efaf1ea1d6c6158928b62ce01ba2
2017-09-28 14:38:03 -07:00
jeffreyhuang
0c292c08dc Introduce ShowSurfaceUpdatesPreferenceController
- Create new ShowSurfaceUpdatesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I649549af1c5dd9d541bc9e6a62b4553fa7877233
2017-09-28 13:47:42 -07:00
jeffreyhuang
25ce51f4af Introduce BluetoothInbandRingingPreferenceCtrl
- Create new BluetoothInbandRingingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I2551803b50323c93ce8f1595d5bbab92b7a18ed4
2017-09-28 11:19:21 -07:00
Jeffrey Huang
f77a3fbdc3 Merge "Introduce PointerLocationPreferenceController" 2017-09-28 18:07:05 +00:00
Jeffrey Huang
e6d8e9d374 Merge "Introduce BluetoothAbsoluteVolumePreferenceCtrl" 2017-09-28 18:06:37 +00:00
Jeffrey Huang
cfc2ede22f Merge "Introduce AdbPreferenceController" 2017-09-28 18:05:11 +00:00
TreeHugger Robot
bcc3b924f9 Merge "Refactor IndexData conversion flow" 2017-09-28 17:43:04 +00:00
jackqdyulei
b963125159 Merge "Hide summary for type system" into oc-mr1-dev am: aadee0997c
am: da9247d645

Change-Id: I440fcbfea0cf934e68737eb5314739e397d80d88
2017-09-28 02:18:59 +00:00
jackqdyulei
da9247d645 Merge "Hide summary for type system" into oc-mr1-dev
am: aadee0997c

Change-Id: I99a8cfefe4253ee223b91d2a3e0b9e7721e73ee4
2017-09-28 02:17:08 +00:00
TreeHugger Robot
aadee0997c Merge "Hide summary for type system" into oc-mr1-dev 2017-09-28 02:11:54 +00:00
Doris Ling
9a3fd4f7f1 Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev am: d52c4482e4
am: eccb0fcff9

Change-Id: Ic62d580bad8d520e9a1ec942ab30c361df9e24aa
2017-09-28 02:07:04 +00:00
Doris Ling
eccb0fcff9 Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev
am: d52c4482e4

Change-Id: I2206805a6b9dada11576a6e6667980585acc8472
2017-09-28 02:05:10 +00:00
TreeHugger Robot
d52c4482e4 Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev 2017-09-28 01:58:47 +00:00
Chien-Yu Chen
3ea5b0973f Settings: Show HAL HDR+ option in user build am: 4d26fa03a8
am: f0c328ed78

Change-Id: Ia14d7a5ada922d29816f8c9d2895f6141d86ff27
2017-09-27 23:35:18 +00:00
Chien-Yu Chen
f0c328ed78 Settings: Show HAL HDR+ option in user build
am: 4d26fa03a8

Change-Id: I9b94c91b0a212ca727b9ba2ee7fc75902f2590e4
2017-09-27 23:33:01 +00:00
TreeHugger Robot
af83bfa58f Merge "Settings: Correctly align cursor in Settings" 2017-09-27 22:47:40 +00:00
TreeHugger Robot
cc01bdc158 Merge "Settings: Show HAL HDR+ option in user build" 2017-09-27 22:45:27 +00:00
jeffreyhuang
5acf47e402 Introduce PointerLocationPreferenceController
- Create new PointerLocationPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia2d190ec39d35e10d7ae6663584b993d16958d5e
2017-09-27 15:36:06 -07:00
TreeHugger Robot
784cfd10e7 Merge "delete obsolete SELinux code." 2017-09-27 22:12:06 +00:00
TreeHugger Robot
0e680b3cfd Merge "Introduce ConnectivityMonitorPreferenceCtrlV2" 2017-09-27 21:36:55 +00:00
PMS22
63a0560a6c Settings: Correctly align cursor in Settings
Steps to Reproduce:
- Click on Density Settings (DPI Settings) / Renaming BT Device / Renaming SIM Settings
- EditText Dialog pops up
- The cursor is at the leftmost side of the text
- Logically Cursor should be at rightmost side which can be aligned grabbing text length

Screenshots:
Before:
http://imgur.com/a/o4vkr
http://imgur.com/a/6Qext

After:
http://imgur.com/a/fuxqT
http://imgur.com/a/vm2WX

Bug: 65185652
Test: RunSettingsRoboTests: OK (47 tests)

Change-Id: Id00308e7e019434edad4afab56cf4719be0d0d54
Signed-off-by: PMS22 <prathams99@rediff.com>
2017-09-27 14:12:32 -07:00
Chien-Yu Chen
bb41a76256 Settings: Show HAL HDR+ option in user build
Test: CameraHalHdrPlusPreferenceControllerV2Test
Bug: 66919557
Change-Id: Ibaadf1b24ba82a8440aae9058397c96db6f24188
2017-09-27 14:09:47 -07:00
Chien-Yu Chen
4d26fa03a8 Settings: Show HAL HDR+ option in user build
Test: CameraHalHdrplusPreferenceControllerTest
Bug: 66919557
Change-Id: I02e89d34db56398e64e12616f34b8584df25c48b
2017-09-27 14:03:12 -07:00
Nick Kralevich
b255b3a6ed delete obsolete SELinux code.
This settings field only shows up on devices which have the
ro.build.selinux property, which is never something we added. This code
is dead.

Change-Id: I20349b4e8fea5be761047e47d4551c1a4f087a37
Test: code compiles and setting app works.
2017-09-27 13:34:45 -07:00
Jeffrey Huang
3e6488448c Merge "Introduce ShowTapsPreferenceController" 2017-09-27 20:02:51 +00:00
Jeffrey Huang
a56dc5a329 Merge "Introduce TetheringHardwareAccelPreferenceCtrl" 2017-09-27 20:02:25 +00:00
jeffreyhuang
8d8f1663b4 Introduce AdbPreferenceController
- Create new AdbPreferenceController
 - Create AdbOnChangeListener interface for adb change callbacks
 - Create EnableAdbSettingWarningDialog
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Add deprecated annotation to EnableAdbPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Id57146149943d770bf5ccc9ed5ecc6ea9d8ae66c
2017-09-27 12:57:52 -07:00
Matthew Fritze
ab741bb627 Refactor IndexData conversion flow
This is entirely implementation detail, the public
interface and tests get to stay the same.

- The Raw, Resource and Provider methods now return single
or lists of IndexData rather than adding to a member var.
- Some code duplication was removed for Raw IndexData.
- Extra methods were squashed or removed

The only remaining refactoring in IndexDataConverter is
moving work done on IndexProviders to get the raw and
resources into PreIndexDataCollector.

Bug: 33577327
Test: make RunSettingsRoboTests, Database dump before & after
Change-Id: If6011046955f242ba2614400cfeca3bea5b683cb
2017-09-27 12:06:26 -07:00
Tony Mantler
2d479598f0 Merge "Make ApplicationsState.Session lifecycle-aware" 2017-09-27 18:22:03 +00:00
Jeffrey Huang
41d7c4209b Merge "Introduce WifiVerboseLoggingPreferenceCtrl" 2017-09-27 17:08:19 +00:00
Jeffrey Huang
80bf731f81 Merge changes from topic "DevOptionsDebugger"
* changes:
  Introduce WaitForDebuggerPreferenceController
  Introduce SelectDebugAppPreferenceController
2017-09-27 17:03:09 +00:00
Kevin Chyn
6019137279 Merge "Move fingerprint authentication to a sidecar" 2017-09-27 02:56:01 +00:00
jeffreyhuang
07436287db Introduce ShowTapsPreferenceController
- Create new ShowTapsPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ifb4aa9e3c95c04bc7f8fd7e0220c9fe46b502ea6
2017-09-26 17:05:27 -07:00
TreeHugger Robot
7a77663036 Merge "Plumb SuggestionControllerMixin to DismissController." 2017-09-26 23:46:21 +00:00
jeffreyhuang
141c92bf62 Introduce ConnectivityMonitorPreferenceCtrlV2
- Create new ConnectivityMonitorPreferenceControllerV2
 - Deprecate ConnectivityMonitorPreferenceController
 - Create controller inside the DashboardFragment
 - Copy logic from ConnectivityMonitorPreferenceController with slight
 modifications for dashboard fragment compatibility

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ibba32208abb2535e1d13b299705e4f4e63aef8c8
2017-09-26 16:39:01 -07:00
Kevin Chyn
b8cfec8da1 Move fingerprint authentication to a sidecar
It's possible for this sequence of events to occur
1) touch FPS
2) rotate device
3) authentication succeed message goes to pre-rotated activity
The pre-rotated activity will continue authenticating, and the fragment
will not highlight correctly upon authentication

Fixes: 63907591

Test: manual test of above condition, looks to be fixed

Test: rapidly tapping FPS while rotating works as expected

Change-Id: Ic830016f8bf52f926681110fcd908619ffc9dd31
2017-09-26 23:16:05 +00:00
jeffreyhuang
fad926bfec Introduce WaitForDebuggerPreferenceController
- Create new WaitForDebuggerPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I95e25ad244328dd49da1b1e8fcd1c264f0ccc587
2017-09-26 15:52:47 -07:00
jeffreyhuang
9d6f5d6f1d Introduce SelectDebugAppPreferenceController
- Create new SelectDebugAppPreferenceController
 - Update onActivityResult to loop through all controllers
 - Add new activity request code
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I90b1da2d536389e45d717adffb3b190ec13b9a2a
2017-09-26 15:52:47 -07:00
jeffreyhuang
35169cde05 Introduce BluetoothAbsoluteVolumePreferenceCtrl
- Create new BluetoothAbsoluteVolumePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If5b979e8bb641eb8ad2db58246362ec327e17f36
2017-09-26 14:56:40 -07:00
jeffreyhuang
9a0495f636 Introduce TetheringHardwareAccelPreferenceCtrl
- Create new TetheringHardwareAccelPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ida551460d8227b20cc6bca3f1d46c39ee7176f8f
2017-09-26 14:55:42 -07:00
jeffreyhuang
371979f38d Introduce WifiVerboseLoggingPreferenceCtrl
- Create new WifiVerboseLoggingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Iccfc9840ed8f5cf4417e326b1bdc62800cb4e93e
2017-09-26 14:54:04 -07:00
Jeffrey Huang
8caf1ff929 Merge "Introduce BluetoothDeviceNoNamePreferenceCtrl" 2017-09-26 21:52:00 +00:00
Jeffrey Huang
dd24c49735 Merge "Introduce MobileDataAlwaysOnPreferenceController" 2017-09-26 21:51:42 +00:00
Jeffrey Huang
a19e3c1e75 Merge "Introduce WifiAggressiveHandoverPreferenceCtrl" 2017-09-26 21:51:30 +00:00
Jeffrey Huang
29b2c07956 Merge "Introduce CameraHalHdrPlusPreferenceControllerV2" 2017-09-26 21:51:01 +00:00
Fan Zhang
cd7b13bba5 Plumb SuggestionControllerMixin to DismissController.
- The SuggestionControllerMixin is needed to dismiss a suggestion.
- When swipe a suggestion, SuggestionControllerMixin is called, which
  then calls API in SuggestionService to dismiss a suggestion.

Bug: 65065268
Test: robotests
Change-Id: I6a0c5823d60b995ab4a36b1c91777f5cd31a500d
2017-09-26 14:09:22 -07:00
jeffreyhuang
c1aca60f61 Introduce MobileDataAlwaysOnPreferenceController
- Create new MobileDataAlwaysOnPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DeveloperSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If4b1a0d14c4b24cb1562a37627436bfb011e9310
2017-09-26 12:13:26 -07:00
jeffreyhuang
78a560ff28 Introduce BluetoothDeviceNoNamePreferenceCtrl
- Create new BluetoothDeviceNoNamePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia73952bd396fb50d96393befd011f7cdc08689f7
2017-09-26 12:10:47 -07:00