- isAvailable() is defaulted to return true for all developer options
preferences
- child controllers should override for custom hiding logic
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I89921f801c25e74bf78d02c55b5f34cf1d464cd0
Fix merge conflict.
The old onSubmit was a no-op. It now correctly pipes onSubmit to
WifiManager#save() with the new WifiConfiguration. On successful save,
it displays the new network in the list, and on failure, it displays a
toast indicating that the save action failed. Adds a test for the
WifiDialog behaviors on this page.
Bug: 66177765
Test: make RunSettingsRoboTests, manual - tested with Wifi enabled and
disabled, and with networks that were visible and not.
Change-Id: I27446aa49bc9efaf1ea1d6c6158928b62ce01ba2
- Create new ShowSurfaceUpdatesPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I649549af1c5dd9d541bc9e6a62b4553fa7877233
- Create new BluetoothInbandRingingPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I2551803b50323c93ce8f1595d5bbab92b7a18ed4
- Create new PointerLocationPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia2d190ec39d35e10d7ae6663584b993d16958d5e
Steps to Reproduce:
- Click on Density Settings (DPI Settings) / Renaming BT Device / Renaming SIM Settings
- EditText Dialog pops up
- The cursor is at the leftmost side of the text
- Logically Cursor should be at rightmost side which can be aligned grabbing text length
Screenshots:
Before:
http://imgur.com/a/o4vkrhttp://imgur.com/a/6Qext
After:
http://imgur.com/a/fuxqThttp://imgur.com/a/vm2WX
Bug: 65185652
Test: RunSettingsRoboTests: OK (47 tests)
Change-Id: Id00308e7e019434edad4afab56cf4719be0d0d54
Signed-off-by: PMS22 <prathams99@rediff.com>
This settings field only shows up on devices which have the
ro.build.selinux property, which is never something we added. This code
is dead.
Change-Id: I20349b4e8fea5be761047e47d4551c1a4f087a37
Test: code compiles and setting app works.
- Create new AdbPreferenceController
- Create AdbOnChangeListener interface for adb change callbacks
- Create EnableAdbSettingWarningDialog
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
- Add deprecated annotation to EnableAdbPreferenceController
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Id57146149943d770bf5ccc9ed5ecc6ea9d8ae66c
This is entirely implementation detail, the public
interface and tests get to stay the same.
- The Raw, Resource and Provider methods now return single
or lists of IndexData rather than adding to a member var.
- Some code duplication was removed for Raw IndexData.
- Extra methods were squashed or removed
The only remaining refactoring in IndexDataConverter is
moving work done on IndexProviders to get the raw and
resources into PreIndexDataCollector.
Bug: 33577327
Test: make RunSettingsRoboTests, Database dump before & after
Change-Id: If6011046955f242ba2614400cfeca3bea5b683cb
- Create new ShowTapsPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ifb4aa9e3c95c04bc7f8fd7e0220c9fe46b502ea6
- Create new ConnectivityMonitorPreferenceControllerV2
- Deprecate ConnectivityMonitorPreferenceController
- Create controller inside the DashboardFragment
- Copy logic from ConnectivityMonitorPreferenceController with slight
modifications for dashboard fragment compatibility
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ibba32208abb2535e1d13b299705e4f4e63aef8c8
It's possible for this sequence of events to occur
1) touch FPS
2) rotate device
3) authentication succeed message goes to pre-rotated activity
The pre-rotated activity will continue authenticating, and the fragment
will not highlight correctly upon authentication
Fixes: 63907591
Test: manual test of above condition, looks to be fixed
Test: rapidly tapping FPS while rotating works as expected
Change-Id: Ic830016f8bf52f926681110fcd908619ffc9dd31
- Create new WaitForDebuggerPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I95e25ad244328dd49da1b1e8fcd1c264f0ccc587
- Create new SelectDebugAppPreferenceController
- Update onActivityResult to loop through all controllers
- Add new activity request code
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I90b1da2d536389e45d717adffb3b190ec13b9a2a
- Create new BluetoothAbsoluteVolumePreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If5b979e8bb641eb8ad2db58246362ec327e17f36
- Create new TetheringHardwareAccelPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ida551460d8227b20cc6bca3f1d46c39ee7176f8f
- Create new WifiVerboseLoggingPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Iccfc9840ed8f5cf4417e326b1bdc62800cb4e93e
- The SuggestionControllerMixin is needed to dismiss a suggestion.
- When swipe a suggestion, SuggestionControllerMixin is called, which
then calls API in SuggestionService to dismiss a suggestion.
Bug: 65065268
Test: robotests
Change-Id: I6a0c5823d60b995ab4a36b1c91777f5cd31a500d
- Create new MobileDataAlwaysOnPreferenceController
- Create controller inside the DashboardFragment
- Port logic from DeveloperSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If4b1a0d14c4b24cb1562a37627436bfb011e9310
- Create new BluetoothDeviceNoNamePreferenceController
- Create controller inside the DashboardFragment
- Port logic from DevelopmentSettings into the controller
Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia73952bd396fb50d96393befd011f7cdc08689f7