Commit Graph

67 Commits

Author SHA1 Message Date
Malcolm Chen
26938b36ee In ApnEditor, restore preference values after re-creating.
After destroying and re-creating, the preference values in ApnEditor
are not restored. This results in incorrect behavior if it enters
two window mode where it's destroyed and re-created. The fix is to
have them restored and shown correctly.

Bug: 65338066
Test: Manual
Change-Id: I5ea16ce01c72061ab116f9c15bfc5cc39bb7a095
2017-09-12 01:01:09 +00:00
Amit Mahajan
a00af97ab1 Change to disable mvno data field in ApnEditor if needed.
Test: manual
Bug: 65243262
Change-Id: I4b3dec6d9dc7fecf0b0a8131dccc349c7daffe48
2017-08-31 21:01:25 +00:00
Amit Mahajan
9eac2f7cbc Change to not cache user entered apn type as user may change it.
Test: manual
Bug: 64263412
Change-Id: Idc49109926e123eddec7f6553f3c493b1ed22212
2017-08-02 09:59:03 -07:00
Amit Mahajan
313c940080 Add new column user_editable to Carriers table in telephony db.
Test: Verified manually that an APN with user_editable=false cannot be
modified via UI
Bug: 62852457
Change-Id: I1dbf2622b7fada8a201c990a06d07a9cdc258840
2017-07-18 16:58:59 +00:00
TreeHugger Robot
94714cf0c9 Change empty apn type in user entered APN to non-read-only types.
Test: Manually added APN and verified read-only and non-wildcardable
types are not included
Bug: 38186417

Change-Id: I07bcf1c2a950a1257446f0a7beb602fed79423b3
2017-07-05 21:46:43 -07:00
Amit Mahajan
7243db2572 Check for null mReadOnlyApnTypes.
Test: none
Bug: 62247121
Change-Id: I6866bf2df8d4cb46dd75b94ab88c1e62e65ddda7
2017-06-01 16:39:40 -07:00
Amit Mahajan
1eee1f8bbc Disallow adding/editing dun APNs unless allowed by carrier.
Test: WIP
Bug: 38186417
Change-Id: If1cc34ad979659a56a3886da2a02fdbf642739ac
2017-05-22 16:01:46 -07:00
TreeHugger Robot
7cab6a9a17 Merge "Change to not call update() if APN is not modified." into oc-dev 2017-05-02 01:59:38 +00:00
Amit Mahajan
657c237522 Change to not call update() if APN is not modified.
Test: manual
Bug: 37629096
Change-Id: Icd7e61267d724b576edf872485dd1a1e2ab18d46
2017-05-01 06:43:52 -07:00
Amit Mahajan
b4ac40b204 Do not call update() for read only APNs.
Calling update marks the APN USER_EDITED and thus makes it user
editable.

Test: manual
Bug: 37607890
Change-Id: Ia5aa0df470e04c8bcc58080577cc3da2ab6dc9df
2017-04-24 11:02:03 -07:00
xiaocheng.x.wang
63bff146ab Merge "Fix apn can't be updated when pressing back key" am: 5c6e7a2116 am: 2d38abb49a am: 2366d4dcfd
am: b4624dceda

Change-Id: I72288936aaf38faf2810dbcf2e426aca68aa8242
2016-12-09 21:14:32 +00:00
Treehugger Robot
5c6e7a2116 Merge "Fix apn can't be updated when pressing back key" 2016-12-09 20:50:39 +00:00
xiaocheng.x.wang
7602e88504 Fix apn can't be updated when pressing back key
APN can't be updated because onkey() method is not invoked when user presses
the virtual back key. The ApnEditor was changed from Activity to Fragment
in Android N. A fragment can't receive onKey() event without calling
setFocusableInTouchMode(true).

Test: manual - updated apn setting, then pressed back
Bug: 32815214
Change-Id: I7824e84bd617d2057a61f4198fa7fd50f123bc8e
2016-11-11 12:48:57 +09:00
Tamas Berghammer
265d3c2a0c Update package names to work with the proto3 compiler
Bug: b/28974522
Change-Id: I5f3adf4946ee4ba1e09e4f40afe83c151405972a
2016-11-08 14:06:17 +00:00
Amit Mahajan
91c60745ce Changes to make APN fields uneditable based on carrier config. am: 7c01344349 am: f3f35a9b1e
am: 69b9c2f04c

Change-Id: I0ed7c050c66594cb91907c99432b12324903934a
2016-09-21 18:52:05 +00:00
Amit Mahajan
69b9c2f04c Changes to make APN fields uneditable based on carrier config. am: 7c01344349
am: f3f35a9b1e

Change-Id: I18e4e4c557d61eb0209a848ed8b2891a7107bc11
2016-09-21 02:24:38 +00:00
Amit Mahajan
7c01344349 Changes to make APN fields uneditable based on carrier config.
Bug: 30457714
Change-Id: I682445eab8eb3ff4ff3eaf036964b467217366f0
2016-09-20 15:25:26 -07:00
Amit Mahajan
a69a6a9e34 resolve merge conflicts of 66a8895 to master
Change-Id: I227a240175034e862ad241ce9c6722a093919616
2016-09-19 10:14:41 -07:00
Amit Mahajan
66a889588d Changes to support read-only apn types. am: 5892792b17
am: b56fab0270

Change-Id: I297226cff2cc7e002686a65ed02b4cea6874f827
2016-09-19 16:41:01 +00:00
Amit Mahajan
5892792b17 Changes to support read-only apn types.
User will not be allowed to add/modify APNs for the read-only types.

Bug: 31074581
Change-Id: I954bd68249a93ce9deb0146725c1432ea6cb0f38
2016-09-16 16:22:18 -07:00
Fan Zhang
ac5e593223 Add logging for a few dialogs in Settings.
Bug: 30681529
Test: Checked via adb logcat -b events |egrep'(sysui_|notification_)'

Change-Id: Ida7ce88f11fd476164f2d016ac0badcd7c549ae4
2016-09-14 13:25:28 -07:00
Fan Zhang
6507613ebc Log visibility change for all fragments.
Bug: 30681771
Test: SettingsUnitTests

Refactor visibility logging from InstrumentedFragment into a mixin. And
apply mixin in remaining fragments.

Change-Id: Ibbb59904336254a3e4bb9e8c7d0b36e5a6bc2622
2016-08-18 14:04:13 -07:00
Jason Monk
feee247e0c Fix build
Change-Id: I264b0d9507e62ad5a2debad663faedd549414012
(cherry picked from commit e3ce6713d3)
2016-06-08 21:29:48 +00:00
Jason Monk
e3ce6713d3 Fix build
Change-Id: I264b0d9507e62ad5a2debad663faedd549414012
2016-06-08 16:09:03 -04:00
Jason Monk
4a8b16323b resolve merge conflicts of 167f6cc to nyc-mr1-dev-plus-aosp
am: 84f544a2ae

Change-Id: I73d7ff76eae3871659063eb58d4efc849f261ac8
2016-06-08 19:34:31 +00:00
Jason Monk
167f6cc87c Merge \"Remove PreferenceActivity\" into nyc-dev
am: 7f7092c705

Change-Id: I1d7431bd7bf4654f2fbfe8c43344e22d28b5b2f7
2016-06-08 19:15:42 +00:00
Jason Monk
b7e4380cd2 Remove PreferenceActivity
Its broken and isn't worth maintaining, instead port the few things
using it over to SettingsPreferenceActivity with wrapping blank
Activities like the rest of Settings.

Change-Id: Ic82f0dcb63ed9b4078f7da6a79c0c52f0130e8d1
Fixes: 28779941
2016-06-08 09:48:58 -04:00
Amit Mahajan
91fb480efa Fix ApnEditor UI -- specifically protocol and roamingProtocol summary
Summary was being overwritten with the value for these fields.

Bug: 28962919
Change-Id: I563213b10253b1c519c31762186c922368d38ef9
2016-05-25 20:26:13 +00:00
Amit Mahajan
d2477357e8 resolve merge conflicts of 5213f71 to nyc-dev-plus-aosp
Change-Id: I6cf4ec06ee296fa13b51e36379a9bc77edaac1bc
2016-04-19 16:15:56 -07:00
yifan.bai
28fa440116 Fix APN cannot save after ApnEditor is paused.
When ApnEditor is paused and user does not enter name or APN,
the new APN URI will be deleted in validateAndSave() method.
After the activity is resumed, the APN will not able to be
saved because the database record has been deleted.

Change-Id: I19f5246020e4a52239a7fc0ac86a281372e34b90
2016-04-11 10:43:41 +08:00
Wei Huang
84fd69a783 MVNO value is not grayed out when MVNO type is none
MVNO type is judged as none by comparing key string to "None",
but this logic does not work when language setting is non English
because key is not "None" due to translation.

Bug: 27267663
Change-Id: Ic39a084cd77f661f833b13106dc28444926487d8
2016-04-01 18:57:22 +00:00
Jason Monk
d2e75e0528 Fix date and time and apn editing
Bug: 27219773
Bug: 25822074
Change-Id: Iec5d56846bf5d3a875180e8907529518949a0d7e
2016-02-17 17:28:46 -05:00
Chris Wren
9d1bfd1e8d port settings over to new metrics enum
Change-Id: I0b3efd2f4db773ccbc52bfe59ee8eb0dab9584fb
2016-01-27 10:58:58 -05:00
Amit Mahajan
21742874f7 Validate the uri received in ApnEditor.
Uri should only refer to telephony carriers and no other provider.

Bug: 11184401
Change-Id: I38c25a37a48883f971c4f405a98db5066a707909
2015-10-28 20:45:25 +00:00
Jason Monk
39b467482d Depend on support lib preferences
Bug: 24576551
Change-Id: Ic6190bacd3f7582c9bbc8de972da4612bd92421e
2015-10-13 10:12:20 -04:00
Sungmin Choi
fab7c109b7 Fix bug to force to close once change Bearer on APN
Bug: 22544257
Change-Id: I43eea4034c3d106b8e3f8e4f999f389db04b7567
2015-07-20 17:09:42 -07:00
Amit Mahajan
17b0c481e0 Show only APNs belonging to carrier (mno/mvno) under apn settings.
Bug: 10719093
Change-Id: I942ce59995afffd395f7d73e4fd70674db0f643f
2015-05-12 17:17:56 -07:00
Amit Mahajan
7e28221640 ApnEditor changes to support bearer as a bitmask.
Change-Id: I8d97f7e789a6ab75f2c5931624fe9694589fc215
2015-04-30 18:03:17 -07:00
Chris Wren
8a963babe2 log visibility of views
Depends-On: I5b1dccb5d103ece3112acf38889bae16273b092f
Change-Id: I116aed2bb805f723a5bf2ec9eb94257de0b4a7b5
2015-03-27 13:39:07 -04:00
John Spurlock
9a23adf69d Settings: Remove all unused imports.
Change-Id: Iebfa52cb849d69974c94902b0b020893cf5618a3
2015-03-18 15:51:15 -04:00
Mick Lin
09c9e5eb5d [DS] Correct the access method for telephony system property
Bug: 18675498

    Review: https://partner-android-review.git.corp.google.com/#/c/198822

Change-Id: I7d6eab7d8f513de20bd8995b999a124097f725e7
2015-01-27 05:30:47 +00:00
Fabrice Di Meglio
daef2e2b06 Fix bug #15730311 Checkboxes on R side should update to Quantum/Material on/off switch
Per UX request, convert more CheckBoxes to Switches

Change-Id: I04712bce4c0a54516d9ecedbb554f403fd6dd9e7
2014-10-15 19:00:35 -07:00
Jing Zhao
f04d69a1d4 Test APNs
Add test APNs to carriers table.
Enable APN Setting editing for testing PLMNs.
Allow user to toggle carrier_enabled for test APNs.

Bug: 17136661
Change-Id: Ieabfac5ea02a5b9971c7050d8278ad0095863e3a
2014-08-28 16:22:19 +00:00
Amith Yamasani
247520c369 More User Settings improvements
Add a menu checkbox to allow creation of users from lockscreen.
Add a delete icon in restricted profiles settings.
Other little fixes to icons.
Update some strings based on feedback.

Bug: 15761405
Bug: 16550371
Bug: 16298824

Change-Id: Ib876bd57f15c6ce2d71856f72571c6b8b0e3102d
2014-07-26 14:09:43 +00:00
Fabrice Di Meglio
710e309951 Fix bug #12978671 RTE while tapping on Access points
- revert back to a PreferenceActivity

Change-Id: Ie79b46908c9d8dcf3c2b77bd0999341c7e72050e
2014-02-11 18:27:38 -08:00
Fabrice Di Meglio
263bcc8b73 Use Drawer in Settings app
- get rid of PreferenceActivity as much as we can and use fragments instead
- add Drawer widget
- add Dashboard high level entry into the Drawer (but this is work in progress and would be done in another CL)
- add bypass of fragment's Header  validation when launched from the Drawer but *force* validation if external
call thru an Intent

Be aware that WifiPickerActivity should remain for now a PreferenceActivity. It is used by SetupWizard and should
not trigger running the SettingsActivity's header building code. SetupWizard is a Home during the provisionnig process
and then deactivate itself as a Home but would make the Home header to appear in the Drawer (because momentarily we
would have two Home).

Also, verified that:

- the WiFi settings still work when called from SetupWizard
- when you have multiple Launchers, the Home header will appear in the list of Headers in the Drawer

Change-Id: I407a5e0fdd843ad7615d3d511c416a44e3d97c90
2014-02-03 16:36:46 -08:00
Sungmin Choi
cd1cb16bad pre-provide the mvno data of the edited apn
For mvno, user can add or edit mvno data field.
Pre-provide the mvno data of the edited apn when the user selects
one of the mvno types.
For example if user choose gid, populate the data field with the
current sim's gid1 data, or if user choose the SPN option, fill
in data with the current carrier string. If IMSI, fill in imsi data.

Change-Id: I1bc280054cc7cd37e78a279866cefd62872a19fb
2013-04-01 16:44:15 -07:00
Sungmin Choi
aa4d4c653b add MVNO field for APN Editor
For MVNO, add related data fields.

Bug: 8143480
Change-Id: Idfa06c6f39a2c15ff4f0815724823f44b76ac819
2013-02-28 13:20:39 +09:00
Tore Anderson
68b9a26543 Enable "APN roaming protocol" for all platforms
Allows users to change the protocol (the PDP context type) used when
roaming in the same way they already can for when they are in their home
network. This is required in order to make IPv6 and IPv4v6 data roaming
work correctly in 3GPP networks.

See also: http://code.google.com/p/android/issues/detail?id=32631

Change-Id: I052842122e5fe96a8779077f0ae9ff4bc83066c5
Signed-off-by: Tore Anderson <tore@fud.no>
2012-08-08 23:10:35 +02:00
Wink Saville
9ad4a89877 Use telephony-common - DO NOT MERGE
Change-Id: Ic95136fd5934afdd53a08bfd640d40add67fdb44
2012-07-17 12:23:26 -07:00