Commit Graph

1212 Commits

Author SHA1 Message Date
TreeHugger Robot
edec9f1795 Merge changes from topic 'FrictionIcons'
* changes:
  Revert picker icon sizes to 24dp.
  Comment changes from ag/1991360.
  Clean up wifi_friction icon unused states.
  Fix list item spacing for preferences.
2017-03-17 23:06:10 +00:00
Daniel Nishi
47b07cc9c1 Merge changes from topic 'storage-o-strings'
* changes:
  Use total size and not free in Storage summary.
  Add new strings.
2017-03-17 22:03:48 +00:00
William Luh
f2feb70ba6 Merge "Cache the summary and icons for Security Settings injected tiles." 2017-03-17 22:01:39 +00:00
Matthew Fritze
5c83cfa278 Remove Index.java from old Search and its dependents
Test: make RunSettingsRoboTests
Bug: 35763944, 36192909
Change-Id:  If216e1eeb4c29e7372720c6228fa4e99ea2a9904
2017-03-17 14:26:05 -07:00
TreeHugger Robot
a2475114ac Merge "Remove "remove account" from account sync detail page" 2017-03-17 19:49:10 +00:00
Sundeep Ghuman
4d725a7708 Comment changes from ag/1991360.
Bug: NA
Change-Id: I832f4459e8becdc5862c83c2b2efd5cee0d417c9
Test: NA
2017-03-17 12:44:54 -07:00
Daniel Nishi
d8bcca1852 Merge "Add lifecycle methods for managing the options menu." 2017-03-17 19:41:39 +00:00
William Luh
45f4e1241d Cache the summary and icons for Security Settings injected tiles.
This helps the summary and icons load more smoothly when resuming
from recents.

Bug: 35994047
Test: make RunSettingsRoboTests
Change-Id: I763f7dd19f64007959e1281f0ff04ecd19bbfbfc
2017-03-17 12:09:58 -07:00
Fan Zhang
499c8d54e8 Remove "remove account" from account sync detail page
Change-Id: I40cc9d3d593c31a5e3b02553ac12f77c0825ed51
Fix: 36375879
Test: make RunSettingsRoboTests
2017-03-17 11:02:46 -07:00
TreeHugger Robot
d964467622 Merge "Fix NPE when building suggestion identifier." 2017-03-17 01:47:59 +00:00
TreeHugger Robot
0fea0d33e5 Merge "Add "Use open Wi-Fi automatically" setting." 2017-03-17 01:34:25 +00:00
Fan Zhang
264c0c2bbe Fix NPE when building suggestion identifier.
And refactored the getIdent logic into feature provider.

Change-Id: Id6f66a6942cbaf6d26ae4dca62037a6cf01179a5
Fix: 36314240
Test: make RunSettingsRoboTests
2017-03-16 17:12:22 -07:00
TreeHugger Robot
0fa7262c49 Merge "Listen to mobile data enabled flag change." 2017-03-17 00:09:54 +00:00
Amin Shaikh
1cf25748d6 Add "Use open Wi-Fi automatically" setting.
- Add toggle to ConfigureWifiSettings for "Use open Wi-Fi automatically"
- Start ACTION_CUSTOM_ENABLE activity and handle result to set the
USE_OPEN_WIFI_PACKAGE setting.

Bug: 34773276
Test: make
Change-Id: I602e271d5113e415d290468548e35059bd45d8b8
2017-03-16 16:54:20 -07:00
Daniel Nishi
17529b7dc1 Add lifecycle methods for managing the options menu.
Test: Settings robotests
Change-Id: I087cd0ec097041a4c4e0dd561dd2ec62f45f5390
2017-03-16 16:13:20 -07:00
TreeHugger Robot
8c451742d0 Merge "Purify SettingsActivity from old search code." 2017-03-16 23:01:45 +00:00
Fan Zhang
917721c8d6 Listen to mobile data enabled flag change.
The listener is necessary to show/hide the gear icon on top of billing
cycle settings screen as user turn on/off mobile data from QS.

code cleanup: remove dividedCategory

Fix: 28066849
Test: make RunSettinsgRoboTests

Change-Id: I3b7075512042127fd711a8a70a572adfed069502
2017-03-16 15:08:49 -07:00
Matthew Fritze
0b431fc003 Purify SettingsActivity from old search code.
Bug:35763944, 32590887
Test: make RunSettingsRoboTests
Change-Id: Id8140b68a676e595bff095546fa119cd3ced2c4a
2017-03-16 14:14:44 -07:00
TreeHugger Robot
d764c57dcc Merge "Remove ranking code for Old Search" 2017-03-16 20:15:02 +00:00
Fan Zhang
4eb22906bb Merge "Fix a crash when resuming sound setting with AfW on Ryu" 2017-03-16 20:13:36 +00:00
TreeHugger Robot
89052d7268 Merge "Update some strings to match spec" 2017-03-16 18:30:09 +00:00
Fan Zhang
dc9a82f5b0 Fix a crash when resuming sound setting with AfW on Ryu
Also renamed a few xmls

Change-Id: I8ff5a778a39ea45471a27048be4ea2f21075872a
Fix: 36357493
Test: make RunSettingsRoboTests
2017-03-16 11:26:33 -07:00
Fan Zhang
50f82ac557 Update some strings to match spec
Change-Id: Iba242871fce9c9bca8fbbc5d3ad3f7948f35d3d0
Fix: 36234108
Test: make RunSettingsRoboTests
2017-03-16 09:59:42 -07:00
Matthew Fritze
aa15a8e9c6 Remove ranking code for Old Search
Test: make RunSettingsRoboTests
Bug:35763944
Change-Id: I30b1d22f2de293bd6ff03352ca5793b00beec61a
2017-03-16 08:53:14 -07:00
TreeHugger Robot
94d2dece74 Merge "Create robolectric tests for WifiNetworkDetailsFragment." 2017-03-16 00:46:38 +00:00
TreeHugger Robot
54c962f55e Merge "SearchFragment removes stale data from the database" 2017-03-16 00:17:12 +00:00
TreeHugger Robot
b1427f0034 Merge "Disable collapse when fragment is opened from search" 2017-03-16 00:13:19 +00:00
Daniel Nishi
f1050cb7c7 Use total size and not free in Storage summary.
Fixes: 36223330
Test: Settings Robotest
Change-Id: I4406dc673961db0f91ae37da3abd0e1541517c7d
2017-03-15 16:51:21 -07:00
Matthew Fritze
ebb5b7f73d SearchFragment removes stale data from the database
When search fragment is created, it will get a list of
the non-indexable keys and verify that each of the results
are not a part of that list.

This CL moves the non-indexable keys logic into a
controller for shared use between SearchFragment
and DatabaseIndexingManager.

Bug:33209418
Test: make RunSettingsRoboTests
Change-Id: I4ed3812ecc5ee9e63b75ba6edbc7ff8712e8e9c9
2017-03-15 15:34:49 -07:00
Sundeep Ghuman
4c1b174f5f Create robolectric tests for WifiNetworkDetailsFragment.
More tests to follow in separate CLs. Submitting test class in order to
unblock parallel development.

Bug: 35963536
Test: make RunSettingsRoboTests
Change-Id: I50752ba0d6c53d016bf5809f7bd5d5f6e0350b90
2017-03-15 15:34:42 -07:00
Fan Zhang
f0215712ba Disable collapse when fragment is opened from search
Change-Id: I9564dff4ec53256a0fe992055049cf65ce68e37b
Fix: 36076953
Test: make RunSettingsRoboTests
2017-03-15 15:21:34 -07:00
TreeHugger Robot
0104852dc0 Merge "Refactor all saved query related logic into a controller" 2017-03-15 21:44:36 +00:00
Daniel Nishi
02b269be4b Merge "Category breakdown size should match total size." 2017-03-15 20:30:10 +00:00
TreeHugger Robot
0ef2a55b08 Merge "Allow page to suppress all of its content from search." 2017-03-15 19:44:41 +00:00
Fan Zhang
8c3dc96b21 Refactor all saved query related logic into a controller
Change-Id: I96f7dd91d7d2715141a9905cb59262d927560da4
Fix: 27391895
Test: make RunSettingsRoboTests
2017-03-15 12:41:00 -07:00
Fan Zhang
fe44549626 Add button to remove saved search query
TODO: move all saved query related logic into its own manager instead of
leaving them in SearchFragment.

Change-Id: I9635140eb507331246f9035a23138421cfa4b50a
Fix: 27391895
Test: make RunSettingsRoboTests
2017-03-15 10:43:10 -07:00
TreeHugger Robot
be0e3f376e Merge "Display recents when search fragment open." 2017-03-14 21:46:34 +00:00
Fan Zhang
cabc509e4f Allow page to suppress all of its content from search.
To suppress things from search, we usually use preferencecontroller to
control individual items. But a page can sometimes to disabled
entirely. Now it can set isPageSearchEnabled to false to achieve that.

Change-Id: I39424b7fdc6460e27fd7c83cf09b5ace12d1cc37
Fix: 36201167
Test: make RunSettingsRoboTests
2017-03-14 13:59:33 -07:00
Lei Yu
0ff13a4971 Merge "Remove hardcoded color for settings dashboard" 2017-03-14 20:01:33 +00:00
Fan Zhang
199b0fd697 Display recents when search fragment open.
Bug: 27391895
Test: make RunSettingsRoboTests
Change-Id: I62cfa35af96babf85a795910aa76dc774e2b80f2
2017-03-14 11:59:57 -07:00
jackqdyulei
9d690bdbd7 Remove hardcoded color for settings dashboard
1. Change card_background to default background color. In settings
light theme, background color is exactly the #fafafa
2. Change card_background_grey to colorSecondary, which is
material_grey_200 in settings light theme.

Bug: 36139640
Test: Screenshot
Change-Id: I20081e768985ce6c0b9000448ae48599f18b293a
2017-03-14 10:40:09 -07:00
TreeHugger Robot
e02d17ac8a Merge "Add misc logging:" 2017-03-14 17:17:15 +00:00
TreeHugger Robot
eb3d371953 Merge "Update strings and layout for enterprise privacy" 2017-03-14 00:44:03 +00:00
TreeHugger Robot
6ea894bbb8 Merge "Swipe to dismiss suggestions" 2017-03-13 23:38:40 +00:00
Fan Zhang
c49ab99007 Add misc logging:
- Button clicks in app detail page:
  uninstall/disable/clear data/clear cache
- More logging in search:
  log inline search result click, and its metadata such as
  name/value/rank.

Fix: 32652772
Fix: 32798201
Test: make RunSettingsRoboTests
Change-Id: I90cef7c9ea9ea69ea9cf083013a38417097f8594
2017-03-13 16:30:55 -07:00
Bartosz Fabianowski
ba66a0ef09 Update strings and layout for enterprise privacy
This CL continues the finalization of UI layout and strings for the
enterprise privacy page:
* Turn footer into a header
* Update strings
* Dynamically generate summaries for entry points in security page

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: Ibf248ac269380fb1b919b01f88f721130060b7f9
2017-03-13 23:59:35 +01:00
Daniel Nishi
26a5a71d31 Merge "Don't show owner as a secondary user." 2017-03-13 22:11:00 +00:00
Fan Zhang
a5b620e738 Swipe to dismiss suggestions
- Move dismiss suggestion logic into feature provider
- In DashboardData, use hashcode as suggestion's stable id. This is much
  more likely to provide a truely stable id for each suggestion card.
  Eventually I want to use hash for all tiles to provide stable id.
- Add a SuggestionDismissionController to handle swipe to dismiss
  callbacks

Change-Id: If3770f07a90c5469a0b86fc28f3eb5e4c17227cd
Fix: 35159816
Test: make RunSettingsRoboTests
2017-03-13 14:39:00 -07:00
TreeHugger Robot
bb5509f84f Merge "Extends the touch area for the switch in Master Switch preference." 2017-03-13 21:26:30 +00:00
Matthew Fritze
8145b0f35a Merge "Add optional feedback button for settings search" 2017-03-13 19:39:50 +00:00