Commit Graph

10474 Commits

Author SHA1 Message Date
kholoud mohamed
00c46041b6 UX changes for the new cross profile settings page
Bug: 136249261
Bug: 140728653
Bug: 148594054
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesDetailsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesSettingsTest

Change-Id: I9666b34a03e5c082eed7c4120e70a07017ab7ef0
2020-02-14 11:51:39 +00:00
Jason Chiu
ca9ece1a0c Card showing mechanism change in homepage
- update contextual card proto interface to fit the new SettingsIntelligence
- show sticky cards at the tail of the card area

Bug: 149274976
Test: robotest
Change-Id: Icca167825c1c037ec12d8836d82c5fdff4331a8e
2020-02-14 17:44:11 +08:00
Bonian Chen
4074e9aab7 [Settings] Code refactor for IMS part
Return boolean in method names starting with "is".

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Change-Id: I2a9ca9ae829f0dcda478f3343cd50e61f441a9a7
2020-02-14 16:29:11 +08:00
Zhen Zhang
c2b9e5ef20 Update summary for AllInOneTetherPreference accordingly
The summary for AllInOneTetherPreference in NetworkDashboardFragment is
updated according to tethering state and tether interface chosen by
user.

Bug: 149256198
Test: AllInOneTetherPreferenceControllerTest, TetherEnablerTest,
CodeInspectionTest

Change-Id: I24ba4deabbb02b203e76d32048040d7ccf1b2d22
2020-02-14 00:14:23 -08:00
Zoey Chen
7b8e8255cd Merge "[Settings] Add permission for #getCdmaRoamingMode and use value from TelephonyManager Bug: 145788881 Test: make Change-Id: Idf237f008af2ab6cab07689f1f2a602f6a98c4f1 Merged-In: Idf237f008af2ab6cab07689f1f2a602f6a98c4f1" am: 864bd01efe
Change-Id: I951346d955f2223fce1b4c88e72cd44a5e33e1a5
2020-02-14 07:01:49 +00:00
Zoey Chen
864bd01efe Merge "[Settings] Add permission for #getCdmaRoamingMode and use value from TelephonyManager Bug: 145788881 Test: make Change-Id: Idf237f008af2ab6cab07689f1f2a602f6a98c4f1 Merged-In: Idf237f008af2ab6cab07689f1f2a602f6a98c4f1" 2020-02-14 06:49:45 +00:00
Menghan Li
8a689ab650 Merge "Remove DaltonizerPreferenceControllerTest unnecessary test" 2020-02-14 01:59:19 +00:00
Zhen Zhang
c4a2294730 Merge "Add a Preference into "Network & internet" for new tethering UI" 2020-02-14 00:05:54 +00:00
Menghan Li
655debca76 Merge "Accessibility Service & Shortcut Redesign - Remove “volume key shortcut” setting (2/n)" 2020-02-14 00:01:49 +00:00
menghanli
8a3a58eea5 Remove DaltonizerPreferenceControllerTest unnecessary test
Bug: 149481490
Test: make RunSettingsRoboTests ROBOTEST_FILTER=DaltonizerPreferenceControllerTest
Change-Id: Ieda7481a49fb84802e8ad27851c1971269ab1cde
2020-02-14 07:46:52 +08:00
TreeHugger Robot
c4e63d7834 Merge "Ignore two broken tests" 2020-02-13 21:16:15 +00:00
Raff Tsai
7d932e4ef6 Merge "Fix test case error" 2020-02-13 17:51:19 +00:00
Bonian Chen
fd8e319801 Merge "[Settings] Replace isImsRegistered" 2020-02-13 17:25:57 +00:00
Raff Tsai
c793bd4761 Fix test case error
Fixes: 149473766
Test: make RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.deviceinfo.storage"
Change-Id: I94c857f1ed806ce5f6727a0159dd6e49a20e532a
2020-02-14 00:02:24 +08:00
TreeHugger Robot
1e7ecc1ad5 Merge "Show the footer when global switch is off." 2020-02-13 15:34:31 +00:00
Zhen Zhang
31f1a34629 Add a Preference into "Network & internet" for new tethering UI
Adding a MasterSwitchPreference into "Network & internet" and create
corresponding controller. The preference is hidden by the feature flag.
It does NOT affect the existing UI.

Bug: 146147778
Test: CodeInspectionTest, TetherPreferenceControllerTest,
NetworkDashboardFragmentTest
Change-Id: Ida8e088efbb22d0c983acecbc420672206392dad
2020-02-12 23:55:02 -08:00
menghanli
a8b9f30d11 Accessibility Service & Shortcut Redesign - Remove “volume key shortcut” setting (2/n)
Bug: 142529032
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityShortcutPreferenceControllerTest
Change-Id: Ic55d4fd8db0678b8fccbbb6ef1d217b47a5094bd
2020-02-13 15:44:11 +08:00
Menghan Li
c359bdf884 Merge "Accessibility Service & Shortcut Redesign - Remove “volume key shortcut” setting (1/n)" 2020-02-13 06:28:42 +00:00
menghanli
40f9e47bb7 Accessibility Service & Shortcut Redesign - Remove “volume key shortcut” setting (1/n)
Bug: 142529032
Test: Manual test
Change-Id: Icfff02b25b1c83598774dd1708e145c0cf9447d7
2020-02-13 06:27:07 +00:00
Tsung-Mao Fang
1958a27d24 Ignore two broken tests
Bug: 149352891
Test: run robo test
Change-Id: I835e2170e1513fe5cfc2473c5537147c8d4eb113
2020-02-13 14:17:26 +08:00
Peiyong Lin
89bc735369 Show the footer when global switch is off.
In the original implementation we showed a footer when global switch is off,
however, this was broken due to some refactor. This patch fixes the issue where
we don't set the visibility of the footer when global switch is on/off.

Bug: b/148626177
Test: make RunSettingsRoboTests ROBOTEST_FILTER=GraphicsDriver
Change-Id: I0f0763ee1551199cc8611c650350a2adbdf402ed
2020-02-12 16:03:51 -08:00
Yiwen Chen
54114d7895 Merge "Device config flag clean up." 2020-02-12 22:07:42 +00:00
Zach Johnson
6c562f763a Merge "Revert "Pass in active device to all BluetoothA2dp APIs in packa..."" 2020-02-12 21:39:48 +00:00
Daniel Chapin
2be6fc2afe Revert "Pass in active device to all BluetoothA2dp APIs in packa..."
Revert submission 10253996-bt-a2dp-no-null

Reason for revert: b/149361880
Reverted Changes:
If43934374: Pass in active device to all BluetoothA2dp APIs in...
I22dd1ca36: Make sure calls to BluetoothA2dp APIs pass non-nul...
If6475af6f: Require user pass in a non-null BluetoothDevice to...
I9d0e2c89c: Pass in active device to all BluetoothA2dp APIs in...
I1faa6174d: Need to now pass in active device instead of null ...
I69a941a7e: Pass in active device to all BluetoothA2dp APIs in...

Change-Id: I1d8660b11c917cf657e61478d58794182e17ec1a
2020-02-12 17:16:10 +00:00
Bonian Chen
569f760c12 [Settings] Replace isImsRegistered
Replace isImsReigstered() by callback from ImsMmTelManager.

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=SimStatusDialogControllerTest
Change-Id: I904da749df7074918d205ebd004a173ed109c561
2020-02-12 21:10:07 +08:00
TreeHugger Robot
6b37d72c1b Merge "Revert "Revert "Show "Add users from lock screen" dependent on secure lock screen.""" 2020-02-12 13:01:53 +00:00
Bonian Chen
f9bf994ae0 Merge "[Settings] Code refactor for Wifi calling IMS API" 2020-02-12 06:14:31 +00:00
Bonian Chen
cf19596829 Merge "[Settings] Data roaming warning only when turn ON" 2020-02-12 06:14:20 +00:00
timhypeng
716777d3ad Replace preference with remote media preference group in xml
-remove previous preference controller and its test cases
-update sound setting test case

Bug: 147395289
Test: make -j42 RunSettingsRoboTests
Change-Id: I9e383e11370a13868fdbcb76eafef5aedad895c5
2020-02-12 04:57:18 +00:00
TreeHugger Robot
9ccbadebab Merge "Rename GameDriver* to GraphicsDriver*." 2020-02-12 02:43:03 +00:00
Thomas Devaux
3f0b74cf84 Merge "Auto-open Captive Portal when user clicks on open network." 2020-02-12 02:37:58 +00:00
Stanley Wang
b53efae0ab Merge "Fix security issue for using mock location without permission." 2020-02-12 02:23:52 +00:00
TreeHugger Robot
ff6e341509 Merge "Add remote media slice in volume panel" 2020-02-12 01:34:15 +00:00
TreeHugger Robot
910cc87fcb Merge "tether setting: fix test error: updateDisplay_shouldUpdateValue" 2020-02-12 01:33:13 +00:00
Treehugger Robot
226ef3d100 Merge "Import translations. DO NOT MERGE" 2020-02-12 01:12:50 +00:00
Peiyong Lin
4e89f929d7 Rename GameDriver* to GraphicsDriver*.
To make graphics driver selection more generic, rename GameDriver
specific classes to GraphicsDriver.

Bug: b/148626177
Test: make RunSettingsRoboTests ROBOTEST_FILTER=GraphicsDriver
Change-Id: If2780b32e2826bda56de11734736260f916182d0
2020-02-11 16:50:26 -08:00
Thomas Devaux
158d17fef6 Auto-open Captive Portal when user clicks on open network.
Rationale: many users are confused about what to do after tapping the captive
portal network in Settings, and since there is explicit user action to
connect to that network at that point, auto-opening the portal is
natural and makes it simpler.

Bug: 148538768
Test: manually with local AP with Captive Portal and:
> make RunSettingsRoboTests -j40
> atest com.android.server.ConnectivityServiceTest

Change-Id: I29573132cd3e46ff22e6f67bb3678516fabac47d
2020-02-12 00:45:46 +00:00
Zhen Zhang
2d7264eb75 Merge "Add tether preferences into AllInOneTetherSettings" 2020-02-11 23:34:55 +00:00
TreeHugger Robot
7b036f36e1 Merge "Add a settings for notification history" 2020-02-11 20:50:18 +00:00
Ben Murdoch
fa92269759 Revert "Revert "Show "Add users from lock screen" dependent on secure lock screen.""
And fix the failing test that caused the revert.

Bug: 148015798
Bug: 149209670
Test: make -j64 RunSettingsRoboTests

This reverts commit 666dacc32a.

Change-Id: I34bb82e621e009ec26c28835f309e7a5b996e9b3
2020-02-11 13:35:45 +00:00
Bonian Chen
19135546a3 [Settings] Data roaming warning only when turn ON
handlePreferenceTreeClick() goes after setChecked() however
configuration may have been altered within setChecked().

Follow same design within MobileDataPreferenceController to fix this
issue. A boolean state will be maintained as the condition when warning
dialog is required when click.

Bug: 148491064
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=RoamingPreferenceControllerTest
Change-Id: I63c4e2149b0e9efa16fd9ee402652c67eb9c5a4d
2020-02-11 20:46:44 +08:00
Zhen Zhang
ec966cb7a3 Add tether preferences into AllInOneTetherSettings
These preferences are for user to toggle a specific tethering option,
like USB, BT or WIFI.

Bug: 147323306
Test: CodeInspectionTest, AllInOneTetherSettingsTest, TetherEnablerTest
Change-Id: I1229ffd2dd12b39e9c6e48dc29c6e46ce9ad7634
2020-02-10 23:04:37 -08:00
TreeHugger Robot
181ca05462 Merge "Fix incorrect UI issue of "previously connected devices"" 2020-02-11 06:43:02 +00:00
Stanley Wang
cdf4028142 Fix security issue for using mock location without permission.
Remove mock location apps if developer option is disabled.

Change-Id: Iad32ea336376eeb923f6d4424fd85c2da2bb5128
Bugs: 145136060
Test: manual
2020-02-11 14:33:34 +08:00
lesl
df450cc9f6 tether setting: fix test error: updateDisplay_shouldUpdateValue
ag/10257734 change band convert to general design.
Fix test to match new design

Bug: 149251992
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
Change-Id: I6f09d9d4f440515fb51a237d966327e232fe5928
2020-02-11 11:18:21 +08:00
TreeHugger Robot
bc4981d25f Merge "Pass in active device to all BluetoothA2dp APIs in packages/apps/Settings as null input is no longer supported" 2020-02-11 02:36:51 +00:00
TreeHugger Robot
9368270fe2 Merge "Revert "Show "Add users from lock screen" dependent on secure lock screen."" 2020-02-11 02:07:24 +00:00
Roshan Pius
93f6c463d6 Merge "Settings: Use new API for wifi wakeup feature toggle" 2020-02-11 00:36:17 +00:00
Jon Spivack
666dacc32a Revert "Show "Add users from lock screen" dependent on secure lock screen."
This reverts commit 0149363a39.

Reason for revert: Droidcop: Potential culprit for Bug 149209670- verifying through Forrest before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ia1f1ce35ef5d93664cf665bea86a472376b84aab
2020-02-10 22:11:57 +00:00
Rahul Sabnis
dcedd7d6f5 Pass in active device to all BluetoothA2dp APIs in
packages/apps/Settings as null input is no longer supported

Bug: 147287141
Test: Manual
Change-Id: If43934374914c657080ffd0509f8095d988cc550
2020-02-10 11:16:49 -08:00