Commit Graph

30 Commits

Author SHA1 Message Date
Peter Kalauskas
80e914a263 Enable use_resource_processor for all sysui deps
This will make the build faster

Test: m checkbuild
Bug: 295208392
Change-Id: If75acb6b1c3f204e3686c20cef609f7cfabe15cf
2023-09-21 23:09:39 +00:00
Chaohui Wang
8e2ae547d6 Clean up FeatureFactory.getFeature()
Bug: 286764889
Test: m Settings
Change-Id: I7e472e6b0ca6b7a735c1b92742ddf06c545176fc
2023-08-08 08:41:48 +00:00
Chaohui Wang
2541381259 Fix references to resources for Settings
Bug: 293810334
Test: m Settings
Change-Id: Ie140278f492ef7e1c062ec1ecae2866c521a86aa
2023-08-08 01:56:05 +00:00
Etan Cohen
d3f7fa6aef Force MAC randomization to enabled on ACTION_WIFI_ADD_NETWORKS
The ACTION_WIFI_ADD_NETWORKS allows an app to request the user to
confirm addition of WiFi networks. The intent attaches
WifiNetworkSuggestions (used to specify the networks). However, the
calling app may configure MAC randomization to be disabled - using
reflection.

Fix to always override the MAC randomization setting to enabled. This
will override any user configuration to disable randomization - however,
considering this is (now) a new configuration it should safely start
from the default Setting.

Verified using using a test app to force non-randomized (using
reflection) value and confirm that without change randomization is
disabled and that with change it is reset correctly.

Bug: 236825742
Test: manual - use a test app
Change-Id: I3fba958c461d88005fdb5d2c3d1f2fd4ce725b8c
2023-03-19 16:20:48 +00:00
Weng Su
673f06c2ec Show WiFi minimum level when the Wi-Fi level is UNREACHABLE
- Use WIFI_LEVEL_MIN instead of WIFI_LEVEL_UNREACHABLE to get the Wi-Fi icon resource to avoid app crashing because no valid Wi-Fi icon could be found.

Bug: 213294802
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksFragmentTest

Change-Id: Ia805e902716c25db3276b96116a84d0dd2d96a1b
2022-09-26 20:54:19 +08:00
Weng Su
08adf4c2ed Ignore CRLF strings in display SSIDs to avoid display errors
- Keep user-entered SSIDs in Wi-Fi Configuration

- Ignore CRLF strings in display SSIDs only

Bug: 224545390
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksFragmentTest

Change-Id: Ifc081f9c5c02b2d70412f296688b88e44e893add
2022-07-05 03:18:26 +08:00
Weng Su
f53f3e6e41 Restrict AddAppNetworksActivity for guest user
- Don't show AddAppNetworksActivity if the user is a guest.

Bug: 224772678
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksActivityTest

Change-Id: I17571905f1c4a38db884e6d0523b7f8d668df607
2022-06-16 00:33:07 +08:00
Weng Su
f5cd7140f4 Fix adding wifi configuration issue
- The Wi-Fi Enterprise Restrictions add a new
  UserManager.DISALLOW_ADD_WIFI_CONFIG restriction from T.

- When a user requests to add Wi-Fi configuration, Settings will
  reject the request if the user is not allowed.

- The above restriction need to be retrieved in advance so that the
  user's request will not be rejected.

- See the result screenshot in b/224459753#comment8

Bug: 224459753
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksActivity

Change-Id: I2dfb6b9946dd9dbd4eb8bf0f6549ac5cb4466f17
2022-03-23 06:18:55 +08:00
Quang Luong
9d66b22ee0 Do update signal icon for -1 level in AddAppNetworksFragment
The level of a WifiEntry may be -1 (WIFI_LEVEL_UNREACHABLE) due to race
conditions. Thus, only update the signal icon if the level is a valid
value [0, 4]

Bug: 213477566
Test: m
Change-Id: I87f1c108d262bb5a7575c9ad434d2cfb953134af
2022-01-21 14:56:07 -08:00
changbetty
06df9c9fc0 Add WiFi Enterprise restrictions check for WiFi Configuration Addition
When UserManager.DISALLOW_ADD_WIFI_CONFIG is set to true.
  - Disable the "Add network" item in the Internet settings.

  - Activity action API for ACTION_WIFI_ADD_NETWORKS should not be
    permitted and the user shouldn’t see a prompt for approval

Bug: 203169077
Test: make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksActivityTest
Change-Id: I18d7703b5972bfbc12dca10b6432d756813abace
2022-01-10 16:06:20 +00:00
changbetty
064aa91e45 Add package name check for the calling app
Bug: 198661951
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksActivityTest
Change-Id: I68a543a5c9a5b74db30780f6a6d9f9bc9c6eec08
2021-10-18 03:17:06 +00:00
Alex Stetson
aff80d1e14 Use shared model for non-system overlay toggle
Allows settings applications on other platforms to re-use values by
migrating to Settings.secure and moving HideNonSystemOverlayMixin to
SettingsLib.

Bug: 184967544
Test: atest SettingsUnitTests
Change-Id: If9aaeca29ebb8b481d75622934503e368d7435d3
2021-05-06 08:28:19 -07:00
Steven Liu
c1477650c9 Introduce a WifiTrackerLibProvider.
This make the WifiTrackerLib can be customized.

Bug: 149540986
Test: manual test wifi picker, and atest com.android.settings
Change-Id: I1418ae39c895ce2ff87f18005a226a4835f9e083
2021-01-06 08:44:34 -08:00
Arc Wang
e7c2bc6e1a [Wi-Fi] Fix a UI defect of AddAppNetworksFragment
After clicking Save button, the signal icon always shows level 0.
To correctly get the signal, this change fetches both
saved WifiEntries and connected/connecting WifiEntry for signal
icon information.

Bug: 157344581
Test: manual visual
      1. Use the intent Settings.ACTION_WIFI_ADD_NETWORKS to bring up the UI.
      2. Click Save button and observe the signal icon.
Change-Id: If33d1c02019ea2c1acccfbbc29bd1bf42de1cc82
2020-05-25 11:05:37 +08:00
govenliu
23d91663f6 [Wi-Fi] Enhance AddAppNetworksFragment unit test cases
Add new unit test cases in AddAppNetworksFragmentTest.java

The coverage rate of com.android.settings.wifi.addappnetworks will raise from 65% to 81%

Bug: 151696220
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksFragmentTest
Change-Id: Iae15b5ad27b20f90cbf8b0318a24a9069b738a33
2020-05-15 16:05:45 +08:00
Arc Wang
a52782bc06 [Wi-Fi] Quit worker thread of WifiPickerTracker
Should quit worker thread when a fragment is about to
be destroyed.

Bug: 152454787
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksFragmentTest
Change-Id: I809511b7f7c092cf9787e8f6bb7c7513c27c98c8
2020-05-13 10:34:51 +08:00
govenliu
0fc956bc57 [Wi-Fi] Refactor AddAppNetworksFragment to use WifiEntry but not AccessPoint.
Because WifiTracker2 refactoring in framework side is done, Settings App need to refactor AddAppNetworksFragment to use WifiEntry but not AccessPoint.

Bug: 152454787
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksFragmentTest
Change-Id: Ica2fb7e7fcac112140e5d64f3e4193222c974352
2020-03-26 19:48:51 +08:00
David Su
b03044351e Rename WifiNetworkSuggestion#getPasspointConfiguration
Renamed to getPasspointConfig to be consistent
with setPasspointConfig

Bug: 149912516
Test: compiles
Change-Id: I5809f50793f89eb3b811c019b7494a437dd991e7
2020-02-23 19:12:02 +00:00
govenliu
e88f5efeb9 [Wi-Fi] Apply cache in WifiTracker to update the signal icon immediatelly.
issue: Signal icon on the add wifi network feature need to wait for the scan result.
Solution: Apply the cache in the WifiTracker to update signal icon for
shortening the waiting time of new scan result.

Bug: 146842198
Test: Add following unit test cases to test signal level has been updated correctly:
      1. withOneSuggestion_whenScanResultChangedButWifiOff_uiListShouldHaveZeroLevel.

Change-Id: Id72e2b43e020f2cafa2af4af5ffb1c28529002bd
2020-02-04 10:40:55 +08:00
David Su
77b86b1e55 Migrate AddAppNetworksFragment to use public getWifiConfiguration()
Field wifiConfiguration is @hide and cannot be
used, instead use public getter.

Bug: 138801922
Test: compiles
Exempt-From-Owner-Approval: Fix broken build
Change-Id: Idcaa2fee1950651b1a60e52838083ac8d75e9462
2020-01-21 18:13:27 +00:00
David Su
f56c4defc7 Merge "Settings: migrate usage of @hide NetworkSuggestion APIs" 2020-01-21 17:05:24 +00:00
govenliu
7e1018c0d0 [Wi-Fi] Add Wifitracker mechanism to update the signal icon.
Signal icon on the add wifi network feature is constant, didn't change with real signal level.

Bug: 146842198
Test: Add following unit test cases:
      1. withOneSuggestion_uiElementShouldHaveInitLevel() to test init level.
      2. withOneSuggestion_whenScanResultChanged_uiListShouldHaveNewLevel() to test level should updated according to scan result.

Change-Id: I212a825da9455a09a5c7777f87c0a74ec030c890
2020-01-20 17:34:20 +08:00
David Su
453d88568f Settings: migrate usage of @hide NetworkSuggestion APIs
Settings uses @hide WifiNetworkSuggestion.
wifiConfiguration/passpointConfiguration.
Migrate to @SystemApi getters.

Removed call to PasspointConfiguration.validate()
as it is an @hide API, instead
WifiManager.addOrUpdatePasspointConfiguration()
will perform the required validation.

Bug: 138801922
Test: make RunSettingsRoboTests -j40
Change-Id: I748010b66634b1d24e89a175917492f638267cb1
2020-01-17 15:41:40 -08:00
govenliu
237290f854 [Wi-Fi] Refactor add wifi networks feature to use WifiNetworkSuggestion.
WifiConfiguration used in the feature of add apps Wi-Fi networks was Deprecated, need to be changed to use WifiNetworkSuggestion.

Bug: 136472483
Test: Refactor AddAppNetworksFragmentTest to apply WifiNetowrkSuggestion
Change-Id: I022d200905880f7f7bd367f5fa62fa88e785db02
2020-01-16 09:38:00 +08:00
govenliu
2b97be399f [Wi-Fi] Change constant security type definition to Wificonfig value
Remove constant security type definition and use
Wificonfiguration.Authtype() to judage same Config or not

Bug: 147258501
Test: Just change constant, so only manually check.
Change-Id: Ib6397f9b6deeec3595b51b8243e35993867460e5
2020-01-07 19:01:08 +08:00
govenliu
d9a414b61e [Wi-Fi] Add a new intent handler process for adding new networks panel page.
For the R feature "Add saved networks to the
device for apps", need to handle the new intent case to update the content to be the specific networks in the new intent.

Bug: 146105504
Test: Add following unit test case to check if UI list had been updated:
      getThreeNetworksNewIntent_shouldHaveThreeItemsInUiList.

Change-Id: Id043fabb16ba5a75aa81be8cacd403e62e5268b8
2019-12-23 18:23:51 +08:00
govenliu
cfd8a5d253 [Wi-Fi] Use new defined proto field for adding new networks panel page.
Use new metric, PANEL_ADD_WIFI_NETWORKS, for proto upload log use.

For R feature: Add a mechanism for apps to add saved networks to the
device, need to apply new metrics category.

Bug: 144891278
Test: Add following test case for testing metric:
      getMetricsCategory_shouldReturnPanelAddWifiNetworks()

Change-Id: I7cde8057c5f2b01c951b1de4203ab1c1a2f0f40a
2019-12-18 13:57:30 +08:00
govenliu
c45672be54 [Wi-Fi] Add multiple networks request case for adding Wi-Fi for apps feature.
Handle adding multiple networks case, add UI components and process saving flow.

Bug: 136472483
Test: Add unit test cases to test filterSavedNetworks API.
Change-Id: I222e2f8294793796e293de49acdb96ecd6a57b0d
2019-12-05 17:33:51 +08:00
govenliu
7b6b93b4f8 [Wi-Fi] Add one network request case for adding Wi-Fi for apps feature.
Handle adding one network case, add UI components and process saving/connecting flow.

Bug: 136472483
Test: Add unit test cases to test one network in list case and null list case, and also check if the SSID set correct or not.
Change-Id: I99f804a967575538c9dc3f1faabb2b507e92e558
2019-11-28 16:39:06 +08:00
govenliu
d507b56ad1 [Wi-Fi] Add basic UI structure for adding Wi-Fi for apps feature.
Add following changes:
1. Add intent receiver.
2. Add panel UI with icon, title, summary.
3. Add two buttons (save and cancel).
4. Add test case for activity and fragment

Bug: 136472483
Test: Add following test cases for checking button and package name in activity and fragment.
      1. AddAppNetworksActivityTest
      2. AddAppNetworksFragmentTest
Change-Id: I5515a96fa3feb0e3e6d68159b2c0dec0894c15ee
2019-11-22 17:02:59 +08:00