Commit Graph

48821 Commits

Author SHA1 Message Date
Fan Zhang
87c69c0440 Merge "Disable toggling wifi tethering in secondary user." 2018-11-19 18:32:11 +00:00
TreeHugger Robot
f9fcdc1b74 Merge "Refined the CardContentProvider unused operations" 2018-11-19 18:00:25 +00:00
tmfang
86fcd905b0 Add below/above dividers for new action buttons
- App info
- App storage
- Power usage

Test: visual
Bug: 116346008
Change-Id: Ie4a4ad6f41b74e7bc38f3ac99f241da6be19e647
2018-11-19 18:02:09 +08:00
Raff Tsai
667e9137f6 Change Switchbar fontFamily and textSize
Test: manul
Change-Id: I8e03dd9ca500ab5517ed7a0d4abcb6e9edfbe239
Fixes: 116342461
2018-11-19 17:43:18 +08:00
tmfang
787cfb34c8 Apply new action buttons style for instant app
Test: visual
Bug: 116346008
Change-Id: I5a9f31960da28757e51683db4011820f7339e2f9
2018-11-19 14:10:53 +08:00
Kevin Chyn
b4dcebec03 Use the correct manager to generate token
Bug: 111548037

Test: manual
Change-Id: I84f106ace988165f9f6dbc667c46302cbd1c6226
2018-11-16 15:58:02 -08:00
Doris Ling
9f1c617016 Disable toggling wifi tethering in secondary user.
- in previous release, the shortcut widget was for the top level
Hotspot & Tethering settings page. The top level settings has logic to
check whether the page is restricted and remove all preferences and
show a message to tell the user that tethering settings are not
available, and the user will not be able to launch the wifi hotspot
settings page.
- the updated shortcut now launches the wifi hotspot page directly.
The settings does not check for restriction. Copy the logic from the top
level settings to check for restriction and remove all preferences
accordingly.

Change-Id: I76fb7838e2db379f6ffbce7bf14003bccc1b10d3
Fixes: 116642428
Test: make RunSettingsRoboTests
2018-11-16 15:05:22 -08:00
Doris Ling
ac00f2cb76 Fix data usage failing test.
- update the tests that faile when data usage v2 is turned on.

Change-Id: I6bd09245d695791fb1564b6e598600e889d0712f
Fixes: 117433810
Test: make RunSettingsRoboTests
2018-11-16 13:06:37 -08:00
TreeHugger Robot
bd088c4205 Merge "Only update mutable shortcuts." 2018-11-16 19:11:26 +00:00
Salvador Martinez
5e568343c2 Merge "Update Settings components for dark theme" 2018-11-16 18:29:48 +00:00
Raff Tsai
d9d57be243 Merge "Fix Settings crash when clicking search bar" 2018-11-16 15:45:26 +00:00
Johnson Lu
dda5cbad68 Merge "Add QrDecorateView for QrCode scanner implementation" 2018-11-16 13:06:27 +00:00
TreeHugger Robot
3704899fc9 Merge changes from topic "settings-action-button"
* changes:
  Remove setButtonPositive method
  Apply new action button visual design
  Create a new visual design for action buttons
2018-11-16 10:45:29 +00:00
TreeHugger Robot
3f31a7820d Merge "Make UI refresh when there is only one contextual card left." 2018-11-16 09:50:31 +00:00
Sunny Shao
8e5807fcc9 Refined the CardContentProvider unused operations
updated delete and update operations to throw UnsupportedOperationException

Bug: 119647595
Test: robotest
Change-Id: If77662213b89dc91b9ca2d6b028c635a46266eab
2018-11-16 15:44:53 +08:00
Yanting Yang
5b5d4c6d33 Merge "Add Low Storage slice to Contextual Settings Homepage" 2018-11-16 07:36:02 +00:00
tmfang
5c7f4de999 Remove setButtonPositive method
Since new UI design only exist two button in layout,
we don't need these methods anymore.

Test: robotest
Bug: 116346008
Change-Id: If2e8f7dddb9c13e480438f36fe3c5d6affa4e9ff
2018-11-16 14:33:16 +08:00
tmfang
3adb74ea60 Apply new action button visual design
- Add some icon resources.
- Add icon for each button in action button preference.
- Update "Enable" and "Disable" string to "Install" and "uninstall".
- Remove unused string.
- Add divider between entity header and action buttons.

Test: visual, robotest
Fixes: 119203074
Bug: 116346008
Change-Id: Ib8d7aeb2943d39d257e977b84f165f002bf47559
2018-11-16 14:33:03 +08:00
Emily Chuang
9c52951ba6 Make UI refresh when there is only one contextual card left.
After having card dismissal mechanism implemented, it is possible that
the card list loaded from the card loader will be empty (users may
dismiss all cards). When there is only one card remaining on the screen
and user dismiss it, the card should go away.

Fixes: 119580732
Test: robotest
Change-Id: I7ae3b03f16a0b8b009d8aa77811b5a6d39c359e7
2018-11-16 14:15:54 +08:00
Raff Tsai
d103f8eb81 Fix testcase fail
-Ignore testcase in RemoteDeviceNameDialogFragmentTest
-Fix SettingsPreferenceFragmentTest and ApnEditorTest testcase fail

Test: make RunSettingsRoboTests
Change-Id: I63053cd2256c9c00f92b57a813513e5df05fd60a
Bug: 119592320
2018-11-16 12:26:23 +08:00
Johnson Lu
49abb2cc6d Add QrDecorateView for QrCode scanner implementation
This view draw the lines at the corner of the inner frame.

Bug: 118797380
Test: RunSettingsRoboTests
Change-Id: I159dba8d3a23eaa489932a1a13f63a574079b448
2018-11-16 10:45:51 +08:00
Raff Tsai
6c731f4631 Merge "Fix crash on AppInfoDashboardFragment" 2018-11-16 02:14:23 +00:00
Doris Ling
79848abfbd Only update mutable shortcuts.
When trying to update the flags for the existing shortcuts, check and
skip the immutable shortcuts, since they should not be modified.

Change-Id: Iee70ed92f45c1b0b0f0c5b902069c017acfa4990
Fixes: 119119713
Test: make RunSettingsRoboTests
2018-11-15 16:29:53 -08:00
Salvador Martinez
2bb9930866 Update Settings components for dark theme
This CL updates the colors and properties of various themes and
widgets to make them follow dark theme UI. Specifically, it changes
the color accent and uses true black for the background.

Test: manual inspection
Bug: 111397440
Change-Id: I15214a4c5d4864244af856312d2fc3e3a7e7ce36
2018-11-15 15:00:44 -08:00
Beverly Tai
4fa2b88556 Merge "Add new settings page for apps overriding dnd" 2018-11-15 18:06:06 +00:00
Raff Tsai
a75a724bdd Fix Settings crash when clicking search bar
- When user disable settings suggestion in App Settings, click
search button without leaving settings app. The search button is
still existed.
- Doesn't allow user to disable app in App Settings
- Add check before start search intent

Change-Id: Ifbc4615914678d8df734e14d63bb626403313d1e
Fixes: 118805907
Test: manual
2018-11-15 18:08:40 +08:00
tmfang
5659fc6ac9 Fix crash on AppInfoDashboardFragment
When AppInfoDashboardFragment launch a new page,
it sets SUB_INFO_FRAGMENT(1) as request code.

This request code is same as REQUEST_REMOVE_DEVICE_ADMIN(1).
So, when AppInfoDashboardFragment got onActivityResult callback,
it will handle the event about REQUEST_REMOVE_DEVICE_ADMIN.

So, we change REQUEST_REMOVE_DEVICE_ADMIN to a unique value.

Test: manual test, robotest
Fixes: 118841475

Change-Id: Idabd62c5062ccfbf4b8acee82df7401fc9ce7484
2018-11-15 16:58:29 +08:00
Yanting Yang
04eb082bce Add Low Storage slice to Contextual Settings Homepage
Bug: 114808204
Test: robotests, visual
Change-Id: I0c1a02dc40a0a72b7a2ad8f46505325e52bee942
2018-11-15 16:32:12 +08:00
Leon Liao
d6f13c1c49 Merge "Implement a11y UI for Accessibility timeout feature." 2018-11-15 07:17:40 +00:00
Stanley Wang
83680c7c98 Merge "Layout updated for file size text wrapping with largest display" 2018-11-15 07:10:49 +00:00
TreeHugger Robot
6f93c8bb31 Merge "Fix App permission doesn't show summary" 2018-11-15 04:10:40 +00:00
Leon Liao
fc29b1c331 Implement a11y UI for Accessibility timeout feature.
This UI control the Accessibility Timeout API in Settings App.
Add a user control to set timeout length to suit their need.

Bug: 119283926
Test: atest AccessibilityTimeoutControllerTest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=CodeInspectionTest
Test: atest UniquePreferenceTest
Change-Id: Ic8f7337e6bd7739c1189382cc87d45465b64c6ed
2018-11-15 10:24:43 +08:00
tmfang
8f65efa8f9 Create a new visual design for action buttons
- Create a new style for two action buttons.
- Change the layout of two_action_buttons.
  Since we use same style for positive/nagative
  buttons now, we only remain button1/button2 for
  this layout.
- Create a setButtonIcon interface in ActionButtonPreference.
  So, user can set icon for each button in this preferece.

Test: visual, robotest
Bug: 116346008
Change-Id: I511272cba5fd961349b85cae6d30004ddabe2c8e
2018-11-15 10:15:58 +08:00
TreeHugger Robot
ac6377199e Merge "Show device name in About Phone summary." 2018-11-15 02:13:35 +00:00
Raff Tsai
12b3c70d7b Merge "Change function modifier" 2018-11-15 02:09:54 +00:00
TreeHugger Robot
1a2d01b8a6 Merge "Use ColorDisplayManager" 2018-11-15 00:40:26 +00:00
Kevin Chyn
4cb30c6656 Merge "Fix ConfirmDeviceCredentials for work profiles" 2018-11-15 00:24:09 +00:00
Doris Ling
97d0593298 Show device name in About Phone summary.
- change from using device model to device name for the top level about
phone preference summary.

Change-Id: I6c1891f3867f55cf1501baf76ea147e2df49111e
Fixes: 119157622
Test: make RunSettingsRoboTests
2018-11-14 14:52:41 -08:00
Beverly
7973c635c9 Add new settings page for apps overriding dnd
Close starred contacts cursor

Test: atest ZenModeAllBypassingAppsPreferenceControllerTest
Test: atest ZenModeBypassingAppsPreferenceControllerTest
Bug: 111475013
Change-Id: I84d259aaef1bc5cc907ec5bef08beade91a8b904
2018-11-14 15:56:29 -05:00
TreeHugger Robot
8208d28461 Merge "Add setup chooselock internal activity to manifest." 2018-11-14 19:15:30 +00:00
Kevin Chyn
127da9c73c Fix ConfirmDeviceCredentials for work profiles
1) Fixed the theme for CDCA$InternalActivity to be transparent
2) CDCA only cares about biometrics, which are tied to userId
3) Moved shared methods to a util class

Fixes: 119296586

Test: Followed the steps in comment#1 of the bug linked above


Change-Id: Ie47fc7c3a53dfb7780087937e1ca83287cc52d71
2018-11-14 11:03:57 -08:00
TreeHugger Robot
2167b7deab Merge "Update delete user strings in multiple users page" 2018-11-14 18:12:24 +00:00
TreeHugger Robot
c052bcb8be Merge "Update strings" 2018-11-14 13:18:38 +00:00
Edgar Wang
22e29a28ee Update delete user strings in multiple users page
Change-Id: I3ab25e491af3894f8163d9ef9a88c446575ebbc3
Fixes: 111723127
Test: visual
2018-11-14 20:32:59 +08:00
Edgar Wang
913790b4cb Update strings
Bug: 118399687
Test: visual
Change-Id: I0b5f86235b7fd7530ba8eeed9649f0c3dc3b94bf
2018-11-14 18:17:32 +08:00
Eran Messeri
8e9e32e1b9 Merge "Private DNS: Add policy transparency" 2018-11-14 10:07:33 +00:00
Raff Tsai
3dbd1651d8 Change function modifier
- We need to use getName() function in different package

Test: rebuild
Bug: 79698338
Change-Id: I2e7eb71863fee14f58e84efd8064891f7e34fd3c
2018-11-14 17:42:25 +08:00
Yanting Yang
3085eac41f Merge "Add description into strings.xml for missing comment" 2018-11-14 09:25:16 +00:00
Stanley Wang
1ed36d8b23 Layout updated for file size text wrapping with largest display
This solution will change the portrait layout for
large, larger, and largest of Display size.

Change-Id: Ib00b23553c34c1e69cb84e446f409c38ea7544ef
Fixes: 69074097
Test: manual
2018-11-14 16:31:53 +08:00
tmfang
057539f186 Fix App permission doesn't show summary
Since AppPermissionsPreferenceController assigns
a fixed preference key in constructor, so it can't
be used by same controller in Privacy page.

So, we change contructor directly, let controller
read preference key from xml file.

- Also remove unused imports.

Test: visual
Bug: 116628158
Change-Id: I42d6e978e91f0a2fe796d290cb9f34db596aa1f4
2018-11-14 16:25:48 +08:00