Commit Graph

24391 Commits

Author SHA1 Message Date
TreeHugger Robot
ae40f0018c Merge "Update scanning settings to show states in summary" 2018-12-08 09:32:19 +00:00
TreeHugger Robot
625646a55c Merge "Add a helper class for filtering available subscriptions" 2018-12-08 01:13:24 +00:00
Lifu Tang
bee747173f Update scanning settings to show states in summary
Bug: 120220144
Test: build, flash, and test manually
Change-Id: I913d93c2f41e5ffea1d0b9c00d519eba327a0832
2018-12-07 16:11:53 -08:00
Antony Sargent
270296ea23 Add a helper class for filtering available subscriptions
In several places implementing the new changes for better UX with
multiple mobile subscriptions, we need a bit of code that filters the
results coming from the SubscriptionManager. This CL adds that common
code in a util class that will be used in later CLs.

Bug: 116349402
Test: RunSettingsRoboTests
Change-Id: Ie9376629604ac2c4a2f15123edc380c5999f2f83
2018-12-07 13:40:28 -08:00
TreeHugger Robot
34668b6494 Merge "Don't plot usage data beyond current date." 2018-12-07 19:24:43 +00:00
TreeHugger Robot
a0d2adf198 Merge "Reload data if slice binding returns null at rendering time." 2018-12-07 17:02:11 +00:00
TreeHugger Robot
978aaad16f Merge "Log contextual card is visible and homepage is displayed event" 2018-12-07 04:11:45 +00:00
TreeHugger Robot
b8f00fa1ac Merge "Show reboot dialog when tunring off developer option" 2018-12-07 02:05:41 +00:00
Yi-Ling Chuang
ddfc085f2b Reload data if slice binding returns null at rendering time.
We are not able to guarantee the binding results in the pre-check and
real binding would always be the same sinc slice may decide what it
would be based on some conditions. Hence, we should reload data and
refresh UI when it comes to null to prevent from blank suggestion.

Bug: 120221527
Test: visual
Change-Id: I79790edfe7fc3af7b9c3b3a7df6a7ffa7d405d50
2018-12-07 09:54:15 +08:00
Doris Ling
8727a40893 Don't plot usage data beyond current date.
- the new data usage api returns buckets for future date with 0 usage.
When we plot the data usage chart, need to check the bucket date to make
sure we only plot points up to the current date.

Change-Id: I50e161ca9cdbb30c8fda8f6cdd24c993b546ad0d
Fixes: 120490567
Test: make RunSettingsRoboTests
2018-12-06 17:12:05 -08:00
Raff Tsai
e58e0c6e0e Log contextual card is visible and homepage is displayed event
Bug: 79698338
Test: Robolectric
Change-Id: I89ac5ed2765729d8571e84d3a050f0aa07385caa
2018-12-07 09:00:05 +08:00
TreeHugger Robot
e4128eca14 Merge "Allow appending static preferences to RadioButtonPickerFragment" 2018-12-06 23:57:39 +00:00
Doris Ling
985d85e8c1 Merge "Add search to app info list." 2018-12-06 22:39:27 +00:00
TreeHugger Robot
a5cafaad3a Merge "Catch error when we fail to get slice icon." 2018-12-06 22:25:48 +00:00
Salvador Martinez
42e9d26635 Allow appending static preferences to RadioButtonPickerFragment
This makes it so that static preferences can also be added after
the candidates so they can show up on the bottom of the screen.
This is done via a new xml tag for the preference screen that
is usually mostly empty that RaiodButtonPickerFragments use

Test: robotests
Bug: 111450127
Change-Id: I0fe2f480f0ff59b9bf9269e94b33ab4b008b47b8
2018-12-06 14:03:08 -08:00
Fan Zhang
69a56b42a1 Catch error when we fail to get slice icon.
Change-Id: Ia8bdf1ef8a090d2f939abf27b2308eafde7d8928
Fixes: 120588243
Test: robotests
2018-12-06 12:21:44 -08:00
Chen Xu
f80e5b561e Merge "address API council feedbacks for Telephony.Carriers" 2018-12-06 20:11:18 +00:00
Antony Sargent
2b0c991efc Merge "Layout changes in v2 Network & internet page" 2018-12-06 18:55:42 +00:00
Fan Zhang
fec2c738ef Merge "Correct metrics category in ConnectedDeviceSlice" 2018-12-06 17:59:30 +00:00
Beverly Tai
05f2e476e4 Merge "Update DND strings" 2018-12-06 14:09:02 +00:00
Yanting Yang
bd8374fb26 Merge "Fix deep link issue of Slice cards in home page" 2018-12-06 09:56:19 +00:00
TreeHugger Robot
82d5a9afda Merge "Added FloatingAppBarScrollingViewBehavior" 2018-12-06 09:47:49 +00:00
Chienyuan
eda2987b86 Show reboot dialog when tunring off developer option
The toggle button "Disable Bluetooth A2DP hardware offload" in developer
options need reboot to take effect when value changed. Otherwise, the
A2DP will not work until user reboot the device.

If we want this toggle button change back to default value when turning
off developer options, we need reboot device as well.

This patch will check the property value of A2DP hardware offload. If
turning off developer options will change the value, show a dialog to
force the user to reboot device.

Bug: 80449594
Test: make -j50 RunSettingsRoboTests

Change-Id: Ibace1ff72c1b41bd55444242a74e3f0b49187668
2018-12-06 17:40:21 +08:00
TreeHugger Robot
97a6c1f4a4 Merge "Stop observing a slice view when a slice is dismissed." 2018-12-06 06:36:23 +00:00
Sunny Shao
2f7f14f08c Added FloatingAppBarScrollingViewBehavior
-Added FloatingAppBarScrollingViewBehavior for search bar. It can be scolling,
 transparent and overlapped the scrolling child view.
-Exchanged the position of NestedScrollView and AppBarLayout in
 settings_homepage_container.xml.
-Set the app bar height.

Change-Id: I6ef4c9001a1f893292fcbc825a0a9f2069b7286b
Fixes: 118886724
Test: robotest
2018-12-06 14:24:49 +08:00
Xiangyu/Malcolm Chen
c8b7207edb Merge "Only enable data for one SIM in DSDS." 2018-12-06 01:25:07 +00:00
Malcolm Chen
42055cbe50 Only enable data for one SIM in DSDS.
Only enable mobile data for one SIM for simplicity. Which means When
turning on mobile data on non-default sub, pop a notification to user
that it will turn off data of the other one.

Bug: 120515679
Test: manual and unittest
Change-Id: I7c190bb70d771b7f280c246038a380e4fc7338a3
2018-12-06 01:24:58 +00:00
TreeHugger Robot
5923b3d677 Merge "Make a few custom slices implement CustomSliceable." 2018-12-06 01:14:24 +00:00
Fan Zhang
d7fa2fa64e Make a few custom slices implement CustomSliceable.
Bug: 80263568
Test: robotests, slice-browser
Change-Id: Id809a347d77448917154c2d1144fd2517e70829a
2018-12-05 15:47:14 -08:00
Doris Ling
35c066c997 Add search to app info list.
- add a search option menu to the manage applications page.
- add a search filter to the app list adapter to remove any app whose
app name does not contain the search query.

Change-Id: Ie749daeef2cdc4a22fade45422ae90f44d00ceb2
Fixes: 119598311
Test: make RunSettingsRoboTests
2018-12-05 15:31:51 -08:00
TreeHugger Robot
4e681c1586 Merge "Fix manual certificate installation" 2018-12-05 22:43:24 +00:00
Antony Sargent
11b7c7f254 Layout changes in v2 Network & internet page
This adds the skeleton of a header section which will only appear when
the device has two or more active mobile subscriptions. Subsequent CL's
will add the actual logic implementing it.

Also this moves up the airplane mode toggle higher up on the page, and
removes the proxy selector entry (which has been unconditionally
disabled by the ProxyPreferenceController for a while).

Bug: 116349402
Test: manual (this is mostly a layout change - subsequent changes will
have actual logic to test for the subscriptions header)

Change-Id: Iaee338d5c13e05d3c2d9d04872a94cf90e5da588
2018-12-05 14:18:45 -08:00
Beverly
fdebb9632b Update DND strings
Fixes: 120497233
Bug: 111475013
Test: manually flash and check strings
Test: make RunSettingsRoboTests -j40
Change-Id: I0a8971226a485f8ec41d83c167e51dac1a9c8107
2018-12-05 17:13:49 -05:00
TreeHugger Robot
bccad4abd8 Merge "Reset dismissal UI to the baseline when exiting the page." 2018-12-05 18:32:51 +00:00
Christine Franks
c4be214f47 Merge "Move color management check to ColorDisplayManager" 2018-12-05 16:29:51 +00:00
Yanting Yang
66b2b91d72 Fix deep link issue of Slice cards in home page
Add setData(uri) back to intent to fix deep link launching error.

Change-Id: Ibffce43ddeb9a1388d001515d8d3b320c5b45520
Fixes: 120473478
Test: robotests, visual
2018-12-05 21:10:47 +08:00
Yanting Yang
7b0dc688c2 Correct metrics category in ConnectedDeviceSlice
The used category METRICS_CATEGORY_UNKNOWN in Bluetooth detail intent is
not matched. Correct the category to BLUETOOTH_DEVICE_DETAILS.

Bug: 114807655
Test: robotest
Change-Id: I941db81164ac2b3a09b6d3c0d97f14c5e65fb6ed
2018-12-05 19:03:56 +08:00
Eran Messeri
ca2291cc30 Fix manual certificate installation
Fix a bug where, when the user manually imports a certificate + key into
KeyChain, the imported certificate would sometimes not be marked as
user-selectable and so the user would not see it when
KeyChaine.choosePrivateKeyAlias was called.

The cause was the async task for marking the key as user-selectable
sometimes executing after the activity for installing the certificate
has terminated, leading it to try and interact with an
already-terminated KeyChain service.

The fix is to call the activity's finish() method only after the key is
marked as user-selectable.

Test: Manual, using CtsVerifier KeyChain Storage test.
Bug: 116716944
Change-Id: I23832ff7b609d7c609e734af48e9a0642f1df527
2018-12-05 10:05:29 +00:00
Yi-Ling Chuang
72e54c8f85 Stop observing a slice view when a slice is dismissed.
In order to receive updates of slices, we make sliceLiveData observes
slice views. When a slice is dismissed, it should stop observing
the view so the view can be recycled and reused.

Fixes: 120465506
Test: robotests
Change-Id: Ie4f12e9a3e6e0e7d59d3346ab17282707047bf16
2018-12-05 13:52:11 +08:00
Yi-Ling Chuang
2efa93460c Reset dismissal UI to the baseline when exiting the page.
Flip the card back to slice view if users exit the page instead of
getting the dismissal UI preserved. We should also reset the UI to the baseline
if users dismiss a card, so when the view is reused, slice view can
then be displayed correctly.

Change-Id: If5448c57dec44ef5c1d3472358d4ddc9398538b8
Fixes: 119820168
Test: robotests
2018-12-05 11:58:34 +08:00
TreeHugger Robot
8df1f9384e Merge "Add action/ or intent/ to all custom slice uri path." 2018-12-05 02:00:25 +00:00
Leon Liao
15cdfc4ec2 Merge "Add summary with accessibility timeout item" 2018-12-05 00:30:38 +00:00
Fan Zhang
8a4d854603 Add action/ or intent/ to all custom slice uri path.
Test: rebuild, robotests
Change-Id: Ibb4a071cffb458a9f871aa11ff2737cd40328574
2018-12-04 16:07:40 -08:00
TreeHugger Robot
5a95813df9 Merge "Schematize vold system properties" 2018-12-05 00:00:42 +00:00
TreeHugger Robot
b6323b9608 Merge "Set slice uri as data in PendingIntent." 2018-12-04 23:24:28 +00:00
Leon Liao
2457f46fa8 Add summary with accessibility timeout item
Add summary with accessibility timeout item in Accessibility
Settings. This summary describe its level to time limit of
Accessibility timeout feature.

Bug: 119283926
Test: atest AccessibilitySettingsTest
Test: atest AccessibilityTimeoutControllerTest
Test: make RunSettingsRoboTests
Change-Id: I86c096e6f4adb62150e1ff2af4c22afac240b41e
2018-12-05 05:35:54 +08:00
Fan Zhang
66d4f77d2e Set slice uri as data in PendingIntent.
Presenter needs to disambigue multiple slice action PendingIntents, just
setting extra is not enough.

Bug: 117445451
Test: manual
Change-Id: I26e10bc064585e241def72e6b5194c117a9ebc16
2018-12-04 13:21:24 -08:00
Fan Zhang
e994d4665d Fix crash when dynamic_homepage flag is off.
This partially rolls back ag/5650901. We should revert this change when
dynamic_homepage flag is permanently on.

Change-Id: I5e340421d04bc20c77dd30395fd8522693807954
Fixes: 118444000
Test: manual
2018-12-04 13:05:47 -08:00
Doris Ling
282a0d9222 Remove "v2" from the data usage version 2 code.
Change-Id: I8ede82029194d1a9a43d00a3de7ec1a8dd77d978
Fixes: 117420679
Test: make RunSettingsRoboTests
2018-12-04 18:24:37 +00:00
Fan Zhang
d3ad570818 Merge "Make migrate option menu invisible when src volume is not mounted" am: 6db9f21256 am: b084c60686
am: 4036866211

Change-Id: I25f21e3c176e225db6900d3c93b6a8860e701061
2018-12-04 10:15:02 -08:00