Commit Graph

23703 Commits

Author SHA1 Message Date
TreeHugger Robot
75e2bdbcc9 Merge "Do not include disabled activity in Default Browser." 2018-09-13 01:57:53 +00:00
TreeHugger Robot
7e8ea8db98 Merge "Fix nits in contextual card package." 2018-09-13 01:36:37 +00:00
Fan Zhang
ff6f6f6991 Merge "Clean up: delete unused methods" am: 41f9566da8 am: b371dea0cb
am: 88cbe51f27

Change-Id: Ib166230d692cc7a3973355239161ed88ffd6af60
2018-09-12 17:44:52 -07:00
Fan Zhang
88cbe51f27 Merge "Clean up: delete unused methods" am: 41f9566da8
am: b371dea0cb

Change-Id: I0545f7f9914337d64d8d91eb152005e4858b6869
2018-09-12 17:39:21 -07:00
Fan Zhang
b371dea0cb Merge "Clean up: delete unused methods"
am: 41f9566da8

Change-Id: I973b289c688c04c00f70a6c0ba15a5b205d6633a
2018-09-12 17:12:54 -07:00
Fan Zhang
41f9566da8 Merge "Clean up: delete unused methods" 2018-09-12 23:46:31 +00:00
TreeHugger Robot
4d44c02b0e Merge "Remove battery app list feature flag" 2018-09-12 23:26:20 +00:00
TreeHugger Robot
b01d15aab1 Merge "Fix visibility of AddUser when toggling multiuser." 2018-09-12 22:34:55 +00:00
Doris Ling
dfe663879d Do not include disabled activity in Default Browser.
- query the intent activites with flags 0, so that only
enabled activities will be returned.

Change-Id: I6ec4e3f3fdff850228a723bcb2d2bdc5721b41eb
Fixes: 111796304
Test: make RunSettingsRoboTests
2018-09-12 15:34:49 -07:00
Fan Zhang
089ed21526 Fix nits in contextual card package.
We missed to catch a few nits in previous CLs. This change cleans up
some of it.

Test: manual
Change-Id: Ibd3466f781952f998e1183a49f56e812cbce99a1
2018-09-12 14:07:12 -07:00
Fan Zhang
de3ff1eee1 Merge "Implemented the CardContentLoader" 2018-09-12 20:14:56 +00:00
Fan Zhang
409a5f8c98 Clean up: delete unused methods
Test: rebuild
Change-Id: I144ebbdaf137ee091af949a9e38f68d02941f705
2018-09-12 13:08:15 -07:00
jackqdyulei
94b26f12ad Remove battery app list feature flag
It is not used anymore

Bug: 115542275
Test: Build
Change-Id: I931d081a13d5d4b698c785205d356182fec3e02d
2018-09-12 12:58:04 -07:00
Doris Ling
73d7773eb2 Fix visibility of AddUser when toggling multiuser.
- when enabling multi user, also need to update the visibility of the
Add user preference, but need to check the add user capability as well.

Change-Id: Ia243901c7537bdb39ca3a39aed559b003f803e4d
Fixes: 115397726
Test: make RunSettingsRoboTests
2018-09-12 12:33:46 -07:00
Sunny Shao
a87e4cb227 Implemented the CardContentLoader
- Implemented the CardContentLoader
- Refactored the CardLoader and increased the code readable
- Added try-with-resource
- Removed all custom card codes
- Modified ContextualCardManager to add CardContentLoaderCallbacks

Bug: 112521307
Test: robotest
Change-Id: Ieb9cdeaacdfb8fdae9747c60395206d15af034c1
2018-09-12 10:34:40 -07:00
TreeHugger Robot
16a71df6a3 Merge "Check for Data Usage intent before populating "Data Usage" summary." 2018-09-12 16:57:19 +00:00
Lenka Trochtova
2f4558d3fc Revert the mandatory backups feature.
Bug: 79736299
Test: make RunSettingsGoogleRoboTests
Test: make RunSettingsRoboTests

Change-Id: Ie9702664c0fb4daccdee74eac6080c959fe1b608
2018-09-12 11:52:11 +02:00
Fan Zhang
d67668a1c3 Merge "Fix a crash when launching app detail for bad package name" am: ada1a39ffb am: 2e2e1e243d
am: 59cd5abb96

Change-Id: I746d5c959761306d463a934e7c01f4155934fd93
2018-09-11 18:53:09 -07:00
Fan Zhang
59cd5abb96 Merge "Fix a crash when launching app detail for bad package name" am: ada1a39ffb
am: 2e2e1e243d

Change-Id: I3614f70f71c0e0eb064331175cb51fa30ed5a5b7
2018-09-11 18:49:12 -07:00
Fan Zhang
2e2e1e243d Merge "Fix a crash when launching app detail for bad package name"
am: ada1a39ffb

Change-Id: Ia96ca4a889e9005da4e685b8e04ae2d6b78eff85
2018-09-11 18:28:08 -07:00
Fan Zhang
13d2551156 Fix a crash when launching app detail for bad package name
Change-Id: I3bfb5f8e003b810c09d295bc89f4a59af186a121
Fixes: 78779901
Test: robotests
2018-09-11 15:12:16 -07:00
TreeHugger Robot
939f3a3823 Merge "Null check for ManagedServiceSetting dialog title" 2018-09-11 19:08:54 +00:00
Beverly
6543b077cb Null check for ManagedServiceSetting dialog title
Test: manual
Change-Id: If3753b01431ab9690cdbae5a0d7f0edf9c80fcec
Fixes: 114803288
2018-09-11 10:06:13 -04:00
Sunny Shao
744cb8b18f Merge "Added the bulkInsert for CardContentProvider" 2018-09-11 03:32:34 +00:00
Fan Zhang
18eecb1e67 Add config to disable app tray preview in display size.
Also move some files

Change-Id: I4636fcd81425991acadede0b703e09513c82543c
Merged-In: I4636fcd81425991acadede0b703e09513c82543c
Fixes: 113374067
Test: robotests
2018-09-10 19:01:35 -07:00
Fan Zhang
9aca4cb48c Add config to disable app tray preview in display size.
Also move some files

Change-Id: I4636fcd81425991acadede0b703e09513c82543c
Fixes: 113374067
Test: robotests
2018-09-10 15:03:54 -07:00
Sunny Shao
45a3919cf4 Added the bulkInsert for CardContentProvider
- Modified CardContentProvider and added bulkInsert
- Modified CardContentProviderTest
- Moved the endTransaction to finally clause
- Let insert call bulkinsert

Bug: 111820446
Test: robotest
Change-Id: Ie84fe1143abc28bb60f261ce763051bedd469100
2018-09-10 11:15:35 +08:00
TreeHugger Robot
698465c236 Merge changes I81990d63,I053a6220
* changes:
  Fix settings crash if launched with null args
  Fix settings crash on noti listener screen
2018-09-08 04:52:19 +00:00
TreeHugger Robot
16d523b349 Merge "Do not show AddUser if adding user is not allowed." 2018-09-08 01:22:46 +00:00
Doris Ling
e845b40f35 Do not show AddUser if adding user is not allowed.
- when multi user is enabled, we should keep the current visibility for
AddUser preference, since earlier check has been done to update its
visibility according to the add user capability. We should only set the
visibility to false if multi user is disabled.

Change-Id: I246e9242f255dbd57c5309b2d16c95d202607531
Fixes: 114241868
Test: make RunSettingsRoboTests
2018-09-07 14:08:49 -07:00
Fan Zhang
44be9131b1 Open personal settings tab when launching homepage
Change-Id: I341e1a128fda7db8f953f9a0800050cc007554c5
Fixes: 114441682
Test: manual/robotest
2018-09-07 13:44:21 -07:00
Fan Zhang
ea0b32d1ed Misc clean up
- Rename a few more things from Homepage* to ContextualCard*
- Fixed a wrong parameter that GridLayoutManager was using

Test: rebuild
Change-Id: I7986b1caf63158e876295de6d31dbbe05581664d
2018-09-07 12:40:47 -07:00
Julia Reynolds
cbacfc5753 Fix settings crash if launched with null args
Test: manual
Change-Id: I81990d63606074fc670cc39471c91ee61a73f1fc
Fixes: 73666426
2018-09-07 15:24:09 -04:00
Julia Reynolds
e4fe56e161 Fix settings crash on noti listener screen
Test: manual
Bug: 114417814
Change-Id: I053a62201d3e9a1066d16d4a494a0c13bebccaf7
2018-09-07 15:23:12 -04:00
Fan Zhang
72a7d87a65 Merge "Rename a bunch of stuff." 2018-09-07 15:48:54 +00:00
TreeHugger Robot
cfa39d3b6b Merge "Don't update state after stop bluetooth tethering" 2018-09-07 06:20:59 +00:00
Dan Willemsen
831768fffe Fix imports on pi-dev-plus-aosp to fix build
Change-Id: Ifa467eef0f9264348d657ceb8372990313b42fed
Merged-In: I0b1a170967ddcce7f388603fd521f6ed1eeba30b
2018-09-06 21:13:57 -07:00
Fan Zhang
a746381401 Rename a bunch of stuff.
For homepage cards, rename Homepage* to ContextualCard*.

Change-Id: I95740f15a1789683fa6c61f03ecf9bc47c367146
Fixes: 113966426
Test: robotests
2018-09-06 18:15:12 -07:00
Fan Zhang
21526c1f80 Launch the new TopLevelSettings for all settings tab.
The new TopLevelSettings page uses a standard DashboardFragment to host
all top level settings. It's easier to maintain than DashboardSummary.

It does not support conditional cards or suggestion cards. We will use
PersonalSettingsFragment to host these as contextual cards going
forward.

Bug: 110405144
Test: visual
Change-Id: I2ab2d3556e870e86ebc18f9876336c4a3a361897
2018-09-06 18:04:05 -07:00
TreeHugger Robot
3dc29151da Merge "Fix Battery Usage graph layout for small screens" 2018-09-06 22:56:29 +00:00
jackqdyulei
04e48eae76 Merge "Update PBAP info for all pairing dialogs. DO NOT MERGE" into pi-dev
am: 205479c25d

Change-Id: Ib1ae9f0af0cabdc26dc883f58dbc28b37ce54e42
2018-09-06 13:14:18 -07:00
Mill Chen
8c71a24e43 Switch to GridLayoutManager to support two-column layout
In order to display both half-width card and full-width card,
we use GridLayoutManager and SpanSizeLookup to achieve this purpose.

Bug: 111822407
Test: manual
Change-Id: I225fb0b5f731e3faf2bca9858395c40d318acf2f
2018-09-06 20:49:51 +08:00
Raff Tsai
76e91c8cdd Merge "Modify Settings homepage layout" 2018-09-06 01:15:24 +00:00
Antony Sargent
ef814b81fc Fix Battery Usage graph layout for small screens
In PowerGaugePreference, if there isn't an icon to show, we were just
adding an empty one, which causes space to be reserved and isn't what we
want on small screens.

Bug: 111318404
Test: visual (set display size to Larger or Largest, and visit Battery
page in settings; the "Last full charge" and Screen usage since full
charge" items at the bottom should not be indented)

Change-Id: I60d39836ab7d50234022a377ff6d97dde8d4c7db
2018-09-05 13:53:29 -07:00
Doris Ling
2ced4caff1 Remove unnecessary methods from SupportFeatureProvider.
Bug: 112587239
Test: make RunSettingsRoboTests
Change-Id: I7256fdbab1ae629b39cdd07da2fe813bd0fa455f
2018-09-05 18:26:10 +00:00
Ben Lin
3210396de9 Check for Data Usage intent before populating "Data Usage" summary.
On some devices, data usage is not available; thus, it is possible that
ACTION_DATA_USAGE_SETTINGS has no matching activity. If no matching
activity is found, we should not populate "data usage" in the summary
field.

Bug: 111398942
Test: Manual check. I see that data usage is no longer visible on
devices without Data Usage activity.
Test: make RunSettingsRoboTests

Change-Id: I838206b76497c6550ef4826ad19e605cd32906ee
2018-09-05 02:29:04 -07:00
TSO FU WANG
ac5cfffd73 Merge ""Dsiabled" text aligns to textview right" 2018-09-05 09:11:50 +00:00
Stanley Wang
857c1ca1d1 "Dsiabled" text aligns to textview right
Change-Id: Id0c2b9de8355e977d1954998266079ba065c8c0b
Fixes: 112123106
Test: manual
2018-09-05 16:04:12 +08:00
Raff Tsai
43a7b18f21 Modify Settings homepage layout
- Add BottomNavigationView which has two tabs
- Remove BottomSheet in layout files

Change-Id: I493290fa9dee0566c73c5c9d7fbba10b71b4e2b4
Fixes: 113266753
Test: visual
2018-09-05 11:55:16 +08:00
Chienyuan
bad5898fb6 Don't update state after stop bluetooth tethering
After using ConnectivityManager.stopTethering(), TetheringSettings may
update state before PanService set mTetherOn to false. This makes the
toggle button checked again and user need click it twice to disable it.

Bug: 111578971
Test: on/off bluetooth tethering from settings UI
Change-Id: I6873d762d2a290080d844b7a44e54f4bd532347e
2018-09-05 11:10:01 +08:00