Commit Graph

41477 Commits

Author SHA1 Message Date
jeffreyhuang
f6cbc875e5 Introduce DebugGpuOverdrawPreferenceController
- Create new DebugGpuOverdrawPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ibaa2faa79716a0cc769d15f6fe3b868719c0f8a6
2017-10-10 15:47:59 -07:00
Jeffrey Huang
07ed55e9d0 Merge "Introduce BluetoothAvrcpVersionPreferenceCtrl" 2017-10-10 22:45:16 +00:00
Eric Schwarzenbach
389daf02ff Show updated Speed Label on Wifi detail page.
Fixes a bug where the detail page sometimes doesn't show a speed label
even when WifiSettings shows it. WifiSettings stores its connected
AccessPoint in a bundle on page load and connect. If that AccessPoint's
score cache doesn't have a score yet, it won't (can't) store it in the
bundle. If the score cache is then updated, it will display a score in
WifiSettings, but since the bundle has already been saved, the
AccessPoint that WifiNetworkDetailPage receives will not have a score.

This change modifies the preference to store the bundle only once the
user clicks the preference, so the detail page will be in sync with
WifiSettings.

Bug: 67607122
Test: manual
Change-Id: I6b33129b5a03b0e3e6d6e48ea48726e8dbe840b9
2017-10-10 15:22:56 -07:00
TreeHugger Robot
be1220071b Merge "Add content description to suggesiton footer" 2017-10-10 22:17:01 +00:00
Tony Mantler
4e43cca7fd Delete usage of WifiTracker#getCurrentAccessPoints
Bug: 67640649
Test: RunSettingsRoboTests, manually search for saved AP
Change-Id: I5a243ccc49abf78551710011cabf0c7473270cc4
2017-10-10 15:12:02 -07:00
jeffreyhuang
9c4a8c104f Introduce WindowAnimationScalePreferenceController
- Create new WindowAnimationScalePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I71c17f4ea7ca9a0273a84cb75e506e9668817473
2017-10-10 14:51:55 -07:00
Ajay Nadathur
8057f3b6aa Hero suggestion is announced as disabled by talkback
- Removed calls to disable view. No ripple effect seen even after
  the change

bug: 65851388
Test: Manually tested and verified
Change-Id: I876696a3e7351d586e6d045c8b2d07676f96ea9d
2017-10-10 21:37:57 +00:00
TreeHugger Robot
0f3bb0447f Merge "Convert more of StatusFragment to PreferenceControllers" 2017-10-10 21:04:21 +00:00
jeffreyhuang
ff1e0e1041 Introduce BluetoothAvrcpVersionPreferenceCtrl
- Create new BluetoothAvrcpVersionPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I752a5d1d777b216e102a5e074f55fa73e63ff6ca
2017-10-10 14:02:01 -07:00
Fan Zhang
231986ae9c Hide "Lanauage" in search to avoid dupe results.
Change-Id: I607ac2150912bfa6ca05e6f977daab7fd90a9637
Fixes: 67515153
Test: robotests
2017-10-10 13:54:05 -07:00
Jeffrey Huang
f12d7270de Merge "Introduce LogdSizePreferenceControllerV2" 2017-10-10 20:43:24 +00:00
TreeHugger Robot
9249707fc9 Merge "Fix Settings crash when activity is null" 2017-10-10 20:35:48 +00:00
Glen Kuhne
ddf705903e Allow 64 char HEX string PSKs in WifiSettingsUi
A check for valid PSKs in the settings UI didnt capture the 64 character
HEX string case. Added a check for it.

Test: tests/app/src/com/android/settings/wifi/WifiSettingsUiTest.java
Test: manual verification
Bug: 67492639
Change-Id: Ide738c4a67f23b613883b4a69f8264a0ffb8a0bc
2017-10-10 13:12:21 -07:00
Fan Zhang
e84911dcf9 Add content description to suggesiton footer
Change-Id: I90402301f9a294326619d8e353e14c1db9962b86
Fixes: 67633955
Test: manual
2017-10-10 12:59:08 -07:00
Fan Zhang
8333260aa5 Remove DevelopmentTileConfigActivity and clean up fragment.
- The tile activity is internal to Settings and nobody should launch it
  externally, thus it doesn't need to have its own activity. Preference
  framework can launch the fragment as a SubSetting

Fixes: 67603649
Test: robotests
Change-Id: I9ba2fc55eb7f571f816ec045567f2dd2714c44e8
2017-10-10 12:12:19 -07:00
TreeHugger Robot
d2b2d2ae0f Merge "Alphabetically sort special access setting menus." 2017-10-10 18:48:48 +00:00
songkailun
c96eeb279e Fix Settings crash when activity is null
in ManageApplications, if getActivity is null, it will cause crash
because in HelpUtils#prepareHelpMenuItem it will call activity's
getString method.

Test: manual
Change-Id: I4c9cf985e94192a936d195ea4279ec1d0f22eb10
Signed-off-by: songkailun <songkailun@xiaomi.com>
2017-10-10 11:33:14 -07:00
TreeHugger Robot
747215614b Merge "Adds a Util.setSafeIcon() function used to avoid crashes." 2017-10-10 17:39:31 +00:00
Felipe Leme
bd88450183 Adds a Util.setSafeIcon() function used to avoid crashes.
There are many places on Settings that loads an icon provided by an application,
and if the icon is too big it crashes Settings.

This CL creates a helper method used to set an icon in a safe way, and
uses it in a few places (but most likely not all of them).

Bug: 65739885
Test: manual verification with an app providing a 2MB png

Change-Id: Iae2becb6d0ec8893328d9ef1de618f9bd12fa4a0
2017-10-10 08:56:56 -07:00
Li YanJia
b699603f68 Fix PrivateVolumeSettings be launched repeatedly
Symptom:
After manually pull out the removable sd card or usb storage in
StorageSettings screen, it automatically moves to
PrivateVolumeSettings screen. This time, launching
PrivateVolumeSettings Activity is triggered six times and end-user
has to press back key six times to exit PrivateVolumeSettings
screen.

Root cause:
When sd card is pulled out, StorageSettings got three state change
event (UNMOUNTED, BAD_REMOVAL and onDiskDestroyed) through
StorageEventListener that triggers launching PrivateVolumeSettings
screen. In addition StorageSettings register the listener two
times, then StorageSettings receives six event in total.
Therefore, PrivateVolumeSettings screen is launched six times.

Solution:
Skip launching PrivateVolumeSettings if it's already triggered.
And removed the duplicated listener registration.

Bug: 67612903

Change-Id: Iabef51677a393977b7be29fc54aa050434213500
2017-10-10 12:49:32 +09:00
edgar.huang
bd0d33e3bd There is no NEXT button in find sensor screen of fingerprint.
Precondition: set the Font size and Display size to largest
Enter into the find sensor screen and the NEXT button is missing.
Test: manual - Enter into the find sensor screen -
and can find the NEXT button after sliding the screen.

Merged-In: I8f6219ab22abad98111f016d633bf100dc3222ce
Change-Id: I8f6219ab22abad98111f016d633bf100dc3222ce
2017-10-10 01:51:33 +00:00
TreeHugger Robot
68468aa892 Merge "Add left padding to misc pages" 2017-10-10 00:06:14 +00:00
TreeHugger Robot
67430754f0 Merge "Move summary_empty string to settingslib" 2017-10-09 23:34:59 +00:00
jeffreyhuang
cafce68bc2 Introduce LogdSizePreferenceControllerV2
- Create new LogdSizePreferenceControllerV2
 - Deprecate LogdSizePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I4bc03ee8481d01e553b8a4df9f9ec03b53d4eee4
2017-10-09 16:29:15 -07:00
TreeHugger Robot
b1224431fa Merge "Hide default webview app icon in developer options" 2017-10-09 23:26:23 +00:00
TreeHugger Robot
ba7cc4e935 Merge "[Settings]Crashed when 3rd-party app call ZenModeScheduleRuleSettings directly" 2017-10-09 22:54:07 +00:00
Kevin Chyn
0f0ae3426e Merge "Fingerprint enrolling icon should not overlap text" 2017-10-09 22:25:29 +00:00
Fan Zhang
4bc914386b Alphabetically sort special access setting menus.
Change-Id: I8e2a0a37995438edf12367dd27b6d7a65fb704c7
Fixes: 36077121
Test: visual
2017-10-09 15:18:15 -07:00
Fan Zhang
a0450c78eb Add left padding to misc pages
Change-Id: I6349672e92d170564212679d58cdbfe9991005a2
Fixes: 36459450
Test: visual
2017-10-09 15:11:42 -07:00
Fan Zhang
d77ba003bd Hide default webview app icon in developer options
Change-Id: I165d0a079f247a7162b0b94f9c52a343563aa527
Fixes: 65267538
Test: robotests
2017-10-09 14:28:27 -07:00
liurong
20965328db [Settings]Crashed when 3rd-party app call ZenModeScheduleRuleSettings directly
Fix the issue that some 3rd-party apps call ZenModeScheduleRuleSettings directly
without set the extra ConditionProviderService.EXTRA_RULE_ID. It will raise the
exception and make settings crash.

Test: 1. Install the app "QuickShortcutMaker"
      2. Following the steps descripted in the issue:
         https://issuetracker.google.com/issues/37977351
      3. make ROBOTEST_FILTER="(ZenModeScheduleRuleSettingsTest)" RunSettingsRoboTests

Change-Id: Ia7de0e691eef6d0da26e629ff0c6af7006757623
Signed-off-by: liurong <liurong@xiaomi.com>
2017-10-09 14:12:17 -07:00
Jeffrey Huang
e2fc925bb3 Merge changes from topics "RefactorDevControllers", "MoveDevOptionPrefCtrl"
* changes:
  Refactor AdbPreferenceController
  Move DevOptionsPrefCtrl to SettingsLib
2017-10-09 21:09:54 +00:00
Fan Zhang
52e39240e8 Move summary_empty string to settingslib
Bug: 65612375
Test: rebuild
Change-Id: Ib55e66c02267b9419e92885973e0d9e3287959b7
2017-10-09 13:53:45 -07:00
Kevin Chyn
caa78af159 Fingerprint enrolling icon should not overlap text
Fixes: 67369609

Test: manual test of enrolling with combinations of multi-window
      and text/display sizes

Change-Id: I163af87c69a51b0c91778611afa9e80960231c6a
2017-10-09 12:03:31 -07:00
jeffreyhuang
fe537c8d84 Refactor AdbPreferenceController
- Refactor AdbPreferenceController to use
 AbstractEnableAdbPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: If34e2968ff8900276023e12f89d9cc86468adf7a
2017-10-09 11:50:29 -07:00
Tony Mantler
b35a19bce8 Convert more of StatusFragment to PreferenceControllers
Bug: 67410808
Test: RunSettingsRoboTests
Change-Id: Ia79d89d3d3b70bf7af950daa3e588db3f7f597e2
2017-10-09 11:15:58 -07:00
jeffreyhuang
37df3d6d1f Move DevOptionsPrefCtrl to SettingsLib
- Move DeveloperOptionsPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ie434d479d8d3f7527ffce54f241ac2e090e0fc44
2017-10-09 10:17:44 -07:00
Bill Yi
b51efdb511 Merge "Import translations. DO NOT MERGE" into oc-mr1-dev am: 6ed9a78922 -s ours
am: e81904ece6  -s ours

Change-Id: Ic638e56f8f312068875245a2074c20c4b25206d5
2017-10-08 07:01:44 +00:00
Bill Yi
e81904ece6 Merge "Import translations. DO NOT MERGE" into oc-mr1-dev
am: 6ed9a78922  -s ours

Change-Id: I1d35b06b119081d46680035c32858572a8acad35
2017-10-08 06:59:18 +00:00
TreeHugger Robot
6ed9a78922 Merge "Import translations. DO NOT MERGE" into oc-mr1-dev 2017-10-08 06:57:28 +00:00
TreeHugger Robot
792ea68baa Merge "Import translations. DO NOT MERGE" 2017-10-08 06:43:56 +00:00
Bill Yi
dbbd311c50 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Bug: 64712476
Change-Id: I8e31d776f5036724722d7578be51651b5199e419
2017-10-07 19:13:23 -07:00
Bill Yi
ebb2044916 Import translations. DO NOT MERGE
Change-Id: I0867e4dddbb04ecc548a800d511d59aeb1ec7ca7
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
2017-10-07 18:49:24 -07:00
Andrew Sapperstein
52211db347 Merge "Update wakeup anomaly to exclude blacklisted wakeups." into oc-mr1-dev am: 8bd54d4592
am: 95ebdd359d  -s ours

Change-Id: I21baaf3035fc4efcd9498ed28368da579e24b3f0
2017-10-07 17:10:12 +00:00
Andrew Sapperstein
95ebdd359d Merge "Update wakeup anomaly to exclude blacklisted wakeups." into oc-mr1-dev
am: 8bd54d4592

Change-Id: If099f1d66dcb83817d5b6c3e22d4ca3e550d5e71
2017-10-07 17:06:15 +00:00
TreeHugger Robot
8bd54d4592 Merge "Update wakeup anomaly to exclude blacklisted wakeups." into oc-mr1-dev 2017-10-07 17:03:32 +00:00
Andrew Sapperstein
f59cbb143c Update wakeup anomaly to exclude blacklisted wakeups.
Also disables all anomalies out of the box.

Provides the ability to ignore certain wakeups if blacklisted in
AnomalyDetectionPolicy. Compares each wakeup to the blacklist and
if it exists, does not include it in the count used to compare against
the threshold.

Change-Id: I038ca966aed5a030853b4786bc201397bf4f9b70
Merged-In: I4ef548bd0952be5f0d4e36df5698f287839d0704
Fixes: 67000019
Test: robotests
2017-10-06 21:01:21 -07:00
Maurice Lam
d2e50c3c2b There is no NEXT button in find sensor screen of fingerprint.
Precondition: set the Font size and Display size to largest
Enter into the find sensor screen and the NEXT button is missing.
Test: manual - Enter into the find sensor screen -
and can find the NEXT button after sliding the screen.

Change-Id: I8f6219ab22abad98111f016d633bf100dc3222ce
2017-10-06 18:21:58 -07:00
TreeHugger Robot
88a2ed1954 Merge "Update wakeup anomaly to exclude blacklisted wakeups." 2017-10-07 00:08:25 +00:00
Andrew Sapperstein
e063427d0b Update wakeup anomaly to exclude blacklisted wakeups.
Also disables all anomalies out of the box.

Provides the ability to ignore certain wakeups if blacklisted in
AnomalyDetectionPolicy. Compares each wakeup to the blacklist and
if it exists, does not include it in the count used to compare against
the threshold.

Change-Id: I4ef548bd0952be5f0d4e36df5698f287839d0704
Fixes: 67000019
Test: robotests
2017-10-06 15:10:38 -07:00