Commit Graph

6 Commits

Author SHA1 Message Date
Hakjun Choi
a0ba9182ad [Internal cleanup] remove warning message for resource ID
Currently we are seeing Drawable com.android.settings:drawable/ic_check_circle_24px has unresolved theme attributes! error
To address this, use Context.getDrawable(int) to provide theme info when using the icon

Bug: 356149221
Flag: EXEMPT bugfix
Test: manually run Satellite setting menu and check the log whether the waring is shown or not
Change-Id: I55fd1bd4cbaf07e7433cdd286e71f88dacc3e1b5
2024-07-29 16:46:38 +00:00
Hakjun Choi
bdfd24ed5a Add a condition for preventing NPE when accessing SatelliteManager
There could be a case that FEATURE_TELEPHONY_SATELLITE is false but KEY_SATELLITE_ATTACH_SUPPORTED_BOOL it true
Since SatelliteManager can be returned only when FEATURE_TELEPHONY_SATELLITE is enabled, added a condition checks whether SatelliteManager is null or not

Bug: 347057183
Test: atest SatelliteManagerTest SatelliteManagerTestOnMockServiceTest
      manually e2e test with FEATURE_TELEPHONY_SATELLITE disabled
Change-Id: I3f51e6805ccab3366d9d01be2e999818cd18354f
2024-06-17 06:26:21 +00:00
Hakjun Choi
2bc6d77cbf Add activity expose condition for Satellite messaging activity
In case carrier_enabled_satellite_flag or KEY_SATELLITE_ATTACH_SUPPORTED_BOOL is not supported, activity invocation intent will be ignored.
Because the guidance description of the activity cause misunderstanding to users when the satellite feature is not set properly.

Bug: 338377564
Test: manual test adb shell am start -a "android.settings.SATELLITE_SETTING" --ei sub_id (test sub id) for each key's enable/disable combination for KEY_SATELLITE_ATTACH_SUPPORTED_BOOL and carrier_enabled_satellite_flag
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:308ced3fc8e69378611ce333ed5f0e8337ff91fe)
Change-Id: Ib5401f433f802e7aa74cc175179776deb576edfc
2024-05-16 15:32:30 +00:00
Hakjun Choi
3c54876db7 Make satellite more info url carrier configurable
guidance url link are vary per each carrier, therefore makes it carrier configurable

Bug: 330948681
Test: manually test whether URL works as intended on pixel with TMO/SKT SIM
Change-Id: I062b1e9267c6edf3289d85dc58f9ab2d9cff64d8
2024-03-28 23:24:14 +00:00
Hakjun Choi
7f2f0612d1 Reflect satellite api refactoring to Settings
Removed the word Satellite from all the method names might improve brevity and readability excluding cases that cause confusion.

Bug: 297933128
Test: manual test using testSatelliteApp

Change-Id: Ia817b8bf531031c28264750c03a6f7004ed81aa5
2024-01-26 13:26:25 +00:00
Hakjun Choi
2f57f53831 Add Satellite Messaging activity
Add satellite messaging activity into Settings for carrier satellite
service

Bug: 319035517
Test: manual
1. Set CarrierConfig Key KEY_SATELLITE_ATTACH_SUPPORTED_BOOL as false then verify satellite messaging menu is not shwon from
   Settings > Network & internet > SIMs > test sim
2. Set CarrierConfig key KEY_SATELLITE_ATTACH_SUPPORTED_BOOL as true
3. Insert test SIM
3. Get into to Settings > Network & internet > SIMs > test sim > verify Satellite messaging is shown
4. Verify whether descriptions are as directed. icons are as directed.
5. Add satellite messaging does not work when click
6. Invoke web browser with test website when click 'More about satellite messaging'
7. Replace SIM of which MCC/MNC is not test sim
8. verify no action happen when click 'More about satellite messaging'

Change-Id: Iee8fad58b41cbca34f373d2a9df1d074c447cfb1
2024-01-23 07:49:00 +00:00