Commit Graph

1024 Commits

Author SHA1 Message Date
Julia Reynolds
aceccce75c Reorganize notification Settings classes
The notification package was getting too big.

Test: make -j64 RunSettingsRoboTests
Fixes: 145224451
Change-Id: I25ba82f42f7a137d8adcce72dcf8089d0e018bdc
2019-11-27 10:02:13 -05:00
Beverly
a30cb1158f Focus remains on the button after turning on/off
Test: manually test talkback
Fixes: 145181672
Change-Id: I16ceb81dd686e4a18354dfd464c7683ba94df79d
2019-11-26 15:37:42 +00:00
Tsung-Mao Fang
14c80f8151 Move UpdatableListPreferenceDialogFragment to SettingsLib
Change-Id: Ide669e1f35715fc45b5e7fe4b0852860812d392c
Fix: 79459635
Test: robo test
2019-11-19 18:16:47 +08:00
Julia Reynolds
9540929cfe Merge "Add NLS specific screens for notification listener approval" 2019-11-13 14:02:39 +00:00
TreeHugger Robot
eb3eb1fdb3 Merge "Update text on notification on/off toggles for clarity" 2019-11-11 19:24:42 +00:00
Julia Reynolds
f356ced8d7 Remove filtering from "recent sent" notifs preference
The 'has a launch intent' filter was inherited from 'recent apps'
preference but an app doesn't need a launch intent in order to
send notifications. Also, the next screen didn't apply the filter
so the data wouldn't always match up.

Also make the preferencecontroller more robust to failure.

Test: manual, trigger a notification from a non-launchable app
and makes sure it appears in the list
Fixes: 141380329
Fixes: 142956641

Change-Id: Icf3abead82c572bbffe6e06ecf51a8e02c11c982
2019-11-11 17:38:23 +00:00
Julia Reynolds
78b4505d6e Update text on notification on/off toggles for clarity
Test: manual
Fixes: 141011559
Change-Id: I06b8519bb5a80496d84889f8c5264bff098ebefd
2019-11-11 17:37:45 +00:00
Jay Aliomer
b499cc5643 Merge "Don't disable DND permission settings for apps that have disabled NLS" 2019-11-08 16:38:12 +00:00
Jay Aliomer
8754d40124 Don't disable DND permission settings for apps that have disabled NLS
ZenAccessController.getPackagesRequestingNotificationPolicyAccess
was including disabled packages.
We change this behavior to exclude any disabled package

Test: make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.applications.specialaccess.zenaccess.ZenAccessControllerTest"
Change-Id: I354b8f0bdbf602d1f35233d5003ce09f01df3cb2
Fix: 141318822
2019-11-08 16:21:15 +00:00
Julia Reynolds
31dc1fd806 Add NLS specific screens for notification listener approval
Fixes: 141689199
Fixes: 143639217
Test: atest

Change-Id: I4ead087e0015ad33d6be4f9357de50a4298b3347
2019-11-08 14:13:24 +00:00
timhypeng
b2297dcdf9 Unable to adjust cast device's volume
- Update slider UI when receiving volume changed
- Do not create an infinite message loop

Bug: 143262277
Test: make -j42 RunSettingsRoboTests
Change-Id: If83a97cfce8b90c2eda7d55389775222bfc6bba0
2019-10-25 10:05:09 +08:00
TreeHugger Robot
764115ca4e Merge "Fix crash on clicking dismissed notifications" 2019-10-11 19:12:41 +00:00
Julia Reynolds
d80ddbd82b Fix crash on clicking dismissed notifications
Read the channelid from the notification vs RankingMap
for historical notifications

Test: manual
Fixes: 142531668
Change-Id: Ia7b48e6bcee3995286eea2e2f5f3b6bc4cff98e2
2019-10-11 17:27:36 +00:00
Julia Reynolds
3b10e450cb Rename class
Test: atest
Bug: 137397399
Change-Id: Idae73251bb67fbef2cf29f730f1420e98e38a8f3
2019-10-11 11:45:51 -04:00
Julia Reynolds
4c1bfdfe73 Merge "Handle multi-user in notif log" 2019-10-07 13:15:16 +00:00
Julia Reynolds
7e7271fff8 Handle multi-user in notif log
Test: manual
Fixes: 141575553
Change-Id: I03ff85358e8ae6ed5e6699358c4f9c785c416ecf
2019-10-03 11:50:12 -04:00
Raff Tsai
6db277ebb7 Remove summary provider
- use SummaryProvider to provide the summary of UserSettings
- use WifiDisplayPreferenceController to replace the summary loader
in WifiDisplaySettings
- use ConfigureNotificationPreferernceController to replace the
sumary load in ConfigureNotificationSettings

Fixes: 141653158
Test: robolectric
Change-Id: Id5f5ed645707caa0b25ecae5252174cbf017651c
2019-10-03 15:04:36 +08:00
Beverly
0ea2d6fb87 Update enabled state of ZenRulePreference
Test: manual
  1. Settings > Sound > Do Not Disturb > Schedules > Sleeping
  2. Toggle enable state of DND rule to ON
  3. Navigate back
  4. Observe: Sleeping rule is enabled visually (check box is checked)
Fixes: 140090071
Change-Id: I44078cdba9642eea93f9b6d2eb3eef486d3c38bc
2019-09-27 15:58:26 -04:00
Raff Tsai
966fa01423 Use SettingsLib Indexable
- Use SettingsLib Indexable
- Directly use resource id in getPreferenceScreenResId

Bug: 135053028
Test: roboletric
Change-Id: I05f493b55e8b6e2091301e9231ba5615215618e6
2019-09-25 18:24:56 +08:00
Raff Tsai
ac3e0d0988 Directly use BaseIndexableProvider
- Add function getXmlResourceId, Fragments don't need to write
xml resource id twice.
- Remove getPreferenceControllers from Indexable.java. Because it will
move to SettingsLib later for other apps which don't need this function

Bug: 135053028
Test: robolectric
Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003
2019-09-24 00:35:52 +08:00
Julia Reynolds
b294b82c84 Update notification log
- Change notification presentation to better match notification shade
- Stop constantly removing and readding all of the preferences
- Update individual preferences in a kind of hacky way (to be improved
later)
- Link notification entries to notification preferences screen
- Hide notification summaries

Bug: 137396965
Test: manual
Change-Id: Icdd54488b8bf659f6fe42af93e42cd21912fa4fe
2019-09-18 17:30:04 -04:00
Raff Tsai
1f30b1cd67 Merge similar BaseSearchIndexProvider code together
Bug: 135053028
Test: robolectric, check search_index.db contains the same items
Change-Id: If3c18a170b0e671690df1fdf26e59a421d2c48cd
2019-09-12 11:09:09 +08:00
Mady Mellor
0c47113a5b qt-r1-bubbles-dev @ build 5835883
Test: presubmit setup on source branch

Bug: 129158983
Bug: 136034310
Bug: 137876221
Change-Id: If2b813f24cf5998829fe417e32179c5e8283d308
2019-08-29 17:54:26 -07:00
Sunny Shao
b46650a10f Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ZenCustomRuleBlockedEffectsSettings page.

Fixes: 139264543
Test: manual test
Change-Id: Ib174eaa1c18b33e03fe5729d4a966b260e2bc15d
2019-08-12 17:10:17 +08:00
Sunny Shao
b4214464e5 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the ZenModeBlockedEffectsSettings page.

Fixes: 139258311
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.notification
Change-Id: I0367390ffb27743e394db3108b3992fee1b943a7
2019-08-12 12:09:39 +08:00
Christine Franks
2b07a7e818 [DO NOT MERGE] Update title for null uri when setting changes
am: ea14373666

Change-Id: Icfb8e179f59529b30d3262c00d644257aa2f67f1
2019-08-04 00:55:36 -07:00
Christine Franks
ea14373666 [DO NOT MERGE] Update title for null uri when setting changes
Currently, the title will not update at all if set to silent.

Bug: 130445562
Test: make RunSettingsRoboTests -j48
Change-Id: Id8fc0182adb37c05436f5924b7dcdffb9d994e0d
2019-08-03 01:00:31 +00:00
Beverly
ea42ef17e6 Pass context for Starred Contacts Summary
So the correct context will be used to obtain the
correct translation for the summary string

Test: manual
Fixes: 138158873
Change-Id: I3d121fdfc7587870a86f7ad56f4efcbde664586d
2019-07-23 21:22:41 +00:00
Lyn Han
c44efcb3e4 Secure => global bubble settings pt 2
Follow up to http://ag/8222583
- Replace references to Secure.NOTIFICATION_BUBBLES with
Global.NOTIFICATION_BUBBLES

Fixes: 136034310
Bug: 129158983
Test: m RunSettingsRoboTests
Test: atest SystemUITests
Test: manual - work profile bubbles show up
Change-Id: Ifa71206353237b837cfcda6d23ea6a6ec2c146d0
2019-07-15 13:51:18 -07:00
Lyn Han
ca77022900 Revert "Secure => global bubble settings pt 2"
This reverts commit a978ab4526.

Reason for revert: fix test

Change-Id: Id6b49106ab7d8a42ea5de8b16a0dd3ed49d58817
2019-07-15 18:06:32 +00:00
Lyn Han
a978ab4526 Secure => global bubble settings pt 2
Follow up to http://ag/8222583
- Replace references to Secure.NOTIFICATION_BUBBLES with
Global.NOTIFICATION_BUBBLES

Fixes: 136034310
Bug: 129158983
Test: atest SystemUITests
Test: manual - work profile bubbles show up
Change-Id: I03ffd7f1126f2c20d819f741cd4f7dcced81a405
2019-07-12 11:32:39 -07:00
Julia Reynolds
a295d71c94 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
2019-07-02 11:24:50 -04:00
Julia Reynolds
050f5da680 Remove dead code am: ab63fd3c25 am: bf35e5cc55
am: 25d55fb821

Change-Id: I45b62580c01cf5a81443d7043f65755bb3986245
2019-06-21 10:45:47 -07:00
Julia Reynolds
ab63fd3c25 Remove dead code
Test: try to search 'gentle'
Fixes: 135640138
Change-Id: If03703e59f77206da08fc80e88bb986f821c18fe
2019-06-21 13:24:05 +00:00
Julia Reynolds
2ab97e02cd Refresh the whole rule in zen listing screen am: 78ef02eb8f am: 39bff61eea
am: 01be0f85b3

Change-Id: Ia366dd746291e127eb618ea9410a4d2f2aa83670
2019-06-13 11:42:55 -07:00
Julia Reynolds
78ef02eb8f Refresh the whole rule in zen listing screen
Because the whole rule is pushed to NMS when it's
enabled/disabled.

Test: manual
Fixes: 135170330
Change-Id: I4bbc30f82dab07cff9184f9ab8a6f729499c6126
2019-06-13 16:48:22 +00:00
TreeHugger Robot
7855c640c7 Merge "Fix launching of work profile notif settings" 2019-06-12 17:44:14 +00:00
Julia Reynolds
142920e0c2 Fix launching of work profile notif settings
Test: manual
Fixes: 132289017
Change-Id: I3c177aae1f4dd46556b652253d24b225d01987eb
2019-06-12 11:39:39 -04:00
tmfang
dad177ada4 Fix overlapping problem on notification screen am: 564fcb90ab am: 1c474bf789
am: 114864981a

Change-Id: I1dcbbdece7db796fe2a83fc9c81c88d794534319
2019-06-11 10:59:45 -07:00
Yi-Ling Chuang
d6bd5b1339 Update sound summary when it is set to None.
Currently when the sound is set to None, we don't update the summary,
unless users go to other pages and come back. Now we refreash it for a
better user experience.

Fixes: 134994978
Test: robotest
Change-Id: I5d9c0238ee31e0c26ebde3201794c17737791c62
2019-06-11 17:21:58 +08:00
tmfang
564fcb90ab Fix overlapping problem on notification screen
If we didn't set view and lifecycle for EntityHeaderController,
it only sets "z-order" as 0 for action bar.

So, user sees overlapped problem while user is scrolling view.

For now, we set view and lifecycle as parameter for EntityHeaderController,
then EntityHeaderController can change "z-order" while scrolling view.

Test: visual, robotest
Fixes: 132819126
Change-Id: Ieb01b26e4d6ca4d82f72371620938665de8149a0
2019-06-11 13:57:57 +08:00
Julia Reynolds
a1a598d44e Silent notifs appear on lockscreen by default
Test: atest
Bug: 134613164
Change-Id: I1ee39a1302010a2a29ba6d0060f19565e41859a2
2019-06-06 17:03:20 +00:00
Julia Reynolds
569732474e Read the subtext of notif importance field on selection
When using a11y services

Test: manual with Talkback
Bug: 133649570
Change-Id: Ic68a948ab5d55e68994e6b14456d25d438637886
2019-06-05 18:31:19 +00:00
Julia Reynolds
eeefeebeff Change notification alert icon
Test: manual
Bug: 134054170
Change-Id: Ibd66a55a30ac9fbeb7a32638fe236067c6175bc4
2019-05-30 14:47:07 -04:00
Julia Reynolds
c0c4b3a111 Fix a11y readout of notification importance buttons
Test: manual with TB
Bug: 134047401
Change-Id: Idab3426a37ed3f25c2cde47e0747ac9a31850f62
2019-05-30 10:31:40 -04:00
Raff Tsai
1a2b34b625 Fix IllegalArgumentException in AudioHelper
Audio streams for phone calls in BT device (STREAM_VOICE_CALL) is not
supported in AudioManager.getStreamMinVolume(), fallback to use
STREAM_VOICE_CALL

Fixes: 133812547
Test: make RunSettingsRoboTests
Change-Id: I8e330f60bae2a7cf9cd0cf7288076b8320ccc504
2019-05-30 16:18:37 +08:00
Julia Reynolds
3562c97441 Add snooze notification setting
Test: atest
Bug: 133494458
Change-Id: I3c0534860aaeb374384c4e30764313b1cb83c82a
2019-05-28 10:40:53 -04:00
Julia Reynolds
aaecede217 Merge "Allow the default SMS app to be blocked" into qt-dev 2019-05-24 17:00:12 +00:00
TreeHugger Robot
4321e038ff Merge "Simplify channel importance settings screen" into qt-dev 2019-05-24 16:36:49 +00:00
Evan Laird
472e19eae4 Simplify channel importance settings screen
Back to bell icons, and removed the flavor text

Test: visual
Bug: 132971502
Change-Id: I55ce6dd07404aed2ceb5423796b733a70c3bfa13
2019-05-24 09:08:14 -04:00