Commit Graph

2189 Commits

Author SHA1 Message Date
TreeHugger Robot
c53717f5d7 Merge "Add a helper class for listening to subscription and airplane mode changes" 2018-12-11 07:11:57 +00:00
TreeHugger Robot
625646a55c Merge "Add a helper class for filtering available subscriptions" 2018-12-08 01:13:24 +00:00
Antony Sargent
b33f74192c Add a helper class for listening to subscription and airplane mode changes
For the new multi subscriptions UX, in several places we need to listen
for both subscription changes (eg a sim card was inserted or removed),
as well as airplane mode changing state. This combines those in one
helper class that can be reused.

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: Ibcbb669ae291a917f89735dbda043742efaa58c9
2018-12-07 15:40:00 -08:00
Antony Sargent
270296ea23 Add a helper class for filtering available subscriptions
In several places implementing the new changes for better UX with
multiple mobile subscriptions, we need a bit of code that filters the
results coming from the SubscriptionManager. This CL adds that common
code in a util class that will be used in later CLs.

Bug: 116349402
Test: RunSettingsRoboTests
Change-Id: Ie9376629604ac2c4a2f15123edc380c5999f2f83
2018-12-07 13:40:28 -08:00
Chen Xu
f80e5b561e Merge "address API council feedbacks for Telephony.Carriers" 2018-12-06 20:11:18 +00:00
Antony Sargent
2b0c991efc Merge "Layout changes in v2 Network & internet page" 2018-12-06 18:55:42 +00:00
Xiangyu/Malcolm Chen
c8b7207edb Merge "Only enable data for one SIM in DSDS." 2018-12-06 01:25:07 +00:00
Malcolm Chen
42055cbe50 Only enable data for one SIM in DSDS.
Only enable mobile data for one SIM for simplicity. Which means When
turning on mobile data on non-default sub, pop a notification to user
that it will turn off data of the other one.

Bug: 120515679
Test: manual and unittest
Change-Id: I7c190bb70d771b7f280c246038a380e4fc7338a3
2018-12-06 01:24:58 +00:00
Antony Sargent
11b7c7f254 Layout changes in v2 Network & internet page
This adds the skeleton of a header section which will only appear when
the device has two or more active mobile subscriptions. Subsequent CL's
will add the actual logic implementing it.

Also this moves up the airplane mode toggle higher up on the page, and
removes the proxy selector entry (which has been unconditionally
disabled by the ProxyPreferenceController for a while).

Bug: 116349402
Test: manual (this is mostly a layout change - subsequent changes will
have actual logic to test for the subscriptions header)

Change-Id: Iaee338d5c13e05d3c2d9d04872a94cf90e5da588
2018-12-05 14:18:45 -08:00
Raff Tsai
626c6e0b17 Replace SliceAction deprecated method
- Replace new SliceAction with SliceAction.createDeeplink() or
SliceAction.create()

Test: make RunSettingsRoboTests
Change-Id: Ied34469d2220d8220a2dcc6c2fb4d32dd9cd9b8c
Fixes: 119879284
2018-12-01 06:21:01 +08:00
chen xu
54d5a727c1 address API council feedbacks for Telephony.Carriers
Bug: 118296421
Test: telephony unit test
Change-Id: Idf8bcad4fe9d765a73563e9b0c1c659175835447
Merged-in: Idf8bcad4fe9d765a73563e9b0c1c659175835447
2018-11-29 23:20:13 -08:00
chen xu
3b76d0f9ef address API council feedbacks for Telephony.Carriers
Bug: 118296421
Test: telephony unit test
Change-Id: Idf8bcad4fe9d765a73563e9b0c1c659175835447
2018-11-29 23:13:18 -08:00
Fan Zhang
53f75f0df9 Move all custom slice uris to a registry class.
Change-Id: I192320f95ac81d14c8891ce2531d603912e59f56
Fixes: 119776308
Test: robotests
2018-11-29 16:41:21 -08:00
Josh Hou
170afc4827 Merge "Refine APN fetching logic" 2018-11-28 22:24:35 +00:00
Matthew Fritze
71a255968f Merge "First commit for settings panels" 2018-11-27 17:34:22 +00:00
Josh Hou
1e1d6d1466 Refine APN fetching logic
APN fetching logic has been encapsulated in URL_SIM_APN_LIST API in
TelephonyProvider

Bug: 115709816
Test: Live netwrk test
Change-Id: I735bc50e912dfbec0903fbcafdc4d6eaa6ccfc7b
2018-11-27 15:59:39 +08:00
Matt Fritze
90899e08f0 First commit for settings panels
Establish the Activity which hosts Settings panels through the
PanelFragment. The Activity's purpose is to validate the intent
data coming in, including:
- Called with startActivityForResult (so we can log who is calling)
- Intent has the proper intent extra to link to a Panel

The fragment takes the Panelable data and builds a Settings Panel.
Each panel will have:
- Title
- List of Slices
- Link to underlying content

The Panelable interface is created to provide all of those datums, and
the new FetureProvider provides the Panelables by linking them with
keys. The keys will eventually become public APIs with CTS tests.For
now, we store them locally.

I included an exmaple panel, the InternetConnectivityPanel which
currently shows Wifi and Airplane mode.

Screenshot: https://screenshot.googleplex.com/c6sv7ZzQ5OJ
Bug: 117804089
Test: make -j40 RunSettingsRobotest
Test: Manual app
Change-Id: I1932f7179cc32088acd6413a736901ddf9651892
2018-11-26 15:26:02 -08:00
Youming Ye
976ca1c4c7 Merge "Display a toast to notify user that Preset APN setting cannot be viewed" am: a995cb334b am: e29c62ea04
am: e5e4e4cb76

Change-Id: Ic4c41e88c28a322d54a8489844b6ef0ff041d3a1
2018-11-26 14:09:21 -08:00
taiki tsutsumi
4d044ced6d Display a toast to notify user that Preset APN setting cannot be viewed
When KEY_HIDE_PRESET_APN_DETAILS_BOOL is set to true, Preset APN setting
is hidden. When user taps Preset APN, a toast should be shown to inform
that user cannot view the APN.

Test: manual - check Preset APN setting details are hidden
Bug: 115453290
Depends-On: I8a5c6f92f876d349b304acf89b4ffab86ff3f24b
Change-Id: I0078b3492ae87a4297f24871b8bea1579e6a79af
2018-11-21 15:40:58 -08:00
Pengquan Meng
6da4302864 Fix CarrierSettings preference
This used the CarrierConfigManager to get the CarrierSettings activity
component and open that activity when the preference is clicked.

Bug: 117651939
Test: make -j40 ROBOTEST_FILTER=telephony RunSettingsRoboTests
Change-Id: Ic5267bba18ab32fbcc2e04aa61e7361151130275
2018-11-20 18:58:47 -08:00
Eran Messeri
8e9e32e1b9 Merge "Private DNS: Add policy transparency" 2018-11-14 10:07:33 +00:00
Fan Zhang
1e4e80162e Revert "Revert "Add a new logger for StatsLog""
This reverts commit f14d4af767.
Test: rebuild

Reason for revert: Fixes build

Change-Id: I003af1d9c973e58c09b1d8b9717c427febd6f809
2018-11-10 10:29:15 -08:00
Todd Kennedy
f14d4af767 Revert "Add a new logger for StatsLog"
This reverts commit b2b84372b5.

Reason for revert: Causes build failures

Change-Id: I04f4a6e6d6082903056c296d543870dd165b6eea
2018-11-10 13:51:50 +00:00
Fan Zhang
b2b84372b5 Add a new logger for StatsLog
Bug: 117860032
Test: robotests
Change-Id: I4f3f5b1fb47df9427140a22f1e78126ad391ff68
2018-11-09 15:54:12 -08:00
Eran Messeri
203856e444 Private DNS: Add policy transparency
When the Private DNS setting is disabled via a user restriction, show
information to the user explaining that they cannot change this setting
due to IT admin policy.

Testing steps:
* Installed & configured TestDPC on the device.
* Made sure that the Private DNS setting is usable.
* Set the user restriction via TestDPC ("User Restrictions" -> "Disallow
config Private DNS").
* Navigated to Settings -> Network & Internet -> Advanced
* Observed that Private DNS is greyed out and the Restricted icon is
showing.
* Observed that when tapping either the icon or the greyed-out text I
get a dialog with policy information.

Implementation notes:
I have not utilized the existing RestrictedPreference as the Private DNS
mode preference extends CustomDialogPreferenceCompat.
I have also not utilized the RestrictedPreferenceHelper as it modifies
the summary shown for the preference. This preference has its own
summary (showing the current state of Private DNS configuration) which I
did not want to override.

Bug: 112982691
Test: Manual, see above.
Change-Id: I9b7496b5b2cbb26012d889369f2199239cd2e00f
2018-11-09 13:33:16 +00:00
Youming Ye
0c7e7dba82 Merge "Fix issue that read-only apns can be edited" am: e871464053 am: 6b0237ebfb
am: 502ad46dc1

Change-Id: I6bd527b0fb0b63393d5ddf8414257f543a532805
2018-11-08 17:47:59 -08:00
Pengquan Meng
b8d59fc9f8 Replace some configs with CarrierConfig
Replace the following config with CarrierConfig
- config_enabled_lte
- config_support_tdscdma
- config_support_tdscdma_on_roaming_networks
- carrier settings activity package/class name

Bug: 115429501
Test: make -j40 ROBOTEST_FILTER=telephony RunSettingsRoboTests
Change-Id: I3d973f926813c01fff6fcff50b3392c4eff69eb8
2018-11-06 15:34:25 -08:00
Lei Yu
152081e7b0 Merge "Add null check for carrierConfig" 2018-11-05 18:29:56 +00:00
jackqdyulei
9588d2af14 Update show4GForLTE config
Get it from CarrierConfigManager instead of config in systemui package.
Also remove unused CdmaOptions

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Iac47a60e51f68047b8f800dbdcf0efbcd432a015
2018-11-02 14:28:36 -07:00
jackqdyulei
16c5d77df8 Add null check for carrierConfig
Since it may return null when Crash happens in CarrierConfigManager

Bug: 118402844
Test: RunSettingsRoboTests
Change-Id: I9db0f1a873b3e24936b021989f6716369569b17b
2018-11-02 11:25:37 -07:00
Yuming Mao
8d1eee08f7 Fix issue that read-only apns can be edited
When entering to ApnEditor with ApnSettings#onPreferenceTreeClick(),
subId is not passed.
So invalid subId is used and it gets wrong carrier config values.

To resolve this issue, remove unnecessary ApnSettings click event.
The only click event for launching ApnEditor is ApnPreference click
event.

Test: manual - Check that the read-only APN can't be edited when tap
the edge of the APN settings screen
Bug: 117302653
Change-Id: I0a61b409539d6e4f6aa9860235e61c43c76640fa
2018-11-02 19:56:11 +09:00
Fan Zhang
cdf284b732 Make Settings robotest work with tot Robolectric
Bug: 116278591
Test: make -j RunSettingsRoboTests
Change-Id: I32cb2fcf6094675f79d2fc24702ef6298a9691e4
2018-10-31 17:59:17 -07:00
Lei Yu
dd3feeb155 Merge "Rename a bunch of mobile network files" 2018-10-31 20:04:03 +00:00
TreeHugger Robot
db403ad785 Merge "Update network select page" 2018-10-31 18:56:43 +00:00
Antony Sargent
2cbd720d21 Add a feature flag for new version of Network and internet settings page
In addition to adding the flag, this also adds a new xml layout that is
the same as the existing network and internet page, but will begin to be
changed in subsequent CLs. There is also a change in code to use this
new layout when the flag is turned on.

One other change is to make the list of displayed feature flags in
developer options be in sorted order instead of whatever semirandom
order they come out of the map's key set.

Bug: 116349402
Test: Manual (settings_network_and_internet_v2 flag should should up in
Settings -> System -> Developer options -> Feature flags, and those
flags should be in sorted order)

Change-Id: I5520d286efb6bec50ba4ca99f64aeca94f01d533
2018-10-31 05:29:34 +00:00
jackqdyulei
2aae67a061 Rename a bunch of mobile network files
1. Make them have "MobileNetwork" prefix
2. Also update WifiCallingPreference to remove its category
if it is invisible

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I25871d579d6495e902e5583030889942ed2506a8
2018-10-30 16:28:56 -07:00
Lei Yu
76da1123e4 Merge "Update the mobile activity" 2018-10-30 22:56:01 +00:00
jackqdyulei
4f0c28da9e Update network select page
1. use getPrefContext() to make sure it has correct style
2. Move operation back to bg thread so it won't block UI

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I7737ea8b21d44790617b9c4f13a8c4c41037fca4
2018-10-30 14:59:35 -07:00
jackqdyulei
008c7781e8 Refine the logic to show/hide cdma preference
1. Add special check for "system select"
2. For cdma, need to check whether to hide carrier settings

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I0a20816912500725894208a60bba7a5c74912561
2018-10-29 14:16:14 -07:00
jackqdyulei
400e13cc11 Update the mobile activity
1. Add listener to ACTION_RADIO_TECHNOLOGY_CHANGED
2. Update fragment switch by using replace
3. Remove todo for sort because list is already sorted by sim slot
4. Make actiivty accept SUB_ID from intent
5. Add icon for multi-sim support

Bug: 114749736
Test: RunSettingsRoboTests && Screenshot

Change-Id: I11c472b1479ec9243266cb2a7ef4292370ac6894
2018-10-29 13:05:50 -07:00
Lei Yu
ed33c87c02 Merge "Remove unused code in telephony fragment" 2018-10-26 01:14:27 +00:00
Lei Yu
6b4e5a2343 Merge changes Iafe111bf,Ie9d8e935
* changes:
  update CdmaApnPreferenceController
  Add network selection preferences
2018-10-26 00:28:30 +00:00
Lei Yu
f3baeb1e0d Merge changes Iad3bc131,Id43cb480
* changes:
  Update NetworkSelectSettings page
  Recopy NetworkSelectSetting from phone to settings
2018-10-25 22:32:32 +00:00
jackqdyulei
72eaed5479 Remove unused code in telephony fragment
Bug: 114749736
Test: Manual
Change-Id: Ifff0cd03b024a482ce2c61e0d052c95a77e714ee
2018-10-25 14:32:38 -07:00
jackqdyulei
4c0b300e21 update CdmaApnPreferenceController
Rename it to ApnPreferenceController since it support both Gsm and
Cdma. Also add check for Gsm sim card.

Bug: 118402844
Test: RunSettingsRoboTests
Change-Id: Iafe111bfdc8f8e7d91d104df652ae9b27c9b166f
2018-10-25 13:13:13 -07:00
jackqdyulei
762f75f150 Add network selection preferences
1. Toggle to decide whether to auto select
2. Preference to go to network selection page

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Ie9d8e9353bf2a99b8cba1fb14d5a440a43fde66e
2018-10-25 12:47:54 -07:00
Fan Zhang
130c477044 Remove DashboardSummary and all related classes.
- Condition is already supported in PersonalSettingsFragment
- Suggestion is already supported in PersonalSettingsFragment
- Static/dynamic tiles are supported in TopLevelSettings

Change-Id: I51882e3bd0919ad95109baefac683d98667c11e3
Fixes: 110405144
Test: robotests
2018-10-25 11:27:47 -07:00
jackqdyulei
227526a8ac Update NetworkSelectSettings page
Clean it up and make it compatiable with all devices. Before this CL
it only used in Pixel 3 with new moderm.

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Iad3bc131e294d34cff90b9130715780182adccd7
2018-10-25 10:51:23 -07:00
jackqdyulei
3a2226be63 Recopy NetworkSelectSetting from phone to settings
NetworkSelectSetting is changed during the migration, recopy it
to make it up to date

Following CL will refactor to reuse this fragment for all devices.

Bug: 114749736
Test: Build
Change-Id: Id43cb480cf31447a6e4a23eb3709f9ab972a2930
2018-10-24 18:53:09 -07:00
jackqdyulei
cdfa5bb378 Refactor Cdma preference in ECM
When phone is in ECM mode and Cdma preference is clicked, it should
first pop up ECM exit dialog. If user click yes, then it should launch
normal dialog.

This CL create a Cdma preference to stop launch normal dialog when in
ECM mode.

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Iba887d9fc49770b21cf0421ecc0120d63da43ef9
2018-10-23 14:38:32 -07:00