This suggested change is automatically generated based on group
memberships and affiliations.
Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy. We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain. It can always be
reverted if needed.
If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.
See the owner's recent review activity for context:
https://android-review.googlesource.com/q/bonianchen@google.com
To report an issue, file a bug in the Infra>Codereview component.
Change-Id: I4c8726b26469e9f8f986b2e54fe0a8edea21f246
Bug: 374994012
Test: atest SubscriptionInfoListViewModelTest
Test: manual test in live network
FLAG: EXEMPT flag clean up
Change-Id: Ib9f9f692658df13aad45f2e889a48f2bffed9ed4
When the pSIM is inserted for the first time, this subscriptionInfo arrives late.
It causes the sim onboarding is closed.
We add the timer to wait the psim's subscriptionInfo.
Bug: 377171470
Flag: EXEMPT bugfix
Test: insert the psim and showing the sim onboarding flow.
Change-Id: Ib50c28d1bb1372fb822b3cf10cfa3fb22c457b3b
Since the framework behavior was changed after the enabling mobile data dialog was implemented.
Bug: 368450590
Test: manully test the dialog.
Change-Id: I08e0e1b9643781e52f6a9d4fa2c0eccf0feb7901
If the sim onboarding on, then sim should use the sim onboarding flow.
Bug: 362289792
Test: manual test
Flag: EXEMPT bugfix
Change-Id: Ibe22309db9dea5737de5ad351825a046599e6744
After the telephony flag resetPrimarySimDefaultValues on, the telephony
set the preferred default subscription to remaining sim. Therefore, here
can ask whether the user uses [remaining SIM] for mobile data or not
Bug: 349783684
Test: remove the sim card, and settings show "use mobile data" dialog
Flag: EXEMPT bugfix
Change-Id: I5e3399e777bf1e8ef7998074082e55635eb23eb4
when the user inserts the psim, showing the sim onboarding for the user to setup the sim switching or the default data subscription in DSDS.
Will show dialog for below cases.
1. the psim slot is not active.
2. there are one or more active sim.
Bug: 348524643
Test: verify the UI
Flag: EXEMPT bugfix
Change-Id: I3c782fa2486fde25ac15a69b48ba2f07f90572bd
When the user inserts the psim, showing the sim onboarding for the user
to setup the sim switching or the default data subscription.
Bug: 336488573
Test: verify UI
Change-Id: I1faab0a3166efab3f1fd82d6a69ab4d33b624556
When the user remove the sim and then insert it back, the DDS may
be -1. If the DDS is -1, then the mobile data can not be turned on.
Show the sim onboarding for user for this case, the user can update
DDS by the flow.
Bug: 336380853
Test: verified UI
Change-Id: I7fd086cb08917f2cac2c1252585687179a2a2f93
When satellite session is started, we need to suppress the 'Choose SIM for mobile data' and 'Update preferred SIM' dialogs to prevent user turn on SIM.
Bug: 334139957
Test: atest, manual
Change-Id: Id56a98f3d1cfd38875173a643c992393d3dbeec8
Bug: 330585109
Test: SatelliteManagerTestOnMockService SatelliteSessionControllerTest SatelliteControllerTest
Manual test with demo and real mode
Change-Id: Iade6426981f76a0b9b71828e0c86d3088c3e974e
When device has two active esim and the user insert psim, the settings
will popup the dailog to ask user select the two sim card.
Now, there is the new sim UI, so it should show the new one.
Bug: 335780975
Test: verify UI
Change-Id: I298d488d467c447d6f8d91d86383708a4d1f70c9
Cherry-picking ag/26965536 into the 24D1-dev branch caused conflicts. Therefore, manually create this CL to migrate the MobileNetworkSwitchController to Kotlin and utilize Compose.
Bug: 315928920
Test: atest, manual
Change-Id: I215b5a4615a3b3da6fc160f76c85c814210cc3ef
Merged-In: I7aaaf43b4c449129197e7cc92565d274ffdd2d8c
In order to support Satellite SOS, device will have two modems, one for TN, one for NTN(satellite).
When device switches to satellite mode, PSS only disables TN eSIM (and not TN PSIM). Since NTN image only supports eSIM, there is no need to disable TN PSIM before switching to NTN image. Somehow device is seeing that TN PSIM is available and is showing the user to enable it. So we need to handle it by not showing this dialog during satellite mode enabled.
Bug: 330585109
Test: atest, manual
Change-Id: I9781b7e1cef8f7f10e7ecdbb23ca729da4d06eba
When SmartForwardingActivity attempts to set the Toolbar to ActionBar
in #onCreate, an llegalStateException is thrown. This is because
SmartForwardingFragment sets the default action bar by window decor to
ActionBar first by updating the title in #onCreatePreferences.
This occurs in cases where SmartForwardingFragment is created in the
process of being SmartForwardingActivity created, such as when rotating
SmartForwardingActivity.
Use getActivity()#setTitle instead of getActionBar()#setTitle.
Test: manual
Bug: 314232525
Change-Id: I041d62605ba666ecce041086854e675d9b19ac45
- Add the setup flow for switching sim and rename and setup primary sim
items
- Add the bottom sheet and progress dialog.
Bug: 318310357
Bug: 298898436
Bug: 298891941
Test: build pass. Will upload another cl for testing
Change-Id: Ie9680f0a67afe453c1449c0f2b59e98fd627e215
Since U, a sub can be associated with a particular profile, and thus in V we enforce filtering on the caller and only show the subs that are associated with the caller.
However, in some cases the caller indeed needs to see all subs regardless of its association, e.g. sysUI. Therefore, a param isForAllProfile is added to indicate whether the caller intends to see all subs.
Bug: 296076674
Test: voice call + data browsing
Flag: ACONFIG com.android.internal.telephony.flags.enforce_subscription_user_filter
DEVELOPMENT
Change-Id: I88e29b445a11f36e1a3db80368bb9e46ef06eac3
SwitchPreference and SwitchPreferenceCompat are both TwoStatePreference.
Using TwoStatePreference in Java will helps migration in the future.
Bug: 306771414
Test: manual - check Settings pages
Change-Id: I84e1d7b09451106797c2b23d127855c6976678ca
This error may be because onCreateDialog did not initialize mSubscriptions correctly, causing it to be null.
java.lang.RuntimeException: java.lang.NullPointerException at com.android.settings.sim.SimListDialogFragment.updateDialog.
Fix: 194175217
Test: Manual Test
Change-Id: I761fed847441c6061ea4690658f06b9c2021bcee
When disabling Smart forwarding, the SS requests for both subs will be
sent simultaneously, but sometimes network can't handle both SS
requests from both subs causing call forwarding settings to not be
changed without any notification to user.
Send the next SS request after completing the previous request same as
enabling Smart forwarding.
Test: manual
Bug: 289326844
Change-Id: I4869fa200d3fbb70ba1b6b46cc491ea45299f412
- Restrict UI if user is a guest
- Restrict UI if user has DISALLOW_CONFIG_MOBILE_NETWORKS
Bug: 262242946
Bug: 271849181
Test: manual test
atest -c SimDialogActivityTest
Change-Id: I227400aa71880895d8356f3d2961cb610ad2a357
The JobService.onStartJob() is run on main thread, should return in time
instead of wait for job complete, otherwise will cause ANR.
Not wait the job finish, and call jobFinished() when finished to fix
this issue.
Fix: 277031144
Test: Manual check with log that onStartJob() is returned in time
Test: Manual check with log that job is not run in main thread
Change-Id: I1e83363ca87a29fb9424100bf99b3f2d212fd9d0
