Commit Graph

3606 Commits

Author SHA1 Message Date
Yomna N
ec412eb802 Merge "Handle failing calls to TelephonyManager" into main 2025-03-03 14:35:40 -08:00
yomna
3d66e6b6fe Handle failing calls to TelephonyManager
If the phone process has died, Settings cannot make calls to
TelephonyManager. Update the handling of this case to new best
practices.

Bug: b/394077023
Test: m & atest CellularSecurityPreferenceController
Flag: EXEMPT bugfix
Change-Id: I64ecb143d0830873b590ce4a397c398d8b41943f
2025-03-03 17:34:14 +00:00
Treehugger Robot
c794912537 Merge "[Expressive design] Apply colors to homepage icons" into main 2025-03-03 02:21:05 -08:00
Jason Chiu
9c16e94552 [Expressive design] Apply colors to homepage icons
Bug: 396944193
Test: visual, robotest
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: I6ec24bdf8cb9a6f8454bd837daffe743b3b01526
2025-03-03 00:45:08 -08:00
Jacky Wang
e60bff2d81 [Catalyst] Fix UI flicker when toggle Airplane mode
The UI flicker is because preference change is notified twice after
onActivityResult calls setBoolean: 1) Catalyst framework registers a
common listener on each preference's storage to update UI when
preference value is changed. 2) The PhoneStateListener in
AirplaneModeStorage. Remove the second listener fixes the issue.

NO_IFTTT=Catalyst only

Fix: 395774878
Flag: com.android.settings.flags.catalyst
Test: manual
Change-Id: I9f93faf1da87d52a82d9019361b17b4b500d79fe
2025-03-03 07:54:42 +08:00
Treehugger Robot
d3b4656bec Merge "Modify string to match the design." into main 2025-02-26 05:39:02 -08:00
tom hsu
9b7f0bbf95 Modify string to match the design.
Flag: EXEMPT bug fix
Bug: b/397958254
Test: Manual test.
Change-Id: Ic424e30ce4c44ea63ee650bd6c1bcafcd60070a4
2025-02-26 03:08:01 -08:00
noshinmir
16e32fae3f Add nested toggle switches under Adaptive connectivity settings UI
Bug: 393645580
Flag: com.android.settings.flags.enable_nested_toggle_switches
Test: Manual testing
atest AdaptiveConnectivityScreenTest
hsv: https://hsv.googleplex.com/5165236934934528

Change-Id: I12403f5c80290ebccc04f11771ec3f06ee216610
2025-02-26 07:16:38 +00:00
Treehugger Robot
0a1540ed51 Merge "Add strings for NTN connection manual type" into main 2025-02-25 05:37:42 -08:00
tom hsu
b91d21ba76 Add strings for NTN connection manual type
Flag: EXEMPT bug fix
Fix: b/397958254
Test: Manual test. see b/397958254#comment10
Change-Id: Ibcd3511edee9b3203c6c0cad68e0988b4b621b39
2025-02-25 04:33:00 -08:00
SongFerng Wang
57da8021d0 Merge "Add null checker for telephonymanager" into main 2025-02-25 02:14:42 -08:00
songferngwang
e4c2cddfae Add null checker for telephonymanager
Bug: 399023211
Test: atest Enable2gPreferenceControllerTest
Flag: EXEMPT bugfix
Change-Id: I3872ecfff2296cbec9f0ef54ee7cee5a554f111f
2025-02-25 08:41:55 +00:00
Jack Yu
0b2effb371 Merge "Cleaned up the flag enforce_telephony_feature_mapping_for_public_apis" into main 2025-02-24 17:45:03 -08:00
Tom Hsu
3c1e8e19cb Merge "Make Satellite UI updatable during receiving callback" into main 2025-02-20 23:27:01 -08:00
Treehugger Robot
540361621a Merge "Fixed crash issues in Emergency Callback Mode" into main 2025-02-20 03:35:54 -08:00
Weng Su
af065146d5 Fixed crash issues in Emergency Callback Mode
- Avoid using controllers when Catalyst design is enabled

Bug: 394015881
Flag: EXEMPT bugfix
Test: Manual testing
  atest NetworkDashboardFragmentTest
Change-Id: I4393be5e76c0328f2a53f1d828814491991557f1
2025-02-20 18:24:16 +08:00
tom hsu
d5548d1463 Make Satellite UI updatable during receiving callback
- Refactor code
 - Make Satellite category be updatable by callback.

Flag: EXEMPT bug fix
Fix: b/396233604
Fix: b/382664790
Test: atest pass
Change-Id: I893030005ae5af1403557f7bd22e8cdaf038ffcf
2025-02-20 09:34:45 +00:00
Nikhil Nayunigari
487a4774d1 Add ethernet interface details settings subpage
Adds a click listener to the ethernet interface row and displays a
settings subpage with interface connection status.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest SettingsRoboTests:
com.android.settings.network.NetworkProviderSettingsTest

Change-Id: Id64ce3657b47dd4ca70d425dd3d13227c8468d2c
2025-02-19 04:55:22 +00:00
Nikhil Nayunigari
0afd3f64a5 Merge "Display one row item per Ethernet interface" into main 2025-02-18 15:39:43 -08:00
Jack Yu
a38de2654d Cleaned up the flag enforce_telephony_feature_mapping_for_public_apis
Cleaned up the 24Q3 flag enforce_telephony_feature_mapping_for_public_apis

Test: Basic telephony functionality tests
Test: atest FrameworksTelephonyTests
Bug: 297989574
Flag: EXEMPT flag cleanup
Change-Id: Iefb9a02eebe06fb42a23d645e6be034c94508487
2025-02-18 13:32:36 -08:00
Liana Kazanova (xWF)
a17dfe4ecc Merge changes from topic "revert-31790253-UHOKZZQOPA" into main
* changes:
  Revert "Make Satellite UI updatable during receiving callback (P..."
  Revert "Modify the default satellite category title."
2025-02-18 10:46:03 -08:00
Nikhil Nayunigari
25c5971e89 Display one row item per Ethernet interface
This change adds a preference category to host rows for ethernet
interfaces.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests:
com.android.settings.network.NetworkProviderSettingsTest

Bug: 369889610

Change-Id: Idb37cbf17f06db2c9a217659affb35d9dcebadf3
2025-02-18 09:41:49 -08:00
Liana Kazanova (xWF)
790fa6e00e Revert "Make Satellite UI updatable during receiving callback (P..."
Revert submission 31790253

Reason for revert: DroidMonitor: Potential culprit for http://b/397368653 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:31790253

Change-Id: I851046019821fff0d132efb0b00cbff1e3ecbe72
2025-02-18 09:35:50 -08:00
Hakjun Choi
0be57cf311 Merge "Clean up aconfig flag carrier_enabled_satellite_flag" into main 2025-02-18 03:29:48 -08:00
Treehugger Robot
8fda02a7de Merge "Fix crash due to display name is not set to View." into main 2025-02-18 03:11:16 -08:00
tom hsu
04006ccb48 Fix crash due to display name is not set to View.
Flag: EXEMPT bug fix
Fix: b/396700275
Test: manual test
Change-Id: I2a70c4e31c182f99cc4fb3da93ce7911da005429
2025-02-18 10:04:34 +00:00
Hakjun Choi
1a53ea7a05 Clean up aconfig flag carrier_enabled_satellite_flag
Bug: 393951373
FLAG: EXEMPT flag clean up
Test: atest NetworkSelectSettingsTest WifiCallingSettingsForSubTest SatelliteSettingsPreferenceControllerTest
Test: manual test in live network
Change-Id: I154e9be8a8c771fafb37af078be7b495f18b6100
2025-02-18 08:41:14 +00:00
Aleksander Morgado
c9aaa03d7b Merge changes from topic "settings-visibility-return-fixes" into main
* changes:
  Return DISABLED_FOR_USER in deviceinfo/simstatus availability if not admin user
  Return UNSUPPORTED_ON_DEVICE in deviceinfo/simstatus when no telephony
  Added unit tests for SimStatusPreferenceController visibility
  Return DISABLED_FOR_USER in IMEI availability if not admin user
  Return UNSUPPORTED_ON_DEVICE in network/imei when no telephony
  Added unit test for MobileNetworkImeiPreferenceController visibility
  Added unit tests for ImeiInfoPreferenceController visibility
  Return UNSUPPORTED_ON_DEVICE in network/phonenumber when no telephony
2025-02-18 00:10:26 -08:00
tom hsu
9df2e6fdc9 Make Satellite UI updatable during receiving callback (Part II)
- Refactor code
 - Make Satellite category and preference be updatable by callback.

Flag: EXEMPT bug fix
Fix: b/396233604
Fix: b/382664790
Test: atest pass
Change-Id: I55423317d82589312ce4a2f851b32b242529e922
2025-02-18 06:32:33 +00:00
tom hsu
048be18c5e Make Satellite UI updatable during receiving callback (part I)
- Refactor code
 - Make Satellite category and preference be updatable by callback.

Flag: EXEMPT bug fix
Fix: 396233604
Test: atest pass
Change-Id: If2e3d9b82950f05c4911ee7ce3bb41fb26e0d3e4
2025-02-18 06:19:47 +00:00
tom hsu
543e446150 Fix test error of SatelliteSettingsPreferenceControllerTest
- Root cause is wrong Resouce string got.

Flag: EXEMPT bug fix
Fix: b/396571641
Test: atest passed
Change-Id: I25a4c7fff0ea20ab3c6e7fde99e1fba2b0288dfd
2025-02-17 11:28:47 +00:00
Aleksander Morgado
64fb695d9b Return DISABLED_FOR_USER in IMEI availability if not admin user
The correct return when checking for the IMEI field availability
for non-admin users is DISABLED_FOR_USER.

UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest ImeiInfoPreferenceControllerTest
Test: atest MobileNetworkImeiPreferenceControllerTest

Change-Id: I4ee89a84953993daad539d33d3a2e576540c580f
2025-02-17 00:44:30 -08:00
Aleksander Morgado
2a0ad1efdf Return UNSUPPORTED_ON_DEVICE in network/imei when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

This change also aligns the behavior with the deviceinfo/imei
entry.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest MobileNetworkImeiPreferenceControllerTest
Change-Id: Ia01cf3812f8343eabd8ea6970b691ac71432e8bd
2025-02-17 00:44:30 -08:00
Aleksander Morgado
a66d27c488 Return UNSUPPORTED_ON_DEVICE in network/phonenumber when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

This change also aligns the behavior with the deviceinfo/phonenumber
entry.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I5f2392969fad1884a89de3870ad37be5601fbe37
2025-02-17 00:44:30 -08:00
Nikhil Nayunigari
2c90d30415 Merge "Changes to add Ethernet settings row item" into main 2025-02-15 11:46:13 -08:00
Nikhil Nayunigari
bfd3722e06 Changes to add Ethernet settings row item
Adds EthernetSettings row item to NetworkProviderSettings and its
controller.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests:
com.android.settings.network.EthernetSwitchPreferenceControllerTest

Change-Id: I27965ad0c8563657b17e0aa6d3bd19b97fcf5615
2025-02-15 18:20:46 +00:00
tom hsu
bb80fe2df1 [Satellite Settings] Show device's app info on Satellite settings page.
- Shows device apps' info up to 3 on Satellite settings' page.
 - Add a new page to show all device's app info with Satellite supported.

Flag: com.android.internal.telephony.flags.satellite_25q4_apis
Fix: b/395813844
Test: atest pass
Change-Id: Ibd5e1c74b636639082ec9477f2b6796bcbc8340d
2025-02-14 06:40:10 -08:00
tom hsu
63242bc3ff [Satellite Settings] Add a new API to SatelliteRepository
Flag: com.android.internal.telephony.flags.satellite_25q4_apis
Bug: b/395813844
Test: atest pass
Change-Id: Ife9e370dbcb3694adfd0bfbcc2ec2a742fbc4434
2025-02-14 06:39:45 -08:00
SongFerng Wang
b7d640ef36 Merge "Check if ECBMode when activate SIM card" into main 2025-02-13 18:41:42 -08:00
songferngwang
538fb34027 Check if ECBMode when activate SIM card
If in ECBMode, start ACTION_SHOW_NOTICE_ECM_BLOCK_OTHERS to show a
dialog instead.

This align with the deactivate sim case

Bug: 393298086
Test: atest SubscriptionActivationRepositoryTest
Test: adb shell cmd phone emergency-callback-mode
Flag: EXEMPT bugfix
Change-Id: Id40d087b7d2d3ca99504ec75bac1c5e29c67258d
2025-02-13 12:04:07 +00:00
Aleksander Morgado
bd56a0efd3 Merge changes from topic "hide-phone-number" into main
* changes:
  Phone number only available if telephony capable
  Phone number only available for admin users
  Added unit test for MobileNetworkPhoneNumberPreferenceController visibility
  Added unit tests for PhoneNumberPreferenceController visibility
2025-02-13 00:06:32 -08:00
Treehugger Robot
793a6802ac Merge "Fix accessibility issues in Private DNS Settings" into main 2025-02-12 21:08:22 -08:00
Weng Su
b3938a0244 Fix accessibility issues in Private DNS Settings
- Keep the Save button enabled at all times

- Show error in the Hostname view to remind the user
  - "The field is required" error
  - "The hostname you typed isn't valid" error

Bug: 386323822
Flag: EXEMPT bugfix
Test: Manual testing
atest -c PrivateDnsModeDialogPreferenceTest \
         PrivateDnsPreferenceControllerTest

Change-Id: I63973bd5001b838d7f27827e6a6d4ac96ac78ca9
2025-02-13 12:05:25 +08:00
SongFerng Wang
b8388cd90f Merge "Fix popping up the the VoLTE screen when it's disabled by the carrier." into main am: 9dc07f4e19 am: 4fec2b9e47
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3481415

Change-Id: I195bc0554e509f1cf3a391609a77f934f1cbdb80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-12 19:42:39 -08:00
Aleksander Morgado
731df0fa98 Phone number only available if telephony capable
The Phone Number field in either the about or network details pages
should not be shown if the device does not have telephony
capabilities.

Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I04f682cc829d5dc7879e6cdacdaebc55a3b6fd2c
2025-02-11 18:43:40 +00:00
Aleksander Morgado
571103b891 Phone number only available for admin users
The phone number is hidden to non-admin users, following the same
reasoning that exists for other telephony-specific fields like the
baseband IMEI.

Bug: 392808943
Flag: EXEMPT bugfix
Test: atest PhoneNumberPreferenceControllerTest
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I4e612219d0c7439930e91b3e1d6e368a0dfd073e
2025-02-11 18:30:42 +00:00
Jacky Wang
a2e663dadd [Catalyst] Move PreferenceRestrictionMixin
NO_IFTTT=Catalyst only

Bug: 377600992
Flag: EXEMPT refactor
Test: atest
Change-Id: I3c26a5a56d8fd6e887e4ff4d38d8e8eb97844672
2025-02-11 20:18:43 +08:00
Jacky Wang
afbcf06654 [Catalyst] Move metrics class
NO_IFTTT=Catalyst only

Bug: 389886085
Flag: EXEMPT refactor
Test: atest
Change-Id: I8c24a4edf768aa2286adf66f16077e962080bb48
2025-02-11 20:18:30 +08:00
SongFerng Wang
30af231cc4 Merge "Handle the sim switch for restricted ss mode case" into main 2025-02-10 20:25:41 -08:00
Treehugger Robot
1b1fa4810f Merge "[Satellite] Add satellite string for KDDI if no entitlement" into main 2025-02-10 19:30:27 -08:00