Commit Graph

69439 Commits

Author SHA1 Message Date
Stanley Wang
5e13ed3415 Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: 7c0f60f24e am: 11b97ea0ae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: Ia203d647cd124ac17ab6a45fbd8863c63196d9a6
2020-06-22 11:03:28 +00:00
TreeHugger Robot
b81bb4780a Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be am: a456072536 am: 733d80a575
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: Iba295486e08bbe2e94d59863ff5a2ed521a0eeb1
2020-06-22 11:03:22 +00:00
Stanley Wang
411f25a5f9 Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: b1895fc072 am: bd7e2b93e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: Id2606cadf93cf8caa6f70a894751863382a7c695
2020-06-22 11:03:22 +00:00
Stanley Wang
dc3ad75817 Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: b1895fc072 am: 69eaf216eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: Id996da73c3e94887ce7fe8ab5f6b7d0f9944472f
2020-06-22 11:03:15 +00:00
TreeHugger Robot
49ebea153c Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be am: f5c9bf01c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: Id5e9517d512afe8c52ace07b2487f2bb56d0a47c
2020-06-22 10:51:21 +00:00
TreeHugger Robot
5b5f0f0836 Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be am: a456072536
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: I05ad005de4386cc72babe4c589d87262b93acc04
2020-06-22 10:51:16 +00:00
Stanley Wang
bd7e2b93e8 Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: b1895fc072
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: Iba0db5469c4a8671496e38f4121cccd8e227e6a7
2020-06-22 10:51:09 +00:00
Stanley Wang
11b97ea0ae Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: 7c0f60f24e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: If240648f9ae164915225afc6cefb3e3e7f7d3488
2020-06-22 10:51:05 +00:00
TreeHugger Robot
733d80a575 Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be am: a456072536
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: I086c26c26bc911056a55800c99b480f3b91fac8c
2020-06-22 10:50:46 +00:00
Stanley Wang
69eaf216eb Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: b1895fc072
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: I06655ae21068d4f9bd0f9430e88be8b3a69eacf9
2020-06-22 10:50:39 +00:00
TreeHugger Robot
f5c9bf01c3 Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: I242e99fed086552dd9492c9ad8a294b72e166212
2020-06-22 10:43:06 +00:00
TreeHugger Robot
a456072536 Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: Ib8597a1df999e308b90ae00ffd83b281627e7809
2020-06-22 10:42:42 +00:00
TreeHugger Robot
72dac6e5be Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev 2020-06-22 10:40:46 +00:00
Stanley Wang
7c0f60f24e Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: I2f29322ed4c14d9ed093777d330e9df7b364feb4
2020-06-22 10:38:20 +00:00
Stanley Wang
b1895fc072 Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: I7bda54792d81ace1bcdee9f018fb3e5f3db0fc1b
2020-06-22 10:38:04 +00:00
Stanley Wang
7afb61e6dc Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev 2020-06-22 10:25:58 +00:00
Stanley Wang
2bbfe95f74 Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: 843622806b am: de3ddf5f3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I83fd3cbee9cc79ab2ac453ebb6588a49900b7f58
2020-06-22 08:57:00 +00:00
Stanley Wang
eb8360d820 Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: d4714ff1db am: a8ba796123
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I21a8f290ac04d5652016af900355f9c3527035be
2020-06-22 08:56:36 +00:00
Stanley Wang
6a331078b7 Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: 843622806b am: 24eaff871f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I0c502ec881dc592113ad1d210843a563aaf89ca1
2020-06-22 08:55:31 +00:00
Stanley Wang
f1a0801c00 Fix the bug of not showing lock screen before entering Smart Lock page.
Controller can't find the target preference to handle the click event.
Store the preference keys to match the clicked item.

Fixes: 158716163
Test: run robotest and manually test the click behavior

Change-Id: Ie243206ceffef013c56c4ea29c14fe56da510fb6
2020-06-22 16:49:02 +08:00
Stanley Wang
de3ddf5f3f Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: 843622806b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I13f42839733c90f88496adeea44aeaccdb89a9b3
2020-06-22 08:46:53 +00:00
Stanley Wang
a8ba796123 Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: d4714ff1db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I6171c7298881194901f6e4b9d5963c5cf02e6a25
2020-06-22 08:46:48 +00:00
Stanley Wang
24eaff871f Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: 843622806b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I0c038c91405dbf81d4c7e5d1012335ed1907e68b
2020-06-22 08:46:25 +00:00
Jason Chiu
9f7d74185e Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: c13f549973 am: e7a9baaf8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: Iceee340ef3e76aacc8a1a0f85e15f53927275e93
2020-06-22 08:40:53 +00:00
Jason Chiu
2de1b7ade4 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: 1bb216e35e am: 092f612ab2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I49099ac35f5c5ba42cb9c5b084ebaa5b8cd80db5
2020-06-22 08:40:39 +00:00
Jason Chiu
a5ff2d0230 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: c13f549973 am: 16b830e465
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I80784e7d2a8fd83fd3a21879bbe9a1e660ed6b9d
2020-06-22 08:40:33 +00:00
Stanley Wang
d4714ff1db Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I0c23ec0766d3d9a87e59d59f0003778e4edc6acc
2020-06-22 08:29:58 +00:00
Stanley Wang
843622806b Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I8d32c05d89d857859b88477d282fc36a614c4d9a
2020-06-22 08:29:51 +00:00
Jason Chiu
092f612ab2 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: 1bb216e35e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I1e73dd84798698d03c7fdb3ec4ed79702f0018cb
2020-06-22 08:25:05 +00:00
Jason Chiu
e7a9baaf8f Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: c13f549973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: Ib2bcfe75f1ed54a3c9b4ab898d163ab1adab43ee
2020-06-22 08:24:48 +00:00
Jason Chiu
16b830e465 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: c13f549973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I15f115cacf0d233c5337d3e59242e545f877b368
2020-06-22 08:24:48 +00:00
Stanley Wang
1117895745 Merge "Add log to capture the hardware status." into rvc-dev 2020-06-22 08:19:36 +00:00
Jason Chiu
1bb216e35e Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I572e26bd5148fe6823095272bf5cea57104def1c
2020-06-22 08:12:05 +00:00
Jason Chiu
c13f549973 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: Ia202ea7899f8ebb8770db91ea676b28f29cbef64
2020-06-22 08:11:49 +00:00
Jason Chiu
c548288a51 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev 2020-06-22 07:58:25 +00:00
Jason Chiu
c3e54f569c Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e am: 0d96af8cea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: Ib4d007afa377615a445ee6c97d89813927a48b8f
2020-06-22 07:41:28 +00:00
Jason Chiu
34e5c36ce7 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 5d37336eb3 am: 81d612d5fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I3a0fdbbbbad03659c0329803a2a9224d15e51c28
2020-06-22 07:41:18 +00:00
Jason Chiu
4aa3003ecf Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e am: d1056becc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I60a5eaedf38db9d36cadd6f568f131b8d58a9101
2020-06-22 07:41:05 +00:00
Jason Chiu
73afb042dc Workaround of Slice not pinned bug when using SliceCallback
When a client registers a SliceCallback, it starts to observe Slice
changes. The observer is running in the main looper and binds Slice
in AsyncTask.

However, when the client unregisters the callback, it unpins the Slice
in the client's thread. Thus, if the AsyncTask has pinned the slice but
hasn't bound it yet, it may be unpinned by the client, and an exception
occurs.

This fix is to unpin the Slice in the same SerialExecutor of AsyncTask,
which is to ensure bindSlice() and unpinSlice() are called in the same
thread one after another without the race condition.

Bug: 157387583
Test: robotest
Change-Id: If5f4b4bc0d8c5a2800cad8ff2afd7084426a6c96
2020-06-22 07:38:50 +00:00
Jason Chiu
0d96af8cea Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I222b266722c726c8346491a87107aace2168615a
2020-06-22 07:27:48 +00:00
Jason Chiu
81d612d5fa Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 5d37336eb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I2ea7f182efc44bbdc0a6e8c05dcc0dcebd45834a
2020-06-22 07:27:48 +00:00
Jason Chiu
d1056becc2 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I342f57b7adb215835fcebd9dff0b3e51cd0f3e7c
2020-06-22 07:27:19 +00:00
Jason Chiu
5d37336eb3 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I1913715e1ecddf6f39fd8a3357a7db3125add0b8
2020-06-22 07:15:04 +00:00
Jason Chiu
07081ae34e Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: Ia422444a14e73076de14098a612794d4c0909ddc
2020-06-22 07:14:46 +00:00
Jason Chiu
f1a65df04a Merge "Decrease memory usage for sleep idle test" into rvc-dev 2020-06-22 07:05:38 +00:00
Automerger Merge Worker
009b00a6bc Merge "Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 23c1016d6d" into rvc-qpr-dev-plus-aosp 2020-06-22 06:56:32 +00:00
Jason Chiu
c8996cf552 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 23c1016d6d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: If481e8ea8b54b41339603c6c7b9f8908c5e1ba70
2020-06-22 06:56:28 +00:00
Jason Chiu
faee522b97 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: eb50dcaac5 am: aecb321beb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I5e3168de6e4be79db1d86ce88705b19636781447
2020-06-22 06:56:26 +00:00
Jason Chiu
031062198e Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 2e67b3f645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: Ic3ba82a08f20fa035075c3b3af0ae043be55504e
2020-06-22 06:56:21 +00:00
Yi-Ling Chuang
b54f9b4921 Disable the defulat animation of the RecyclerView to avoid UI jank.
When users go to a sub page in Settings and come back to the homepage
again, those sticky cards flicker which makes the UI janky. This is
because we rebind sticky cards to ensure it's always up-to-date, where
the recyclerView has its default animation while notifyItemInserted(),
ane thus introduce the jank.

Fixes: 158627602
Test: Open Settings -> go to sub pages -> back to the homepage -> cards
are not flickering.

Change-Id: I2104dbe0bed8b2486c35521bcc0b5c8b54efb995
2020-06-22 14:53:10 +08:00