Commit Graph

31273 Commits

Author SHA1 Message Date
Faye Yan
d3584a02f5 Merge "UX updates in Settings for unrestricting permissions." into main 2024-03-26 19:16:52 +00:00
marcusge
9ec6673b3f [Accessibility] Color Contrast address talkback bugs
Test: local raven device
Bug: 329352987
Bug: 329192396
Bug: 329187057
Flag: aconfig
com.android.settings.accessibility.enable_color_contrast_control

Change-Id: I60d2b23acb2e406db15f348ba7881577e55a8868
2024-03-26 19:08:42 +00:00
Joseph Vincent
f58eeaaf15 Merge "Change icon for Private Space unlocked and setup success toast" into main 2024-03-26 19:04:11 +00:00
Joshua McCloskey
199d75b332 UDFPS Enrollment Refactor (1/N)
This CL creates a few necessary components that are needed to create the
UI

Test: adb shell device_config put biometrics_framework com.android.settings.flags.fingerprint_v2_enrollment true
Bug: 297082837

Change-Id: I17c4f65fdeac4ebf3c19ba69f5928787b5ace52e
2024-03-26 18:13:54 +00:00
Angela Wang
85f933f056 Fix button insufficient contrast ratio problem
Apply textColorSecondary as the tint color for the arrow icon to prevent
insufficient contrast ration problem under light theme.

Bug: 331139289
Test: manually check the UI
Change-Id: I010a6129cdd7bf11840421abc5f53156433b6708
2024-03-26 13:23:10 +00:00
Faye Yan
ff6c0b3fcb UX updates in Settings for unrestricting permissions.
Bug: 331266942
Test: presubmit
Change-Id: I4fba9f8e75a61d59c07a371581dc6f8fa10795e1
2024-03-26 09:14:07 +00:00
Jason Chiu
c53a73ef70 [Safer intents] Connectivity
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: I44ff8a789d933f11ba7e68e52055575245276224
2024-03-26 16:44:48 +08:00
Chaohui Wang
ecd71a6300 APN label for radio button
Fix: 330808298
Test: manual - with APNs
Change-Id: Ic5b8d7cb1369deda0ec5f89b621c972c97819664
2024-03-26 13:34:30 +08:00
Roy Chou
1c898252cb fix(magnification): make always on toggle unavailable when capabilities is window only
As b/328787031, we make the MagnificationAlwaysOnPreferenceController observe the magnification capabilities then update the preference enabled state. Therefore, when changing the capabilities to window mode only, the preference will become unavailable.

We use the bug-fix flag to verify the fix with rollout process.

Bug: 328787031
Flag: ACONFIG com.android.settings.accessibility.hide_magnification_always_on_toggle_when_window_mode_only DEVELOPMENT
Test: manually flip the flag
      atest MagnificationCapabilitiesTest
      atest ToggleScreenMagnificationPreferenceFragmentTest
      atest MagnificationAlwaysOnPreferenceControllerTest
Change-Id: I1a25f80131d84ecdd927030e40a18ebb32b7862f
2024-03-26 05:11:06 +00:00
SongFerng Wang
bf210b9834 Merge "Replace the bottomsheet with dialog" into main 2024-03-26 03:50:09 +00:00
Haijie Hong
f5d8f4afa9 Merge "Disable media output switcher in Settings when audio sharing" into main 2024-03-26 03:23:51 +00:00
Josh Hou
3c38a12347 Aggregation checkbox and locale text
Refer to other settings with the checkbox to read the checkbox and corresponding text together, such as "Erase SIMs" or "Show password" in WiFi settings.

Bug: 288223637
Bug: 317927064
Test: Perform some accessibility test like TalkBack and Select to Speak
Change-Id: I571fe3f2f8d7b6b4f4c7b5804d0217a2a2b97757
2024-03-26 03:19:19 +00:00
Varun Shah
a5593de4c5 Hide the Perform Backup Tasks Settings page.
Since we are now hiding the new RUN_BACKUP_JOBS permission, hide the
associated special app access page in Settings.

Bug: 331272951
Test: BackupTasksAppsPreferenceControllerTest
Test: visual (Settings pages)
Change-Id: I875b286798f48ee4e94d5e37c1b21bb84acf390d
2024-03-26 02:43:30 +00:00
Angela Wang
53985e6307 Merge "Enable the hyphenation in pin confirm dialog" into main 2024-03-26 00:57:21 +00:00
Chun-Ku Lin
257ac13217 Merge "Update a11y edit shortcut screen's text and tutorial text" into main 2024-03-26 00:47:51 +00:00
Chaohui Wang
fbaa520e43 Merge "Set Default APN radio button's size to 48dp" into main 2024-03-25 23:48:37 +00:00
Chun-Ku Lin
3aee92e2e8 Update a11y edit shortcut screen's text and tutorial text
Bug: 323792194

Test: manual
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts

Flag: N/A simple string changes

NO_IFTTT=Introduce new IfThisThenThat lint

Change-Id: I7ba4096d669453c33257880407e85ffe76d358f8
2024-03-25 22:19:10 +00:00
Kyle Zhang
fc21e32cb3 Use new naming for Widevine Developer option.
Bug: 301669353
Change-Id: Idf9802fc6bbffdc81c9c0fa3527dc3eb7efbf2a1
2024-03-25 22:04:51 +00:00
Neil Fuller
43ded696dd UI changes to support time feedback
The feature is behind a release flag. It is also behind an experiment
flag so it can be trialed with Googlers before general release even
after being enabled in a release.

The feedback button only shows up if there is an intent URI configured,
which should be handled via an overlay. The design means that the intent
is potentially dependent on the manufacturer (good!), though I expect we
will suggest a standard one for GMS devices so we get feedback from a
variety of devices with different form factors / capabilities.
In this default, GMS core (Google Play Services) will handle the intent
and take the user through a feedback UI flow.

Testing:

To enable the button you need to build with one of release variants that
supports dynamic flags, e.g. trunk_food.

Then release flag:
$ adb shell device_config put location com.android.settings.flags.datetime_feedback true

It still won't work without the experiment flag:
$ adb shell device_config put settings_ui time_help_and_feedback_feature_supported true

Finally, the settings entry will launch an intent when pressed which has
to have a receiver. The receiver will be in GMS core but will be subject
to its own review / launch process. Until then, this feature will remain
quiet, biding its time.

Bug: 283239837
Test: Manual (see above)
Test: atest SettingsRoboTests:com.android.settings.datetime
Change-Id: I68798798fc0a47ae4c6755174ce509fbaee24142
2024-03-25 19:00:47 +00:00
marcusge
05f42b52da [Accessibility] Color Contrast address UX bugs
Reformatted xml files and added constraints to make sure texts do not go
out of bound.

Test: local raven device
Screenshot: attached on bug
Bug: 329176991, 329169251
Flag: aconfig
com.android.settings.accessibility.enable_color_contrast_control

Change-Id: I7cb15a46557f54833c77fe41928fb6e98d5ec519
2024-03-25 17:57:28 +00:00
Hakjun Choi
6263205fa8 Fix the Settings to align with the requirements in PRD am: ec735999b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26691418

Change-Id: I5b92e67cb046e97bc5d70e08c6845bddab4ac462
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-25 17:56:24 +00:00
josephpv
4cc915ad64 Change icon for Private Space unlocked and setup success toast
Change is made to show customised icon in Toast message shown by using
Toast.makeCustomToastWithIcon()

Screenshots :
go/ss/AcaRQUJQfh79wDw.png
go/ss/5j4oD8xydwX7HTX.png

Bug: 329391204
Bug: 309575523
Test: Manual
Change-Id: I336d7d0419b1de60024e584e943a725662b446a9
2024-03-25 16:53:46 +00:00
Chaohui Wang
1ea5a786e2 Set Default APN radio button's size to 48dp
Which is the minimum tap size.

Also set ApnPreference not selectable, since itspPrimary target and
radio button could be selectable, but entire preference itself is not
selectable.

Fix: 330812055
Fix: 330290274
Test: manual - with APNs
Change-Id: I651642e8a275932be6b8bcb365198e5dc1ad92f8
2024-03-25 12:23:33 +00:00
songferngwang
0dbe979994 Replace the bottomsheet with dialog
using the dialog and update the string

Bug: 330097568
Test: verify the UI

Change-Id: I4c9a21fc74e608e08db334053d4e5bfb57abce70
2024-03-25 10:08:40 +00:00
Jason Chiu
d89fd5942f [Safer intents] System
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: Iaf5466f3acd3293e738f450e0117e180b93d4e1c
2024-03-25 18:08:03 +08:00
Hakjun Choi
ec735999b0 Fix the Settings to align with the requirements in PRD
Update the guideline string to the latest from UX team.

Bug: 330961550
Test: manually testing from pixel device
Change-Id: Ic6eb4ba2a85cbfc5544182f30fe645283084084a
2024-03-25 06:09:26 +00:00
Haijie Hong
c1a5a7c9b1 Disable media output switcher in Settings when audio sharing
Bug: 327080094
Test: atest MediaOutputPreferenceControllerTest
Change-Id: I1e81d507c5c92c2b6f21494551931b359d5043cb
2024-03-25 14:01:35 +08:00
Ze Li
24652df671 Merge "[PairDevicePage] Add content description so that the loading icon will be announced." into main 2024-03-25 05:36:34 +00:00
Tom Hsu
af5e80b7d8 Merge "Enforce BaseUserRestriction for DISALLOW_CONFIG_BRIGHTNESS" into main 2024-03-25 03:00:38 +00:00
Samridhi
c635e76d81 Merge "Add order to display settings" into 24D1-dev am: 790abeba56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/26639338

Change-Id: Iee8907af5ca2dab78d10b09d96685b9e643d1d1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-22 18:43:45 +00:00
Samridhi
790abeba56 Merge "Add order to display settings" into 24D1-dev 2024-03-22 18:13:23 +00:00
Treehugger Robot
55b1a62ed8 Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-03-22 16:39:52 +00:00
Treehugger Robot
bc2186f2a6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-22 16:36:40 +00:00
Treehugger Robot
f9b93ccf15 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-22 16:36:40 +00:00
tomhsu
7465e27d85 Enforce BaseUserRestriction for DISALLOW_CONFIG_BRIGHTNESS
- For Adaptive brightness

Fix: 330855652
Test: Manual test. see b/330855652
Change-Id: Iea848c9d92abdf152d3eb827fbe1fb141f4687d7
2024-03-22 11:50:22 +00:00
Joseph Vincent
4230ad4b07 Merge "Add a preference in reset options to delete private space" into main 2024-03-22 10:01:19 +00:00
Ze Li
ac55929205 [PairDevicePage] Add content description so that the loading icon will be announced.
Test: manual test
Bug: 318785556
Change-Id: I2f2c584c7e54a3603925a9def55e9bb976b2f36c
2024-03-22 17:38:10 +08:00
Angela Wang
dc50a50d6e Enable the hyphenation in pin confirm dialog
Bug: 328520865
Test: manually check the UI element
Change-Id: I8e4f08126f53e35aee5fd7a5ada9fcdb63a39bed
2024-03-22 09:35:05 +00:00
Sunny Shao
e352753093 Merge "Handle the Edge to Edge problem" into main 2024-03-22 08:28:17 +00:00
Bill Yi
4a21cc3763 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ied59e1f177db16784d506a9c4bc057aa4dc60ba5
2024-03-21 21:10:17 -07:00
Bill Yi
f56110033f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I57629baa4915f38efa8f70516e2d8c5a1c740871
2024-03-21 21:08:28 -07:00
Bill Yi
89ce8faad3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie07fb2bf6b6d658f075d50e7a1bac7eb81964606
2024-03-21 21:06:59 -07:00
Bill Yi
b9bbd9d6a5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I70ff035fca7e86e0f34f86430ac8a628ad527b15
2024-03-21 21:03:20 -07:00
Xinyi Mao
7f1a96537b Merge "Fix talkback focus on "Less than a min"" into main 2024-03-22 03:28:11 +00:00
josephpv
43c8d3a3f8 Add a preference in reset options to delete private space
This takses care to add an entry point in Settings->System->Reset
options->Delete private space when private space feature is supported on
the device. Entry point appears both when private space exists and also
when private is not created.
On selecting asks for user authentication and on successful
authentication using device lock shows a dialog asking for
confirmation and calls for deletion private space.

Based on this entrypoint it would not be possible to guess if private
space exists on the device.

Recording link : b/329041740#comment3

Bug: 329041740
Test: atest ResetOptionsDeletePrivateSpaceControllerTest and verified
this doesn't give away existence of private space

Change-Id: I9a5b908e7a3f9edaf609cf7e6a87f9842d689ce6
2024-03-21 21:54:52 +00:00
Andy Wickham
9aa1c402ae Allows for system navigation settings to be added dynamically.
This allows for controller-backed preferences to be added or
overridden via xml.

Similarly, if the controllers cause all of the preferences for
2 or 3 button nav to be unavailable, we hide the settings button.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: I2371f3173076172489966728ac69c8767570cd56
Merged-In: I2371f3173076172489966728ac69c8767570cd56
2024-03-21 20:31:06 +00:00
Jakub Rotkiewicz
de27acef86 Refactor Bluetooth Codec settings to dynamic ListPreference
Fetch supported codecs from native and present to user using
ListPreference.

Bug: 305779598
Bug: 311451118
Bug: 323319530
Tag: #feature
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.AbstractBluetoothListPreferenceController
Test: atest SettingsRoboTests:com.android.settings.development.bluetooth.BluetoothCodecListPreferenceControllerTest

Merged-In: Iedbfd01c0d1b59df8a073f4e9aedca3913e6d45f
Change-Id: I90ed0d83c3250c64789e27707b0b7bff30043335
2024-03-21 11:06:18 +00:00
Sunny Shao
458ed92600 Handle the Edge to Edge problem
- Fix the navigation bar overlapped problem in sub-pages.
- Use a workaround solution to handle Homepage statusbar problem.

Bug: 328622648
Fixes: 330217912
Test: manual test
Change-Id: I67a65e2af10def84bf743d4d3cd0047098423ffe
2024-03-21 19:04:58 +08:00
Charlotte Lu
f30692550a Merge "Add certificate summary." into main 2024-03-21 07:48:25 +00:00
mxyyiyi
ff3786f451 Fix talkback focus on "Less than a min"
- update text "min" to "minute"

Fix: 317140357
Test: manual
Change-Id: Iad1b72064f1b17c9d1ef4ed02b3d2de280d5449c
2024-03-21 15:04:13 +08:00