Commit Graph

106062 Commits

Author SHA1 Message Date
Presubmit Automerger Backend
dbd4423d03 [automerge] [DO NOT MERGE] Enforce INTERACT_ACROSS_USERS_FULL permission for NotificationAccessDetails 2p: 9a7bd79ca3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21298578

Bug: 259385017
Change-Id: I6c0a1f1167ad07d11c1eb85f93e8d7bd1ce6ba2b
2023-02-06 14:14:21 +00:00
Valentin Iftime
9a7bd79ca3 [DO NOT MERGE] Enforce INTERACT_ACROSS_USERS_FULL permission for NotificationAccessDetails
When using EXTRA_USER_HANDLE, check for INTERACT_ACROSS_USERS_FULL permission on calling package.

Bug: 259385017
Test: 1. Build a test app that creates and starts an intent to NOTIFICATION_LISTENER_DETAIL_SETTINGS while setting the intent extra  android.intent.extra.user_handle to UserHandle(secondaryUserId).
 2. Create and switch to a secondary user
Settings > System > Multiple users > Allow multiple users > Add user > Switch to New user
 3. Open Settings > Notifications > Device & app notifications and choose an app from the list (uses android.permission.BIND_NOTIFICATION_LISTENER_SERVICE). Enable Device & app notifications for selected app and disable all attributed permissions.
 4. Switch back to the Owner user.
 5. Get the userId of the secondary user: adb shell pm list users.
 6. Open the test app and enter the userId for the secondary user and the component name that uses android.permission.BIND_NOTIFICATION_LISTENER_SERVICE.
 8. In the settings window that open, enable all 4 sub-options.
 9. Switch to the secondary user and note that the all sub-options for the app are disabled.

Change-Id: I875b9f2fc32c252acdcf8374a14067836e0f1ac6
2023-02-06 14:14:12 +00:00
Bill Yi
2e6a5ceba3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I49dd93ef30e98dbdf5eb52ab3b928fc1e0156829
2023-02-05 19:31:46 -08:00
Diya Bera
87567ceb5e Remove background tint during SUW
Test: Manual - navigate to the activity mentioned in the bug and observe
the background
Bug: 264993674

Change-Id: I21c8143099e4c76ed5744cff12f31f578320a871
2023-02-03 23:29:06 +00:00
Lucas Silva
ca65b6e5ba Add content description to screensaver customization button
This will let users know which screensaver they are customizing.

Fixes: 267582102
Test: flashed device and enabled talkback, opened screensaver settings,
and verified talkback correctly says the name of the screensaver

Change-Id: I9d0d9422f06b7a78efca0e6953b73fe612f79e2a
2023-02-03 15:27:26 -05:00
Jack Yu
c4a0475681 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042 am: 4745a591c5 am: 34ce0e2c3a am: 1befdab699
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: Iafe87e53b9337f84dcd44494e509aa8398b0298c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 14:42:19 +00:00
Jack Yu
1befdab699 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042 am: 4745a591c5 am: 34ce0e2c3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I0df6b9e868058e014644742f2cfa4841d83ad838
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 13:49:58 +00:00
Jack Yu
34ce0e2c3a Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042 am: 4745a591c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: Ia0803da9acf81da41d5ffd289b705eb3e7128547
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 13:16:57 +00:00
Jack Yu
4745a591c5 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97 am: 9d643d3042
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I3099c3e158aaf0a99a8fa3d894b0c5dc1713e2b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 12:22:41 +00:00
Jack Yu
9d643d3042 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0 am: 3ccadd2c97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I763baefc5b94776c0583273fe9ab47ae99e6a57c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 11:27:23 +00:00
Jack Yu
3ccadd2c97 Only primary user is allowed to control secure nfc am: 0e57ff90cd am: c098bdcad0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I5690485d1cacd39b5b74316f561691bc68d48787
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 10:10:20 +00:00
Jack Yu
c098bdcad0 Only primary user is allowed to control secure nfc am: 0e57ff90cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154458

Change-Id: I35c94f779d47e27c170ec3b4becafc563f077a68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 09:21:04 +00:00
Chengfei Tao
08ac9c1246 Accessibility toggle button small tappable area fix
Revert part of the layout change from b/233835795 fix so that
the issue of small tappable area in b/265859032 is fixed while
we continue to look at a better fix for b/233835795

Test: Manually change different Display & Font size to test UI
Test: m RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.biometrics.face.FaceEnrollEducationTest"

Bug: 265859032

Change-Id: I90ba7cc11dc61380dfdf0c3bcd2c59a17b43ee0e
2023-02-02 15:14:28 +08:00
TreeHugger Robot
a50ca10f33 Merge "Update illustration for tablet" into tm-qpr-dev 2023-02-02 03:09:34 +00:00
Edgar Wang
296f4c4a6f Update illustration for tablet
Fixes: 244271773
Test: visual
Change-Id: Ic8968a951fc6c9b8023aa522aabdac3f1bcb84d3
2023-02-02 01:33:06 +00:00
Josh Hou
576564873f [automerger skipped] Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e am: 406abc4d62 -s ours
am skip reason: Merged-In I2e25a308bcba6ea0edee89c7a78465f766bdbeac with SHA-1 5d7d1665fe is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: I19bad7bb7aa3f25ecc76494082a4a725c690a039
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 01:28:45 +00:00
Josh Hou
406abc4d62 Fix the security vulnerability issue in AppLocalePickerActivity am: 33ef83795e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21152842

Change-Id: Ic0ff8ade7897052d04c118dc0a8f67312f5d0ebf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 00:50:59 +00:00
Josh Hou
1739114d44 Merge "Fix the security vulnerability issue in AppLocalePickerActivity" into tm-qpr-dev 2023-02-02 00:15:12 +00:00
Diya Bera
31406c042d Merge "Tests for SUW in work mode" into tm-qpr-dev 2023-02-01 23:29:35 +00:00
Diya Bera
1021b58ae5 Tests for SUW in work mode
Bug: 247049655
Test: m RunSettingsRoboTests -j30 ROBOTEST_FILTER=MultiBiometricEnrollHelperTest
Change-Id: Ifabb96a90c340bc9306cc0f033ba103c614f32a9
2023-02-01 22:05:09 +00:00
Edgar Wang
b5215abde7 Merge "Update lottie illustration for tablet" into tm-qpr-dev 2023-02-01 10:22:46 +00:00
Josh Hou
33ef83795e Fix the security vulnerability issue in AppLocalePickerActivity
Examine whether the packages is allowed to display app locales list when creating the AppLocalePickerActivity, and examine whether the target user is the same as the calling user.

Bug: 257954050
Test: Follows the test step listed in b/257954050#comment14
Change-Id: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
Merged-In: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
2023-02-01 15:49:20 +08:00
Josh Hou
5d7d1665fe Fix the security vulnerability issue in AppLocalePickerActivity
Examine whether the packages is allowed to display app locales list when creating the AppLocalePickerActivity, and examine whether the target user is the same as the calling user.

Bug: 257954050
Test: Follows the test step listed in b/257954050#comment14
Change-Id: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
Merged-In: I2e25a308bcba6ea0edee89c7a78465f766bdbeac
2023-02-01 15:42:22 +08:00
Edgar Wang
2f5f6d4ee6 Update lottie illustration for tablet
Bug: 243889662
Bug: 243889643
Test: visual
Change-Id: Icac10e4401da3d704350aef6ef2723ff92ca34f8
2023-02-01 07:27:18 +00:00
Yong Zhang
6cb1a7ce5a Merge "Adjust AlwaysExpand List so that face detail settings will show in side panel while posture guidance will show full-screen" into tm-qpr-dev 2023-01-31 23:33:24 +00:00
Jack Yu
0e57ff90cd Only primary user is allowed to control secure nfc
Bug: 238298970
Test: manual
Merged-In: I945490ef1e62af479a732c9a260ed94bdd8bc313
Change-Id: I945490ef1e62af479a732c9a260ed94bdd8bc313
2023-01-31 07:41:49 +00:00
Derek Jedral
7e524288b5 Add strings for active unlock in settings
Add strings that active unlock needs to consume when surfacing itself in
combined biometrics settings.

Test: none, strings aren't consumed yet.
Bug: 266583888
Bug: 240437016
Change-Id: I41e3b9c1830212303fc3379462e80cb18a23d026
Merged-In: I41e3b9c1830212303fc3379462e80cb18a23d026
2023-01-30 18:17:32 -08:00
TreeHugger Robot
6b55b6c07a Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-01-30 17:44:51 +00:00
Valentin Iftime
1e81f6eb95 Fix notification settings bottom sheet scroll in landscape
Fix layout size and configuration listener for landscape orientation.

Test: adb shell cmd notification post "Test notif" &
    adb shell am start -a android.settings.CHANNEL_NOTIFICATION_SETTINGS     --es android.provider.extra.CHANNEL_FILTER_LIST "sound"     --es android.provider.extra.CHANNEL_ID "shell_cmd"     --es android.provider.extra.APP_PACKAGE "com.android.shell
Bug: 238845213
Change-Id: I6c2ba149cddfdf35292b0b6fc92c0d8418a86c54
2023-01-30 15:14:54 +00:00
Chengfei Tao
b5e5100f92 Adjust AlwaysExpand List so that face detail settings will show in side panel
while posture guidance will show full-screen

Test: Manual testing with power cycle
Bug: 263068723
Change-Id: I6d632d08dcb3597cd8470f8d3d34258e4280dc14
2023-01-30 10:17:04 +08:00
Bill Yi
72a66bbf28 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If0994989dc0ca9781b9cce2543977117050691a3
2023-01-27 14:18:04 -08:00
TreeHugger Robot
4591a191e1 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-01-27 06:57:01 +00:00
Stefan Andonian
d0e6bddbc5 Merge "Move ViewCapture On/Off controls to QuickSettings Tile." into tm-qpr-dev 2023-01-27 04:38:04 +00:00
Bill Yi
f0104105fe Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6b9f9cd2b3f944107a5b980ae67bbca70eb1be93
2023-01-26 18:01:59 -08:00
Diya Bera
9f1e35fe1a Merge "Added string to encourage user to enroll more fingerprints" into tm-qpr-dev 2023-01-25 22:16:34 +00:00
Diya Bera
711f16ddd8 Added string to encourage user to enroll more fingerprints
Test: Manual - Finish enrolling a fingerprint and check the message
displayed
Bug: 265023475

Change-Id: I77a6bd08a5bfb58971539bf4d366d0425ae0c9a0
Merged-in: I77a6bd08a5bfb58971539bf4d366d0425ae0c9a0
2023-01-25 18:32:13 +00:00
Daniel Norman
f6e3be8352 Merge "RESTRICT AUTOMERGE Updates Accessibilty Settings resources for sw600dp." into tm-qpr-dev 2023-01-25 17:44:40 +00:00
Tyler Freeman
fe7f4fe5ad chore(magnification): update assets for tablets
Fix: 261547655
Fix: 243902461

Test: launch cf_x86_64_tablet, open Settings > Accessibility
Test: Open "Magnification", check banner animation
Test: Open "Magnification" > "Magnifcation Type", check images
Test: Perform the above with both light and dark mode.
Change-Id: I93fa93b32790de207edfd34fe95f416802a5dfee
2023-01-24 19:19:29 +00:00
TreeHugger Robot
b6eeb6c975 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-01-24 03:48:22 +00:00
TreeHugger Robot
da8b6c7cbb Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-01-24 03:48:22 +00:00
TreeHugger Robot
2b80fa789a Merge "Enforce INTERACT_ACROSS_USERS_FULL permission for NotificationAccessDetails" into tm-qpr-dev 2023-01-23 17:05:28 +00:00
Valentin Iftime
99b8b4cd60 Enforce INTERACT_ACROSS_USERS_FULL permission for NotificationAccessDetails
When using EXTRA_USER_HANDLE, check for INTERACT_ACROSS_USERS_FULL permission on calling package.

Bug: 259385017
Test:
 1. Build a test app that creates and starts an intent to NOTIFICATION_LISTENER_DETAIL_SETTINGS while setting the intent extra  "android.intent.extra.user_handle" to UserHandle(secondaryUserId).
 2. Create and switch to a secondary user
Settings > System > Multiple users > Allow multiple users > Add user > Switch to New user
 3. Open Settings > Notifications > Device & app notifications and choose an app from the list (uses android.permission.BIND_NOTIFICATION_LISTENER_SERVICE). Enable Device & app notifications for selected app and disable all attributed permissions.
 4. Switch back to the Owner user.
 5. Get the userId of the secondary user: adb shell pm list users.
 6. Open the test app and enter the userId for the secondary user and the component name that uses android.permission.BIND_NOTIFICATION_LISTENER_SERVICE.
 8. In the settings window that open, enable all 4 sub-options.
 9. Switch to the secondary user and note that the all sub-options for the app are disabled.

Change-Id: I875b9f2fc32c252acdcf8374a14067836e0f1ac6
2023-01-23 16:57:21 +00:00
Rubin Xu
8f839acd71 Merge "For top layout use FrameLayout than GlifLayout" into tm-qpr-dev 2023-01-23 16:25:15 +00:00
Bill Yi
1b50b32ff1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib737e1fae6923c8ae2be1c92510a8cc12e889e72
2023-01-23 07:00:28 -08:00
Bill Yi
fe2b12b076 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic8aaea743c53e00ee7bfb2f3fa6b402fb3ea3cde
2023-01-23 06:54:45 -08:00
Mariia Sandrikova
436ede94c3 Remove "nosensor" restriction from FallbackHome
This was previously added in I875fa6d112db23273026dbc39b5d32748d7e99f1 to match boot animation orientation. But the first system orientation after boot is no longer influenced by FallbackHome and instead is influenced by the default rotation in DisplayRotation#readDefaultDisplayRotation so it should be safe to remove this restriction.

On the other side, if we keep this restriction it can lead to orientation flickering on devices that have ignoreOrientationRequest enabled since "nosensor" is respected on them unlike other orientations so it's possible that FallbackHome and launcher orientations won't match.

Fix: 264329911
Test: manual
Change-Id: I688a4ba3d81c1fe908b9f88c3d601aaccc4f2119
2023-01-22 17:02:10 +00:00
Daniel Norman
383c10fe93 RESTRICT AUTOMERGE Updates Accessibilty Settings resources for sw600dp.
Includes some .java updates to automatically convert colors for lottie
animation files.

Fix: 261547883
Fix: 243905003
Fix: 243889447
Fix: 261544574
Test: launch cf_x86_64_tablet, open Settings > Accessibility
Test: Open "Color & motion" > "Color inversion"
Test: Open "Timing controls" > "Time to take action"
Test: Open "Caption preferences"
Test: Open "Magnification" > "Magnification shortcut"
Test: Open "Accessibility shortcuts" >
      "Accessibility button and gesture", change options
Test: Perform the above with both light and dark mode.
Change-Id: I46b75b53feb8870d3154744e058eb898e6011725
2023-01-20 23:32:20 +00:00
Steve Elliott
c8a6db40ac Merge "Setting to control seen notification filtering" into tm-qpr-dev 2023-01-20 23:22:56 +00:00
Sally Yuen
cc377605ef Merge "Add extra dim banner for tablets" into tm-qpr-dev 2023-01-20 17:20:56 +00:00
TreeHugger Robot
cd68d8f7a3 Merge "[DO NOT MERGE] Add SHA team into Settings OWNER" into tm-qpr-dev 2023-01-20 13:13:28 +00:00