Commit Graph

9622 Commits

Author SHA1 Message Date
hughchen
d6ec2ac7be Tethering shouldn't indicates on when SIM without tethering option
Before this CL, If SIM doesn't have tethering option then UI will not
back to previous option when press "USB tethering" in
[Default USB configuration].

This CL added receiver to observe USB state that get correct state
from UsbManager.

Bug: 138630479
Test: make -j42 RunSettingsRoboTests
Change-Id: I6cc8da508f6ab142142ca8c28460125bad93925b
2019-10-04 15:41:45 +08:00
SongFerngWang
dd7f9b57f6 Preferred network list add 5G item
Preferred network list add 5G item, and change "recommended" from 4G to
5G, and add summary for 5G.

Bug: 138544359
Test: 1.fake the device network type bitmask to 5G, UI show 5G list
2.atest EnabledNetworkModePreferenceControllerTest.java :pass

Change-Id: I4a78e2e7fbb067ce841df4aaf1d5161607fdcf90
2019-10-04 04:53:31 +00:00
Goven Liu
834c301139 Merge "[Wi-Fi] Wrong MAC address shown in Settings." 2019-10-04 01:13:03 +00:00
Raff Tsai
a80a7c16f2 Merge "Remove summary provider" 2019-10-03 15:23:21 +00:00
govenliu
228cf200ae [Wi-Fi] Wrong MAC address shown in Settings.
The MAC addresses in "About phone" and "Saved networks" may be different
because of new Randomized MAC mechanism.

1.Add new UIs to guide users to saved network and use different titles to
show different conditions.
2.Remove MAC address and IP fields in WifiPreference by new design.

Bug: 133466540
Test: add test case to check if the title changed according to the
privacy level.

Change-Id: Idb5972dc2565f6fe58a83f6aa7124abbc035888f
2019-10-03 19:36:58 +08:00
Sunny Shao
3526f666a8 Fix the display abnormal of Tap & pay screen in landscape mode
- Add a new layout for the landscape mode.
- Update the logic to show image when has no any visible preference.

Bug: 141559275
Test: manual view
make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.nfc
Change-Id: Ib59ad3347e0635c07d61d557d75f8feaf78ff23c
2019-10-03 18:56:36 +08:00
Raff Tsai
590042b3ba Hide sliceView if Slice is null
Fixes: 142035673
Test: robolectric, visual
Change-Id: I2b5b34d068ba4590f65a284d4f62a1cc77f9666f
2019-10-03 17:23:35 +08:00
Raff Tsai
6db277ebb7 Remove summary provider
- use SummaryProvider to provide the summary of UserSettings
- use WifiDisplayPreferenceController to replace the summary loader
in WifiDisplaySettings
- use ConfigureNotificationPreferernceController to replace the
sumary load in ConfigureNotificationSettings

Fixes: 141653158
Test: robolectric
Change-Id: Id5f5ed645707caa0b25ecae5252174cbf017651c
2019-10-03 15:04:36 +08:00
Raff Tsai
9e3a9fd255 Add fragment in xml instead of using injected way
- It can improve performance because we use less injected item
- Also remove summary provider from those fragments

Bug: 141653158
Test: robolectric
Change-Id: I6255f71b3b8300aea064a4fefd6711c1ff59e08a
2019-10-02 11:49:51 +08:00
Bonian Chen
f726a31457 Merge "[Settings Telephony] Carrier name API replacement" into qt-qpr1-dev
am: 556b34d03d

Change-Id: Ibffb60c57aa4152b4681f3fe95dae7175f2e878e
2019-10-01 19:53:31 -07:00
Bonian Chen
c7c84d2c87 [Settings Telephony] Carrier name API replacement
Replacing TelephonyManager.getNetworkOperatorName() by
Obtaining carrier name from SubscriptionInfo.getCarrierName().

TelephonyManager.getNetworkOperatorName() only be used when there's no
SubscriptionInfo can be found.

Bug: b/140443508
Test: Manual testing
  atest MobileNetworkUtilsTest
  atest OpenNetworkSelectPagePreferenceControllerTest

Change-Id: I7a86395c86d31fe2ba54c04ac16b1a0ebfc843f3
2019-10-01 17:59:43 +00:00
Bonian Chen
527a43530e Merge "[AutoTest] Settings Telephony part" 2019-10-01 11:13:25 +00:00
Mill Chen
649ec4ba16 Merge "Fix BatteryInfo test case failures" 2019-10-01 11:01:29 +00:00
Paul Hu
77226593e0 Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" am: a67ca4cfd7 am: 3a728ae13b am: a6dadc465b
am: 67fe04814d

Change-Id: I27e85d6780025122b5b56c0f8f827a0a8060e955
2019-10-01 03:21:27 -07:00
Paul Hu
67fe04814d Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" am: a67ca4cfd7 am: 3a728ae13b
am: a6dadc465b

Change-Id: I08a04f4e627ce876a3cabd194a9838a0b5ce8459
2019-10-01 03:15:14 -07:00
Paul Hu
a6dadc465b Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" am: a67ca4cfd7
am: 3a728ae13b

Change-Id: Id211709644b505fa866b0661f9657991c36dbaf6
2019-10-01 03:09:15 -07:00
Paul Hu
3a728ae13b Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED"
am: a67ca4cfd7

Change-Id: I7a2a4d76d1e0092188121d390c75c12eac20cdab
2019-10-01 03:03:36 -07:00
Paul Hu
a67ca4cfd7 Merge "[Settings] Replace CONNECTIVITY_INTERNAL to TETHER_PRIVILEGED" 2019-10-01 09:50:28 +00:00
Mill Chen
0ac194de10 Fix BatteryInfo test case failures
Fixes: 141901539
Test: robotests
Change-Id: I63140c36996e463862bb2dc77d26acdaa96530b2
2019-10-01 08:53:38 +00:00
Bonian Chen
199cae427b [AutoTest] Settings Telephony part
Change design to avoid using Robolectric.setupActivity()

Bug: 140707056
Test: make RunSettingsRoboTests ROBOTEST_FILTER=EuiccPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=DataServiceSetupPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=ApnPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkActivityTest
make RunSettingsRoboTests ROBOTEST_FILTER=DataUsagePreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=ApnEditorTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkSummaryControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=SubscriptionsPreferenceControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkListControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkPreferenceControllerTest

Change-Id: Ifacd2e6c8733d8e814a277cf34d6f7eb1a9ddba4
2019-10-01 16:15:59 +08:00
TreeHugger Robot
14772ca9f2 Merge "Fix FaceSetupSlice test cases failure." 2019-10-01 08:13:21 +00:00
Yi-Ling Chuang
8a4cf7c903 Fix FaceSetupSlice test cases failure.
Fixes: 141900531
Test: robotests
Change-Id: I0c68928e99b9fe12ae8d41b37a173ec1b1ecf44c
2019-10-01 14:58:42 +08:00
Raff Tsai
129c98bba1 Remove summary loader in some fragments
- Summary Loader only works in injected items, but those fragments
are not injected to Settings UI. The SummaryLoader class them are
useless.

Bug: 141653158
Test: robolectric
Change-Id: I1ca0bf5a1f417b7fe86b28e96aff7d4aee2cf2d3
2019-10-01 10:02:26 +08:00
Kevin Chyn
7ce886bdd7 Fix FaceSetupSliceTest am: acde97cf90
am: a9c14ab4b1

Change-Id: Ic96ff261766e750e0fff6b3ff73e21d0588b0222
2019-09-28 01:20:03 -07:00
joshmccloskey
be7d733886 Added different flow for re-enrollment am: bba7632f28
am: 3511ad89ca

Change-Id: I2b06407f4df37f8d16f95c6068de0ac3523df293
2019-09-27 18:38:20 -07:00
Kevin Chyn
a9c14ab4b1 Fix FaceSetupSliceTest
am: acde97cf90

Change-Id: Ied72d5ae4b891ef1c5600b8d416b016d0aede23e
2019-09-27 01:07:02 -07:00
Kevin Chyn
acde97cf90 Fix FaceSetupSliceTest
Bug: 141380252

Test: make -j56 RunSettingsRoboTests

Change-Id: Ifb9a29d8f3115759a9e8e93e3721135c6ba229bf
2019-09-26 22:32:52 -07:00
joshmccloskey
3511ad89ca Added different flow for re-enrollment
am: bba7632f28

Change-Id: Ie5174848a3a35df197177b0aa2cf6c324813b8dd
2019-09-26 20:06:48 -07:00
joshmccloskey
bba7632f28 Added different flow for re-enrollment
In order to enable this new flow, a user must currently have an enrolled
face and the security setting face_unlock_re_enroll must be non-zero.

Ex.
1. Enroll Face.
2. adb shell settings put
(secure face_unlock_re_enroll|secure_face_unlock_must_re_enroll) 1
3. If settings is opened, close it.
4. Open settings
5. Verify the new flow appears.

Bug: 141380252
Bug: 141254937
Test: Verified that the user's face is deleted after clicking delete.
Test: Verified that the user can re-enroll after removing their face.
Change-Id: I2b36a0bda5cb10fb33dfb2a5627d8fa40f14fb7e
2019-09-26 23:54:59 +00:00
lucaslin
570f7dbc4b Improve the wifi description for the case of private DNS broken
Currently, users don't know if the wifi description shows
"No internet" means it really doesn't have internet access or no
internet is because of private DNS resolution failed. So, Add a
new description for wifi when private DNS is broken.

Bug: 113242081
Test: make -j44 RunSettingsRoboTests \
      ROBOTEST_FILTER=WifiDetailPreferenceControllerTest

Change-Id: I44a7e51cf76dc3f2a6b9583f226af6649f9b1f5f
2019-09-26 15:55:01 +08:00
TreeHugger Robot
d48189c564 Merge "Use SettingsLib Indexable" 2019-09-26 06:51:17 +00:00
Taesu Lee
d6d299a4d6 Merge "Fix to show eUICC preference in eng build" am: e825c30137 am: 9e81a2f4a8 am: c4c8f51bb0
am: 1c20ea5644

Change-Id: I531faa4430a0fa914b239383d97ef5af58c8bb0b
2019-09-25 23:35:06 -07:00
Taesu Lee
1c20ea5644 Merge "Fix to show eUICC preference in eng build" am: e825c30137 am: 9e81a2f4a8
am: c4c8f51bb0

Change-Id: I58dae46adec67c855a5e26542d75d15f116c37dc
2019-09-25 23:28:11 -07:00
Taesu Lee
c4c8f51bb0 Merge "Fix to show eUICC preference in eng build" am: e825c30137
am: 9e81a2f4a8

Change-Id: I777273344c8eb4f791756be7fcb9755a5bf9e8b8
2019-09-25 23:21:12 -07:00
Taesu Lee
9e81a2f4a8 Merge "Fix to show eUICC preference in eng build"
am: e825c30137

Change-Id: Ie6ca5a575e5c5caa4c841286421d037649765397
2019-09-25 23:14:10 -07:00
Treehugger Robot
e825c30137 Merge "Fix to show eUICC preference in eng build" 2019-09-26 05:53:10 +00:00
Raff Tsai
966fa01423 Use SettingsLib Indexable
- Use SettingsLib Indexable
- Directly use resource id in getPreferenceScreenResId

Bug: 135053028
Test: roboletric
Change-Id: I05f493b55e8b6e2091301e9231ba5615215618e6
2019-09-25 18:24:56 +08:00
Bonian Chen
b18061c305 Merge "[Settings Telephony] Carrier name API replacement" 2019-09-25 06:45:50 +00:00
Bill Yi
500e7b2b71 Import translations. DO NOT MERGE
Change-Id: I0f9786915ebc5c168487e7a5386d4f2060d27a12
Auto-generated-cl: translation import
2019-09-24 18:54:26 -07:00
Bonian Chen
ed332c0829 Merge "[ManualNetworkSelect] Improve error handling" 2019-09-24 10:05:23 +00:00
TreeHugger Robot
818ad60218 Merge "Do not block UI when this page didn't have slice" 2019-09-24 09:57:50 +00:00
Bonian Chen
7a4c679790 [Settings Telephony] Carrier name API replacement
Replacing TelephonyManager.getNetworkOperatorName() by
Obtaining carrier name from SubscriptionInfo.getCarrierName().

TelephonyManager.getNetworkOperatorName() only be used when there's no
SubscriptionInfo can be found.

Bug: 140443508
Test: Manual testing
  atest MobileNetworkUtilsTest
  atest OpenNetworkSelectPagePreferenceControllerTest

Change-Id: I7a86395c86d31fe2ba54c04ac16b1a0ebfc843f3
2019-09-24 07:59:56 +00:00
Bonian Chen
1b64578f3c [ManualNetworkSelect] Improve error handling
1. [batch mode] Support graceful app stop behavior
   Avoid thread crash when UI abort the request.
2. [incremental mode] Stop search UI earlier when error during API access
   Generate error instead of keeping UI in progressing
   when fail to access Telephony API

Bug: 139398483
Bug: 140448617
Test: atest NetworkScanHelperTest
Change-Id: I429f3aa2ef692c27100514faa413b16dbd2459d7
2019-09-24 07:58:42 +00:00
hughchen
d49de61f96 Do not block UI when this page didn't have slice
This CL before, if controller have UIBlocker interface
will going to blocker condition to make whole page
invisible for a certain time until slice is fully loaded.

This CL add the check condition that if the controller
have UIBlocker inferface but didn't have slice uri will
not go to blocker condition.

Bug: 141292712
Test: make -j42 RunSettingsRoboTests ROBOTEST_FILTER=DashboardFragmentTest
Change-Id: I79daae131654f8fd823a9c8f1be46ad6c7921908
2019-09-24 10:30:49 +08:00
Raff Tsai
ac3e0d0988 Directly use BaseIndexableProvider
- Add function getXmlResourceId, Fragments don't need to write
xml resource id twice.
- Remove getPreferenceControllers from Indexable.java. Because it will
move to SettingsLib later for other apps which don't need this function

Bug: 135053028
Test: robolectric
Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003
2019-09-24 00:35:52 +08:00
TreeHugger Robot
5ff9517f23 Merge "Developer option off must not affect laser sensor" 2019-09-23 15:07:13 +00:00
Yi-Ling Chuang
fe790ec76d Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc am: 8d8c3e19b5 am: b26711944b
am: 3b8a14e86f

Change-Id: I97bcdc54f908db6f5895d99f284ee24fb4015433
2019-09-22 20:23:28 -07:00
Yi-Ling Chuang
3b8a14e86f Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc am: 8d8c3e19b5
am: b26711944b

Change-Id: I0edf1eff42cf54e644e60a11ba97219c38891e93
2019-09-22 20:16:25 -07:00
Yi-Ling Chuang
b26711944b Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc
am: 8d8c3e19b5

Change-Id: I8fae05f98c2ad04e0d7fba7a2aa409c08f781c0b
2019-09-22 20:09:51 -07:00
Yi-Ling Chuang
8d8c3e19b5 Merge "Enable dismissal feature on legacy suggestions."
am: ee39335edc

Change-Id: Ibce2403de032bd3d7fce750f6cd80191a8b14441
2019-09-22 20:03:21 -07:00