Commit Graph

18669 Commits

Author SHA1 Message Date
Fan Zhang
d32e9b5229 Merge "Revert "Revert "Make subsettings display edge-to-edge""" into qt-dev
am: 17521d0ac7

Change-Id: Id702a72ce6adc1dbb20c4f00c0b16cf1ff5ef603
2019-05-14 17:41:06 -07:00
TreeHugger Robot
17521d0ac7 Merge "Revert "Revert "Make subsettings display edge-to-edge""" into qt-dev 2019-05-15 00:01:30 +00:00
Salvador Martinez
ee5f79edbd Fix dark theme and battery saver interaction
In settings we weren't properly taking into account battery saver
enabled dark theme. This CL makes it so that when battery saver
on we disable the toggle until battery saver is off since
you can't change dark theme in battery saver. Additionally it
adds a message indicating why the toggle was disabled so the
user doesn't get confused.

Test: robotests
Bug: 131913864
Change-Id: I855e429a666098c837650852d1e1355477afa13d
2019-05-14 14:08:24 -07:00
Fan Zhang
b4b7725937 Revert "Revert "Make subsettings display edge-to-edge""
This reverts commit 9e98b8cf0f.

We have to set clipToPadding false on scrollView to make it extend below
navbar. But the side effect is it stops clipping to padding. So it
overlaps with sibling views. In this case anything pinned on top of
screen (switchbar, pinned header for most UIs, and preview indicator for
font size page).

To fix them:
1. in preview pages, just revert back to clipTo*. Their UI doesn't scroll
   so it they don't need to special clip flag to begin with.
2. For pinned to top headers, we need to change the "z-order" by setting
   elevation and make sure background is not transparent.

Fixes: 132182711
Fixes: 132672399
Test: visually on normal screen, font size scree, wifi main setting UI,
      wifi data usage screen

Reason for revert: Rollforward with fix.

Change-Id: Ib6f7c4167b9a680a336f2a7310d82340094d3aac
2019-05-14 13:48:12 -07:00
Joshua Mccloskey
d7de47e6d9 Merge "Increased char limit for translations" into qt-dev am: 5513a9bdd1
am: 1e84e431d8

Change-Id: Ic97c962c5acd3d520827ac23d8e89a0c61f5b5c4
2019-05-14 12:39:09 -07:00
Joshua Mccloskey
1e84e431d8 Merge "Increased char limit for translations" into qt-dev
am: 5513a9bdd1

Change-Id: I4ccf9f83431c4a450d05b9118bb8d35cd6f08328
2019-05-14 12:23:21 -07:00
Joshua Mccloskey
5513a9bdd1 Merge "Increased char limit for translations" into qt-dev 2019-05-14 19:13:11 +00:00
Fan Zhang
95959878bb Merge "Revert "Make subsettings display edge-to-edge"" into qt-dev am: 9a51ede665
am: 7db72f0ef1

Change-Id: Ie400dae74f651ba127a372d5109967f2256f509e
2019-05-14 11:34:47 -07:00
Fan Zhang
7db72f0ef1 Merge "Revert "Make subsettings display edge-to-edge"" into qt-dev
am: 9a51ede665

Change-Id: I1c152ddacaf43fa035ebf04159b9cf151cc11292
2019-05-14 11:10:40 -07:00
Fan Zhang
9a51ede665 Merge "Revert "Make subsettings display edge-to-edge"" into qt-dev 2019-05-14 17:17:26 +00:00
Fan Zhang
9e98b8cf0f Revert "Make subsettings display edge-to-edge"
This reverts commit c2a85a374d.

Bug: 132672399
Bug: 132182711
Test: n/a

Reason for revert: b/132672399

Change-Id: Icb34ae5b16b7a32215fe2c1a5f0d0d028c91b2ca
2019-05-14 16:31:08 +00:00
Sorin Dinu
ccf895aac0 Added icons for partial system update card in the Security category
Bug: b/132288646
Test: make RunSettingsRoboTests
Change-Id: I7f053b54d9b7e15a81f0f02895ee3266a613477e
2019-05-14 12:25:32 +01:00
Cn Chen
b5b3699f4c Merge "Font size page support light theme in deferred setup" into qt-dev
am: 421a05a6a9

Change-Id: I3646918b1c52d2962ef736699c2198be0f42613f
2019-05-14 00:32:35 -07:00
Cn Chen
421a05a6a9 Merge "Font size page support light theme in deferred setup" into qt-dev 2019-05-14 07:18:03 +00:00
Kevin Chyn
b79cba7d1f Merge "Update button string to "Start"" into qt-dev am: 9a252aa6b5
am: 815e1912bf

Change-Id: I743bfbb262a6f0f3e0f249beff06aabe21478f12
2019-05-13 23:02:01 -07:00
cnchen
3eee5cf02e Font size page support light theme in deferred setup
Bug:124470158
Test: atest & manually test
Change-Id: I41e1e98a9a64e516a294c4a94c8b5f335434078f
Merged-In: I41e1e98a9a64e516a294c4a94c8b5f335434078f
2019-05-14 14:01:14 +08:00
Kevin Chyn
815e1912bf Merge "Update button string to "Start"" into qt-dev
am: 9a252aa6b5

Change-Id: If4db1d8ef03f273641a7afe7869fd85104ddfe45
2019-05-13 22:56:55 -07:00
Cn Chen
1062d3376d Merge "Font size page support light theme in deferred setup." 2019-05-14 05:55:09 +00:00
Kevin Chyn
9a252aa6b5 Merge "Update button string to "Start"" into qt-dev 2019-05-14 05:49:05 +00:00
Kevin Chang
7eddb0e4dc Change string of switchbar and installed service category title
Bug: 122897712
Test: Visual
Change-Id: I4e15ebc8b91c58d24aadb7e665c6692ebcd627a8
2019-05-14 11:47:19 +08:00
joshmccloskey
7e470bf806 Increased char limit for translations
Test: It builds.
Bug: 132638233
Change-Id: Ie7deaf82471c832351af9f25f7b4725b65f3c66a
2019-05-13 19:29:24 -07:00
Mehdi Alizadeh
5da39b16b7 Merge "Refactors the System Navigation settings page" into qt-dev am: e575fc44f5
am: e53b5845b9

Change-Id: Ie33befe3f79bf5a6e79a8fd2e9df32f96e9f1b97
2019-05-13 18:44:32 -07:00
Kevin Chyn
200dd1b8b3 Update button string to "Start"
Fixes: 132648319

Test: Builds
Change-Id: I05fa1a8d4d24d5ebef95588df64442718bf42c99
2019-05-13 18:23:22 -07:00
Mehdi Alizadeh
e53b5845b9 Merge "Refactors the System Navigation settings page" into qt-dev
am: e575fc44f5

Change-Id: I6e308e2b0bd2e1c6c8cc0dd55f184480e4b2145c
2019-05-13 18:22:43 -07:00
Mehdi Alizadeh
e575fc44f5 Merge "Refactors the System Navigation settings page" into qt-dev 2019-05-14 01:08:22 +00:00
cnchen
7a83d51a6b Font size page support light theme in deferred setup.
Bug:124470158
Test: atest & manually test
Change-Id: I41e1e98a9a64e516a294c4a94c8b5f335434078f
2019-05-14 09:04:29 +08:00
Antony Sargent
4d9c264560 Merge "Strings for "Data during calls" preference" into qt-dev am: 27de8ae098
am: 7e155aa244

Change-Id: I04bd89746b5cd98c5e3837212b7e29cd7daafb2b
2019-05-13 18:04:00 -07:00
Lifu Tang
19fb2db46c Merge "Revert recent location apps to pre-Q behavior" into qt-dev am: 3d6bacc731
am: cf5deb067f

Change-Id: I185af8e3e2abdeab3d2a0131b7c6cbb5979fcd2e
2019-05-13 17:56:33 -07:00
Mehdi Alizadeh
173810e2ac Merge "Update strings for System Navigation settings page" into qt-dev am: 485b3ad655
am: 8ca5e7862a

Change-Id: Ia2fbc3c4474185d474ed4256268dca41b07a81df
2019-05-13 17:55:34 -07:00
Fan Zhang
da11a517da Merge "Make subsettings display edge-to-edge" into qt-dev am: 66db1f95e0
am: 886c361bb7

Change-Id: I2574366d5e0b12f3ac1e1f5bf31e918ade7f1f94
2019-05-13 17:54:01 -07:00
Antony Sargent
7e155aa244 Merge "Strings for "Data during calls" preference" into qt-dev
am: 27de8ae098

Change-Id: I25bb3ec44e8e24de51b3b55bb444f2828e05019e
2019-05-13 17:29:28 -07:00
Lifu Tang
cf5deb067f Merge "Revert recent location apps to pre-Q behavior" into qt-dev
am: 3d6bacc731

Change-Id: Iacc48610f25fed5c3598c90c03de58eea26a1135
2019-05-13 17:24:44 -07:00
Mehdi Alizadeh
8ca5e7862a Merge "Update strings for System Navigation settings page" into qt-dev
am: 485b3ad655

Change-Id: I9a6135103076c4ab3cdc815332493f776251fe09
2019-05-13 17:23:29 -07:00
Fan Zhang
886c361bb7 Merge "Make subsettings display edge-to-edge" into qt-dev
am: 66db1f95e0

Change-Id: Ie4b8a19b7fe798810763c63196aff92812a1de25
2019-05-13 17:22:47 -07:00
TreeHugger Robot
27de8ae098 Merge "Strings for "Data during calls" preference" into qt-dev 2019-05-14 00:19:07 +00:00
TreeHugger Robot
3d6bacc731 Merge "Revert recent location apps to pre-Q behavior" into qt-dev 2019-05-14 00:07:28 +00:00
Mehdi Alizadeh
485b3ad655 Merge "Update strings for System Navigation settings page" into qt-dev 2019-05-14 00:07:25 +00:00
TreeHugger Robot
66db1f95e0 Merge "Make subsettings display edge-to-edge" into qt-dev 2019-05-14 00:05:47 +00:00
Lifu Tang
166b54c0f6 Revert recent location apps to pre-Q behavior
- List recent location request instead of location access
- Show in list view instead of app list widget
- Add overflow menu to "see all" page to show/hide system apps

Bug: 124015107
Test: build, flash, and test manually
Change-Id: I78df6d4b13ddf774013e8d819cf343ce012e6b0b
2019-05-13 15:24:09 -07:00
Mehdi Alizadeh
36f32a46ca Refactors the System Navigation settings page
Bug: 130915285
Bug: 128855215
Bug: 127718810
Bug: 129115299
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest

Change-Id: If11e1fe4bf150d2dd9578f731e71abf6b74f5d90
2019-05-13 14:31:20 -07:00
Mehdi Alizadeh
815ed755c3 Update strings for System Navigation settings page
Bug: 130437843
Bug: 128522050
Test: Manual test to verify the right strings in settings app
Change-Id: Id6e589d896be34c98fded3b3fff897840e9d3f4f
2019-05-13 14:31:20 -07:00
Antony Sargent
7d8f015151 Strings for "Data during calls" preference
In some dual-SIM cases, when you have an active voice call using a SIM
that isn't the default one for mobile data, you may not get data
connectivity at all (from any other SIM) due to technical limitations in
the telephony stack. This preference will allow the user to leave data
off for a SIM, but opt in to have data become active only during calls.

Bug: 132114205
Test: n/a
Change-Id: I3e7cdaedd8b685e0fe65221d94f5b426bc95942e
2019-05-13 14:03:48 -07:00
Mady Mellor
47aad1c655 Merge "Move feature-level Bubble setting into developer options; default to off" into qt-dev am: 240b227e1f
am: 34fa757cc9

Change-Id: I01aa071f1ce7f59aa160b7e53baf9da2d2a7db95
2019-05-13 11:59:52 -07:00
Mady Mellor
34fa757cc9 Merge "Move feature-level Bubble setting into developer options; default to off" into qt-dev
am: 240b227e1f

Change-Id: I899722a6df929c4093a5a74447eb25a610c80308
2019-05-13 11:38:26 -07:00
Mady Mellor
240b227e1f Merge "Move feature-level Bubble setting into developer options; default to off" into qt-dev 2019-05-13 18:18:31 +00:00
Zhi An Ng
bb3f187569 Merge "Update string description in SAW unsupported screen" into qt-dev am: 516bdc20fb
am: 3a6d75d7fa

Change-Id: I13f6932f81b0bbd8f203305667eed37c6312bb72
2019-05-13 10:17:39 -07:00
Zhi An Ng
3a6d75d7fa Merge "Update string description in SAW unsupported screen" into qt-dev
am: 516bdc20fb

Change-Id: Ie6513a8cb03fa8789ad5d70d9a6d6c14dcb4cf67
2019-05-13 10:13:32 -07:00
Fan Zhang
c2a85a374d Make subsettings display edge-to-edge
Fixes: 132182711
Test: visual
Change-Id: I3b0635cba359f74d463c2360323d80c5c9533228
2019-05-13 10:07:13 -07:00
Zhi An Ng
516bdc20fb Merge "Update string description in SAW unsupported screen" into qt-dev 2019-05-13 16:52:22 +00:00
Arc Wang
472a9da81d Merge "Fix Wi-Fi QR code scanner height at 360dp" into qt-dev am: 26ff84d3f4
am: bdd68115dd

Change-Id: I5d89bac92fe0ddba7184b589236dfcfb59b9b6f9
2019-05-13 00:35:59 -07:00