Commit Graph

3437 Commits

Author SHA1 Message Date
Mill Chen
9915b14914 Merge "Fix overlapping in TrustedCredentialsSettings" 2019-10-04 10:26:56 +00:00
Bonian Chen
779abebc63 [Settings UX] Enlarge data usage clickable area
Orignal clickable area within data usage editor is too small.
Enlarge it through changing the configuration of layout.

Bug: 131268240
Test: manual testing following the steps provided in issue.
Change-Id: I2cb8dba635ec0bd74c837c2425895ff39ceed13c
2019-10-04 17:11:23 +08:00
Raff Tsai
c303894040 Merge "Fix talkback issue" 2019-10-04 08:05:51 +00:00
Raff Tsai
6ff13962a3 Fix talkback issue
Fixes: 141226569
Test: manual
Change-Id: I631554ab33d6cc77f3d3f2e4625d359a802dd5b5
2019-10-04 11:59:56 +08:00
Jay Aliomer
aed74bf543 Talkback speaking for the notification option should be consistent
Because the "Silent" button uses RelativeLayout with getAccessibilityClassName not returning "Button", we use the NotificationButtonRelativeLayout which does that instead
Fix: 141348514
Test: manual testing. see bug report
Change-Id: Ic1c329ae1ad97aed45dc488ee7260d0081211784
2019-10-03 14:42:29 -04:00
Julia Reynolds
7e7271fff8 Handle multi-user in notif log
Test: manual
Fixes: 141575553
Change-Id: I03ff85358e8ae6ed5e6699358c4f9c785c416ecf
2019-10-03 11:50:12 -04:00
Mill Chen
cd869051ef Fix overlapping in TrustedCredentialsSettings
It's a side effect caused by making scrollView extend below navbar.
Set both of clipToPadding and clipChildren true to fix overlapping.

Fixes: 138962899
Test: visual
Change-Id: Icf696a151055d4be76cafe44d5cb95b67bc2ea9f
2019-10-03 00:00:45 +08:00
Arc Wang
1fa97eca18 Merge "[Wi-Fi] Improve UX when there is no user certificate to choose for WPA-Enterprise 192-bit" 2019-10-01 08:34:05 +00:00
Raff Tsai
360d2f2c6f Fine tune language UI to match preference style
Fixes: 141830486
Test: visual
Screenshot: https://screenshot.googleplex.com/LVv2W9D963s
Screenshot: https://screenshot.googleplex.com/VbJQ0cSPBKK
Change-Id: I44b0ac8ac2bd32b3beeabee195aab928ec4bacc2
2019-09-30 11:17:04 +08:00
Yi-Ling Chuang
fe790ec76d Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc am: 8d8c3e19b5 am: b26711944b
am: 3b8a14e86f

Change-Id: I97bcdc54f908db6f5895d99f284ee24fb4015433
2019-09-22 20:23:28 -07:00
Yi-Ling Chuang
3b8a14e86f Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc am: 8d8c3e19b5
am: b26711944b

Change-Id: I0edf1eff42cf54e644e60a11ba97219c38891e93
2019-09-22 20:16:25 -07:00
Yi-Ling Chuang
8d8c3e19b5 Merge "Enable dismissal feature on legacy suggestions."
am: ee39335edc

Change-Id: Ibce2403de032bd3d7fce750f6cd80191a8b14441
2019-09-22 20:03:21 -07:00
Arc Wang
44fa9d579d [Wi-Fi] Improve UX when there is no user certificate to choose for WPA-Enterprise 192-bit
Show error message when a user does not specify a user certificate
for WPA3-Enterprise 192-bit.

Bug: 138417816
Test: visual
Change-Id: Ifc519d484dbf78dad37ad7047e8b9bb40685d54c
2019-09-23 09:39:20 +08:00
Yi-Ling Chuang
83ac0efd81 Enable dismissal feature on legacy suggestions.
Add back the close button for legacy suggestions.

Fixes: 140786274
Test: robotest
Change-Id: Iaf0376bd482db4c4ff7d04a68131071c29c01ced
2019-09-20 18:03:10 -07:00
TreeHugger Robot
0aec85c8c1 Merge "Update notification log" 2019-09-20 14:24:24 +00:00
Goven Liu
fcfff7a7f3 Merge "[Wi-Fi] Cannot connect to hidden WiFi network." 2019-09-20 04:17:23 +00:00
Kevin Chang
ddc8440aad Merge "Change disable accessibility service dialog layout" 2019-09-20 02:14:26 +00:00
hughchen
932d156aca Change text size of header title in advanced bluetooth
1. change the text size of header title
2. Set gravity of header title as "center"

Bug: 138633953
Test: manually
Change-Id: I358c6a10e3cb97b46c3b8f6d50f7046414ddfb13
2019-09-19 16:57:14 +08:00
Julia Reynolds
b294b82c84 Update notification log
- Change notification presentation to better match notification shade
- Stop constantly removing and readding all of the preferences
- Update individual preferences in a kind of hacky way (to be improved
later)
- Link notification entries to notification preferences screen
- Hide notification summaries

Bug: 137396965
Test: manual
Change-Id: Icdd54488b8bf659f6fe42af93e42cd21912fa4fe
2019-09-18 17:30:04 -04:00
govenliu
712df89893 [Wi-Fi] Cannot connect to hidden WiFi network.
When click "Add network" to add a new network, user may ignore the "Hidden network" item, which is in "Advanced options". That will cause the added hidden network can not be connected.

To improve it, move the "Hidden network" from last one to be first one.

Bug: 135281908
Test: Check if the hidden setting spinner is the first one item in Advanced options.
Change-Id: I0f90a6b2992b38ccae461c07d6b13cda0ca9d2b2
2019-09-18 16:56:22 +08:00
Raff Tsai
e80f67b94b Replace png file with vector drawable
Fixes: 139336138
Test: visual
Change-Id: I6fa504d406e4b9b37b8260ec9fb92f265e4a45da
2019-09-16 11:41:37 +08:00
Kevin Chang
ee15fa1c2d Change disable accessibility service dialog layout
Bug: 140307087
Test: Visual
Change-Id: I78d573f121e2f799a8395fcd2d21ee48a5fffb23
2019-09-11 15:47:08 +08:00
Raff Tsai
98b55c5214 Use TwoTargetPreference to replace customized layout
Bug: 139336138
Test: manual, robolectric
Change-Id: I0ffe90cd9ab5423b533507eeae47d5972704cf61
2019-09-11 13:08:47 +08:00
TreeHugger Robot
500f1ddc8f Merge "Add padding for SliceView preference" 2019-09-10 10:03:39 +00:00
hughchen
a9e91a8512 Add padding for SliceView preference
This CL adds padding to make it looks like wrapped by preference
category.

Bug: 133784331
Test: Manual
Change-Id: Ic5d3043fb78b64bebbe762fcd32b03c753167835
2019-09-10 15:54:05 +08:00
Sunny Shao
44ae2a898f Fix the title font problem in the System Navigation page
Use the textAppearanceListItem of the attribute to replace the text font of title.

Fixes: 140532398
Fixes: 140771643
Test: manual view
Change-Id: Ieb3a8a73680e1b1804a058e6c413d27aad772ba6
2019-09-10 11:12:42 +08:00
Jimmy Chen
33a05692f0 Merge "wifi: support OCSP in Wifi dialog for certifiate-based EAP type" 2019-09-09 02:23:07 +00:00
Jimmy Chen
3612d3ebc9 wifi: support OCSP in Wifi dialog for certifiate-based EAP type
Bug: 136720092
Test: tested with OCSP supported profile
Change-Id: Ieb0fec5026ea06f88d44361d0c579be2a18ed99a
2019-09-05 15:39:12 +08:00
TreeHugger Robot
34b1e00ca7 Merge "Fix Battery page animation" 2019-08-29 03:41:25 +00:00
Jimmy Chen
7157508edc Merge "wifi: support SAE password identifier in wifi dialog" 2019-08-28 15:31:18 +00:00
Raff Tsai
648ada031d Fix Battery page animation
TextView summary1 has default height 2 line. If the content is longer
than 2 line, the TextView increases itself which causes the animation.
By increasing minLines to 3, it can avoid the animation. And remove
summary2 because it is only for debug purpose, the debug information
can be merged to summary1.

Fixes: 139554919
Test: visual, make RunSettingsRoboTests
Change-Id: I167ac87c9bd83035e00d4991961599e76f4f69e1
2019-08-19 16:47:53 +08:00
Jimmy Chen
d79363fec6 wifi: support SAE password identifier in wifi dialog
Bug: 138305265
Test: atest FrameworksWifiApiTests
Test: atest FrameworksWifiTests
Test: connect to a WPA3 SAE access point with different
      password/identifer combinations.

Change-Id: Idf1f82faaafa9c5f2212a0fa1dcc2eec53a9dbd5
2019-08-19 13:31:53 +08:00
Raff Tsai
896de3b48b Remove PreferenceCategory wrapper
- Avoid similiar issue in b/130396913

Bug: 124129485
Test: manual
Change-Id: I6f4698304210bacba5c76020c375dda49330d2cc
2019-08-14 12:31:06 +08:00
Raff Tsai
946441ca27 Learn mode link is not in footer text
Use wrong footerPreference key.

Change-Id: Ic88b4bf9cf336474231329aa2154242d3f95b91a
Fix: 139086150
Test: visual
2019-08-09 17:21:18 +08:00
Arc Wang
3e64c28534 [Wi-Fi] Remove unsupported EAP methods for WPA3-Enterprise 192-bit
am: bde8c0a64d

Change-Id: I82e94257097ab902a72a0dc7d64ff50241938e24
2019-08-08 01:21:32 -07:00
Arc Wang
bde8c0a64d [Wi-Fi] Remove unsupported EAP methods for WPA3-Enterprise 192-bit
1. Only support EAP-TLS for WPA3-Enterprise 192-bit
2. Remove "Do not validate" from the CA certificate menu
3. Remove "Do not provide" from user certificate menu

Bug: 135127581
Test: WifiConfigControllerTest
Change-Id: Ibf904da9407ec803afb8bb995e9df1a2e25f0dcb
Merged-In: Ibf904da9407ec803afb8bb995e9df1a2e25f0dcb
2019-08-08 14:52:08 +08:00
Julia Reynolds
104bc8e133 Merge "Move channel listing into a pref controller" into qt-qpr1-dev
am: 2d035ddfa2

Change-Id: Ie6d1c1ec4fdd2c074884d258379889bdb120a0d4
2019-07-29 13:24:07 -07:00
Julia Reynolds
c400ce3c80 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
(cherry picked from commit a295d71c94)
2019-07-26 19:24:43 +00:00
Sunny Shao
af68c44ed4 Add start margin in the Screen usage item
Avoid the title and subtitle overlap while text length is long. So add the
start margin for subtitle.

Fixes: 136282569
Test: manual test
Change-Id: Id1728ae60904c654c4ffe95fae7fb5139f368092
2019-07-19 06:11:56 +00:00
TreeHugger Robot
1258c94f9d Merge "Increase height of edittext" 2019-07-17 09:38:56 +00:00
hughchen
7879047f65 Increase height of edittext
Bug: 131134021
Test: RunSettingsRoboTests
Change-Id: Ia85b99d2b1f7b730e66516e61a14979b0f68daa8
2019-07-17 14:34:00 +08:00
Jason Chiu
71e9f9147a Add a vertical padding to DND button
Button is too close to divider

Test: visual, robotest
Fixes: 134406305
Change-Id: I1c2d8d2fad78ea3068a61b8aaa1c255328cf084f
2019-07-16 14:08:31 +08:00
Goven Liu
a47265d028 Merge "[Wi-Fi] EAP method AKA' did not pronounced as AKA prime." 2019-07-11 03:22:35 +00:00
govenliu
41cdecca3d [Wi-Fi] EAP method AKA' did not pronounced as AKA prime.
Spinner did not use ttsspan to store the display string so AKA' just
pronounced as AKA.

To fix it, use charsequence array, which each specific array item have
the ttsSpan to store the string for TTS engine.

Bug: 119929832
Test: Set a 3-texts array and check if the specific array item
replacement mechanism work correctly or not.

Change-Id: I8e7d10da99a3f3503e1019687c45cf40070d0045
2019-07-11 09:31:15 +08:00
TreeHugger Robot
23fbf601a0 Merge "[Wi-Fi DPP] Improve TalkBack information for events" 2019-07-10 08:39:05 +00:00
Jason Chiu
ca2bbc0685 Set the max length of user name field in Profile info
Settings may crash when entering a very long user name.

Fixes: 136005061
Test: manual, robotest
Change-Id: Ica17297588fc6b84ef111ef00017afb27360acd3
2019-07-09 18:25:51 +08:00
Arc Wang
1df7f2d1c1 [Wi-Fi DPP] Improve TalkBack information for events
Title and summary may be changed after user operations or Wi-Fi Easy connect handshake,
setAccessibilityLiveRegion could specify accessibility services to announce these changes.

In WifiDppAddDeviceFragment, I set title before summary for correct TalkBack announce sequence.

Bug: 137069941
Test: manual
Change-Id: Id032cfcb86c350feeac808f070665ac26261ceb8
2019-07-09 17:30:01 +08:00
Raff Tsai
e8bd78e212 Add margin between password entry and error text
Fixes: 130664317
Test: visual
Change-Id: Iefdbd39b94a861736baf8e9a302fbf651a5b14d3
2019-07-05 10:56:15 +08:00
Julia Reynolds
6b0315fbc1 Merge "Move channel listing into a pref controller" 2019-07-02 18:10:12 +00:00
Julia Reynolds
a295d71c94 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
2019-07-02 11:24:50 -04:00