Commit Graph

24071 Commits

Author SHA1 Message Date
Fan Zhang
13b60bb15a Stop showing account based cards in homepage.
Removed data usage/device info/emergency/storage cards

Bug: 118691898
Test: robotests
Change-Id: I9f1ef3f022be9ca37e3359a6820a716d4ebade0f
2018-10-30 13:37:02 -07:00
Fan Zhang
0023558ec3 Fix Display settings summary when there is no wallpaper.
Change-Id: I715cef9dc42de1231491b5a7184f0f151d94af11
Fixes: 69905032
Test: robotests
2018-10-30 10:10:30 -07:00
Stanley Wang
f838aa1059 Fix Developer options page memory leak
Change-Id: I12d53c41adee56850cd294ae89e7a56328639558
Fixes: 117583710
Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.development
2018-10-30 17:49:59 +08:00
Raff Tsai
80306d1aef Merge "Fix Settings crash on changing device orientation" 2018-10-30 09:12:17 +00:00
Raff Tsai
1d88f4c61b Fix Settings crash on changing device orientation
- AppDataUsage assign preferences to Applist in loaderCallback.
When device rotate we will assign preference to Applist second
time which throw IllegalStateException Exception. We will use
restartLoader which create new loader rather than use existed
loader.

Change-Id: I540d645e930a29f989c4fe374e2103ca201da198
Fixes: 118195540
Test: manual
2018-10-30 09:57:53 +08:00
TreeHugger Robot
0c95a2980c Merge "Refine the logic to show/hide cdma preference" 2018-10-29 22:55:57 +00:00
TreeHugger Robot
f93b925588 Merge "Use ImeAwareEditText in FingerprintSettings" 2018-10-29 22:48:29 +00:00
Rakesh Iyer
7ad62ef340 Merge "Misc fixes to TTS settings." 2018-10-29 21:26:26 +00:00
jackqdyulei
008c7781e8 Refine the logic to show/hide cdma preference
1. Add special check for "system select"
2. For cdma, need to check whether to hide carrier settings

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: I0a20816912500725894208a60bba7a5c74912561
2018-10-29 14:16:14 -07:00
TreeHugger Robot
5422d7ea0a Merge "Add Connected Device slice to Contextual Settings Homepage" 2018-10-29 20:27:24 +00:00
Yohei Yukawa
af4426bb65 Use ImeAwareEditText in FingerprintSettings
Like we did the same thing in the Settings app [1][2][3],
FingerprintSetting is another instance that should use
ImeAwareEditText to make sure InputMethodManager#showSoftInput() is
called after the EditText gains IME focus.

This approach should be more robust and easier to maintain than trying
to control the software keyboard visibility with
SOFT_INPUT_STATE_ALWAYS_VISIBLE, which is more complicated that people
think.

This CL also removes RenameDialog#mTextHadFocus since
RenameDialog#mDialogTextField is always focused when the dialog is
shown [4].

This CL also removes the following fields since they can just be a
local final variables that will be captured into callback.

 * RenameDialog#mFingerName
 * RenameDialog#mTextSelectionStart
 * RenameDialog#mTextSelectionEnd

 [1]: I182b05d3ff59fb3b4732d60d0d5a464f0e0e0235
      f6af093e2d
 [2]: I892d639f3cc5d43db553b682d5278b8ce2fe72da
      4803267106
 [3]: Ib75ba0f361b8b46c3b717cc1ffb864726958ed82
      b0bcbed372
 [4]: I5bb1b7227c1323595bf7f483e11e87e2c3550093
      7a1d52eb06

Fix: 118473687
Test: Manually verified as follows.
      1. Build and flash aosp_taimen-userdebug to Taimen
      2. Set up a fingerprint unlock.
      3. Rotate the device to landscape mode.
      4. Open Settings -> Security & location -> Fingerprint
      5. Re-enter password if necessary
      6. Tap "Finger 1"
      7. Make sure that AOSP Keyboard shows up
Change-Id: I2a137aa8f6a1ee2b67923bcf40e82320a56c7b59
2018-10-29 13:09:12 -07:00
jackqdyulei
400e13cc11 Update the mobile activity
1. Add listener to ACTION_RADIO_TECHNOLOGY_CHANGED
2. Update fragment switch by using replace
3. Remove todo for sort because list is already sorted by sim slot
4. Make actiivty accept SUB_ID from intent
5. Add icon for multi-sim support

Bug: 114749736
Test: RunSettingsRoboTests && Screenshot

Change-Id: I11c472b1479ec9243266cb2a7ef4292370ac6894
2018-10-29 13:05:50 -07:00
Rakesh Iyer
52fd31c2f3 Misc fixes to TTS settings.
1. Remove an extra PreferenceGroup that was causing some spacing
   issues.
2. Remove the animations when elements resize because this causes
   items to slide around unnecessarily.
3. While we're in the file, lambda-ify some of the older code.

Bug: 77981482
Bug: 79897262
Test: Manually verified.
Change-Id: I9c79beea3a231ba62aeef3543802faebd775e128
2018-10-29 10:20:28 -07:00
Yanting Yang
f61bc19f6b Add Connected Device slice to Contextual Settings Homepage
- Support Bluetooth device information.
- Not yet integrate slice background worker.

Bug: 114807655
Test: robotests, visual
Change-Id: I23f902137b0468349ee627bed6a394d42ea4a00d
2018-10-29 16:10:58 +08:00
Fan Zhang
293883b2fe Report fully drawn when all settings are loaded.
We do not want to wait for contextual cards in app start
instrumentation, as user can already do everything in settings without
them.

Change-Id: I57d59aa3d623bf6911972ec310d558c25e44bf14
Fixes: 117494071
Fixes: 118495692
Test: perftest
2018-10-28 15:59:24 -07:00
Fan Zhang
0c7c59f1b9 Make android.settings.SETTINGS intent go into homepage.
Change-Id: Ib7453a79a473410c44bdcf06019446cedd34f837
Fixes: 117281845
Test: robotests
2018-10-28 15:59:24 -07:00
Fan Zhang
444b5107e3 Animate contextual cards in after loading.
After initial loading, all cards slide down per material guideline.

Test: visual
Change-Id: I115e086a43fc9a2d4b4da3acad20be689fdee09d
2018-10-26 19:49:35 +00:00
TreeHugger Robot
19e640701e Merge changes Idbb63960,Id7889566
* changes:
  Delete some unused resources
  Move all contextual card related classes.
2018-10-26 19:18:19 +00:00
TreeHugger Robot
63df02cbde Merge "Fix crash on Wi-Fi Slice when it's continuously pinned and unpinned" 2018-10-26 19:10:29 +00:00
Vadim Tryshev
27a76c3988 Using intent action for DWB properties exposed as an API
The intent opens digital wellbeing properties for an app.

Bug: 118319143
Test: Building Android
Change-Id: I0921ba5e8a6cb357ba12a08cafcab64503417dc9
2018-10-26 10:45:40 -07:00
Fan Zhang
5e6e6a14f2 Move all contextual card related classes.
... from homepage to contextualcards.

Test: rebuild
Change-Id: Id7889566ce1e7257eb699d963ae996906fdb58ff
2018-10-26 10:02:04 -07:00
Jason Chiu
89b15785c7 Fix crash on Wi-Fi Slice when it's continuously pinned and unpinned
It's because WifiTracker's initialization and onStop is on different
thread. Fine tune the thread logic in SliceBackgroundWorker.

Fixes: 118165942
Test: manual
Change-Id: Icc86b5df7ec3c6fd0e4a79a62ea0c84465e9528d
2018-10-26 18:47:51 +08:00
Hugh Chen
152de8abde Merge "Make HearingAid code more generic" 2018-10-26 01:57:24 +00:00
Lei Yu
ed33c87c02 Merge "Remove unused code in telephony fragment" 2018-10-26 01:14:27 +00:00
Lei Yu
6b4e5a2343 Merge changes Iafe111bf,Ie9d8e935
* changes:
  update CdmaApnPreferenceController
  Add network selection preferences
2018-10-26 00:28:30 +00:00
Lei Yu
f3baeb1e0d Merge changes Iad3bc131,Id43cb480
* changes:
  Update NetworkSelectSettings page
  Recopy NetworkSelectSetting from phone to settings
2018-10-25 22:32:32 +00:00
jackqdyulei
72eaed5479 Remove unused code in telephony fragment
Bug: 114749736
Test: Manual
Change-Id: Ifff0cd03b024a482ce2c61e0d052c95a77e714ee
2018-10-25 14:32:38 -07:00
jackqdyulei
4c0b300e21 update CdmaApnPreferenceController
Rename it to ApnPreferenceController since it support both Gsm and
Cdma. Also add check for Gsm sim card.

Bug: 118402844
Test: RunSettingsRoboTests
Change-Id: Iafe111bfdc8f8e7d91d104df652ae9b27c9b166f
2018-10-25 13:13:13 -07:00
jackqdyulei
762f75f150 Add network selection preferences
1. Toggle to decide whether to auto select
2. Preference to go to network selection page

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Ie9d8e9353bf2a99b8cba1fb14d5a440a43fde66e
2018-10-25 12:47:54 -07:00
Fan Zhang
130c477044 Remove DashboardSummary and all related classes.
- Condition is already supported in PersonalSettingsFragment
- Suggestion is already supported in PersonalSettingsFragment
- Static/dynamic tiles are supported in TopLevelSettings

Change-Id: I51882e3bd0919ad95109baefac683d98667c11e3
Fixes: 110405144
Test: robotests
2018-10-25 11:27:47 -07:00
jackqdyulei
227526a8ac Update NetworkSelectSettings page
Clean it up and make it compatiable with all devices. Before this CL
it only used in Pixel 3 with new moderm.

Bug: 114749736
Test: RunSettingsRoboTests
Change-Id: Iad3bc131e294d34cff90b9130715780182adccd7
2018-10-25 10:51:23 -07:00
TreeHugger Robot
61a8d1fbe4 Merge "[Settings] Use 1030 opcode, deprecate 1024." 2018-10-25 08:00:01 +00:00
TreeHugger Robot
34537c1c38 Merge "Revert "Add Support for Virtual High Refresh Rate mode"" 2018-10-25 05:59:24 +00:00
timhypeng
c95056d7b5 Make HearingAid code more generic
-handle UI updating when sub device connection state changes
-add test case

Bug: 112735753
Test: make -j42 RunSettingsRoboTests
Change-Id: Ie2643657c47a0956aac3f8cac4bfdbdea0399ce8
2018-10-25 04:06:40 +00:00
Fan Zhang
b2f4994380 Merge "Repro b/118398695" 2018-10-25 02:26:15 +00:00
jackqdyulei
3a2226be63 Recopy NetworkSelectSetting from phone to settings
NetworkSelectSetting is changed during the migration, recopy it
to make it up to date

Following CL will refactor to reuse this fragment for all devices.

Bug: 114749736
Test: Build
Change-Id: Id43cb480cf31447a6e4a23eb3709f9ab972a2930
2018-10-24 18:53:09 -07:00
Peiyong Lin
0a16997fe9 [Settings] Use 1030 opcode, deprecate 1024.
Previously we separated wide color gamut out of color management and added a
new opcode 1030 to query whether the device's built-in display is color
managed. This patch deprecated 1024 opcode.

BUG: 111505327
Test: Build, flash, boot and check Settings>Display>Color
Change-Id: Ifaf03d02d21c47b7b3be987ceaabb61fa4449c8c
2018-10-24 18:23:01 -07:00
Fan Zhang
ac265fd405 Repro b/118398695
Bug: 118398695
Test: robotests
Change-Id: I09331e042368f849651dbb1273d802f4ca24a832
2018-10-24 15:46:21 -07:00
TreeHugger Robot
e2ed46e906 Merge "Add Battery slice in Contextual Settings Homepage" 2018-10-24 21:26:50 +00:00
David Sodman
86d0b28220 Revert "Add Support for Virtual High Refresh Rate mode"
This reverts commit 7915fda7ee
as this feature has been cancelled.

Test: None
Change-Id: I5ea9afcc3191576e84742ccf316b030b5c00e5c4
2018-10-24 13:27:00 -07:00
Fan Zhang
a4c516fe93 Merge "Fix a bug where cards overlap when rotating the screen" 2018-10-24 20:25:54 +00:00
Mill Chen
60f6a25af8 Add Battery slice in Contextual Settings Homepage
- Add Battery card that implements CustomSliceable in Contextual
Settings Homepage.
- Add test case for Battery slice.
- Created a loadBatteryInfo method for BatterySlice.
- Add a map in CustomSliceManager to cache CustomSliceable instances,
let existing battery slice be able to update battery info.
- Use a flag to avoid triggering an infinite loop when calling
notifyChange in the callback function.

Bug: 114796623, 115971399
Test: manual, robotests
Change-Id: I4b785708bf8456c6c4de7cae4b44f8a060bccbae
2018-10-24 20:01:53 +08:00
Emily Chuang
b97bfb0885 Fix a bug where cards overlap when rotating the screen
Check if a certain fragment has been added before. If it's added, then
just show it instead of re-adding it again.

Bug: 118344247
Test: visual
Change-Id: I039a3a7372e163c6bcda386d2aea99e6f8c8e9b1
2018-10-24 19:42:17 +08:00
Fan Zhang
dcfeea3e7b Merge "Fix toast is covered by PIN code screen after wrong pin" am: d5abc0eb44 am: c150f5eb29
am: 4c95f60b9e

Change-Id: I651be252786c84156be901ef30f7cab37c1d4fdb
2018-10-23 19:36:50 -07:00
Fan Zhang
4c95f60b9e Merge "Fix toast is covered by PIN code screen after wrong pin" am: d5abc0eb44
am: c150f5eb29

Change-Id: Ia4e59e195720919f2baa52e7d5667aed27c5ce7c
2018-10-23 19:30:39 -07:00
Fan Zhang
d5abc0eb44 Merge "Fix toast is covered by PIN code screen after wrong pin" 2018-10-24 02:16:57 +00:00
Fan Zhang
5cec560cf3 Merge "Add place holder rows to wifi slice." 2018-10-24 02:15:18 +00:00
Lei Yu
d7a2569034 Merge "Refactor Cdma preference in ECM" 2018-10-23 23:53:29 +00:00
Fan Zhang
cc88c2fe43 Add place holder rows to wifi slice.
When loading wifi slice, the wifitracker is super slow to scan and
return APs. So we will show up to 3 rows of placeholder in the slice UI.

- When building slice, if there are at least 3 APs, show first 3.
- When there aren't enough APs, show them all and fill the rest of
  placeholder rows.

Bug: 118224581
Test: robotests
Change-Id: Id332f64bfa335543ea406f73b249f93504d63d4f
2018-10-23 15:48:14 -07:00
Hao Zhao
754930bc50 Fix toast is covered by PIN code screen after wrong pin
The error toast is displayed when user input wrong PIN
code three times, but at that moment the SIM PUK code input
page in SystemUI pop up and covers the toast, so the user
can't seen the error message.

Adjust the toast window layer, let the the toast pop up
over the SIM pin code input page.

Bug: 74056527
Change-Id: I569a2fc2adac15c4713b4c95e9720335bd4df88a
2018-10-24 06:39:45 +09:00