Commit Graph

65312 Commits

Author SHA1 Message Date
Jakub Pawlowski
138dbb86cc Prevent overlay drawing on top of Bluetooth pairing dialog am: f3afef8419
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11953485

Change-Id: I41bd60685dc58028a328c041ca4532b42881cec7
2020-06-22 19:03:01 +00:00
Jakub Pawlowski
f3afef8419 Prevent overlay drawing on top of Bluetooth pairing dialog
Bug: 155648639
Change-Id: I99643ee9084f3a9bc1ad9a459ac27c587d832c91
Merged-In: I99643ee9084f3a9bc1ad9a459ac27c587d832c91
2020-06-22 17:35:40 +02:00
TreeHugger Robot
49ebea153c Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be am: f5c9bf01c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: Id5e9517d512afe8c52ace07b2487f2bb56d0a47c
2020-06-22 10:51:21 +00:00
Stanley Wang
11b97ea0ae Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: 7c0f60f24e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: If240648f9ae164915225afc6cefb3e3e7f7d3488
2020-06-22 10:51:05 +00:00
TreeHugger Robot
733d80a575 Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be am: a456072536
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: I086c26c26bc911056a55800c99b480f3b91fac8c
2020-06-22 10:50:46 +00:00
Stanley Wang
69eaf216eb Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc am: b1895fc072
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: I06655ae21068d4f9bd0f9430e88be8b3a69eacf9
2020-06-22 10:50:39 +00:00
TreeHugger Robot
f5c9bf01c3 Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: I242e99fed086552dd9492c9ad8a294b72e166212
2020-06-22 10:43:06 +00:00
TreeHugger Robot
a456072536 Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev am: 72dac6e5be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949294

Change-Id: Ib8597a1df999e308b90ae00ffd83b281627e7809
2020-06-22 10:42:42 +00:00
TreeHugger Robot
72dac6e5be Merge "Disable the defulat animation of the RecyclerView to avoid UI jank." into rvc-dev 2020-06-22 10:40:46 +00:00
Stanley Wang
7c0f60f24e Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: I2f29322ed4c14d9ed093777d330e9df7b364feb4
2020-06-22 10:38:20 +00:00
Stanley Wang
b1895fc072 Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev am: 7afb61e6dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11949297

Change-Id: I7bda54792d81ace1bcdee9f018fb3e5f3db0fc1b
2020-06-22 10:38:04 +00:00
Stanley Wang
7afb61e6dc Merge "Fix the bug of not showing lock screen before entering Smart Lock page." into rvc-dev 2020-06-22 10:25:58 +00:00
Stanley Wang
f1a0801c00 Fix the bug of not showing lock screen before entering Smart Lock page.
Controller can't find the target preference to handle the click event.
Store the preference keys to match the clicked item.

Fixes: 158716163
Test: run robotest and manually test the click behavior

Change-Id: Ie243206ceffef013c56c4ea29c14fe56da510fb6
2020-06-22 16:49:02 +08:00
Stanley Wang
a8ba796123 Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: d4714ff1db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I6171c7298881194901f6e4b9d5963c5cf02e6a25
2020-06-22 08:46:48 +00:00
Stanley Wang
24eaff871f Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745 am: 843622806b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I0c038c91405dbf81d4c7e5d1012335ed1907e68b
2020-06-22 08:46:25 +00:00
Stanley Wang
d4714ff1db Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I0c23ec0766d3d9a87e59d59f0003778e4edc6acc
2020-06-22 08:29:58 +00:00
Stanley Wang
843622806b Merge "Add log to capture the hardware status." into rvc-dev am: 1117895745
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11908539

Change-Id: I8d32c05d89d857859b88477d282fc36a614c4d9a
2020-06-22 08:29:51 +00:00
Jason Chiu
092f612ab2 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: 1bb216e35e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I1e73dd84798698d03c7fdb3ec4ed79702f0018cb
2020-06-22 08:25:05 +00:00
Jason Chiu
16b830e465 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: c13f549973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I15f115cacf0d233c5337d3e59242e545f877b368
2020-06-22 08:24:48 +00:00
Stanley Wang
1117895745 Merge "Add log to capture the hardware status." into rvc-dev 2020-06-22 08:19:36 +00:00
Jason Chiu
1bb216e35e Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I572e26bd5148fe6823095272bf5cea57104def1c
2020-06-22 08:12:05 +00:00
Jason Chiu
c13f549973 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: Ia202ea7899f8ebb8770db91ea676b28f29cbef64
2020-06-22 08:11:49 +00:00
Jason Chiu
c548288a51 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev 2020-06-22 07:58:25 +00:00
Jason Chiu
73afb042dc Workaround of Slice not pinned bug when using SliceCallback
When a client registers a SliceCallback, it starts to observe Slice
changes. The observer is running in the main looper and binds Slice
in AsyncTask.

However, when the client unregisters the callback, it unpins the Slice
in the client's thread. Thus, if the AsyncTask has pinned the slice but
hasn't bound it yet, it may be unpinned by the client, and an exception
occurs.

This fix is to unpin the Slice in the same SerialExecutor of AsyncTask,
which is to ensure bindSlice() and unpinSlice() are called in the same
thread one after another without the race condition.

Bug: 157387583
Test: robotest
Change-Id: If5f4b4bc0d8c5a2800cad8ff2afd7084426a6c96
2020-06-22 07:38:50 +00:00
Jason Chiu
81d612d5fa Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 5d37336eb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I2ea7f182efc44bbdc0a6e8c05dcc0dcebd45834a
2020-06-22 07:27:48 +00:00
Jason Chiu
d1056becc2 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I342f57b7adb215835fcebd9dff0b3e51cd0f3e7c
2020-06-22 07:27:19 +00:00
Jason Chiu
5d37336eb3 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I1913715e1ecddf6f39fd8a3357a7db3125add0b8
2020-06-22 07:15:04 +00:00
Jason Chiu
07081ae34e Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: Ia422444a14e73076de14098a612794d4c0909ddc
2020-06-22 07:14:46 +00:00
Jason Chiu
f1a65df04a Merge "Decrease memory usage for sleep idle test" into rvc-dev 2020-06-22 07:05:38 +00:00
Yi-Ling Chuang
b54f9b4921 Disable the defulat animation of the RecyclerView to avoid UI jank.
When users go to a sub page in Settings and come back to the homepage
again, those sticky cards flicker which makes the UI janky. This is
because we rebind sticky cards to ensure it's always up-to-date, where
the recyclerView has its default animation while notifyItemInserted(),
ane thus introduce the jank.

Fixes: 158627602
Test: Open Settings -> go to sub pages -> back to the homepage -> cards
are not flickering.

Change-Id: I2104dbe0bed8b2486c35521bcc0b5c8b54efb995
2020-06-22 14:53:10 +08:00
Jason Chiu
aecb321beb Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: eb50dcaac5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I4cab18be801fde340503f369f3ee478fc8e5e0f7
2020-06-22 06:45:05 +00:00
Jason Chiu
2e67b3f645 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: Ib6f924bc21c9199c05a2374753ad6b8391d2eec9
2020-06-22 06:44:57 +00:00
Jason Chiu
eb50dcaac5 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: Ie317b7ef7d733ec635773bf5af587f4016329261
2020-06-22 06:33:05 +00:00
Jason Chiu
7ebe511104 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I1f30b105bcad02f13661b4d7a3652165a328fa13
2020-06-22 06:32:58 +00:00
Jason Chiu
64dbdebfbf Merge "Fix homepage cards show up problem after first launch" into rvc-dev 2020-06-22 06:20:08 +00:00
Alex Li
953e87a578 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 49df46ef59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I81caf8c8e01ebbf956ed81d6034f3cc594a78279
2020-06-22 04:25:06 +00:00
Alex Li
d5f6a66682 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 0567bb7834
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I905797e8477a4d0ea86bb57b8c02bfac95cfb001
2020-06-22 04:24:46 +00:00
Alex Li
49df46ef59 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: Id0716197d222a2382c3992d05ffbfb1426b929a1
2020-06-22 04:10:53 +00:00
Alex Li
0567bb7834 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I1606b0ae03f46750d0067a9c9abc898dbbfe0c4b
2020-06-22 04:10:37 +00:00
Alex Li
3f8d40bd95 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev 2020-06-22 03:59:30 +00:00
TreeHugger Robot
46383f190a Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 11018b11c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: Ie03b467b5a3d7df4fe1e76e0deba5739ded90cf7
2020-06-22 03:58:55 +00:00
TreeHugger Robot
009de48ded Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 2b697fac94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: I77d3bf02a641854f2388fd40704bc590437842e4
2020-06-22 03:54:55 +00:00
TreeHugger Robot
11018b11c1 Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: I9b287ae61c3c1d1bad877859bb8b1ee80a9421fd
2020-06-22 03:44:29 +00:00
TreeHugger Robot
2b697fac94 Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: I97fcaa6787a5f9a205e8027d3bfe9d52fa358b6a
2020-06-22 03:44:17 +00:00
TreeHugger Robot
fbabf8f251 Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev 2020-06-22 03:27:01 +00:00
Jason Chiu
2e0758f7ae Decrease memory usage for sleep idle test
Postpone setTheme to decrease memory usage of Settings for the test
android.platform.test.scenario.sleep.Idle

Bug: 156631776
Test: forrest test
Change-Id: I4178eae0832e15c9d6da4a0f1f2898f5c797d388
2020-06-22 02:43:10 +00:00
alexylli
40b79387cc [Settings] Avoids disabled component when page start from setup wizard.
Fixs when disable component during system busy, the framework have high possibility to force closing activities on the same task.

test
1. setup a pin code and go through to the anything else page. click "control info on lock screen".
>> The SetupRedactionInterstitial not been disabled.
>> The lock screen can be setup repeatedly.
2. into home screen. using adb command to start SetupRedactionInterstitial.
>> the screen not shown.
3. using adb command to start RedactionInterstitial and click "done".
>> the activity existed normally.

Bug: 158961310
Test: Manual
Change-Id: I09fe95db591d3d3603b2c13623a0873bfab3bac0
2020-06-22 09:59:28 +08:00
TreeHugger Robot
0c94e12c75 [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 27d10f6b63 -s ours am: 85e3e2d0f9 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11944942

Change-Id: I45baa1a1918014ed96f0809c921db1ad8ee5b30d
2020-06-21 00:10:46 +00:00
TreeHugger Robot
b5968c5bcc [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 27d10f6b63 -s ours am: d76af20a41 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11944942

Change-Id: I1d5f8c27f7c6c18d430c02655e118b6ea2785eb8
2020-06-21 00:05:26 +00:00
TreeHugger Robot
85e3e2d0f9 [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 27d10f6b63 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11944942

Change-Id: I60cac5e4038779e6924467878536a74466228518
2020-06-20 23:53:47 +00:00