Commit Graph

37905 Commits

Author SHA1 Message Date
TreeHugger Robot
c8abbc4d8d Merge "Improve pointerSpeedPreference a11y content description" into sc-dev 2021-06-29 10:05:06 +00:00
Stanley Wang
c07f4dfd38 Merge "Fix the problem that the ToggleSubscriptionDialogActivity appears twice when switch changed." into sc-dev am: 09134b237c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15093552

Change-Id: I11685e0da549aa995064a2351978d5b453145788
2021-06-29 10:01:29 +00:00
Stanley Wang
09134b237c Merge "Fix the problem that the ToggleSubscriptionDialogActivity appears twice when switch changed." into sc-dev 2021-06-29 09:48:54 +00:00
Weng Su
5796ebf67f Fix the multiple instences of NetworkProviderSettingsActivity issue
- Use the command "adb shell dumpsys window" to dump how many
activities/windows currently on the system.
  Then search for section like "Task display areas in top down Z order"

Bug: 191956700
Test: manual test
Use "adb shell dumpsys window" to check no more multiple instences

Change-Id: Ie9e04db3db601fbeee9beceedb81929cd6eba439
2021-06-29 17:15:55 +08:00
Yanting Yang
82ed9d47e8 Merge "Improve the latency of first entering Apps page" into sc-dev am: 995e5fbd6e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15093555

Change-Id: If1b0561f0fe1875f98eb4b4029b4bf3b5a16f73a
2021-06-29 08:44:39 +00:00
Yanting Yang
995e5fbd6e Merge "Improve the latency of first entering Apps page" into sc-dev 2021-06-29 08:25:53 +00:00
Weng Su
d2fb4f06a3 [Provider Model] Fix the "Cancel" button issue in the reminder dialog
- Do nothing if user cancel to turn off mobile data

Bug: 192052695
Test: manual test
atest -c ProviderModelSliceTest

Change-Id: Ib4b990a1f3f51a6bf11552a6018c73f8d7105736
2021-06-29 16:08:20 +08:00
Jernej Virag
ccd85ddbf6 Merge "Update power button gesture menu" into sc-dev am: 5b8cc84c04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15104679

Change-Id: Ieff923567506436ed80343758a08245da235913e
2021-06-29 07:59:06 +00:00
Jernej Virag
5b8cc84c04 Merge "Update power button gesture menu" into sc-dev 2021-06-29 07:52:09 +00:00
TreeHugger Robot
921860c4bd Merge "Password settings: Fix UI flicker from loading summary" into sc-dev am: d60eae5539
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15136527

Change-Id: I9ccbdc3acb363dd9d0f8d60ee605f3215779b6bb
2021-06-29 07:36:34 +00:00
TreeHugger Robot
d60eae5539 Merge "Password settings: Fix UI flicker from loading summary" into sc-dev 2021-06-29 07:21:49 +00:00
Stanley Wang
ec95ed2650 Fix the problem that the ToggleSubscriptionDialogActivity
appears twice when switch changed.

- Don't trigger the switch change event if the state of Switch and
  SwitchSettingsMainSwitchPreference are the same.

Fix: 190767461
Test: robotest and operate the switch preference manually

Change-Id: I6ab4b7e5ca1455948ca9118bb4a674fdc4fdbd50
2021-06-29 14:55:15 +08:00
TreeHugger Robot
dd28bb7e12 Merge "Fix the non-working DND toggle" into sc-dev am: 53124fa7b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15109294

Change-Id: Ic7d9e9f527f083ecd8f6ce0f8216f7e5305171d5
2021-06-29 06:47:21 +00:00
TreeHugger Robot
53124fa7b3 Merge "Fix the non-working DND toggle" into sc-dev 2021-06-29 06:35:55 +00:00
Ahaan Ugale
f0d8071bc6 Password settings: Fix UI flicker from loading summary
Adds a placeholder summary string so the UI doesn't shift when the
summary is updated.

Also disables debug logging.

Fix: 191939601
Test: manual
Change-Id: If6027f101a6bad022501f7ba6c6ab576341f0ce4
2021-06-28 23:15:28 -07:00
Yi-Ling Chuang
6a83c73624 Fix the non-working DND toggle
The pendingIntent of the DND toggle was set to immutable previously
which doesn't allow any modification. This CL fixes this by making it
mutable.

Fixes: 191865710
Test: Search "dnd" and make sure the toggle has effect upon modification
Change-Id: Iade256cee8885cb80ade5ca95cc50065c2a78da2
2021-06-29 12:46:08 +08:00
Wesley Wang
3df9608ca6 Merge "Update batteryDiffEntry filter condiction" into sc-dev am: 4c1b805cef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15080731

Change-Id: I32a35f5a3185a4c5f841a821594fbecf6bb0acd7
2021-06-29 04:21:25 +00:00
Tiffany Nguyen
637ec7bdc4 Merge "Log Battery Saver states." into sc-dev am: dc93eda197
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15125481

Change-Id: I9cb0b0d978133b032d3ba311cefffba57b13bf1f
2021-06-29 04:21:18 +00:00
Wesley Wang
4c1b805cef Merge "Update batteryDiffEntry filter condiction" into sc-dev 2021-06-29 04:17:29 +00:00
Tiffany Nguyen
dc93eda197 Merge "Log Battery Saver states." into sc-dev 2021-06-29 04:13:02 +00:00
Joe Bolinger
953b2deb54 Merge "Return enrollment consent status to caller." into sc-dev am: 8d5b841fb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15133398

Change-Id: Ia66f4df37a37f3756377e7a12568e752c4bc8301
2021-06-29 02:57:22 +00:00
Joe Bolinger
8d5b841fb1 Merge "Return enrollment consent status to caller." into sc-dev 2021-06-29 02:41:55 +00:00
Joe Bolinger
eb1dac69f0 Return enrollment consent status to caller.
Bug: 188847063
Test: adb shell am start -a android.settings.BIOMETRIC_ENROLL --ez require_consent true
Change-Id: I3285b379e175539c37355c67749c3d900e6ac62b
2021-06-28 17:51:46 -07:00
Jernej Virag
34cbca502b Update power button gesture menu
This renames the menut to fit within other gesture options. It also properly implements subtitle behaviour in gesture menu and adds a hint on how to invoke the power menu on new Pixels.

Bug:191899039
Bug:168176408
Bug:189506870
Test:  Unit tests for package com.android.setttings.gestures.*
       Manually on device

Change-Id: I985a97514ca142d554ab2aafd61a6219cc1a3dd6
2021-06-28 20:27:03 +00:00
arangelov
8fca8dc092 [Settings] Pass the system user to launch the web help page
Fixes: 191727929
Test: manually observed the policy transparency dialog
with launching the admin policies screen
Test: manually observed the policy transparency dialog
with launching the web help page

Change-Id: If0d10b30a5e5f2a1bade168f049c8613055289e7
2021-06-28 20:14:16 +01:00
Mill Chen
4b5d1e78d5 Merge "Add line spacing multiplier for CollapsingToolbarLayout" into sc-dev am: 968151aa18
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15126437

Change-Id: Ie2fa17748dab18f8659acf4621e15845c15fb3a6
2021-06-28 17:50:50 +00:00
Mill Chen
968151aa18 Merge "Add line spacing multiplier for CollapsingToolbarLayout" into sc-dev 2021-06-28 17:34:01 +00:00
Yanting Yang
5f125d8284 Merge "Clear legacy code about AppAndNotificationDashboard" into sc-dev am: ca0415d475
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15102780

Change-Id: I068ec6d73a402db50f4a292fd76d8943ca8ea415
2021-06-28 13:02:41 +00:00
Yanting Yang
ca0415d475 Merge "Clear legacy code about AppAndNotificationDashboard" into sc-dev 2021-06-28 12:54:44 +00:00
Tiffany Nguyen
f9416e6a40 Log Battery Saver states.
Test: Unit test
Bug: 189914747

Change-Id: Ib815e60a52ec549df2ab2b90df29bca1eeeef339
2021-06-28 11:22:20 +00:00
Mill Chen
139fa375cd Add line spacing multiplier for CollapsingToolbarLayout
Since there is a problem with a small line spacing between multiline
title of collapsing toolbar in a few locales, that caused the title is
overlapping with each other. Enlarging the line spacing by using
lineSpacingMultiplier to fix it.

Fix: 183223866
Test: visual verified
1) Change to MY locale
2) Navigate to Settings > Sounds & vibration > Do not disturb > Alarms &
other interruptions
3) Observe the title and check if it is overlapping with each other

Change-Id: I87f0af5151a6367bc623ac07b15e04c39b51c6ca
2021-06-28 18:39:20 +08:00
Yanting Yang
4124284bb7 Improve the latency of first entering Apps page
Root cause:
AppsPreferenceController will query the recent app usages twice on
the main thread.

Solution:
Set flag to ensure only triggering refreshUi() once when entering
the Apps page.

Also correct the preference key of apps.xml since we don’t have
duplicated preferences now.

Fixes: 183176038
Test: robotests & visual
Change-Id: Ia41ee1e4a1946b8122deca63e318d3915afcc426
2021-06-28 18:30:39 +08:00
Bonian Chen
6be744ee95 Merge "Revert "[Settings] Code Refactor - ActiveSubscip..."" into sc-dev am: a3f28b034d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15125273

Change-Id: Iec3c149b6caeb872c952d833083a3570f9ebb6f7
2021-06-28 10:14:32 +00:00
Wesley.CW Wang
30b60195e8 Remove unnecessary converting us to ms in BatteryInfo
The class "Estimate" has the menber estimateMillis and
the unit of batteryUsageStats.getBatteryTimeRemainingMs() is millisecond,
so converting from us to ms is unnecessary.

Bug: 187379252
Test: make RunSettingsRoboTests
Change-Id: Iefbd8751608eb749367cf08a4a9b184b948a6d33
2021-06-28 17:59:35 +08:00
Bonian Chen
d9bf670725 Revert "[Settings] Code Refactor - ActiveSubscip..."
There seems to be an issue on system when a modification on file name get referenced by multiple submit(s).
(ag/15106410 and ag/15102785).

It seems to me that, build system got build breakage immediately instead of merging all of the files (even within same package).

Reason for revert: Try to submit all of the modifications within single submit as a workaround.

Bug: 192204057
Test: build pass
Change-Id: Ie497088a58c6ac564fde193fad2c0b67a965933c
2021-06-28 09:32:54 +00:00
Weng Su
7a45b33c42 [Provider Model] Hide Connectivity Subsystems when recovering
- Hide Carrier Network

- Hide Wi-Fi toggle

- Hide all of Wi-Fi Networks

Bug: 186590805
Test: manual test
atest InternetResetHelperTest
atest NetworkMobileProviderControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest

Change-Id: Ib8462f890847d14bfc6ef533d1147822fd797a13
2021-06-28 17:19:13 +08:00
Edgar Wang
92d2c96c1d Improve pointerSpeedPreference a11y content description
Fixes: 189725080
Test: manual
Change-Id: I1638acd986fd791c2fbb7b69decda1bc461dee74
2021-06-28 16:22:23 +08:00
Bonian Chen
40a93c2511 Merge changes from topic "revert-15102785-Fix build break of refactor ActiveSubscriptionsListener-TNZMDOZYZU" into sc-dev am: f4a80fdfa3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15120295

Change-Id: I01d1c9a907097c944f68829bc0ff9d68eebd1435
2021-06-28 05:42:19 +00:00
Bonian Chen
4c4d8e3a08 Revert "[Settings] Fix build breakage"
Revert submission 15102785-Fix build break of refactor ActiveSubscriptionsListener

Reason for revert: Build breakage.
Reverted Changes:
I9ae819f06:Revert "Revert "[Settings] Code Refactor - ActiveS...
I15819472b:[Settings] Fix build breakage

Change-Id: Ifb1a579863df157b41aebbdf59ad7e4584efa866
2021-06-28 05:23:33 +00:00
Bonian Chen
69fc8e0ccd Revert "Revert "Revert "[Settings] Code Refactor - ActiveSubscip..."
Revert submission 15102785-Fix build break of refactor ActiveSubscriptionsListener

Reason for revert: Build breakage.
Reverted Changes:
I9ae819f06:Revert "Revert "[Settings] Code Refactor - ActiveS...
I15819472b:[Settings] Fix build breakage

Change-Id: Ib830b7b00504264a703a03a00bfdfcf65135d394
2021-06-28 05:23:33 +00:00
Bonian Chen
aaea164675 Merge "Revert "Revert "[Settings] Code Refactor - ActiveSubsciptionsListener""" into sc-dev am: c437177d4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15106410

Change-Id: I43500208af3d17787ad7065cfe05735486ef2cce
2021-06-28 04:02:18 +00:00
Bonian Chen
c437177d4b Merge "Revert "Revert "[Settings] Code Refactor - ActiveSubsciptionsListener""" into sc-dev 2021-06-28 03:59:43 +00:00
Bonian Chen
bf4120f3f8 Merge "[Settings] Fix build breakage" into sc-dev 2021-06-28 03:59:43 +00:00
Arc Wang
e8de94a21d Fix 'No Apps' UI issues of ManageApplications
Fixes below UI issues

- "No Apps" may not show in fragments of profile tab.

  Fix it by using ConstraintLayout to specify alignments
  of each view and removing extra padding.

-- "No Apps" may flicker by moving position.

  The flicker is from unnecessary visibility changes.
  This change integrates empty view visibility
  control in LoadingViewController to simplify code
  and avoid unnecessary visibility changes.

Bug: 189390795
Bug: 183398721
Test: atest com.android.settings.deviceinfo
      make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.deviceinfo
      Manual visual, observe UI
        Settings -> Storage -> Games
        Settings -> Notifications -> App Settings
	Settings > Apps > Special app access > Media management apps
Change-Id: I634209c6f8466e2adae703226902190bbdf470b9
2021-06-28 11:33:10 +08:00
TreeHugger Robot
46398c4a58 Merge "Fix switch behavior with switch access" into sc-dev am: 0bea498ae1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15112042

Change-Id: I9f7c5cec36fd05f66f274a6321707ea5c3ef4d47
2021-06-28 03:24:11 +00:00
TreeHugger Robot
0bea498ae1 Merge "Fix switch behavior with switch access" into sc-dev 2021-06-28 03:01:29 +00:00
Julia Reynolds
dc5649a529 Fix switch behavior with switch access
Test: manual with talkback, switch access, and no a11y aid
Fixes: 189074205
Change-Id: I95c1d0e9c2f82122e224399c6261ad2198901e04
2021-06-25 14:33:59 -04:00
Julia Reynolds
d802ef1614 Merge "Disable additional pkgs on DND perm page" into sc-dev am: 3d22e9775a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15109118

Change-Id: I74b2da6ee478465ba6d3c4106fa6b13d1c9751cf
2021-06-25 15:07:27 +00:00
Julia Reynolds
3d22e9775a Merge "Disable additional pkgs on DND perm page" into sc-dev 2021-06-25 14:56:13 +00:00
Jan Tomljanovic
c6667337ca Enable controllers to use a custom key.
Test: atest SettingsUnitTests
Test: m -j45 RunSettingsRoboTests
Bug: 191763369
Change-Id: I48eea95613600580c80c8850f0a3fd543a7e0a43
2021-06-25 15:35:53 +01:00