Weng Su
a396a4d8b9
Refine TetherSettings with ViewModel
...
- Use ViewModel to handle the TetheringManager's lifecycle.
- Use LiveData to observe TetheredInterfaces's changes instead of callbacks.
Bug: 246531382
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=TetherSettingsTest
atest -c TetheringManagerModelTest
Change-Id: Ib1a710a19a5340f63401a37b5c2b0bc307ac82f0
2023-01-05 17:13:57 +08:00
Weng Su
29846984e7
Refine TetherSettings to avoid activity leaks
...
- Get system service by application context instead of fragment context to avoid the context being occupied
- Use the application main executor instead of creating new executor locally to avoid the executor being occupied
Bug: 246531382
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=TetherSettingsTest
atest -c TetheringHelperTest
Change-Id: I0de5e9c2bedfc8a224b3f8306224542212c9fcf5
2022-12-28 07:45:47 +00:00
TreeHugger Robot
ee3c5500f6
Merge "Refine TetherSettings"
2022-12-23 07:36:55 +00:00
Weng Su
f077b83586
Refine TetherSettings
...
- Move TetherSettings to network/tether folder
- Refine unit tests
Bug: 237273138
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=TetherSettingsTest
Change-Id: I1eb79780df824c575e79047bdeb3a9276f061fe9
2022-12-22 23:04:59 +08:00
xinghailu
897fd74731
Cleanup some plurals in Settings
...
Change <one> to <1> in string res file, and update related java files.
Test: Update, existing test still pass.
bug: 199230342
Change-Id: Idd0ba3c6adc060da21574d98f8ed765fae00cef8
2022-12-22 16:05:13 +08:00
Bonian Chen
47a8010a52
[Settings] Extend CustomDialogPreferenceCompat class
...
CustomDialogPreferenceCompat is an abstract class, which not allowing
creating a dialog directly.
This is a class to enable constructing it as a generic class.
Bug: 260540995
Test: presubmit build pass
Change-Id: I1353bb92b353d6d27206574fd8f5499742ad3994
2022-12-19 14:44:12 +00:00
Dominik Maier
2f81c06361
Add toggle to allow or disable null algorithms
...
This adds the allow null algorithms toogle to the Settings UI.
If supported by the smartphone baseband, the toggle allows users to opt
out of null algorithms, unencrypted cellular communication, for all
cellular generations.
This toggle is behind a feature flag that is off by default. It also
requires radio network HAL 2.1 or later to show.
Co-authored-by: Gil Cukierman <cukie@google.com >
Bug: b/237529943
Test: atest NullAlgorithmsPreferenceControllerTest
Test: adb shell device_config put cellular_security
enable_null_cipher_toggle true; // On cuttlefish, you can now see the
toggle in SIM settings.
Change-Id: Ia03cceee5463171ca455fa0624b911e06f222d2d
2022-12-16 16:29:49 +00:00
Zoey Chen
e40a3ca111
[Settings] 1. Provision status checking of eSIM 2. Show SIM if isOpportunistic is false
...
Bug: 262679983
Bug: 257120311
Test: manual
Change-Id: I67acd7d6e261d67271438f78ce1a87e90362e0b6
2022-12-16 11:25:04 +00:00
Bonian Chen
6d57edf9ac
Merge "[Settings] Change network reset into reset mobile network"
2022-12-16 00:41:16 +00:00
Bonian Chen
8d43fd9a35
[Settings] Change network reset into reset mobile network
...
Replace reset network into Reset mobile network settings
Bug: 260034791
Test: local and auto
Change-Id: I9547f266c1586073fd2b96f35cc9df8861b0a105
2022-12-15 15:44:08 +00:00
Treehugger Robot
2f96743835
Merge "Align SETTINGS_PACKAGE_NAME reference to a single place" am: d03411f0ee am: 24835ea2f9 am: 8a26d010d0
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2340884
Change-Id: I6b4edd0be16e090b56b628af51a0558c87822ef6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-12-15 13:41:13 +00:00
Treehugger Robot
8a26d010d0
Merge "Align SETTINGS_PACKAGE_NAME reference to a single place" am: d03411f0ee am: 24835ea2f9
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2340884
Change-Id: Ie89e48f670b7e3cc8d8d607149d35c678b67ae8f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-12-15 12:59:37 +00:00
SongFerng Wang
b64d2b2f9e
Merge "Revert "Remove "Backup Calling" button from Settings UI""
2022-12-14 05:56:43 +00:00
TreeHugger Robot
82789d15ce
Merge "[Settings] eSIM transfer: MobileNetworkSettings"
2022-12-13 10:57:38 +00:00
Zoey Chen
5aa4d6915a
[Settings] eSIM transfer: MobileNetworkSettings
...
- Add new entry in pSIM: Convert to eSIM
- Add new entry in eSIM: Transfer eSIM to another device
Srceenshot(pSIM): https://hsv.googleplex.com/6013596216590336
Srceenshot(eSIM): https://hsv.googleplex.com/6584033673740288
Bug: 261810065
Test: manual
Change-Id: Ifb1a6f8213037893939478caf1ced4a5705bdf66
2022-12-13 08:54:20 +00:00
Shen Lin
f677ee600a
Align SETTINGS_PACKAGE_NAME reference to a single place
...
This CL migrated some fragmented declarations of Settings packageName.
When we want to referece package name of Settings, we prefer using
Utils#SETTINGS_PACKAGE_NAME.
Bug: 262123382
Test: make Settings -j64
Change-Id: Ice6afd993d5991bb3c50f676c637b9a5487261f7
2022-12-12 04:56:28 +00:00
Zoey Chen
f1d040a0e4
[Settings] eSIM transfer: MobileNetworkListFragment
...
- Remove the eSIM/pSIM category and separators
- Add pSIM/eSIM icon for SIMs
Screenshot: https://hsv.googleplex.com/5263071317590016
Bug: 261810065
Test: atest NetworkProviderSimListControllerTest
Change-Id: If4b8659c377698e682093e1508699bfc96855b29
2022-12-10 09:34:20 +00:00
Zoey Chen
9ca3255c2d
[Settings] Fix crash and UI error when turn ON/OFF SIM
...
1. Should update the UI when turn off SIM
2. Fix ConcurrentModificationException
Bug: 259487637
Test: manual
Change-Id: If30a6b6323ac0237c92dc210bf3953ce86a199ae
2022-12-09 15:04:59 +00:00
Bonian Chen
13cb087774
Merge "[Settings] Code refactor for device without SIM"
2022-12-09 09:25:17 +00:00
Zoey Chen
f172189e8e
[Settings] eSIM transfer: MobileNetworkSummaryController
...
1. MobileNetworkSummaryController
- No matter single SIM or multiple SIMs, always launch MobileNetworkListFragment
- Remove the + and |
APM off: https://screenshot.googleplex.com/7M8qzsXFesy3nDi.png
APM on: https://screenshot.googleplex.com/C4ZnbpgUTPzTijL.png
2. Fix the APM mode
Bug: 244786012
Bug: 261810065
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MobileNetworkSummaryControllerTest
Change-Id: I8e5c9b8a58ef13b6deaea284e9793077b2da58f6
2022-12-08 10:29:08 +00:00
Bonian Chen
f19e92cc2c
[Settings] Code refactor for device without SIM
...
Code refactor to hide some UI entries, since there's a BluetoothWiFiPreferenceController
covers some of the work for device without SIM.
Bug: 259611847
Test: local & auto
Change-Id: Ia221663e180c8dabed2a25a927643c992ef8ac89
2022-12-08 05:24:01 +00:00
Bonian Chen
7b06d5f0e1
[Settings] BT and WiFi reset menu might covers VPN
...
VPN would be reset by BT and WiFi reset menu under device without a SIM
available.
Bug: 260034791
Test: local and auto
Change-Id: I3c66cd629977cc11172758ebbe314167b5220419
2022-12-07 13:45:51 +00:00
Zoey Chen
45c646d6cb
Merge "[Settings] Update the title if launch the fragment from search app" am: eef6d0cb24 am: 8b0070a509
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2331882
Change-Id: Iffed6efb8542259ae3f1ca22c198cc768a4ad126
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-12-07 10:13:35 +00:00
Zoey Chen
8b0070a509
Merge "[Settings] Update the title if launch the fragment from search app" am: eef6d0cb24
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2331882
Change-Id: Ic4f9bb2f9fb07e9243dbb327f2ce0a41eeb9da0f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-12-07 09:29:48 +00:00
Zoey Chen
a3c97876bb
[Settings] Update the title if launch the fragment from search app
...
Bug: 245613972
Change-Id: I937a4acf0917a16660ff237d0511a5883864a1b9
Test: manual
Merged-In: I07bf9a8f59ea14fc8133e2473746a59a5c187d47
2022-12-07 07:18:42 +00:00
Bonian Chen
dc6877f2ef
[Settings] Add BT and WiFi reset option
...
Add an BT and WiFi reset option into factory reset menu.
Bug: 260034791
Test: local
Change-Id: I9031765cd5a012e3216971a3302176a96c2fbd23
2022-12-06 13:08:46 +00:00
Zoey Chen
11c5b96855
[Settings] Add metrics log
...
Test: manual
Bug: 260077175
Change-Id: I7d3ca64468e3fa957e79a6e1c14e49f9ef520d86
2022-12-05 06:53:55 +00:00
Jack Yu
64511c4934
Revert "Move the auto data switch preference into DDS sim"
...
This reverts commit 28ce6b9057 .
Reason for revert: b/253698164 was not approved by the UX team and discussed with the telephony team.
Change-Id: Ia02b3fb204fad83fee40ee05b908ad8ea56820a3
2022-12-01 22:28:52 +00:00
Ben Murdoch
f526772dcd
Merge "Revert "[Settings] configuration for hidding SIM settings UI"" am: 39d6e92554 am: 48dc0133ce
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2319949
Change-Id: I4edb11e2c2c71cc7ec4ff7b82ad18a3d6d5471d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-28 12:50:29 +00:00
Ben Murdoch
48dc0133ce
Merge "Revert "[Settings] configuration for hidding SIM settings UI"" am: 39d6e92554
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2319949
Change-Id: I7647c859fe8196e0af0e5c2871918f0940a9fe0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-28 12:25:02 +00:00
Bonian Chen
590abcbbf2
Revert "[Settings] configuration for hidding SIM settings UI"
...
This reverts commit 6477275296 .
Reason for revert: Build breakage
Log: https://android-build.googleplex.com/builds/branches/aosp-main-16k-throttled/grid?head=9340544&tail=9338589
Bug: 240515161
Merged-In: If1df99a79e51125d03f534cdfc9408b01c61024f
Change-Id: Ife727bc8b8bddafb58eed0d13d5d19fd1bf0a43e
2022-11-28 11:08:25 +00:00
Bonian Chen
011cdf6ef0
Merge "[Settings] configuration for hidding SIM settings UI" am: 697f570fad am: f7090ebbee
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2319109
Change-Id: I739f417c3d19b22bc102c9a1e0253692008bd370
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-28 08:50:08 +00:00
Bonian Chen
f7090ebbee
Merge "[Settings] configuration for hidding SIM settings UI" am: 697f570fad
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2319109
Change-Id: Iecaa9d4101864eaaeab0d5fc14277d39a9647682
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-28 08:24:30 +00:00
SongFerngWang
28ce6b9057
Move the auto data switch preference into DDS sim
...
Bug: 253698164
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AutoDataSwitchPreferenceControllerTest
Change-Id: I0aee5454e3a57a373b9eea2108c39335e4277f7b
2022-11-28 15:36:18 +08:00
Bonian Chen
6477275296
[Settings] configuration for hidding SIM settings UI
...
Hide SIM settings UI based on configuraion.
Bug: 240515161
Test: test cases and local testing
Merged-In: If1df99a79e51125d03f534cdfc9408b01c61024f
Change-Id: I13ae0909d0120039cdfe8298a6892195de2fb122
2022-11-25 22:57:50 +00:00
Bonian Chen
b644c54256
[Settings][port] configuration for hidding SIM related UI
...
Add overriable configuration for hidding SIM related UI.
Bug: 240515161
Test: test cases and local testing
Merged-In: Ie00bdce2fad429f2ed343e1d7aea4967bcaddf5a
Merged-In: Ie61557590cdc15e2d03b1e71bbc78def2c60046a
Change-Id: I67166b0db08635ee2bc01a8208f96126b64fd0a7
2022-11-25 13:54:35 +00:00
TreeHugger Robot
1793a5a322
Merge "Keep "Resetting your internet" when screen rotates" into tm-qpr-dev am: dc4b54c168
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/20519152
Change-Id: I979fff8af4a4da75a0fd0d173a6561032a78895e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-24 00:30:00 +00:00
Aswin Sankar
9adfa375ea
Revert "Remove "Backup Calling" button from Settings UI"
...
Revert submission 20541028-remove_backup_calling
Reason for revert: Disables backup calling on master builds
Reverted Changes:
Iff2665829:Remove "Backup Calling" button from Settings UI
I5523465a6:Remove "Backup Calling" button from Settings UI
Change-Id: I415cfddfb365dc8911f2ded418892ceb3834ba24
2022-11-23 21:17:51 +00:00
Bonian Chen
7fabcb2a37
Merge "[Settings] Add some log" am: 190b9ae3fa am: cd59cb983e am: 724dfbda22
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2313405
Change-Id: Icb61624f11f45e25dfb07c2d19e5386ce4c468bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-23 18:39:21 +00:00
Bonian Chen
724dfbda22
Merge "[Settings] Add some log" am: 190b9ae3fa am: cd59cb983e
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2313405
Change-Id: Ieb35b981079c558937f73ec3779018a1deaa56b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-23 16:27:42 +00:00
Bonian Chen
cd59cb983e
Merge "[Settings] Add some log" am: 190b9ae3fa
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2313405
Change-Id: I79999bda10e0be0df44fc73d8023e7f35d9f2730
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-23 15:59:17 +00:00
Bonian Chen
c2776e0e67
[Settings] Add some log
...
Add log to support debugging.
Bug: 259611847
Test: auto test
Change-Id: Ic7ea410604794e3b9caa8ab955e1406578a25425
2022-11-23 12:36:17 +00:00
TreeHugger Robot
926df61437
Merge "Keep "Resetting your internet" when screen rotates"
2022-11-23 08:18:03 +00:00
SongFerng Wang
d6189fab1c
Merge "Remove "Backup Calling" button from Settings UI"
2022-11-23 07:22:08 +00:00
SongFerngWang
fa589ca6f1
Remove "Backup Calling" button from Settings UI
...
Remove "Backup Calling" button from Settings UI, keep it always enabled.
Bug: 253698238
Test: build pass
Change-Id: Iff2665829e559ab7dce20e58a50ca75b8dcd6f83
2022-11-23 01:52:50 +08:00
Bonian Chen
8f936c0bdb
Merge changes from topic "revert-2299468-settings_without_siminfo-PZBVIDHEPA" am: 5125477d7b am: d33fbde071
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2310159
Change-Id: Idc1ee6fcf8fc403ed9592adf34417ebe2b15b7da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-22 14:28:07 +00:00
Bonian Chen
4e1a1e65b9
Revert "[Settings] configuration for hidding SIM settings UI" am: 8e98f5a852 am: e4fbf9d941
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2310157
Change-Id: I1bcbe2f57013ace3641937897ae2d0d8b64e2f76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-22 14:28:05 +00:00
Bonian Chen
d33fbde071
Merge changes from topic "revert-2299468-settings_without_siminfo-PZBVIDHEPA" am: 5125477d7b
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2310159
Change-Id: Ic919498fda4172ede68fcd431b8bdd18056fada6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-22 14:08:33 +00:00
Bonian Chen
e4fbf9d941
Revert "[Settings] configuration for hidding SIM settings UI" am: 8e98f5a852
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2310157
Change-Id: I76eae77bcd825e7fa5fbc12b46eb72a7f9ddfd02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-22 14:08:31 +00:00
Bonian Chen
a1c1bd0f81
Revert "[Settings] configuration for hidding SIM provider UI"
...
Revert submission 2299468-settings_without_siminfo
Reason for revert: Fix build breakage
Reverted Changes:
I3d6ecec14:[Settings] configuration for hidding SIM settings ...
I8f0c1d53c:[Settings] configuration for hidding SIM remove UI...
I1b88f0f70:[Settings] configuration for hidding SIM notificat...
Ibe22c3ba3:[Settings] configuration for hidding SIM provider ...
Id5ea14ca8:[Settings] configuration for hidding SIM related U...
I70be07dbc:[Settings] configuration for hidding SIM lock UI
Log of breakage:
https://android-build.googleplex.com/builds/submitted/9318826/full-eng/latest/view/logs/build_error.log
Bug: 260055628
Merged-In: I1cb83787dc1ac1d61bb6bed6aa9c5e7a3ad6e69b
Change-Id: If1951dde860bb49e3ea4cd5603ed92ef18bd1f0d
2022-11-22 11:59:26 +00:00