Commit Graph

37515 Commits

Author SHA1 Message Date
TreeHugger Robot
a27c8d91dd Merge "Properly set all data fields" into sc-dev 2021-06-30 18:58:13 +00:00
Julia Reynolds
b61b739661 Properly set all data fields
So stale data doesn't stick around when the view is recycled

Test: manual:
- dismiss a notification
- set a short timer (a custom view notif)
- check history after timer expires (so there are 2 notifs in 'recently
dismissed')
- stop the timer and check history
- there are now 3 notifs and no stale text in any of them
Fixes: 192294011

Change-Id: I229a0388a703b9df0d92eec81066a9a2f67e183e
2021-06-30 12:59:28 -04:00
Joshua Mccloskey
b182a4fb5c Refactored bad_calibration string
Test: Manual
Bug: 192105305
Change-Id: I82b0965459537c940b269636b8277af89b5ad284
2021-06-30 09:16:20 -07:00
bsears
c358adad56 Revert "Return enrollment consent status to caller."
This reverts commit eb1dac69f0.

Reason for revert: Based on bisection, this CL is the root cause for bug 192420564, which breaks Setup Wizard.

Bug: 192420564
Change-Id: I8d9aee7fe2415e134fcc981b0548bd9ce300db55
2021-06-30 14:53:13 +00:00
Alex Johnston
0ad4783163 Fix Settings usb preference search
* Invert isPageSearchEnabled check

Bug: 192449168
Test: manual testing with TestDPC
Change-Id: I91dcf930485ad16a83cb04bf170c9608c1768ea2
2021-06-30 14:36:23 +00:00
Alex Johnston
8d06d63fe3 Remove credential management app Settings
* Update string and icon
* Flip icon if languate is RTL e.g. Arabic
* Add dialog when 'Remove app' is selected
* Add Material Next theme to dialog
* Update string terminology when removing a
  CA or user certificate to from 'remove'
  to 'uninstall'
* Final UI tweaks to RequestManageCredentials screen

Screenshots
* Light mode: https://screenshot.googleplex.com/66QKFLhtn6ZueZQ
* Dark mode: https://screenshot.googleplex.com/9kkTaaDV6CiHudF
* RTL: https://screenshot.googleplex.com/AkwSibXakARYM8H
* Request light mode: https://screenshot.googleplex.com/6n6raBQ8drXRHcU
* Request dark mode: https://screenshot.googleplex.com/3bmWNoTwE6JBqAX

Bug: 189416800
Test: atest CredentialManagementAppButtonsControllerTest
      manual testing with TestDPC
Change-Id: I5450d33603418930e92b03c4447aaa1095afe9a3
2021-06-30 13:53:58 +00:00
Jason Chiu
c38978f3e1 Guard against the exceptions when launching a non-existing fragment
Test: robotest
Bug: 190371550
Change-Id: I2bb7d4bdb23756634526db7e272563a1587c9640
2021-06-30 18:33:59 +08:00
TreeHugger Robot
cb00a65a0d Merge "Fix 'No Apps' UI issues of ManageApplications" into sc-dev 2021-06-30 09:47:11 +00:00
Stanley Wang
8cd20c0bb1 Merge "Update Adaptive connectivity page." into sc-dev 2021-06-30 09:23:51 +00:00
Stanley Wang
e722fbe277 Update Adaptive connectivity page.
- Use MainSwitchPreference.
- Use the TopIntroPreference to display the summary.
- Use the IllustrationPreference to display the stastic
  illustration.
- Add new illustrations for adaptive connectivity.

Fix: 178673083
Test: robotest and test the switch preference manually
Change-Id: I2376f4433b61ce1d3da287de92660fbeea5dd64e
2021-06-30 16:12:17 +08:00
Peter Wang
baecf00ce2 Merge "Add a cancel string for ToggleSubscriptionDialog to handle Tamil translation" into sc-dev 2021-06-30 06:52:43 +00:00
TreeHugger Robot
d8cd67b52d Merge "Password settings: Fix duplicate title" into sc-dev 2021-06-30 06:35:33 +00:00
Stanley Wang
913fbf7e0c Change the illustration in one-hand mode page.
- Different one-hand modes need to display different illustrations.

Fix: 191334556
Test: rebotest and see the UI
Change-Id: Id6edba40142e008c618fdb3536424edd2b77f9b0
2021-06-30 13:47:34 +08:00
PETER LIANG
1a77fce131 Merge "Replace the AnimatedImagePreference with IllustrationPreference." into sc-dev 2021-06-30 00:38:20 +00:00
Ahaan Ugale
437c037830 Password settings: Fix duplicate title
For the autofill service settings, "Autofill service" is both the
section title and the preference title. This change removes the
duplicate preference title and promotes the app label from the summary
string to the title in its place.

Fix: 192403526
Test: manual - single profile, personal+work profile, change service and
 re-check
Change-Id: Ia012232ba2856e0757289982bc3045d948ff4aa8
2021-06-29 17:21:01 -07:00
TreeHugger Robot
ca61c3919e Merge "Fix buttons and icons for fingerprint enroll intro" into sc-dev 2021-06-29 22:20:03 +00:00
Peter Wang
eba8857094 Add a cancel string for ToggleSubscriptionDialog to handle Tamil
translation

Bug: 185553806
Test: Build
Change-Id: I90149c9e4459747d8cd1c35d00c29f81710eb6f4
2021-06-29 15:08:00 -07:00
Curtis Belmonte
218187bcce Fix buttons and icons for fingerprint enroll intro
Updates the labels of buttons and the colors of icons shown on the
fingerprint enroll intro screen to be consistent with the face enroll
intro screen and match the latest mocks.

Note that this commit removes some unused strings but does not add any
new ones requiring l10n.

Test: Manually tested face enroll from Setup Wizard and Settings

Fixes: 192381823
Change-Id: Id991d4f29d6de82acd538f1853bc8a5e50cd2637
2021-06-29 14:05:27 -07:00
TreeHugger Robot
b36bbc55d1 Merge "[Settings] Pass the system user to launch the web help page" into sc-dev 2021-06-29 18:55:24 +00:00
Jan Tomljanovic
2b8678c5d4 Merge "Enable controllers to use a custom key." into sc-dev 2021-06-29 16:02:55 +00:00
TreeHugger Robot
a375349c0a Merge "[Provider Model] Fix the "Cancel" button issue in the reminder dialog" into sc-dev 2021-06-29 13:13:04 +00:00
TreeHugger Robot
80fd8a7cce Merge "[Provider Model] Hide Connectivity Subsystems when recovering" into sc-dev 2021-06-29 13:11:14 +00:00
TreeHugger Robot
b121a52359 Merge "Fix the multiple instences of NetworkProviderSettingsActivity issue" into sc-dev 2021-06-29 13:10:54 +00:00
TreeHugger Robot
c8abbc4d8d Merge "Improve pointerSpeedPreference a11y content description" into sc-dev 2021-06-29 10:05:06 +00:00
Stanley Wang
09134b237c Merge "Fix the problem that the ToggleSubscriptionDialogActivity appears twice when switch changed." into sc-dev 2021-06-29 09:48:54 +00:00
Weng Su
5796ebf67f Fix the multiple instences of NetworkProviderSettingsActivity issue
- Use the command "adb shell dumpsys window" to dump how many
activities/windows currently on the system.
  Then search for section like "Task display areas in top down Z order"

Bug: 191956700
Test: manual test
Use "adb shell dumpsys window" to check no more multiple instences

Change-Id: Ie9e04db3db601fbeee9beceedb81929cd6eba439
2021-06-29 17:15:55 +08:00
Yanting Yang
995e5fbd6e Merge "Improve the latency of first entering Apps page" into sc-dev 2021-06-29 08:25:53 +00:00
Weng Su
d2fb4f06a3 [Provider Model] Fix the "Cancel" button issue in the reminder dialog
- Do nothing if user cancel to turn off mobile data

Bug: 192052695
Test: manual test
atest -c ProviderModelSliceTest

Change-Id: Ib4b990a1f3f51a6bf11552a6018c73f8d7105736
2021-06-29 16:08:20 +08:00
Jernej Virag
5b8cc84c04 Merge "Update power button gesture menu" into sc-dev 2021-06-29 07:52:09 +00:00
TreeHugger Robot
d60eae5539 Merge "Password settings: Fix UI flicker from loading summary" into sc-dev 2021-06-29 07:21:49 +00:00
Stanley Wang
ec95ed2650 Fix the problem that the ToggleSubscriptionDialogActivity
appears twice when switch changed.

- Don't trigger the switch change event if the state of Switch and
  SwitchSettingsMainSwitchPreference are the same.

Fix: 190767461
Test: robotest and operate the switch preference manually

Change-Id: I6ab4b7e5ca1455948ca9118bb4a674fdc4fdbd50
2021-06-29 14:55:15 +08:00
TreeHugger Robot
53124fa7b3 Merge "Fix the non-working DND toggle" into sc-dev 2021-06-29 06:35:55 +00:00
Ahaan Ugale
f0d8071bc6 Password settings: Fix UI flicker from loading summary
Adds a placeholder summary string so the UI doesn't shift when the
summary is updated.

Also disables debug logging.

Fix: 191939601
Test: manual
Change-Id: If6027f101a6bad022501f7ba6c6ab576341f0ce4
2021-06-28 23:15:28 -07:00
Yi-Ling Chuang
6a83c73624 Fix the non-working DND toggle
The pendingIntent of the DND toggle was set to immutable previously
which doesn't allow any modification. This CL fixes this by making it
mutable.

Fixes: 191865710
Test: Search "dnd" and make sure the toggle has effect upon modification
Change-Id: Iade256cee8885cb80ade5ca95cc50065c2a78da2
2021-06-29 12:46:08 +08:00
Wesley Wang
4c1b805cef Merge "Update batteryDiffEntry filter condiction" into sc-dev 2021-06-29 04:17:29 +00:00
Tiffany Nguyen
dc93eda197 Merge "Log Battery Saver states." into sc-dev 2021-06-29 04:13:02 +00:00
Joe Bolinger
8d5b841fb1 Merge "Return enrollment consent status to caller." into sc-dev 2021-06-29 02:41:55 +00:00
Joe Bolinger
eb1dac69f0 Return enrollment consent status to caller.
Bug: 188847063
Test: adb shell am start -a android.settings.BIOMETRIC_ENROLL --ez require_consent true
Change-Id: I3285b379e175539c37355c67749c3d900e6ac62b
2021-06-28 17:51:46 -07:00
Jernej Virag
34cbca502b Update power button gesture menu
This renames the menut to fit within other gesture options. It also properly implements subtitle behaviour in gesture menu and adds a hint on how to invoke the power menu on new Pixels.

Bug:191899039
Bug:168176408
Bug:189506870
Test:  Unit tests for package com.android.setttings.gestures.*
       Manually on device

Change-Id: I985a97514ca142d554ab2aafd61a6219cc1a3dd6
2021-06-28 20:27:03 +00:00
arangelov
8fca8dc092 [Settings] Pass the system user to launch the web help page
Fixes: 191727929
Test: manually observed the policy transparency dialog
with launching the admin policies screen
Test: manually observed the policy transparency dialog
with launching the web help page

Change-Id: If0d10b30a5e5f2a1bade168f049c8613055289e7
2021-06-28 20:14:16 +01:00
Mill Chen
968151aa18 Merge "Add line spacing multiplier for CollapsingToolbarLayout" into sc-dev 2021-06-28 17:34:01 +00:00
Yanting Yang
ca0415d475 Merge "Clear legacy code about AppAndNotificationDashboard" into sc-dev 2021-06-28 12:54:44 +00:00
Tiffany Nguyen
f9416e6a40 Log Battery Saver states.
Test: Unit test
Bug: 189914747

Change-Id: Ib815e60a52ec549df2ab2b90df29bca1eeeef339
2021-06-28 11:22:20 +00:00
Mill Chen
139fa375cd Add line spacing multiplier for CollapsingToolbarLayout
Since there is a problem with a small line spacing between multiline
title of collapsing toolbar in a few locales, that caused the title is
overlapping with each other. Enlarging the line spacing by using
lineSpacingMultiplier to fix it.

Fix: 183223866
Test: visual verified
1) Change to MY locale
2) Navigate to Settings > Sounds & vibration > Do not disturb > Alarms &
other interruptions
3) Observe the title and check if it is overlapping with each other

Change-Id: I87f0af5151a6367bc623ac07b15e04c39b51c6ca
2021-06-28 18:39:20 +08:00
Yanting Yang
4124284bb7 Improve the latency of first entering Apps page
Root cause:
AppsPreferenceController will query the recent app usages twice on
the main thread.

Solution:
Set flag to ensure only triggering refreshUi() once when entering
the Apps page.

Also correct the preference key of apps.xml since we don’t have
duplicated preferences now.

Fixes: 183176038
Test: robotests & visual
Change-Id: Ia41ee1e4a1946b8122deca63e318d3915afcc426
2021-06-28 18:30:39 +08:00
Bonian Chen
d9bf670725 Revert "[Settings] Code Refactor - ActiveSubscip..."
There seems to be an issue on system when a modification on file name get referenced by multiple submit(s).
(ag/15106410 and ag/15102785).

It seems to me that, build system got build breakage immediately instead of merging all of the files (even within same package).

Reason for revert: Try to submit all of the modifications within single submit as a workaround.

Bug: 192204057
Test: build pass
Change-Id: Ie497088a58c6ac564fde193fad2c0b67a965933c
2021-06-28 09:32:54 +00:00
Weng Su
7a45b33c42 [Provider Model] Hide Connectivity Subsystems when recovering
- Hide Carrier Network

- Hide Wi-Fi toggle

- Hide all of Wi-Fi Networks

Bug: 186590805
Test: manual test
atest InternetResetHelperTest
atest NetworkMobileProviderControllerTest
make RunSettingsRoboTests ROBOTEST_FILTER=NetworkProviderSettingsTest

Change-Id: Ib8462f890847d14bfc6ef533d1147822fd797a13
2021-06-28 17:19:13 +08:00
Edgar Wang
92d2c96c1d Improve pointerSpeedPreference a11y content description
Fixes: 189725080
Test: manual
Change-Id: I1638acd986fd791c2fbb7b69decda1bc461dee74
2021-06-28 16:22:23 +08:00
Bonian Chen
4c4d8e3a08 Revert "[Settings] Fix build breakage"
Revert submission 15102785-Fix build break of refactor ActiveSubscriptionsListener

Reason for revert: Build breakage.
Reverted Changes:
I9ae819f06:Revert "Revert "[Settings] Code Refactor - ActiveS...
I15819472b:[Settings] Fix build breakage

Change-Id: Ifb1a579863df157b41aebbdf59ad7e4584efa866
2021-06-28 05:23:33 +00:00
Bonian Chen
69fc8e0ccd Revert "Revert "Revert "[Settings] Code Refactor - ActiveSubscip..."
Revert submission 15102785-Fix build break of refactor ActiveSubscriptionsListener

Reason for revert: Build breakage.
Reverted Changes:
I9ae819f06:Revert "Revert "[Settings] Code Refactor - ActiveS...
I15819472b:[Settings] Fix build breakage

Change-Id: Ib830b7b00504264a703a03a00bfdfcf65135d394
2021-06-28 05:23:33 +00:00