Commit Graph

1771 Commits

Author SHA1 Message Date
Amin Shaikh
e2815e033d Remove duplicate ic_menu_add_white.
Bug: 123829919
Test: mp settingsg
Change-Id: I88e0dde22762eb6bc019361222ffe783b1c15133
2019-02-04 17:59:29 -05:00
markchien
1dd1d79d90 Support entitlement check in DSDS
Get resource from preferred SIM's subId.

Bug: 122108346
Bug: 120069528
Test: atest TetherServiceTest
Change-Id: Ia4279a418dfa6cd14942b7f4d2a313156066381b
2019-02-04 18:55:16 +08:00
Antony Sargent
e13d04c762 Add dialog for changing display name for mobile network
This CL adds a pencil/edit icon at the top of the mobile network details
page. When clicked, it brings up a dialog that allows the user to set
the display name used for that mobile network - this is most useful in
multi-SIM situations. This dialog also displays the mobile network
operator name and phone number which can help the user keep straight
which one they are renaming.

Bug: 122670283
Test: make RunSettingsRoboTests
Change-Id: Ifd63cfb66ce743bd5ba8a06b52229f06ed56b7bd
2019-01-31 12:54:43 -08:00
Antony Sargent
59adc31773 Add a plus button to the mobile pref on Network & internet page
On the Network & internet page, we have a "Mobile network" pref that in
single-SIM mode leads to a detail page for the current SIM. In multi-SIM
mode it has more complicated behavior (leading either to details about
the current subscription if there is only one, or a list of
subscriptions if more than one).

One of the things we wanted to add was a shortcut to add another eSIM
subscription. So this CL adds a plus button control on the right of the
preference which leads to a flow to add another mobile subscription via
the eSIM manager.

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: I38e0031e3bd603e93c45dcb4557750e7bc1b8b5a
2019-01-29 12:27:46 -08:00
TreeHugger Robot
4918eedefb Merge "Add Subscription ID to extra when start carrier settings activity." 2019-01-24 21:11:07 +00:00
mavishsu
04bcb42d9c Add Subscription ID to extra when start carrier settings activity.
Bug: 123325237
Test: Manual test
Change-Id: I48cda996bca699e97866ae0d1b7221266cf38df2
2019-01-24 15:20:55 +08:00
Antony Sargent
ff484e11e9 Add default calls/SMS subscription prefs to mobile details page
This adds prefs to the the details page for mobile network subscriptions
that appear in multi-SIM mode. They show which subscription is set as
the default for calls and SMS respectively, and let the user change what
the default is for each. They can be set to either a specific
subscription, or set to "Ask every time".

Bug: 122670283
Test: make RunSettingsRoboTests
Change-Id: Id2b23e4b5c3d1b5c04b5766e73fc8202c05d8f75
2019-01-22 16:59:14 -08:00
TreeHugger Robot
ac73d4e721 Merge "Add data usage header to mobile network details page" 2019-01-19 07:17:33 +00:00
TreeHugger Robot
27c0acbfc9 Merge "Use correct metrics value in MobileNetworkListFragment" 2019-01-19 07:08:25 +00:00
Antony Sargent
210268db3c Use correct metrics value in MobileNetworkListFragment
Bug: 116349402
Test: n/a
Change-Id: I01a81be496c296538e3395931a0fed8098f4da99
2019-01-18 09:36:32 -08:00
Antony Sargent
625787b391 Add data usage header to mobile network details page
As a part of the work for subscriptions UI improvements, we want to show
data usage information at the top of the mobile network details page,
and those details need to be specific to the particular subscription
we're showing details for, even if that SIM isn't the current default
one. This is useful for seeing data usage across your SIMs in dual-SIM
devices.

This CL adapts our already existing DataUsageSummaryPreferenceController
class so that if can be used on any fragment instead of just the
DataUsageSummary one, and changes it to take an explicit subscription
id instead of assuming it should use the default one.

Bug: 122670283
Test: make RunSettingsRoboTests
Change-Id: I41e307b0f32580c73b08adec7cabf01c96d7e835
2019-01-17 21:50:27 -08:00
Fan Zhang
31b210017b Migrate all MetricsProto enums to SettingsEnums
Bug: 122855168
Test: rebuild
Change-Id: I962d9a71179f86b7cae9dc5e9a00e0aa1557dc76
2019-01-17 14:55:42 -08:00
Xiangyu/Malcolm Chen
4c62693cd0 Merge "Don't show hidden Cellular subscription in Settings." 2019-01-16 22:00:50 +00:00
Malcolm Chen
14dde50c3a Don't show hidden Cellular subscription in Settings.
Replace getActiveSubscriptionInfoList() with
getActiveSubscriptionInfoList(true) so that settings will not show
hidden subscriptions to the user in various pages.

Bug: 121396526
Test: manual
Change-Id: I717999fed7d3a5a037914239694bef52df7c6207
2019-01-16 00:21:30 -08:00
Antony Sargent
33340366aa Remove the multi-SIM bottom nav in network and internet v2 mode
When a device has multiple SIMs, at the bottom of the SIM details page
we show a chooser with an icon for each SIM card. This UX design is
being supplanted by the new network and internet v2 design where there
is a list of networks you can get to from the Network & internet
homepage. So when the v2 mode is turned on, we don't want that bottom
navigation to appear.

Bug: 116349402
Test: visual (will remove existing tests for this feature eventually)
Change-Id: I9cae479a1f4e689adcc4f4262661b10edbbbf2d3
2019-01-15 21:59:20 -08:00
Antony Sargent
f4ee4ef3bf Add page listing multiple mobile networks
When a device supports simultaneous connection to multiple mobile
networks, we want the "Mobile network" entry on the Network & internet
page to list the number of active SIMs and when clicked, go to a page
that lists them all.

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: Ie642d7801cda07dcbbe74d42c234db6605566be4
2019-01-15 21:57:39 -08:00
TreeHugger Robot
532c3d7200 Merge "Make Network & internet v2 feature flag be persistent" 2019-01-09 01:18:21 +00:00
Antony Sargent
0a830d4f48 Make Network & internet v2 feature flag be persistent
In ag/5386198 we added a flag to turn on the new features of the network
and internet settings page, but that flag resets to the default value
(currently false) every time you reboot, which is annoying and hostile
for dogfooders. This CL makes the flag persistent.

Bug: 116349402
Test: manual / should be covered by existing tests
Change-Id: I098073e81feb199751e967a9652bec6a6445b95e
2019-01-08 14:17:39 -08:00
TreeHugger Robot
2dbdc888c3 Merge "Fix TODO for mobile network settings" 2019-01-07 20:24:13 +00:00
jackqdyulei
b5ce3cd9b0 Fix TODO for mobile network settings
1. Add intent filter to MobileNetworkActivity(new page)
2. Add metrics id
3. Remove obsolete TODOs

Bug: 114749736
Test: Manual
Change-Id: I36f41983dc8cc36ccdf548174fc494044ec1b241
2019-01-04 15:55:09 -08:00
Stanley Wang
242502e5a9 Fix WiFi calling option is showing in search result regardless the carrier supports VoWiFi or not
Change Availability Status to UNSUPPORTED_ON_DEVICE when device doesn't
support VoWiFi.

Change-Id: I8ac501cf7442f1cd7d41f61d2db912d82a9e8c25
Fixes: 120806624
Test: manual and robotests
2019-01-03 13:11:25 +08:00
Pengquan Meng
20e6b01327 Merge "Add PreferenceChangeListener to ApnSettings" am: 66d28c3e37 am: 9745ec5421
am: 1f2ba13698

Change-Id: I6f62e47e04e74cd1d2d9ec7fa3b35032ab8c3ad6
2018-12-27 16:08:07 -08:00
Pengquan Meng
66d28c3e37 Merge "Add PreferenceChangeListener to ApnSettings" 2018-12-27 23:36:18 +00:00
Pengquan Meng
2f434aa7ca Add PreferenceChangeListener to ApnSettings
The PreferenceChangeListener was removed from aosp/779634, when the
selected apn is changed, the result is not saved to the database.

In this CL, we add the PreferenceChangeListener back.

Bug: 121229775
Test: build & manual test
Change-Id: Ief1a2e05c072e5eff8060731b044c19878d346be
2018-12-27 13:27:26 -08:00
Pengquan Meng
92da0c0005 Merge "Set default value for mobile listPreference" 2018-12-23 02:18:20 +00:00
jackqdyulei
6d70582054 Set default value for mobile listPreference
In some cases we don't set value for listPreference, so we need to set
a default one. This is a bug from code migration.

Change-Id: I8072b2a288a6a1254dceabea963f19459b0a9011
Fixes: 119770064
Test: RunSettingsRoboTests
2018-12-21 15:34:42 -08:00
Calvin Pan
e90a5a6812 Merge "Rename SIM_APN_LIST to SIM_APN_URI" am: d594716359 am: a49da46d96
am: 8c758f5ce7

Change-Id: Idbefe3b3cd87e4702852defa7382c30ff8f98e50
2018-12-20 18:34:36 -08:00
Antony Sargent
8e57fedc95 Make taps on subscriptions in multi-network header go to mobile page
This CL does 2 things:

-Makes the MobileNetworkActivity class capable of showing details for
 "available" in addition to just "active" networks. This is useful for
 dual-standby devices where one subscription is active and another is
 registered but not currently active. It also changes the title of this
 screen to be the network display name (defaults to the carrier name
 but can be customized by the user) instead of the generic "Mobile
 network".

-Wires up the subscription entries in the multi-network header (which
 only appears when a device has multiple subscriptions) so that taps on
 a subscription preference bring you to the MobileNetworkActivity screen
 to show details for that network.

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: I0e985652c1d8ec3c597b6b6e4426d222e2ad5352
2018-12-20 09:03:34 -08:00
calvinpan
9b56a8b278 Rename SIM_APN_LIST to SIM_APN_URI
In Telephony SIM_APN_LIST had been rename to SIM_APN_URI.

Bug: 120031619
Test: Build pass.
Change-Id: I203c765c7ba6ee468f76dbfdb84b50c787ac8dbe
2018-12-20 07:09:42 +00:00
Antony Sargent
74cb72433a Add wifi connection info to the multi-network header
The Network & internet page will have a dynamic header at the top when
users have more than one mobile subscription, showing information about
connectivity.

This CL adds a preference to this header when there is a wifi connection,
showing the same information as on the wifi-page (connection strength,
speed rating if available, etc.).

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: Ia80d6e236a4996b501372ac4cd8e46ba6c5f8841
2018-12-17 13:46:40 -08:00
Antony Sargent
e92e07eb97 Add subscriptions list to the multi-network header
The new UX for showing multiple active mobile plan subscriptions (SIMs,
eSIMs, etc.)  needs a header at the top of the Network & internet page
that shows wifi status and a list of active mobile subscriptions in the
form of one Preference per subscription.

This CL adds display of the mobile subscriptions to this header. It does
not yet show the correct summary text or do anything when you tap on
them - that will be coming in subsequent CLs. Also, since adding a
variable number of items to the top of the page messes up our current
strategy of having a fixed number of hidden items at the bottom based on
overall item count, this CL just makes all items visible. Subsequent CLs
can restore this behavior with dynamic adjustment.

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: Ibfadf8cb61f6f5aff6ce38b7974267b1e4ddc719
2018-12-17 13:26:13 -08:00
Josh Hou
e519cd6e68 Refine APN fetching logic
APN fetching logic has been encapsulated in URL_SIM_APN_LIST API in
TelephonyProvider

Bug: 115709816
Test: Live network test
Change-Id: I735bc50e912dfbec0903fbcafdc4d6eaa6ccfc7b
Merged-In: I735bc50e912dfbec0903fbcafdc4d6eaa6ccfc7b
2018-12-17 07:16:50 +00:00
TreeHugger Robot
c53717f5d7 Merge "Add a helper class for listening to subscription and airplane mode changes" 2018-12-11 07:11:57 +00:00
TreeHugger Robot
625646a55c Merge "Add a helper class for filtering available subscriptions" 2018-12-08 01:13:24 +00:00
Antony Sargent
b33f74192c Add a helper class for listening to subscription and airplane mode changes
For the new multi subscriptions UX, in several places we need to listen
for both subscription changes (eg a sim card was inserted or removed),
as well as airplane mode changing state. This combines those in one
helper class that can be reused.

Bug: 116349402
Test: make RunSettingsRoboTests
Change-Id: Ibcbb669ae291a917f89735dbda043742efaa58c9
2018-12-07 15:40:00 -08:00
Antony Sargent
270296ea23 Add a helper class for filtering available subscriptions
In several places implementing the new changes for better UX with
multiple mobile subscriptions, we need a bit of code that filters the
results coming from the SubscriptionManager. This CL adds that common
code in a util class that will be used in later CLs.

Bug: 116349402
Test: RunSettingsRoboTests
Change-Id: Ie9376629604ac2c4a2f15123edc380c5999f2f83
2018-12-07 13:40:28 -08:00
Chen Xu
f80e5b561e Merge "address API council feedbacks for Telephony.Carriers" 2018-12-06 20:11:18 +00:00
Antony Sargent
2b0c991efc Merge "Layout changes in v2 Network & internet page" 2018-12-06 18:55:42 +00:00
Xiangyu/Malcolm Chen
c8b7207edb Merge "Only enable data for one SIM in DSDS." 2018-12-06 01:25:07 +00:00
Malcolm Chen
42055cbe50 Only enable data for one SIM in DSDS.
Only enable mobile data for one SIM for simplicity. Which means When
turning on mobile data on non-default sub, pop a notification to user
that it will turn off data of the other one.

Bug: 120515679
Test: manual and unittest
Change-Id: I7c190bb70d771b7f280c246038a380e4fc7338a3
2018-12-06 01:24:58 +00:00
Antony Sargent
11b7c7f254 Layout changes in v2 Network & internet page
This adds the skeleton of a header section which will only appear when
the device has two or more active mobile subscriptions. Subsequent CL's
will add the actual logic implementing it.

Also this moves up the airplane mode toggle higher up on the page, and
removes the proxy selector entry (which has been unconditionally
disabled by the ProxyPreferenceController for a while).

Bug: 116349402
Test: manual (this is mostly a layout change - subsequent changes will
have actual logic to test for the subscriptions header)

Change-Id: Iaee338d5c13e05d3c2d9d04872a94cf90e5da588
2018-12-05 14:18:45 -08:00
Raff Tsai
626c6e0b17 Replace SliceAction deprecated method
- Replace new SliceAction with SliceAction.createDeeplink() or
SliceAction.create()

Test: make RunSettingsRoboTests
Change-Id: Ied34469d2220d8220a2dcc6c2fb4d32dd9cd9b8c
Fixes: 119879284
2018-12-01 06:21:01 +08:00
chen xu
54d5a727c1 address API council feedbacks for Telephony.Carriers
Bug: 118296421
Test: telephony unit test
Change-Id: Idf8bcad4fe9d765a73563e9b0c1c659175835447
Merged-in: Idf8bcad4fe9d765a73563e9b0c1c659175835447
2018-11-29 23:20:13 -08:00
chen xu
3b76d0f9ef address API council feedbacks for Telephony.Carriers
Bug: 118296421
Test: telephony unit test
Change-Id: Idf8bcad4fe9d765a73563e9b0c1c659175835447
2018-11-29 23:13:18 -08:00
Fan Zhang
53f75f0df9 Move all custom slice uris to a registry class.
Change-Id: I192320f95ac81d14c8891ce2531d603912e59f56
Fixes: 119776308
Test: robotests
2018-11-29 16:41:21 -08:00
Josh Hou
170afc4827 Merge "Refine APN fetching logic" 2018-11-28 22:24:35 +00:00
Matthew Fritze
71a255968f Merge "First commit for settings panels" 2018-11-27 17:34:22 +00:00
Josh Hou
1e1d6d1466 Refine APN fetching logic
APN fetching logic has been encapsulated in URL_SIM_APN_LIST API in
TelephonyProvider

Bug: 115709816
Test: Live netwrk test
Change-Id: I735bc50e912dfbec0903fbcafdc4d6eaa6ccfc7b
2018-11-27 15:59:39 +08:00
Matt Fritze
90899e08f0 First commit for settings panels
Establish the Activity which hosts Settings panels through the
PanelFragment. The Activity's purpose is to validate the intent
data coming in, including:
- Called with startActivityForResult (so we can log who is calling)
- Intent has the proper intent extra to link to a Panel

The fragment takes the Panelable data and builds a Settings Panel.
Each panel will have:
- Title
- List of Slices
- Link to underlying content

The Panelable interface is created to provide all of those datums, and
the new FetureProvider provides the Panelables by linking them with
keys. The keys will eventually become public APIs with CTS tests.For
now, we store them locally.

I included an exmaple panel, the InternetConnectivityPanel which
currently shows Wifi and Airplane mode.

Screenshot: https://screenshot.googleplex.com/c6sv7ZzQ5OJ
Bug: 117804089
Test: make -j40 RunSettingsRobotest
Test: Manual app
Change-Id: I1932f7179cc32088acd6413a736901ddf9651892
2018-11-26 15:26:02 -08:00
Youming Ye
976ca1c4c7 Merge "Display a toast to notify user that Preset APN setting cannot be viewed" am: a995cb334b am: e29c62ea04
am: e5e4e4cb76

Change-Id: Ic4c41e88c28a322d54a8489844b6ef0ff041d3a1
2018-11-26 14:09:21 -08:00