Commit Graph

88 Commits

Author SHA1 Message Date
Matthew DeVore
1fb8fb0b4f Show border highlight when dragging display
In the process of adding highlight we use an extra feature of
LayerDrawable to add insets so that we can add padding without changing
the actual dimensions or position of the DisplayBlock Views.

To make it easier to keep the values consistent and to aid in conversion
between px and dp, use dimen values to store padding and highlight
metrics.

Bug: b/352650922
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: atest DisplayTopologyPreferenceTest.kt
Change-Id: I51ff2ce4a086e84a0c529346f8ede90430090b11
2025-01-23 23:26:53 -06:00
Pat Manning
b50acbfeea Update pointer fill option backgrounds for color contrast and touch
target size.

Fix: 374885995
Fix: 374886964
Test: Manual.
Flag: EXEMPT Bugfix.
Change-Id: Ibf09bfae4a93868ac3605748854ccaaa10847eb6
2024-12-18 14:56:45 +00:00
Marcelo Arteiro
8577c10535 Migrate materialColor* attributes into colors
The new color were already introduces in a previous CL ag/30322786

This CL is about replacing the attribute usage by the new color resources, which should work the same but cannot be overwritten, or styled, guaranteeing consistency across the OS.

The old attributes will be removed in CL: ag/29910036

Bug: 374273611
Test: presubmit
Flag: EXEMPT Un-flaggable refactor of private color resources
Change-Id: I05b5261054bcb6de40e4e40d633025495f3dd01f
2024-12-06 16:55:33 +00:00
Matthew DeVore
6f28e1a3c7 Topology pane in extended displays list
Show an empty topology pane in the extended displays list. Even show
when no external display is connected.

This will be tweaked in a follow-up CL to include the built-in display
in the pane and the displays list.

This fixes an issue where the displays list is not shown when *no*
external displays are connected, which was not the intent of the flag.
The previous flag CL ag/30358161 only respected the flag when 1 external
display was connected.

Based on mocks at go/al-mm-figma

Bug: b/352650922
Test: reboot with zero displays attached and verify display list and pane are shown
Test: on al-13 device, make the activity fullscreen and verify the margins on left and right of pane are larger
Flag: com.android.settings.flags.display_topology_pane_in_display_list
Change-Id: If39fefe943a26c817fa6f636f21eb8aaa080adde
2024-11-25 12:06:04 -06:00
Pat Manning
4a552541aa Style changes for Pointer fill color settings.
Fix: 362455374
Test: Manual. Visual Changes only.
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: Id7a9d7eef540ea33f6bb47451b3d5c25328f9707
2024-09-16 14:01:55 +00:00
Marcus Ge
ff99e1f72f Merge "[Settings] Migrate color roles to respect color contrast" into main 2024-05-07 18:17:14 +00:00
mxyyiyi
03fdbbe504 Use material color res from settingslib for battery tips card
Settings Anomaly Card
[Before-Dark] 	https://screenshot.googleplex.com/5PZC6mbWjqunvuv
[Before-Light] 	https://screenshot.googleplex.com/7eoF6yLX6t3JeHz
[After-Dark]  	https://screenshot.googleplex.com/5j4mQFDXjkVcxHs
[After-Light] 	https://screenshot.googleplex.com/5ySzfzft9293GXb

App Anomaly Card
[Before-Dark] 	https://screenshot.googleplex.com/JKkcqCiAKxkPZds
[Before-Light] 	https://screenshot.googleplex.com/ASB4CnDhPjsQohH
[After-Dark]  	https://screenshot.googleplex.com/5y3LVvng54vndi9
[After-Light] 	https://screenshot.googleplex.com/NCJeuViCtDcNhiV

Bug: 339130556
Test: atest SettingsRoboTests:com.android.settings.fuelgauge.batteryusage
Change-Id: I29d68713c14068fd9961082a148dd02ad38289a6
2024-05-07 13:51:32 +08:00
marcusge
dc087a635b [Settings] Migrate color roles to respect color contrast
This change updated color roles in the main Settings page and in the
alert dialogs.

Bug: 335668262
Bug: 335668306
Bug: 335711196
Bug: 335711422
Bug: 335713067
Bug: 335712185
Bug: 335713398
Bug: 335714079
Bug: 335713405
Bug: 335714437
Test: local raven device

Change-Id: I29895ecb869f1053bbcc55ebeb42020e7ce77b8b
2024-05-03 00:11:41 +00:00
Marcus Ge
3042a3f02b Merge "Update Settings homepage color role mappings" into main 2024-03-12 20:56:49 +00:00
Daniel Norman
6d936ea34f Updates Display Size & Text preview background color.
Per guidance from Setup Wizard UX leads.
This matches the colors used by other accessibility feature preview
backgrounds.

Fix: 294443760
Test: Settings > Accessibility > Display size and text
      Observe white background in light mode, black background
      in dark mode.
Change-Id: I904415f91ce69e21477e761876944661ef69cb99
2023-11-17 23:57:54 +00:00
mxyyiyi
1817f066ec Update Power Anomaly UI.
For Settings tip & app anomaly banner:

- update app anomaly hint color in dark/light theme
[Banner card]
- update icons to GM3 style
- update text font and button text color
- update button style from outlined to filled.
[Chart view]
- update warning icon size
- update percentage label alignment

Screenshots:
- [Settings]
[light]	https://screenshot.googleplex.com/ERWkD7TmDsLaxdG
[dark]	https://screenshot.googleplex.com/6JKvL5vEQTZtJfd
- [App]
[light]
https://screenshot.googleplex.com/3YoncDhGTzUcAZA
https://screenshot.googleplex.com/3hbGmqoYWSy9H9U
[dark]
https://screenshot.googleplex.com/9XKs8tXmRKL2jJP
https://screenshot.googleplex.com/SU4LTJYWXvpd42r
- [RTL+L10N][Arabic]
[Settings] https://screenshot.googleplex.com/V9HJkPcsoBJmsW8
[Apps]
https://screenshot.googleplex.com/B49VKy2jaZYisWK
https://screenshot.googleplex.com/6VZQ2gESRes8RMH
- [Force RTL][EN]
[Settings] https://screenshot.googleplex.com/4V7coyLf5ueUcGv
[Apps]
https://screenshot.googleplex.com/9UaERwDmrpitqdq
https://screenshot.googleplex.com/3JDfcXi8pmz5Mew

Bug: 309569299
Test: manual
Change-Id: I8bee7f86d602112e0cbbd936b439330aaff7275c
2023-11-13 11:52:44 +08:00
Chaohui Wang
e752f7214b Remove unused SwitchBar
Only used in tests, so also migrate the tests.

Bug: 306658346
Test: manual - on bluetooth
Test: m RunSettingsRoboTests
Change-Id: Id2b010c1d9c32abe21dcc8765e9446fc4f7a5b25
2023-10-25 12:17:49 +08:00
SongFerngWang
e986c4cd89 Fix the text color of the sim list in the dark theme
Bug: 305592527
Test: local test pass
Change-Id: I8700b8b50cbbb04991a272bb2a1e58b0e1924349
2023-10-17 18:06:20 +08:00
marcusge
775280aa27 Update Settings homepage color role mappings
doc: go/settings-color-roles-remapping-result
Test: local raven device
Bug: 299907492

Change-Id: I8ba90ec61970fa2aa56f9d5d4029c22c74940120
2023-10-05 17:09:02 +00:00
Julia Tuttle
b23136041d Fix colors in importance and conversation priority preferences
This would have been simpler and faster, but the ChannelPanelActivity
was giving me a context where Material colors always inflated in light
theme even if the device was in dark theme, so I had to work around it.

On the plus side, whoever next needs to change these colors will find
them neatly organized in themes.xml!

Bug: 284380876
Test: manual
Change-Id: I2eee877fe44d307a96d60168d0317444ff002669
2023-06-16 19:17:09 +00:00
Angela Wang
53a8cc0326 Disabled state UI of Flash Notifications preview button
When both the camera flash and screen flash toggles are turned off, tapping on the preview button will have no effect and may confuse users. To avoid this, the appearance of the preview button should be updated to clearly indicated that its current state is disabled. This wil help users better understand the situation and prevent confusion.

Bug: 276494146
Test: checks the UI manually
Test: make RunSettingsRoboTests ROBOTEST_FILTER=FlashNotificationsPreviewPreferenceTest
Change-Id: I55b11188fde6e551921a9b0f7c89daa20a8b766b
2023-05-09 16:48:35 +00:00
Marcelo Arteiro
c5631b45b2 Automated Token Alignment Android/Material
Resubmiting reverted CL Ia1f84669090e04b3a2aaac82bb5971032d74a125.
Reson: Bug was found in another CL (in this topic)

Test: Treehugger
Bug: 268682423

Change-Id: I0fead8915b2bb6281e29b32f7426c35b0138b10e
2023-03-31 10:53:24 +00:00
Angela Wang
79588ff434 Changes screen flash color selected ring color in Flash Notifications
There's an outer ring to show that the screen flash color is selected and it's black in both light and dark themes.

When selecting screen flash color in the dark theme, it's not obvious which color is selected because the indicated ring is black which is similar to the dark background. Changing it to white in the dark theme for better user experience.

Bug: 275283917
Test: checks UI manually
Change-Id: I714597d99dfb74c5ce0ddef3995fd19688feacdf
2023-03-27 08:11:36 +00:00
Marcelo Arteiro
1b599e0232 Revert "Automated Token Alignment Android/Material"
This reverts commit c9ca4a9014.

Reason for revert: Black Search Box in Settings App (Light Theme)

Change-Id: I936e977ce044b8da41d818d6b3392adc6fd1e4e6
2023-03-09 23:40:40 +00:00
Marcelo Arteiro
c9ca4a9014 Automated Token Alignment Android/Material
Test: Treehugger
Bug: 268682423
Change-Id: Ia1f84669090e04b3a2aaac82bb5971032d74a125
2023-02-17 15:14:30 +00:00
Hao Dong
af35c7cb9d Add a flag for moving UdfpsEnroll* from SystemUI to settings.
The added files in this CL are mostly copied from SystemUI. Enabling the flag SETTINGS_SHOW_UDFPS_ENROLL_IN_SETTINGS with this CL, the udfps enrollment icons and progress bar are shown in settings.

Turn this flag on via adb:
adb shell setprop sys.fflag.override.settings_show_udfps_enroll_in_settings true

There are some known issues that will be fixed in the following CLs, including:
- When the finger is down on the screen and the lighting circle on the sensor is shown, the fingerprint icon is not hidden.
- When rotating the screen, fingerprint location is not right.
- Currently the scale factor is hard coded for pixel 7 pro, we should update the scale factor based on the device, etc.

Test: manually tested on device
Bug: 260617060
Change-Id: I5aede070eb1de9eb3b5e1400d6e51a8523079852
2023-01-03 19:37:42 +00:00
Grace Cheng
415314113b Fix alignment of finger animation with progress bar
Makes progress bar opaque and fixes color codes accordingly, and adjusts
values to shift finger animation and progress bar for proper alignment

Test: Enroll finger in light and dark theme and observe alignment of
finger with progress bar
Fixes: 245819077
Change-Id: I26bea8e1870f08b413a4ec2a9e6e83015facd004
2022-09-20 16:13:14 +00:00
Chaohui Wang
6ae88c417f Clean up some UnusedResources detected by lint 3
Bug: 234570979
Test: Manual with Settings App
Change-Id: I73d18397b01a9967fd7acb94b133e7d5497a0854
2022-09-13 13:56:26 +08:00
Chaohui Wang
7fe7ef383e Clean up some UnusedResources detected by lint 2
Bug: 234570979
Test: Manual with Settings App
Change-Id: I2421f1147ce8c9b09c2428355610a9089481d547
2022-09-10 17:34:11 +08:00
Grace Cheng
219b28bb8d Implement SFPS guided enrollment for T6
Reduces perception of long enrollment process by introducing new enrollment layout and stages for SFPS. Also adds user feedback via new animated assets with dynamic colors, and all associated strings and a11y labels.

Test: Observe new guided enrollment process on T6
Test: make RunSettingsRoboTests ROBOTEST_FILTER=FingerprintEnrollEnrollingTest
Fixes: 232024488
Fixes: 233091341
Fixes: 241165082
Fixes: 242218240
Change-Id: I1fa0b9349545586919eceeb9d05f365c2f2ec491
2022-08-31 20:15:55 +00:00
ykhung
4e98bc19f0 Resolve insufficient contrast for system component icons
Screenshots:
https://screenshot.googleplex.com/5UE5aPgHHBqkpHr
https://screenshot.googleplex.com/8yYqPusm9M2euSj

Bug: 242989982
Test: manually checking for icon UI
Change-Id: Ic3e51dd4d0bc042c9caba78a89f5fe6a4b995efb
2022-08-22 15:44:01 +00:00
Hank Sheng
bdda48ebe5 Create the glifv4 theme and set to glifv4 theme when the themestring is glifv4.
screen shot:
https://hsv.googleplex.com/5487921525161984
https://hsv.googleplex.com/4853914928152576
https://hsv.googleplex.com/6492643191160832
https://hsv.googleplex.com/5915886260060160
https://hsv.googleplex.com/6321050657751040
https://hsv.googleplex.com/6222016362315776

Bug: 233036258
Bug: 233032365
Change-Id: If2bb4a82912bfdd18dc17ced11adc59eaf474bed
2022-05-26 07:17:36 +00:00
SongFerngWang
f2a8008ae3 The list does not follow the UX dialog design doc in alert dialog.
Please refer the comment#1 at bug and there are change below
- the divider is 4dp
- the item's radius is different in the list.

Bug: 216233391
Test: manual test: check the UI
make RunSettingsRoboTests ROBOTEST_FILTER=SimListDialogFragmentTest (PASS)

Change-Id: I758d60202fcf477aeb49014e60b949e7ad08c082
2022-01-26 12:49:59 +08:00
SongFerngWang
43ebe68063 Refine the mobile data selection UI
-Adding the margin for bottom at dialog
-Modify the text color of summay in the list at dialog when device is
dark mode.

Bug: 212396431
Test: build pass and check the dialog UI.
Change-Id: I1ec587fd9d64ad67bbf3479c7931c0a901f572cf
2021-12-29 14:31:13 +08:00
SongFerngWang
4780be49f3 [MEP] renew the sim confirm dialog UI
- renew the sim confirm dialog

Bug: 199902896
Test: build pass and local UI test
Change-Id: Icb00b3fc32066e21d22cbeca1fdf50e5d7dbef20
2021-12-21 12:51:16 +08:00
Menghan Li
6001f86910 Merge "Fix Settings app crashes when clicked on the magnification" into sc-v2-dev am: 6de9b2486f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16044202

Change-Id: I9fdf101e209d7ade30c3da5850ed4499d7fcca3d
2021-10-14 07:32:01 +00:00
menghanli
f9ca092d58 Fix Settings app crashes when clicked on the magnification
1. Apply SetupWizardUtils.getTheme for AOSP / Nexus phone
2. Remove Magnification controller
3. Correct the description of the Talkback and Magnification page

Bug: 202792097
Test: manual test and upload fixed demo on bug
Change-Id: I108af30e3e2530bfabfcbdae03a7139a5b4e7a63
2021-10-13 22:34:27 +00:00
TreeHugger Robot
8718963d52 Merge "Refine the ripple effect and text style of ActionPrimaryButton" into sc-dev am: 74e1408513
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15183771

Change-Id: I6e69fb82e1483ea6393540c1ca5888e12535be57
2021-07-02 11:15:24 +00:00
Jason Chiu
7b8eea386c Refine the ripple effect and text style of ActionPrimaryButton
- The background color of the button is inverted, which has to be
  applied to inverse ripple colors.
- Update the font size and family.

Fixes: 190338973
Test: visual, manual
Change-Id: Ia7447b5e2f64546e0f011cca904d1317d6a38cf1
2021-07-02 17:45:42 +08:00
TreeHugger Robot
3110021f51 Merge "Consistent color between status bar and app bar" into sc-dev am: 3d5fd19e9f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15076803

Change-Id: I14c08d87c5895a6962142a226d52f3ed6fbf7b84
2021-06-28 04:37:57 +00:00
TreeHugger Robot
3d5fd19e9f Merge "Consistent color between status bar and app bar" into sc-dev 2021-06-28 04:25:09 +00:00
Tsung-Mao Fang
df00a3bc69 Consistent color between status bar and app bar
In Android S, we add the transparent color to navigation bar
and status bar for consistent color between status bar and
app bar. So, we should add this change for oveall setting
theme since most pages should apply new app bar now.

Thus, we don't need to override the subsetting style for different
activities one by one.

Homepage doesn't have new Android S tool bar, so we shouldn't adopt it.

Test: Try to launch all the pages as many as possible.
Fix: 190797935
Change-Id: Ic4083de5477371f1d0eea2d66f020e4469fa3f86
2021-06-23 17:53:59 +08:00
TreeHugger Robot
d56cb9842f Merge "Clean up unused code" into sc-dev am: 3928e0b4f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15029689

Change-Id: I3a939bc7856efee8be0b8f23b54ad9cdf8c9327b
2021-06-21 11:42:38 +00:00
TreeHugger Robot
3928e0b4f1 Merge "Clean up unused code" into sc-dev 2021-06-21 11:25:35 +00:00
TreeHugger Robot
6f2ed120b3 Merge "Update the image for Fingerprint Finish page" into sc-dev am: f4a1b19c12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15027578

Change-Id: Ie1b044e7a112b9c9e000751f359ac327c05f56ce
2021-06-21 10:41:55 +00:00
Tsung-Mao Fang
53f94d3289 Clean up unused code
Test: Rebuilt apk
Fix: 190142194
Change-Id: I16d18c538b612c6049f561bb524ee1e056255714
2021-06-21 18:17:27 +08:00
Mill Chen
6f93ac0eec Update the image for Fingerprint Finish page
Fix: 188733201
Test: visual verified
Change-Id: Iebb9eaa201ac5481df0104b9394dbc9959aa0c52
2021-06-21 17:20:00 +08:00
TreeHugger Robot
b001f45b3a Merge "Fix dialog color problem in night mode." into sc-dev am: f026108de5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15008367

Change-Id: I7d06f1009b0f94bf2b8143416790e675493b1a0c
2021-06-17 11:16:40 +00:00
Tsung-Mao Fang
1e8a907d91 Fix dialog color problem in night mode.
Assign the suface light and dark color for Dialog.

Test: Rebuilt apk, and see color works well on wifi dialog.
Fix: 190142194
Change-Id: I43d010c70e22639a29a571bfadb4351f41e1a240
2021-06-17 10:08:32 +00:00
Treehugger Robot
e7e7c33de7 Merge "Settings: use framework text colors for SwitchBar" am: b09a17bc9e am: b34692c2b5
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1708559

Change-Id: I15cef0a16d846f68ea331b550b1926caa952d8f6
2021-06-16 15:29:29 +00:00
Curtis Belmonte
f70d574278 Fix color and asset name for large face enroll icon
Don't use extracted color for the large face enroll icon asset shown
on the education and confirmation screens. Also update the name of this
asset to be more accurate and less confusing.

Test: Manual

Bug: 187845699
Change-Id: I1ac1d523f79757caa8aaac6b04b059c2c40fc0de
2021-06-07 16:31:24 -07:00
Jason Chiu
132cc2127b Merge "Revise homepage colors" into sc-dev 2021-06-03 03:31:06 +00:00
Jason Chiu
263d1e2c82 Revise homepage colors
- Increase the contrast ratio of the search bar
- Adjust the color of IA icons

Test: visual
Fixes: 179632631
Change-Id: I9b4fc4d671183929d4b2fed27cba8600d56cc74c
2021-06-02 13:24:33 +00:00
Curtis Belmonte
08f90ddb2d Align assets and colors for biometric enroll intros
Replaces the existing MP4 shown on the face enroll intro/consent screen
with an updated lock asset that matches the current SUW theme. Also
updates the colors of assets and text on these screens for face and
fingerprint so that the two match.

Test: Manually tested both enrollments for dark and light system themes

Bug: 187681255
Change-Id: I119da913cfc76e02160f2efc4654cecf33f1f049
2021-06-01 23:22:48 -07:00
Tsung-Mao Fang
6b8a5d1eb3 Fix GAR color constrast issue on dialog
Based on the UX definition, assign correct error color
for dialog

Test: A11y scanner tool confirms again and no color constrast issue.
Fix: 187396623
Change-Id: I338570b38c6fc5fa32ea1becd069084bf2d631a6
2021-05-31 20:00:20 +08:00