When updating errorprone from 2.23.0 -> 2.32.0, more issues are found.
Bug: 253827323
Flag: EXEMPT refactor
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Iebb442f5e616861d1f2a2e2dc56a8ac72b18cb95
Currently, Metalava has some special handling of '@attr ref R.<field>`
references to make sure that they are fully qualified, i.e.
`@attr ref android.R.<field>`. That special handling complicates
Metalava and is blocking some flagged API work so will be removed.
Before that can be done, the existing incorrect documentation needs to
be cleaned up.
This change cleans up those cases in this repo.
Bug: 371997321
Test: Run `m offline-sdk-docs` before and after to make sure that
there are no differences.
Flag: DOCS_ONLY
Change-Id: Ic97f01b90193d058d65e6d3c6d0a04ce5e55d7c7
The root cause is SubscriptionManager.OnSubscriptionsChangedListener
.onSubscriptionsChanged() not invoked in some cases.
Even the SubscriptionManager.addOnSubscriptionsChangedListener's doc
says the onSubscriptionsChanged() method will also be invoked once
initially when calling it, there still case that the
onSubscriptionsChanged() method is not invoked initially.
For example, when the onSubscriptionsChanged event never happens before,
on a device never ever has any subscriptions.
Adding a .onStart { emit(Unit) } to fix.
Also make the subscriptionsChangedFlow() a shared flow to mitigate the
extra emit cost.
Bug: 369276595
Flag: EXEMPT bug fix
Test: manual - factory reset & no any sim
Test: atest SubscriptionRepositoryTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9969334647b4b9439f549c0c0b2543fb3dec8813)
Merged-In: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
Change-Id: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
Summary: The app bar is not available, causing a null pointer exception.
Test: Successful Build on master branch
Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.
Test: Successful Build on master branch
Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
Updates tests that were broken by the rollout of the standalone_a11y_gesture_enabled flag
Test: atest com.android.settings.accessibility
Bug: 368704597
Flag: android.provider.a11y_standalone_gesture_enabled
Change-Id: Ie90e7495dd4a134538bae6e3e08eea0d02134b14
Selection to open page in app or browser needs to be displayed via radio
buttons as discussed here: http://b/346622495#comment14
Bug: 359262490
Test: Open links in app and browser
Flag: EXEMPT small UI change
Change-Id: Ib23084bcc7f899b97b59019775584807e5b70d7e
If the sim onboarding on, then sim should use the sim onboarding flow.
Bug: 362289792
Test: manual test
Flag: EXEMPT bugfix
Change-Id: Ibe22309db9dea5737de5ad351825a046599e6744
When startSimOnboardingActivity, so we enforce the
no_config_mobile_networks when insert psim.
Fix: 366370519
Flag: EXEMPT bug fix
Test: manual - set no_config_mobile_networks and insert psim
Change-Id: I0d4e85262924cc55a035ebeb2038ae08c0052ef6
If disallowed, not show mobile related search results.
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
`repo upload --verify` fails on HardCodedColor check and ag/29447250
did not fix the issue.
Bug: 269100659
Flag: EXEMPT lint only
Test: repo upload --verify
Change-Id: Ie5462c0956a436f6dd0d5eb95c7b8ec0d3262321
