Commit Graph

3871 Commits

Author SHA1 Message Date
HJ ChangLiao
baaf1fdfe8 Merge "Remove touch effect of Ratio on listitem" into pi-dev am: a976a0eaad
am: 632d6e06ca

Change-Id: I2555f708d14dd41d9ba665504f11ac1590f7900d
2018-03-20 14:30:35 +00:00
TreeHugger Robot
a976a0eaad Merge "Remove touch effect of Ratio on listitem" into pi-dev 2018-03-20 14:07:26 +00:00
Hall Liu
e3b9578658 Merge "Split "Mobile Network Type" indication in Settings" into pi-dev am: 8837f992bb
am: 0738a917df

Change-Id: I5ee44871c48d6052b1d62f4cbd8dd1ed76bd74e6
2018-03-20 07:12:38 +00:00
Andrew Sapperstein
38bf192ed6 Remove LinearColorBar and replace uses with ProgressBar.
We never actually needed it, since progress bar can do
everything we want it to. Renamed data_usage_progress to
color_bar_progress to reflect its more generic state.

Updated color_bar_progress to use proper values.
Since we can't seem to use private attrs in settings,
use the dimen/color values that are customizable.

Updated usages to use regular ProgressBar APIs.

Fixes: 74111937
Test: visual inspection and robotests
Change-Id: I4f0c59e6cf5c629e3cc3901800d9c4afc95fa495
2018-03-19 15:11:49 -07:00
Hall Liu
8837f992bb Merge "Split "Mobile Network Type" indication in Settings" into pi-dev 2018-03-19 21:15:26 +00:00
Jan Nordqvist
49b2ad914d Merge "In Data Usage screen, Above the data bar, Change font size of number." into pi-dev am: 9e1226e431
am: 085b9e6f83

Change-Id: Iff0a9324f91cbdd73e4ef336e63c013278000376
2018-03-19 19:29:16 +00:00
Jan Nordqvist
9e1226e431 Merge "In Data Usage screen, Above the data bar, Change font size of number." into pi-dev 2018-03-19 18:05:44 +00:00
HJ ChangLiao
4807cdfaf7 Remove touch effect of Ratio on listitem
Remove the ripple touch effect of RatioButton,
at Network ratings provider settings page.

Change-Id: Iba067450901572492df68974bdfc14c9ef09a655
Fixes: 70818673
Test: Manual test
2018-03-19 05:35:20 +00:00
Hall Liu
6f4b185331 Split "Mobile Network Type" indication in Settings
Display data and voice network type for clarity

Change-Id: I26e52dcc564dfd96e36e45d94d6e69225ea4a80f
Fixes: 70938010
Test: manual, unit
2018-03-16 22:53:12 +00:00
Jan Nordqvist
b104a25dd0 In Data Usage screen, Above the data bar, Change font size of number.
This is related to ag/3746508 and sets the size of the "small" text to 16sp.

Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I17f859186dc596c4dbab190241325bac4dad5554
2018-03-16 14:26:18 -07:00
Adam Newman
c6b4f3d92c Enable launching captive portal directly
Whenever a user has connected to a captive portal network, split the
ConnectedAccessPointPreference to allow directly signing into the
captive portal or modifying the network's settings. When in any other
network state, use the old behavior of a single tappable preference that
takes the user to settings.

Bug: 63929546
Bug: 68031656
Test: make RunSettingsRoboTests
Test: manual by connecting to Captive Portal and normal WiFi networks.

Change-Id: I444202a12138d90c94bda94945c121c8c0810536
(cherry picked from commit 7577624db7)
2018-03-15 21:05:25 +00:00
Qingxi Li
e0681db921 UI Tweak for eSIM related
This CL update following UI of eSIM:
    1. update title of eSIM reset checkbox under network reset and FDR screens.
    2. update eSIM reset checkbox to default is checked.
    3. Show eSIM reset checkbox in FDR when user is under developer mode.

Bug: 74083169
Bug: 74085673
Bug: 74771900
Bug: 74122440
Test: E2E & make RunSettingsRoboTests
Change-Id: Ia49fdae98d6ef541398b1dfb36c54beea1f2ba39
2018-03-15 11:24:25 -07:00
Adam Newman
7577624db7 Enable launching captive portal directly
Whenever a user has connected to a captive portal network, split the
ConnectedAccessPointPreference to allow directly signing into the
captive portal or modifying the network's settings. When in any other
network state, use the old behavior of a single tappable preference that
takes the user to settings.

Bug: 63929546
Bug: 68031656
Test: make RunSettingsRoboTests
Test: manual by connecting to Captive Portal and normal WiFi networks.

Change-Id: I444202a12138d90c94bda94945c121c8c0810536
2018-03-15 09:50:49 -07:00
Sundeep Ghuman
34aa694717 Merge changes Icf6fafe9,I35eb3f0c,Ieec0c486,I8accb164 into pi-dev am: 437d421eaf
am: 3efee3606d

Change-Id: I701d6a4d252b88661cf932ef13c41fc17e5a1000
2018-03-15 16:08:16 +00:00
Jan Nordqvist
8a241f642e Change text layout of data usage string.
In Data Usage screen, Above the data bar, Change font size of number
In Data Usage screen, Above the data bar, Update text style of “GB used”
In Data Usage screen, Above the data bar, Add “GB left” aligned right of bar (not always shown)

Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: I8accb16425283cf148ddb6b6646f92ff51a74b7c
2018-03-14 22:48:46 -07:00
Sundeep Ghuman
7087d24f82 Merge "Fix the ProgressBar in DataUsageSummaryV2 page." into pi-dev am: d610e51613
am: dfaa287e43

Change-Id: Ide44504a4dc52b67f759343e32e74d501a80dccf
2018-03-15 05:37:10 +00:00
Sundeep Ghuman
d610e51613 Merge "Fix the ProgressBar in DataUsageSummaryV2 page." into pi-dev 2018-03-15 05:00:41 +00:00
Sundeep Ghuman
ea8d866337 Fix the ProgressBar in DataUsageSummaryV2 page.
Bug: 70950124
Test: make RunSettingsRoboTests ROBOTEST_FILTER=DataUsageSummaryPreferenceTest
Change-Id: I83f268c0824d9e3520899725fa572753e1de0814
2018-03-14 16:21:46 -07:00
Yuchen Chang
f2b0bb1b67 Merge "Request focus in wifi screen in add network and secure wifi" into pi-dev am: 4786291624
am: 76fe8d54b1

Change-Id: I31f8ab52294729f685591d33384b878e34247cd5
2018-03-14 18:29:32 +00:00
Yuchen Chang
1bf069f839 Request focus in wifi screen in add network and secure wifi
Request focus from parent view in controller. Based on framework
patch, it can be placed in a parent and focus will go to whatever view
is the default focusable in that hierarchy.

Fixes: 68776177
Fixes: 72882629
Test: RunSettingsRobotests and Manual test
Change-Id: I3bcdc4ec814f68079a00e40435f46bdfa53f4425
2018-03-14 17:18:39 +08:00
Sundeep Ghuman
0e1fdfd472 Merge "Fix new DataUsageSummary page line spacing." into pi-dev am: 9f6ee6e1f8
am: 3791411b62

Change-Id: Idcb170195d6867f0480abf6ba7ac445aee5c2305
2018-03-14 06:15:32 +00:00
TreeHugger Robot
9f6ee6e1f8 Merge "Fix new DataUsageSummary page line spacing." into pi-dev 2018-03-14 06:00:29 +00:00
Andreas Terzis
b6756fc770 Merge "Change the color of the measurement numbers below the data bar." into pi-dev am: b687dac159
am: a745277b34

Change-Id: I7dfae909ddc53c54143d1110b3a61bf55fea6495
2018-03-14 05:14:26 +00:00
Andreas Terzis
b687dac159 Merge "Change the color of the measurement numbers below the data bar." into pi-dev 2018-03-14 03:58:32 +00:00
Doris Ling
c149594bfa Merge "Fix alignment for the instant app button." into pi-dev am: 2dd0a66c81
am: 03c8f085e3

Change-Id: I6a9eacc4d21a468ead9698775f71ed204a342d29
2018-03-14 02:07:46 +00:00
Sundeep Ghuman
101c1d09e1 Fix new DataUsageSummary page line spacing.
There are still some unspecified items pending UX. Have left comments on
ag/3702541 to avoid regressions.

Bug: 70950124
Test: UI change only, no code to test.
Change-Id: I7fa96134af750d71786d031652162aed6bffbeb5
2018-03-13 17:56:19 -07:00
Doris Ling
9e04a917b6 Fix alignment for the instant app button.
- wrap the secondary button in the FrameLayout to make it align properly
with the primary button.

Change-Id: I6964bc67773a77eae551521747c19898a2f22210
Fixes: 69562807
Test: visual
2018-03-13 14:38:33 -07:00
Jan Nordqvist
b17180d21a Change the color of the measurement numbers below the data bar.
Original line item: In Data Usage screen, Below the data bar, Make GB measurement numbers smaller.

Bug: 70950124

Test: manual
Test: make RunSettingsRoboTests
Change-Id: Id30233e038c664539fd688dcd4eb99af0c41f010
2018-03-13 13:12:49 -07:00
Doris Ling
14abf8d05a Merge "Fix layout height for suggestion tile." into pi-dev am: ec9606addb
am: 7eef8156ea

Change-Id: Ic4ba2e6fe757648304c90e22eb59b1a4535ef23e
2018-03-08 05:44:39 +00:00
Doris Ling
8f5773b834 Fix layout height for suggestion tile.
- set minHeight instead of using a fix height, so that when the
font/display size is set to larger, the height will expand accordingly
to fit all elements in the suggestion card.

- revert the change that tint all suggestion icons. The previous logic
should be used to determine if we should tint the icon or not.

Change-Id: I2451490130cee216ff65301a600eb91d2e65c321
Fixes: 74261827
Test: visual and make RunSettingsRoboTests
2018-03-07 15:04:11 -08:00
Victor Chang
2e79a7cc42 Merge "Time zone, Region, UTC picker" into pi-dev 2018-03-06 22:01:35 +00:00
Antony Sargent
403c8d5ba8 Remove unused file res/layout/usb_dialog_container.xml
It looks like the class which used this (UsbModeChooserActivity.java)
was removed in 40bd570352.

Bug: 70848054
Test: should be covered by existing tests
Change-Id: I307852484055dc7f04dc81d5f03145dfde765add
2018-03-06 10:11:19 -08:00
Victor Chang
2b6876ccab Time zone, Region, UTC picker
- Extract most common view related codes into BaseTimeZoneAdapter
  and BaseTimeZonePicker. Subclass handles the text formatting and
  order.
- Search view is added compared to previous version of time
  zone picker
- SpannableUtil is added to preserve spannable when formatting
  String resource.
- Fix the bug using GMT+<arabic> as time zone id. b/73132985
- Fix Talkback treating flags on screens as a separate element

Bug: 72146259
Bug: 73132985
Bug: 73952488
Test: mm RunSettingsRoboTests
Change-Id: I42c6ac369199c09d11e7f5cc4707358fa4780fed
(cherry picked from commit fbd30acef0)
2018-03-06 11:13:59 +00:00
Victor Chang
e00aeff9dc Merge "Time zone, Region, UTC picker" 2018-03-06 11:13:41 +00:00
Victor Chang
fbd30acef0 Time zone, Region, UTC picker
- Extract most common view related codes into BaseTimeZoneAdapter
  and BaseTimeZonePicker. Subclass handles the text formatting and
  order.
- Search view is added compared to previous version of time
  zone picker
- SpannableUtil is added to preserve spannable when formatting
  String resource.
- Fix the bug using GMT+<arabic> as time zone id. b/73132985
- Fix Talkback treating flags on screens as a separate element

Bug: 72146259
Bug: 73132985
Bug: 73952488
Test: mm RunSettingsRoboTests
Change-Id: I42c6ac369199c09d11e7f5cc4707358fa4780fed
2018-03-05 21:53:56 +00:00
arangelov
e35badd9d5 Make "Action not allowed" dialog compliant with Material Spec and replace full screen activities with the dialog.
Bug: 64893948
Test: make ROBOTEST_FILTER=ActionDisabledByAdminDialogTest -j40 RunSettingsRoboTests
Test: make ROBOTEST_FILTER=ActionDisabledByAdminDialogHelperTest -j40 RunSettingsRoboTests
Change-Id: I9308d8d86a3789b8f2c92b9f4f20cf00cce71d14
2018-03-05 20:27:51 +00:00
arangelov
9308154090 Make "Action not allowed" dialog compliant with Material Spec and replace full screen activities with the dialog.
Bug: 64893948
Test: make ROBOTEST_FILTER=ActionDisabledByAdminDialogTest -j40 RunSettingsRoboTests
Test: make ROBOTEST_FILTER=ActionDisabledByAdminDialogHelperTest -j40 RunSettingsRoboTests
Change-Id: I9308d8d86a3789b8f2c92b9f4f20cf00cce71d14
2018-03-05 17:35:48 +00:00
TreeHugger Robot
ca1aab7eb0 Merge "Update layout for app preference" 2018-03-02 03:07:00 +00:00
Fan Zhang
21185523e6 Update layout for app preference
The summary and appendix string each takes 50% of horizontal space so
they don't push the other too far off.

Change-Id: I89d859f1ec46340695aa0ef75e4c81e6435b151a
Fixes: 74028565
Test: visual
2018-03-01 17:46:55 -08:00
Doris Ling
92ffa4e4f0 Merge "Reduce max suggestion to show to 2." 2018-03-01 23:48:55 +00:00
Doris Ling
7d59c441b8 Reduce max suggestion to show to 2.
- since we now either have 1 or 2 suggestions, putting most layout
configuration in the xml instead of dynamically setting it in code.
- remove the suggestion header
- vertical center align the suggestion title text for 2 cards to make
the card with single line looks better.
- tint all suggestions icons.

Change-Id: I0130f15d530264e164e5afd7c091f165a4a6adc2
Fixes: 70573674
Fixes: 73293989
Fixes: 64986736
Test: visual and make RunSettingsRoboTests
2018-03-01 14:16:07 -08:00
Sean Callanan
2dd4377423 Add a preview image to the color mode preference.
For high-color displays, it's desirable to have a preview of the
impact the user's color preference will have on images.  This commit
adds that functionality to ColorModePreferenceFragment by extending
RadioButtonPickerFragment to support static content.

The image used here is a placeholder pending UX.

Bug: 73670362
Test: Added a test verifying that the preview is added correctly.
Change-Id: Id54316bbef6a22291a8e8acbda5fcb2839b88c23
2018-03-01 13:10:26 -08:00
Andrew Sapperstein
0ff942e5de Delete unused layout: preference_importance_slider.
And its associated colors.

Test: builds
Change-Id: Ibe3f4399b15d97f976a598553b04d92296067a74
2018-02-25 17:05:01 -08:00
Maurice Lam
b93f6c171c Merge "Improve pattern layout for tiiiny screens" 2018-02-23 19:00:43 +00:00
TreeHugger Robot
c55276c919 Merge "Revert "[Settings] Add focus for SSIDtext to show IME"" 2018-02-23 06:43:23 +00:00
Yuchen Chang
a253de1906 Revert "[Settings] Add focus for SSIDtext to show IME"
This reverts commit c6233057ca.

Reason for revert: cause side effect for other cursor focus missing

Change-Id: I9c788a2726bdd6bc7c663e9115bbc24538f871de

Bug: 73702700
Bug: 72882629
2018-02-23 04:01:07 +00:00
TreeHugger Robot
deb1e57053 Merge "Add Open button to launch instant app." 2018-02-21 20:57:36 +00:00
TreeHugger Robot
8cd17cba39 Merge "Push app icon 4 dp to the right." 2018-02-21 07:09:32 +00:00
Fan Zhang
b36c071003 Push app icon 4 dp to the right.
- This makes the icon for AppPreference center aligned.

Change-Id: I2624f376d7637fe49b8bc629e87cb55c3b6271cd
Fixes: 72710732
Test: visual
2018-02-20 17:39:05 -08:00
Doris Ling
5b3332547a Update suggestion/condition UI
- reduce top padding for suggestion container
- match condition card corner radius with suggestion card.
- change condition card background color to white
- update suggestion title font from medium to regular.

Change-Id: I0267b37822facf4bd389e2b21c47a1fcf0d00264
Fixes: 70573674
Test: visual
2018-02-20 15:30:47 -08:00