Commit Graph

3871 Commits

Author SHA1 Message Date
tmfang
4b8eccb519 Clean up manage_applications_apps.xml
Since LinearLayout have only one view(FrameLayout),
LinearLayout is redundant.

It can improve a bit render time.

Test: Open App info screen
Fixes: 124702325
Change-Id: I368b20c5f9916b876586dab71eac43512664d15b
2019-03-21 19:29:49 +08:00
Yanting Yang
1cdb780526 Revert layout transition from slice view
Fixes:129002765
Test: visual
Change-Id: Ice56eb0ee5cd6018927271ab33ad9dd3321953b1
2019-03-21 16:59:47 +08:00
TreeHugger Robot
b9e6f894c3 Merge "Add divider line in Preference for scan QR code button and share hotspot button" 2019-03-21 06:26:27 +00:00
Arc Wang
abfd8ab726 Improve Wi-Fi Easy Connect lock screen UI information
1. Change lock screen title and remove description
2. In QR code generator screen, change summary and show password under QR code picture

Bug: 128920152
Bug: 128576809
Test: manual test
Change-Id: Id096d7f417308df14ffe50c618644750aa991df8
2019-03-21 14:09:22 +08:00
TreeHugger Robot
ff02854e9a Merge "Remove hardcoded height for SliceView" 2019-03-21 04:02:48 +00:00
Arc Wang
890f3a4340 Add divider line in Preference for scan QR code button and share hotspot button
Bug: 128940862
Test: manual test
Change-Id: If576f0840cc8924b63348f04fe12c3a0d4edcb89
2019-03-21 10:48:55 +08:00
jackqdyulei
02f64c0634 Remove hardcoded height for SliceView
Fixes: 128953120
Test: Build
Change-Id: I052d2b539421132002a3217fe2ef82d0ab6aba19
2019-03-20 17:10:26 -07:00
TreeHugger Robot
1029b976f4 Merge "Update enrollment intro" 2019-03-20 06:28:33 +00:00
Cosmo Hsieh
64df6a3073 Merge "[Network Connection] Implement new UI changing" 2019-03-20 04:34:25 +00:00
TreeHugger Robot
85c5d73145 Merge "Improve UX of WifiDppChooseSavedWifiNetworkFragment" 2019-03-20 04:07:02 +00:00
Kevin Chyn
f25830b9cc Update enrollment intro
1) Toggles resources between normal and accessibility enrollment
2) Add footer for more detail text

Fixes: 127514618
Bug: 111548033

Test: Builds

Change-Id: Ib0c47f04abc5ce9abbd8b27ef5782d1874379f16
2019-03-19 19:19:23 -07:00
Arc Wang
d0ceb83c95 Improve UX of WifiDppChooseSavedWifiNetworkFragment
In WifiDppChooseSavedWifiNetworkFragment, it does not show the saved Wi-Fi
network which is not reachable, users may be confused about why their saved
Wi-Fi network not on the list. This change shows saved networks regardless
of signal reachable or not.

Fix WifiDppChooseSavedWifiNetworkFragment UI overlap problem, remove redundant
ScrollView and adjust ConstraintLayout parameters.

Bug: 124129645
Test: manual test
Change-Id: I86637e8722bb8f40a3b995a617dc1e22b2ae324a
2019-03-20 10:06:40 +08:00
Arc Wang
e4359a9eee Merge "Fix Wi-Fi Easy Connect buttons UI defects" 2019-03-20 01:53:24 +00:00
Lei Yu
e87fe284b6 Merge "Add circle background outline to unthethered icon" 2019-03-19 17:46:17 +00:00
Fan Zhang
83f85b0a1f Merge "Stop using framework internal layout for timezone header." 2019-03-19 17:18:42 +00:00
Fan Zhang
5d2e0fc10f Stop using framework internal layout for timezone header.
The framework version header has deviated from supportlib version long
ago, and we shouldn't hack our theme to make this layout work. Instead
we now have a custom layout compatible to settings theme.

Fixes: 128833223
Test: visual
Change-Id: I83087352240de183b0639daf844bd7f90e02056a
2019-03-19 10:17:46 -07:00
Arc Wang
baf002d61a Fix Wi-Fi Easy Connect buttons UI defects
1. Apply attr/colorAccent to button icons for theme UI control
2. Apply attr/selectableItemBackground for button tapping ripple effect
3. Use ConstraintLayout to separate ssid EditText and scan button
4. Remove ButtonPreference and add AddNetworkPreference.
   ButtonPreference's naming and design look like a general purpose UI
   component but it's not. This change refactors the code.
5. In AddNetworkPreference, use settingslib layout file
   'preference_access_point' to fix UI alignment problems.

Bug: 126964552
Bug: 125434239
Bug: 126762937

Test: manual test
      atest com.android.settings.wifi.WifiSettingsTest
Change-Id: Ib899a1e10f96bb8427ff00d6b5dfca37a0642c44
2019-03-19 16:27:04 +08:00
cosmohsieh
b795dcbcd1 [Network Connection] Implement new UI changing
1. Change title to multi-lines display
2. Add "SingleSpecifiedSSID" mode, will have connect button
3. Don't pop error dialog, if there is connection failure. Let user
retry.
4. Hide progress icon if list item exists

Bug: 128586511
Test: atest NetworkRequestDialogFragmentTest
Change-Id: Icc560e4882fbcd941574e44690a27d5082a7c4c7
2019-03-19 10:15:33 +08:00
TreeHugger Robot
d55718eeca Merge "Fix voice access issue on home page" 2019-03-18 19:59:27 +00:00
Hunter Knepshield
711b78d5ed Merge "[Strings + layout] Minor changes for eSIM erase." 2019-03-18 18:17:20 +00:00
Yanting Yang
0f3049d4b7 Fix voice access issue on home page
Bug: 128825246
Test: manual
Change-Id: Icd9b31c195f44b11b97a30292de586483ea2e651
2019-03-18 22:12:49 +08:00
Sunny Shao
3ef480e895 Update the expand more icon in the condition
- Rollback the color from accent to gray.
- Use the "ic_expand_more_inverse.xml" to replace the "expand more" icon.

Fixes: 126926489
Test: manual
Change-Id: I438a03f42987001de7dce5040dd01347c2c6a9b0
2019-03-18 06:08:16 +00:00
Hall Liu
c776acee06 Merge "Base implementation of WFC disclaimer UI" 2019-03-15 22:57:06 +00:00
jackqdyulei
8308274058 Add circle background outline to unthethered icon
Fixes: 124247230
Test: manual
Change-Id: I70f8158685134e2115f2a7baded983ebac6c8f1b
2019-03-15 12:40:58 -07:00
Julia Reynolds
4253be9191 Update design of channel pages.
Test: atest
Bug: 127796543
Change-Id: I4fabeafe2602c341554959303e67bc69c8817a8f
2019-03-15 10:21:24 -04:00
Hunter Knepshield
e8e86e631a [Strings + layout] Minor changes for eSIM erase.
1. String changes (uniform on both screens now)
2. Minor non-functional layout changes (margin is uniform now)

Reset everything: https://screenshot.googleplex.com/OZsvOt36CZf
Reset networks: https://screenshot.googleplex.com/in0vdOAeF7u

Change-Id: I92d068c3731f6915c8d393d94ac8c25a3c8ed773
Fix: 119120504
Test: on device
2019-03-14 15:14:35 -07:00
manabu, shimoda
9fae73915c Base implementation of WFC disclaimer UI
Test: manual - Check that no error occurred when changing the wifi
calling settings to turn on.
Test: auto - Passed WifiCallingSettingsForSubTest,
WifiCallingDisclaimerFragmentTest and DisclaimerItemListAdapterTest.
Bug: 67872298

Change-Id: I789f530d3e16baa6e56feaa4269f6696976f747e
2019-03-14 14:58:20 -07:00
TreeHugger Robot
d392beed55 Merge "Align layouts between single and two target preferences." 2019-03-13 19:45:25 +00:00
TreeHugger Robot
4bb33ae9f2 Merge "Update the color of the expand icon as accent color" 2019-03-12 01:05:10 +00:00
TreeHugger Robot
08a2a8183e Merge changes I54a3f033,I2e894501
* changes:
  Fix [a11y] Wi-Fi Easy Connect Talkback issues
  Support to share Wi-Fi hotspot via QR code
2019-03-12 00:42:40 +00:00
Chris.CC Lee
411ca28940 Align layouts between single and two target preferences.
Change the layout to align view components with TwoTargetPreference.

Fixes: 124084391

Test: Visual
Change-Id: I417a8e442bd80c51be04e3f33514a6605c9b45f8
2019-03-12 06:23:56 +08:00
Chalard Jean
230a9949b4 Merge "Support VPN Proxy(2/2)" am: 2a695c4b7b am: e2f74af063
am: aa5d185d7b

Change-Id: Ifa4ac76f78e24296a29f99f5733075651bed9072
2019-03-09 04:20:32 -08:00
Yanting Yang
d6609a872b Merge "Animate the expansion/collapse of a slice" 2019-03-08 09:08:02 +00:00
Arc Wang
70e3580f5d Fix [a11y] Wi-Fi Easy Connect Talkback issues
1. Remove android:contentDescription from ButtonPreference layout file
   'wifi_button_preference_widget.xml' because it should be a more
   general purpose component. Add ButtonPreference#setButtonContentDescription
   for this change.
2. Add a LinearLayout to group title & summary for better Talkback UX
3. Set android:contentDescription for Wi-Fi enrollee scan button
4. setTitle for Talkback actionbar back button of WifiDppQrCodeGeneratorFragment &
   WifiDppQrCodeScannerFragment
5. Auto trigger Talkback to speak title & summary in WifiDppAddDeviceFragment &
   WifiDppChooseSavedWifiNetworkFragment
6. Auto trigger Talkback to speak summary change in WifiDppAddDeviceFragment
7. Auto trigger Talkback to speak error message in WifiDppQrCodeScannerFragment

Bug: 126007405
Bug: 124424996
Bug: 124424445
Test: manual test

Change-Id: I54a3f033bb8871c47be12115ae8f97691fd83302
2019-03-08 12:05:50 +08:00
TreeHugger Robot
b5b61b202b Merge "Alignment of Settings contextual homepage" 2019-03-07 06:07:05 +00:00
TreeHugger Robot
79ba9ad7e8 Merge "Moved left 2dp for the search icon" 2019-03-06 20:06:20 +00:00
Yanting Yang
0cb538bbd0 Animate the expansion/collapse of a slice
Fixes: 123950127
Test: visual
Change-Id: If78bace71b166c484c8f4c358f1007bd2f6ffc89
2019-03-06 19:50:09 +08:00
Jason Chiu
fa62183752 Alignment of Settings contextual homepage
Bug: 127345692
Bug: 126246056
Test: visual
Change-Id: I75e3153de1d6fb9d9b826db70c6cd5703304c04d
2019-03-06 17:28:56 +08:00
Yanting Yang
be15baa155 Merge "Remove dismissal behavior from deferred setup card" 2019-03-06 08:45:32 +00:00
Sunny Shao
6491db8f77 Moved left 2dp for the search icon
Bug: 127345692
Test: manual
Change-Id: I481d7fb46d2108d66a087eee30e7314e22af2314
2019-03-06 14:50:18 +08:00
Ryusuke Sawa
9f7875d547 Support VPN Proxy(2/2)
Adding VPN Proxy settings in advanced option.
 - Proxy host name
 - Proxy port

Bug: 118793208
Test: runtest

Change-Id: I40f3cf049f5822eefc3f9e6ba5dd0bb80c9b3945
2019-03-06 10:38:48 +09:00
Sunny Shao
bb455b8b2d Update the color of the expand icon as accent color
Fixes: 126926489
Test: manual view
Change-Id: I0200e53733ce629686fa6fd53df70809f7cedbb5
2019-03-06 08:59:51 +08:00
Yi-Ling Chuang
76b70687e7 Swap the buttons in the dismissal view.
The affirmative button should be on the right.

Fixes: 126265410
Test: visual
Change-Id: I72ddbacd5ce417cb4271d07c1cfc77e10ccad49a
2019-03-05 17:16:20 +08:00
Yanting Yang
52367e8c65 Remove dismissal behavior from deferred setup card
Deferred setup is not skippable as user will need to review all SUW
screens at least one time.

Fixes: 126225957
Test: visual, robotests
Change-Id: I7b32c2382f459690d3b136cf9faa543d04aa8d3d
2019-03-05 17:08:51 +08:00
Matthew Fritze
cafeaadaa6 UX Fixes for Settings Panels
UI Fixes include:
- Fix height of bottom bar
- Fix start / end padding of See More and Done buttons
- Remove scroll shadow in recycler view
- Consolidate most layout code into a single file, only
separating the distinguished elements into the landscape file.

I cannot fix b/126731930 until a Slice bug is fixed, where the top
padding is applied to the bottom of sliceview instead.

Fixes: 126720235
Fixes: 126720220
Fixes: 126720167
Test: manual inspection & layout inspector

Change-Id: I6e3434aabe221134e7278f92bab34122719c179a
2019-02-28 16:16:10 -08:00
Ng Zhi An
b97bdc38da Disable system alert window permissions on low ram devices
Bug: 63697002
Bug: 117832554
Test: adb am start-activity -a
android.settings.action.MANAGE_OVERLAY_PERMISSION
Change-Id: I44c64001cd07fd4934cdc55f455384cebd5c9cfb
2019-02-26 17:58:43 -08:00
Matthew Fritze
9e50419c75 Remove NFC Slice jank
The NFC Slice would jank on enable and disable, because of the
intent filter it registered with SysUI. The intent filter would
broadcast an update for four states:
1) On
2) Off
3) Turning On
4) Turning off

The first two caused no problems. The third and fourth caused jank,
since when clicked, the switch in the NFC slice would turn on / off
asynchronously - that is, it turned on or off based on the previous
state of the switch, rather than on the actual value of NFC. It does
this to feel fluid in the app in which it is rendered.

From the off state, the order of events is:
1.  Switch clicked
2.  Switch animates on
2.  Background intent is fired to settings to turn on Nfc (happens at
       the same time as animation)
3.  Settings calls the NFC enable API
4.  A broadcast for Turning On is sent
5.  The receiver in SysUI gets the broadcast and forwards it to settings
6.  Settings tells the Slice to make sure it is up to date
7.  The Slice checks for the current value - IMPORTANTLY - which is
        currently off, it is only in the process of being enabled.
8.  The Slice flips back off
9.  Nfc finishes getting enabled in the background
10. The framework pushes the NFC ON broadcast
11. SysUI gets the broadcast, and forwards it to settings
12. Settings tells the slice to update
13. The slice checks again and finds that NFC is on, flipping on.

This CL creates a new background slice worker for NFC and registers
the intent filter there, rather than in SysUI. When the background
worker gets the broadcast, it checks if it is in state 3/4, and if so,
it drops the update silently.

Fixes: 115737701
Test: robotests
Change-Id: I17043828ad3a67a2a5acdf5c75d9cc51ff7e91d0
2019-02-26 08:20:38 -08:00
TreeHugger Robot
2b0611cec4 Merge changes I9f1edb0a,Iaba7077c
* changes:
  Make model & hardware UI full screen.
  Merge Copyable into Sliceable.
2019-02-26 04:00:13 +00:00
Arc Wang
d1d2c029af Merge "Fix [a11y][Qt]Small touch targets in Add network page after running Accessibility scanner" 2019-02-26 01:42:00 +00:00
Fan Zhang
8ae1514299 Make model & hardware UI full screen.
Bug: 112427717
Test: robotests
Change-Id: I9f1edb0ab377aff142b57d86f4fa218b755356b1
2019-02-25 16:36:04 -08:00