Commit Graph

7 Commits

Author SHA1 Message Date
Mill Chen
256c8501c0 Change ScrollView to NestedScrollView for language list
After enabling collapsing toolbar, ScrollView is not working with
CoordinatorLayout. So we need to update it to NestedScrollView to make
it work with CoordinatorLayout.

Bug: 181737215
Test: visual verified
1) Settings -> System -> Languages & input -> Languages
2) Add 6-8 languages to the list
3) Scrolling the list to see if it's smooth

Change-Id: Id47dfc225585ddd4469838ff0898495cda3f6c44
2021-03-05 22:52:55 +08:00
Raff Tsai
29c15273b5 Fix Weird floating "add language" item
- Base theme has android:clipToPadding=false attribute. It let user
UI draw under navigation bar but also cause this problem. Add
android:clipToPadding=true in layout to fix the problem.

Fixes: 142108980
Test: manual
Change-Id: Ibe60b348a3c7c01d9786612ceac23a47a78a208a
2019-11-04 17:34:02 +08:00
Raff Tsai
360d2f2c6f Fine tune language UI to match preference style
Fixes: 141830486
Test: visual
Screenshot: https://screenshot.googleplex.com/LVv2W9D963s
Screenshot: https://screenshot.googleplex.com/VbJQ0cSPBKK
Change-Id: I44b0ac8ac2bd32b3beeabee195aab928ec4bacc2
2019-09-30 11:17:04 +08:00
Mihai Nita
a475fb1e06 Fix various UX bugs.
* In the drag & drop list align numbers with the + in
  the "+ Add a language" button
* Keep the "+ Add a language" button under the list
* Shadow cell while drag & drop
* Updated various strings for dialog titles and messages

Bug: 26557242
Bug: 26710677
Bug: 26712004
Bug: 27070104
Change-Id: I10d26eac9581c955328e667d7309b5f0ac649110
2016-02-23 13:21:21 -08:00
Mihai Nita
7f78a4b723 UX fixes for the language draggable cell
This should bring things closer to the recommended UX guidelines.

It changes the way the checkbox / label play together,
and changes the "localization missing" warning icon to a string.
Also some cleanup of hard-coded styles and sizes.

Bug: 26758865
Bug: 26707846
Change-Id: I07a78a1e4a41122b91e895e363a217d3e9cacd40
2016-02-10 21:46:13 +00:00
Mihai Nita
615659c86b Using a real Button widget for "Add a language"
The initial implementation used a TextView.
But this is cleaner, it is a real button and acts like one.

Bug: 26756569
Change-Id: Ibe3550b0cb81b020dfd4ec6ab29d39a56ba6e1bd
2016-02-02 09:02:05 -08:00
Mihai Nita
d7d48fda53 Implement multiple locales and sublocales in Settings
Does drag-and-drop reordering, supports adding / removing locales,
suggestions, search, removes locales already selected in the
user preferences.

Bug: 25800339
Change-Id: Iffe7b9810c77ec93a84d848ab20b2ba405249676
2016-01-20 12:31:11 -08:00