Commit Graph

24057 Commits

Author SHA1 Message Date
Aleksander Morgado
22c8840526 Return DISABLED_FOR_USER in deviceinfo/simstatus availability if not admin user
The correct return when checking for the SIM status field availability
for non-admin users is DISABLED_FOR_USER.

UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimStatusPreferenceControllerTest

Change-Id: I9bd290f1bdd73909be383a24f2c762d295089ff6
2025-02-17 00:44:30 -08:00
Aleksander Morgado
d58d0be2e1 Return UNSUPPORTED_ON_DEVICE in deviceinfo/simstatus when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest SimStatusPreferenceControllerTest
Change-Id: I0735c949a590190cdc177cbca835444691c50faa
2025-02-17 00:44:30 -08:00
Aleksander Morgado
4cc14d6553 Added unit tests for SimStatusPreferenceController visibility
The new test checks whether the item is available when
config_show_sim_info=false, when telephony is not data capable and
when the user is not admin,

The default visibility status for all tests is defined in the test
setup().

Bug: 395714454
Flag: EXEMPT test only
Test: atest SimStatusPreferenceControllerTest
Change-Id: I8791d9fd4d7ab8648946f044d7aa6a0e77283a00
2025-02-17 00:44:30 -08:00
Aleksander Morgado
64fb695d9b Return DISABLED_FOR_USER in IMEI availability if not admin user
The correct return when checking for the IMEI field availability
for non-admin users is DISABLED_FOR_USER.

UNSUPPORTED_ON_DEVICE should only be used when the setting is
unconditionally hidden as the device does not support the feature.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest ImeiInfoPreferenceControllerTest
Test: atest MobileNetworkImeiPreferenceControllerTest

Change-Id: I4ee89a84953993daad539d33d3a2e576540c580f
2025-02-17 00:44:30 -08:00
Aleksander Morgado
2a0ad1efdf Return UNSUPPORTED_ON_DEVICE in network/imei when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

This change also aligns the behavior with the deviceinfo/imei
entry.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest MobileNetworkImeiPreferenceControllerTest
Change-Id: Ia01cf3812f8343eabd8ea6970b691ac71432e8bd
2025-02-17 00:44:30 -08:00
Aleksander Morgado
dc86669298 Added unit test for MobileNetworkImeiPreferenceController visibility
The new test checks whether the item is available when the
SubscriptionUtil.isSimHardwareVisible() method returns true, i.e. if
the config_show_sim_info boolean flag is true on non-test runtime.

The default visibility status for all tests is defined in the test
setup() method.

Bug: 395714454
Flag: EXEMPT test only
Test: atest MobileNetworkImeiPreferenceControllerTest

Change-Id: Iaa8be041f0299ac36d532ed68fdc9c30e5690b11
2025-02-17 00:44:30 -08:00
Aleksander Morgado
4f4580e5f5 Added unit tests for ImeiInfoPreferenceController visibility
The new test checks whether the item is available when
config_show_sim_info=false, when telephony is not data capable and
when the user is not admin,

The default visibility status for all tests is defined in the test
setup().

Bug: 395714454
Flag: EXEMPT test only
Test: atest ImeiInfoPreferenceControllerTest
Change-Id: Ic4df12da216e5c343cf696d931ff02dc942d105f
2025-02-17 00:44:30 -08:00
Aleksander Morgado
a66d27c488 Return UNSUPPORTED_ON_DEVICE in network/phonenumber when no telephony
If the device does not have any telephony support (either via the
build-time config_show_sim_info=false boolean flag, or when not
declaring the PackageManager.FEATURE_TELEPHONY_DATA feature flag),
returning UNSUPPORTED_ON_DEVICE makes more sense than
CONDITIONALLY_UNAVAILABLE, as there is no runtime change that would
make it available.

This change also aligns the behavior with the deviceinfo/phonenumber
entry.

Bug: 395714454
Flag: EXEMPT bugfix
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: I5f2392969fad1884a89de3870ad37be5601fbe37
2025-02-17 00:44:30 -08:00
Yiyi Shen
6dc3e5938f [Audiosharing] Show add source notif when app not in foreground
Test: atest
Bug: 395786392
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I3c88c4209cf34c8f337965ffb45fb8e9a4db0e05
2025-02-17 14:00:36 +08:00
Menghan Li
972e7a320c Merge changes from topics "A11yFeedback", "AccessibilityFeedbackFeatureProvider" into main
* changes:
  feat(A11yFeedback): Pixel overlay to expose the feedback bucket ID
  feat(A11yFeedback): Add feedback entry for Accessibility page
  feat(A11yFeedback): Add FeedbackManager for Accessibility page
2025-02-16 19:45:09 -08:00
Chun-Ku Lin
0f84b652cc Make ColorAndMotionFragment fully in Catalyst
Bug: 392190782
Test: manual (verify the navigation and the search still works the same)
Test: atest
Flag: com.android.settings.flags.catalyst_accessibility_color_and_motion

Change-Id: I7717390c70246503aec545991fd9a40be5152373
2025-02-17 03:01:36 +00:00
Nikhil Nayunigari
2c90d30415 Merge "Changes to add Ethernet settings row item" into main 2025-02-15 11:46:13 -08:00
Nikhil Nayunigari
bfd3722e06 Changes to add Ethernet settings row item
Adds EthernetSettings row item to NetworkProviderSettings and its
controller.

Flag: com.android.settings.connectivity.ethernet_settings

Test: atest
SettingsRoboTests:
com.android.settings.network.EthernetSwitchPreferenceControllerTest

Change-Id: I27965ad0c8563657b17e0aa6d3bd19b97fcf5615
2025-02-15 18:20:46 +00:00
Treehugger Robot
d171e3e12d Merge "Make sure the flags are setup correctly in the test." into main 2025-02-14 15:02:35 -08:00
Tom Hsu
28f5fbb59d Merge "[Satellite Settings] Show device's app info on Satellite settings page." into main 2025-02-14 14:03:10 -08:00
Pierre Barbier de Reuille
f4505d8b82 Make sure the flags are setup correctly in the test.
Test: atest DesktopModePreferenceControllerTest
Flag: EXEMPT (bug fix)
Fix: 396663349
Change-Id: I8954dfad0a15791545f6c2ff88a488c553e02c69
2025-02-14 21:47:25 +00:00
Pawan Wagh
e443eaf40c Merge "Check if device is online before starting 16kb test" into main am: 7ee0e07a50 am: ca9409db6d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3489997

Change-Id: I03d14eb18e2a47f46bccecb96ed1635a3c5f2355
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-14 11:46:40 -08:00
Pawan Wagh
7ee0e07a50 Merge "Check if device is online before starting 16kb test" into main 2025-02-14 10:40:31 -08:00
tom hsu
bb80fe2df1 [Satellite Settings] Show device's app info on Satellite settings page.
- Shows device apps' info up to 3 on Satellite settings' page.
 - Add a new page to show all device's app info with Satellite supported.

Flag: com.android.internal.telephony.flags.satellite_25q4_apis
Fix: b/395813844
Test: atest pass
Change-Id: Ibd5e1c74b636639082ec9477f2b6796bcbc8340d
2025-02-14 06:40:10 -08:00
tom hsu
63242bc3ff [Satellite Settings] Add a new API to SatelliteRepository
Flag: com.android.internal.telephony.flags.satellite_25q4_apis
Bug: b/395813844
Test: atest pass
Change-Id: Ife9e370dbcb3694adfd0bfbcc2ec2a742fbc4434
2025-02-14 06:39:45 -08:00
Treehugger Robot
d20e849d56 Merge "Create new sections for developer options" into main 2025-02-14 03:40:28 -08:00
Yiyi Shen
6dda673bf0 Merge "Show device in Media devices section if has LEA member connected" into main 2025-02-14 02:03:04 -08:00
Yiyi Shen
9b106ddf42 Merge "[Audiosharing] Avoid concurrent issue when adding preference" into main 2025-02-14 00:11:41 -08:00
Yiyi Shen
fb21686468 Show device in Media devices section if has LEA member connected
Test: atest
Bug: 396009828
Flag: EXEMPT simple fix
Change-Id: Icc6bd1c4fa7cf3c43eec1c4c950fbf778975f803
2025-02-14 14:53:56 +08:00
Yiyi Shen
80b28cb6cc [Audiosharing] Avoid concurrent issue when adding preference
Bug: 394685943
Flag: EXEMPT bug fix
Test: atest
Change-Id: I0d50dee9a36fd719236b52ab633a18818c3e10bb
2025-02-14 14:01:42 +08:00
Menghan Li
6b916e6f29 feat(A11yFeedback): Pixel overlay to expose the feedback bucket ID
This change introduces a feature provider for Pixel overlays, allowing
customization of the feedback bucket ID on Android.

Bug: 393980229
Test: Manual testing for Pixel and non-Pixel overlay in real device
Test: atest AccessibilitySettingsTest
            FeedbackManagerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: Ieeb1dba4de5c13a275e66781621cbfcca7219a5e
2025-02-14 03:01:41 +00:00
Menghan Li
c86e2f3472 feat(A11yFeedback): Add feedback entry for Accessibility page
This entry point allows users to access in the action bar.
Visibility is controlled by the aconfig and FeedbackManager#isAvailable

Bug: 393981463
Test: atest AccessibilitySettingsTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I8c219b8220b5839121d14959fe526e6200afeecb
2025-02-14 03:01:13 +00:00
SongFerng Wang
b7d640ef36 Merge "Check if ECBMode when activate SIM card" into main 2025-02-13 18:41:42 -08:00
William Leshner
e732852cfb Merge "Only show "hub mode" settings when the glanceable_hub_v2 flag is true." into main 2025-02-13 11:46:32 -08:00
Treehugger Robot
63e919d927 Merge "Inline MODES_API flag" into main 2025-02-13 09:43:04 -08:00
Matthew DeVore
3d09a33a73 Merge "Show per-displays pref groups after built-in" into main 2025-02-13 08:13:44 -08:00
Pierre Barbier de Reuille
bf50c0baef Create new sections for developer options
To group desktop experience and window management options

Test: Build and check
Bug: 390625230
Flag: EXEMPT (refactor)

Change-Id: Ie076501da68045fa5f1098423a42d32f16a02838
2025-02-13 15:18:39 +00:00
Ze Li
c66d7bdcf3 Merge changes If4a471e2,I5ed1713d into main
* changes:
  [Temp bonding] Clean up old guest device logic as requirements changed
  [Temp bonding] Move audio sharing settings up
2025-02-13 06:59:22 -08:00
Pragya Bajoria
ea1cad3776 Merge "Rename DesktopMode API back" into main 2025-02-13 05:36:02 -08:00
songferngwang
538fb34027 Check if ECBMode when activate SIM card
If in ECBMode, start ACTION_SHOW_NOTICE_ECM_BLOCK_OTHERS to show a
dialog instead.

This align with the deactivate sim case

Bug: 393298086
Test: atest SubscriptionActivationRepositoryTest
Test: adb shell cmd phone emergency-callback-mode
Flag: EXEMPT bugfix
Change-Id: Id40d087b7d2d3ca99504ec75bac1c5e29c67258d
2025-02-13 12:04:07 +00:00
Chelsea Hao
a219b4dabc Merge "Fix npe when broadcast code is null." into main 2025-02-13 02:09:35 -08:00
Ze Li
220312eab7 [Temp bonding] Clean up old guest device logic as requirements changed
Test: manual test
Bug: 362859132
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Change-Id: If4a471e2058873be5cdb0ee43371333ebdc9a38a
2025-02-13 17:17:29 +08:00
Menghan Li
267251aae3 feat(A11yFeedback): Add FeedbackManager for Accessibility page
This change introduces a new FeedbackManager class to identify and
determine the availability of user feedback. This API will be used
to check if feedback is available for a user to provide.

Bug: 393980229
Test: atest FeedbackManagerTest
Flag: com.android.server.accessibility.enable_low_vision_generic_feedback
Change-Id: I577aa626c18f5c449dc3970d1324cc4940d20639
2025-02-13 09:08:07 +00:00
chelseahao
8b42157d39 Show turn off talkback dialog if needed in find an audio stream page.
Test: atest
Bug: b/362151254
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Id48b6c360473202fed55f5b622a1967084ceef1c
2025-02-13 00:59:59 -08:00
chelseahao
af4b7112f0 Fix npe when broadcast code is null.
Test: atest
Bug: b/381775542
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Id342a4b3ce26927d5ae76c866da07763bf8fbfbe
2025-02-13 00:56:12 -08:00
Xinyi Mao
a000daad53 Merge changes from topic "improve_battery_usage" into main
* changes:
  [Expressive Battery] Implement the expressive style for anomaly hint chip
  [Expressive Battery] Refactor pref with anomaly hint.
2025-02-13 00:32:59 -08:00
Aleksander Morgado
bd56a0efd3 Merge changes from topic "hide-phone-number" into main
* changes:
  Phone number only available if telephony capable
  Phone number only available for admin users
  Added unit test for MobileNetworkPhoneNumberPreferenceController visibility
  Added unit tests for PhoneNumberPreferenceController visibility
2025-02-13 00:06:32 -08:00
chelseahao
1dfd19e5e0 Show turn off talkback dialog if needed in AudioStreamConfirmDialog.
Test: atest
Bug: b/362151254
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I29a20394193eca46ad8f42ffa0bceaad6f08da86
2025-02-12 23:49:08 -08:00
chelseahao
c967f95075 Skip "Stream paused" state change after a stream is set to "Wrong password" state.
Test: atest
Bug: b/396301469
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I2d7208cfffddbf6e885b6b1c78c478c582d488ef
2025-02-13 15:28:24 +08:00
Zoey Chen
23885c6351 Merge "[Settings] Add a flag to control show new System language picker UI or not" into main 2025-02-12 22:31:27 -08:00
Matthew DeVore
2edcb8de0c Show per-displays pref groups after built-in
When the built-in display settings as well as CD settings are both
present in the fragment, show external display settings category after
built-in. This applies to the per-display fragment and the initial
display list fragment.

Stop showing per-display settings nested in a parent list, as this was
causing extra spacing and complicating the code.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: ExternalDisplayPreferenceFragmentTest
Test: manually check topology mode for single display, multiple displays, in both fragments
Test: manually check v1 UI for single display, multiple displays, in both fragments
Bug: b/352648432
Bug: b/396116157
Change-Id: I7fdf72d198988feb1e7559f96a54f7680cf5b8a6
2025-02-13 05:27:05 +00:00
mxyyiyi
a2bdafaf5e [Expressive Battery] Refactor pref with anomaly hint.
- WarningFramePreference & warning_frame_preference.xml is a battery customized layout which looks like a standard Preference layout with an optional app icon & warning chip.
- PowerGaugePreference extends the WarningFramePreference to display the app Preference with optional warning chip in Battery > Battery Usage.
- PowerUsageTimePreference extends the WarningFramePreference to display the usage time with optional warning chip in Battery > Battery Usage > App battery usage.

Bug: 349652542
Test: atest BatteryUsageBreakdownControllerTest PowerGaugePreferenceTest PowerUsageTimeControllerTest
Flag: com.android.settingslib.widget.theme.flags.is_expressive_design_enabled
Change-Id: I5d22703ccc487c54a2bbbc1d9737b92a2de54ba5
2025-02-13 13:16:10 +08:00
Treehugger Robot
793a6802ac Merge "Fix accessibility issues in Private DNS Settings" into main 2025-02-12 21:08:22 -08:00
Treehugger Robot
8efba3fee5 Merge "Do not disable LE audio offload as the developer option being disabled" into main 2025-02-12 20:25:04 -08:00
Weng Su
b3938a0244 Fix accessibility issues in Private DNS Settings
- Keep the Save button enabled at all times

- Show error in the Hostname view to remind the user
  - "The field is required" error
  - "The hostname you typed isn't valid" error

Bug: 386323822
Flag: EXEMPT bugfix
Test: Manual testing
atest -c PrivateDnsModeDialogPreferenceTest \
         PrivateDnsPreferenceControllerTest

Change-Id: I63973bd5001b838d7f27827e6a6d4ac96ac78ca9
2025-02-13 12:05:25 +08:00