Commit Graph

9172 Commits

Author SHA1 Message Date
Joshua Mccloskey
c4f18bb77c Merge "Adding slice for Face Enrollment" into qt-r1-dev am: 35252d1b9f
am: ef3d1939c8

Change-Id: I3c3b28e6ac2e67a588f970d8eae706390f666bc1
2019-06-25 19:31:34 -07:00
Joshua Mccloskey
ef3d1939c8 Merge "Adding slice for Face Enrollment" into qt-r1-dev
am: 35252d1b9f

Change-Id: Ic36d9fd8f00b01fe4c35e005cd9192b9cfe900e9
2019-06-25 18:58:54 -07:00
Joshua Mccloskey
35252d1b9f Merge "Adding slice for Face Enrollment" into qt-r1-dev 2019-06-26 01:15:50 +00:00
Andrew Sapperstein
56a8c33c1b Add UI for mainline modules licenses.
Added a module licenses option that lives in Legal information settings.
Clicking that option opens module licenses page, which displays every
module by name, filtered to exclude modules without license files.
Clicking a module in the list opens HTMLViewer.

Created ModuleLicensesProvider, a new ContentProvider that serves as a
redirect for the Uris sent to HTMLViewer so that they open asset files.
In order to provide the redirect, the provider will write the license file
to a file in Settings' cache directory when the license does not exist
in the cache or is outdated. The provider then opens that cached file.

Fixes: 135183006
Test: robotests
Change-Id: I7d69da34780c8c4efb150d0c0411078c12bc80d8
2019-06-25 16:01:38 -07:00
Antony Sargent
46d819272a Check isWfcProvisionedOnDevice in WifiCallingSettings
On the SIM details page, the preference leading to a page for
configuring wifi calling will appear based on the results of the
MobileNetworkUtils#isWifiCallingEnabled helper function. That helper
uses the ImsManager to check several conditions, among them both
isWfcEnabledByPlatform and isWfcProvisionedOnDevice.

The page for configuring wifi calling has a tabbed UX, with one tab for
each active subscription that supports it. The WifiCallingSettings class
gets a list of the active subscriptions to determine which tabs to show,
and removes any that don't support wifi calling, but was only using the
isWfcEnabledByPlatform test to do so. This is a problem because the code
for showing the contents inside the tab, in WifiCallingSettingsForSub,
includes a sanity check of isWfcProvisionedOnDevice and calls finish()
if that returns false.

What this meant in practice is that if you happened to have 2
subscriptions where one returns true for both isWfcEnabledByPlatform and
isWfcProvisionedOnDevice, but the other only returned true for
isWfcEnabledByPlatform, then you'd never be able to succesfully use the
wifi calling page at all because the tab for the subscription you
*aren't* trying to configure would always call finish() early.

The right long term solution to this problem is probably to remove the
tabbed UX entirely from this page, since we probably don't need it given
the overall new multi-SIM UX. But there may still be legacy uses and
that is likely a bigger change than we want to make right now.

As a stopgap, this CL just adds a check of isWfcProvisionedOnDevice to
the code for filtering out ineligible subscriptions from the tabbed
interface, which we should have always had anyway.

Fixes: 135591718
Test: make RunSettingsRoboTests
Change-Id: I656c3d3fb30cb6fabcb86685eae38c5f0cd0c6f2
2019-06-25 14:16:53 -07:00
TreeHugger Robot
01d889815d Merge "Import translations. DO NOT MERGE" into qt-r1-dev 2019-06-25 19:24:19 +00:00
Antony Sargent
bc50fb8aef Merge "Add a listener for subscription changes to SimDialogFragment" into qt-dev
am: 87fadeeb4a

Change-Id: I59e0e265a5e91bed12d7e786d4fdd3043c068fed
2019-06-25 11:40:48 -07:00
TreeHugger Robot
87fadeeb4a Merge "Add a listener for subscription changes to SimDialogFragment" into qt-dev 2019-06-25 17:54:54 +00:00
Bill Yi
1f064f21bc Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I6a0682180e39156f0959521d47ec707c8da28819
2019-06-25 10:33:04 -07:00
Raff Tsai
50fca4ccdb Merge "Fix cannot switch between multiple TTS engines" 2019-06-25 15:32:15 +00:00
TreeHugger Robot
279050c8d6 Merge "Import translations. DO NOT MERGE" into qt-dev 2019-06-25 14:46:00 +00:00
TreeHugger Robot
28b1277992 Merge "Use FooterPreference in xml explicitly" 2019-06-25 11:39:32 +00:00
Bill Yi
fe1b808001 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I275c2124cebaca1f069837b138a01b9e11f77c55
2019-06-25 04:07:28 -07:00
tmfang
ec83f48e0d Use FooterPreference in xml explicitly
We don't rely on FooterPreferenceMixinCompat
to create footer preference in dashboard fragment.

Instead, declare a FooterPreference explicitly in
xml of screen.

Test: visual, robotest
Bug: 124129485
Change-Id: I4c5b60c3926583eb0d9f0d4cd6996bf169d6408c
2019-06-25 16:48:51 +08:00
Raff Tsai
a9fc062fd1 Fix cannot switch between multiple TTS engines
- We didn't reset reset radio button state when user click back
while dialog was popped. Change the UI, when user really accepts the
dialog content, then changes radio button state.
- Migrate TtsEnginePreferenceFragment to RadioButtonPickerFragment

Fixes: 135588938
Test: manual
Change-Id: Ia824e08d59c77a23e6590ff0f5b7d897a73a1ff8
2019-06-25 16:46:31 +08:00
joshmccloskey
6634c159fd Adding slice for Face Enrollment
Fixes: 134965754
Test: Verified slice appears when not enrolled.
Test: Verified slice does not appear when enrolled.
Test: Verified slice disappears after clicking on icon and going back
to settings page.
Change-Id: Id1c4458742ab622df8d5881e926fe54684b36843
2019-06-24 17:41:36 -07:00
Hai Zhang
089d734f35 Merge "Revert "Add special apps access settings page for financial app."" into qt-dev am: b39810f5ab am: 5f8c446f47
am: 3603e24840

Change-Id: I60a1cfb995b5511a9aeea19c851beec778472702
2019-06-24 14:37:31 -07:00
Hai Zhang
3603e24840 Merge "Revert "Add special apps access settings page for financial app."" into qt-dev am: b39810f5ab
am: 5f8c446f47

Change-Id: I4697c719c9274bd9a0ba5d4c8edf9e9a77454b7b
2019-06-24 14:32:28 -07:00
Hai Zhang
636920da48 Merge "Revert "Add special apps access settings page for financial app."" into qt-dev
am: b39810f5ab

Change-Id: Ia72e4fb5d1a7c930657ca26f15c58cd39220fe5e
2019-06-24 14:28:54 -07:00
Hai Zhang
5f8c446f47 Merge "Revert "Add special apps access settings page for financial app."" into qt-dev
am: b39810f5ab

Change-Id: I8ab0452cd656d25afe164dec49553512decfdcec
2019-06-24 14:28:54 -07:00
Hai Zhang
71f2614736 Revert "Add special apps access settings page for financial app."
This reverts commit 43374eabb8.

Reason for revert: No longer needed because we are using whitelist for
SMS permission

Fixes: 135213238
Test: presubmit
Change-Id: I182be4a1136521f325866e70e875439c17816ef2
2019-06-24 21:11:36 +00:00
Antony Sargent
45f0701380 Add a listener for subscription changes to SimDialogFragment
For some kinds of telephony changes that might happen while we're
already showing one of these dialogs, we already get sent a new intent
for the dialog which we internally convert into a refresh of the dialog
contents instead of stacking a new copy on top of the old one.

But it turns out there are some other cases where the telephony stack
doesn't send a new intent for the dialog but *does* send a change event
through the SubscriptionManager, and we want to respond to those as
well. This CL adds a listener for those events.

Fixes: 135276696
Test: make RunSettingsRoboTests
Change-Id: Ifb93ae95f45fda5831e112306dd9361ccaa5119c
(cherry picked from commit 6a1d7e60ac)
2019-06-24 16:58:40 +00:00
Julia Reynolds
050f5da680 Remove dead code am: ab63fd3c25 am: bf35e5cc55
am: 25d55fb821

Change-Id: I45b62580c01cf5a81443d7043f65755bb3986245
2019-06-21 10:45:47 -07:00
Julia Reynolds
25d55fb821 Remove dead code am: ab63fd3c25
am: bf35e5cc55

Change-Id: Idae478e2764f731f3a7f60a0da6752ba5ec88968
2019-06-21 10:23:27 -07:00
Julia Reynolds
3370e6cfb9 Remove dead code
am: ab63fd3c25

Change-Id: Ie0ff97b0db868f4f5aff19c4d8da2a8fc2a5717d
2019-06-21 10:15:12 -07:00
Julia Reynolds
bf35e5cc55 Remove dead code
am: ab63fd3c25

Change-Id: I8d629b89f8b8145e8381301d888aeb8b050123c8
2019-06-21 10:15:12 -07:00
Fan Zhang
e973b09087 Merge changes Iacc80db5,I66dc0bfd
* changes:
  Load preference title from uri if available
  Clean up ShadowTheadUtils.
2019-06-21 16:46:35 +00:00
Julia Reynolds
ab63fd3c25 Remove dead code
Test: try to search 'gentle'
Fixes: 135640138
Change-Id: If03703e59f77206da08fc80e88bb986f821c18fe
2019-06-21 13:24:05 +00:00
TreeHugger Robot
e5584cd39c Merge "Make the default value of flashlight availibility to true." 2019-06-21 05:23:30 +00:00
Yi-Ling Chuang
8235ed14a4 Make the default value of flashlight availibility to true.
We read from SettingsProvider to decide whether flashlight slice is
available. However, when switching to the second user, FLASHLIGHT_AVAILABLE
will be null. The default was 0 which causes the slice returning null,
so we have to set it to 1 when there is a physical flash unit to be
consistent with system ui.

Fixes: 134734608
Test: robotest
Change-Id: I981461b1b66e6e273e13a9cbcba96e3ccf0aec68
2019-06-21 10:46:44 +08:00
Fan Zhang
823c4daece Load preference title from uri if available
For injected tiles, allow clients to provide dynamic title from
contentproviders similar to dynamic summary.

Fixes: 131837802
Test: robotests
Change-Id: Iacc80db5d003473cf59ede67d88441947a834888
2019-06-20 15:47:38 -07:00
Fan Zhang
d71835125a Clean up ShadowTheadUtils.
Individual tests don't need to specify it in their own @Config

Bug: 135698296
Test: robotests
Change-Id: I66dc0bfdaec9c6cac9b48f3e7906f71dfb3a6b28
2019-06-20 15:17:42 -07:00
Raff Tsai
6acafce104 Merge "Cannot switch between multiple TTS engines" into qt-dev am: 753215fff9 am: 2c01fb911c
am: 864af1ff82

Change-Id: I85b1193f088fa1120fe9921066d5bf9e4bd3e071
2019-06-20 10:09:04 -07:00
Raff Tsai
864af1ff82 Merge "Cannot switch between multiple TTS engines" into qt-dev am: 753215fff9
am: 2c01fb911c

Change-Id: I74218aa4739f81aade84ba1e4ab9bb9ca090c7a2
2019-06-19 23:24:02 -07:00
Raff Tsai
2c01fb911c Merge "Cannot switch between multiple TTS engines" into qt-dev
am: 753215fff9

Change-Id: I5d399c7f653caf53041f1136948f4a8de457d7c5
2019-06-19 22:57:25 -07:00
Raff Tsai
72b48c91f8 Merge "Cannot switch between multiple TTS engines" into qt-dev
am: 753215fff9

Change-Id: Ia48e40c15b7c07e538e87e3c7ec242543c9f0d8c
2019-06-19 22:57:06 -07:00
Antony Sargent
2ee1249b01 Add a listener for subscription changes to SimDialogFragment am: 6a1d7e60ac
am: d985cb848f

Change-Id: Ifb25c4c11e394452b475442dbe452272f52b229e
2019-06-19 20:56:36 -07:00
Antony Sargent
d985cb848f Add a listener for subscription changes to SimDialogFragment
am: 6a1d7e60ac

Change-Id: I7fe944662d3a37223a997ed55d3197764df42a90
2019-06-19 19:07:32 -07:00
Antony Sargent
6a1d7e60ac Add a listener for subscription changes to SimDialogFragment
For some kinds of telephony changes that might happen while we're
already showing one of these dialogs, we already get sent a new intent
for the dialog which we internally convert into a refresh of the dialog
contents instead of stacking a new copy on top of the old one.

But it turns out there are some other cases where the telephony stack
doesn't send a new intent for the dialog but *does* send a change event
through the SubscriptionManager, and we want to respond to those as
well. This CL adds a listener for those events.

Fixes: 135276696
Test: make RunSettingsRoboTests
Change-Id: Ifb93ae95f45fda5831e112306dd9361ccaa5119c
2019-06-19 12:20:59 -07:00
TreeHugger Robot
21da32d9b1 Merge "Pull out PreferenceControllers from AccessibilitySettings" 2019-06-19 16:50:22 +00:00
Mill Chen
d37618c8ed Pull out PreferenceControllers from AccessibilitySettings
- clean up the format of accessibility_settings
- To leverage the existing TtsPreferenceController and
FontSizePreferenceController
- pull out the logic of magnification from AccessibilitySettings

Bug: 135056871
Test: manual, robotest
Change-Id: I414fa7a04fd558d3a3a8b5e157469c198a772732
2019-06-19 15:05:39 +00:00
TreeHugger Robot
174c9b7f82 Merge "Pull out a PreferenceController of lock screen from accessibility" 2019-06-19 10:15:25 +00:00
Mill Chen
dce601db84 Pull out a PreferenceController of lock screen from accessibility
To reduce the complexity of AccessibilitySettings, we are planning to
create a bunch of preference controllers. First of all, we are converting
lock screen preference to a preference controller. The rest part will be
uploaded soon.

Bug: 135056871
Test: robotest, manual
Change-Id: I6079136f3d08934c9a5363eb4d0e0ade29f8ba99
2019-06-19 16:44:42 +08:00
Raff Tsai
39c6a16aba Cannot switch between multiple TTS engines
That is caused by layout xml changes. The radio button was clickable
in old xml resource. But it is not clickable in new xml resource.
Therefore we can't receive click callback. Fixed by changing
Radio button state when preference is clicked.

Fixes: 135285101
Test: manual, make RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.tts"
Change-Id: Idd7bf37d9ccbc1b56d41978d19dc05c8a81cc49a
2019-06-19 16:35:35 +08:00
Malcolm Chen
af7b0ebb9c Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev am: 0304f4d1ce am: b3b52ce088
am: 47ea5ad9dc

Change-Id: Ida614addc7b6cc58178f91e7e6b2645100762723
2019-06-18 22:14:39 -07:00
Matthew Fritze
a891dd8743 Merge "MobileData slice should be null if not-actionable" into qt-dev am: e2ab7540a3 am: 1601d41f8a
am: ae7ca4133a

Change-Id: I1e3012e83243b9dd6be04f1ecc5d885836b8e022
2019-06-18 22:11:48 -07:00
Malcolm Chen
47ea5ad9dc Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev am: 0304f4d1ce
am: b3b52ce088

Change-Id: I672ddbb1a853d16e7a17a2c95fa4754e17d7055c
2019-06-18 20:48:05 -07:00
Matthew Fritze
ae7ca4133a Merge "MobileData slice should be null if not-actionable" into qt-dev am: e2ab7540a3
am: 1601d41f8a

Change-Id: Ic1bce363e5b6d6a5e52fcf3da6547d1976333f2e
2019-06-18 20:39:39 -07:00
Malcolm Chen
b3b52ce088 Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev
am: 0304f4d1ce

Change-Id: I3a78fe154d3861c779365d1e611ac8c559861a10
2019-06-18 20:29:39 -07:00
Malcolm Chen
cdae15bcc4 Merge "Replace isSubscriptionEnabled with isActiveSubId." into qt-dev
am: 0304f4d1ce

Change-Id: I9f91b0292b464e76db849163573031dba8bef5a1
2019-06-18 20:28:40 -07:00