Commit Graph

37091 Commits

Author SHA1 Message Date
Les Lee
d0745b39b6 Merge "Usage Settings: Fix NPE when subscriberId is Null." into sc-dev am: 787685b2cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14847052

Change-Id: Ibb93d30549d00dc7cd85f2d17332d27dcab5657a
2021-06-07 02:51:30 +00:00
Les Lee
787685b2cc Merge "Usage Settings: Fix NPE when subscriberId is Null." into sc-dev 2021-06-07 02:41:28 +00:00
Les Lee
204f0215da Usage Settings: Fix NPE when subscriberId is Null.
For mobile, a old API: buildTemplateMobileAll doesn't includes the
merged wifi network, call the new API: buildTemplateCarrierMetered
to replace the old one.

But new API: buildTemplateCarrierMetered requires non-null subscriberId.
Call old API: buildTemplateMobileAll when subscriberId is NULL since
the matched result is always empty when subscriberId is NULL. No any different
between buildTemplateCarrierMetered and buildTemplateMobileAll.

Bug: 190233044
Bug: 190135429
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SettingsDumpServiceTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=DataUsageLibTest

Change-Id: Ic6dada8260029e47e044d016ebc701c25dbf9b2a
2021-06-05 03:14:18 +00:00
Kevin Han
cbc3c1780d Merge "Move unused apps count calculation to bg thread" into sc-dev am: 603cd6c44c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14795269

Change-Id: I0aacb5fd54793c53b7f5ca15cbfb16128a7d6e80
2021-06-04 23:41:35 +00:00
Kevin Chyn
0a8fcd8fe9 Merge changes I490ad424,I92ae38b8,I5db49dd2 into sc-dev am: 4a0a03f0e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14840764

Change-Id: Id795687f5bc58a57a75f8222030f220a46f1988b
2021-06-04 23:41:23 +00:00
Kevin Han
603cd6c44c Merge "Move unused apps count calculation to bg thread" into sc-dev 2021-06-04 23:35:55 +00:00
Kevin Chyn
4a0a03f0e4 Merge changes I490ad424,I92ae38b8,I5db49dd2 into sc-dev
* changes:
  Update fingerprint/face enrollment to lock icon
  Update fingerprint intro drawable
  Remove SUW-specific fingerprint enroll description
2021-06-04 23:26:19 +00:00
Chloris Kuo
d07a484c46 Merge "Fix NotificationAssistantPreferenceController constructor" into sc-dev am: f9bde76ab9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14829751

Change-Id: I02e0e2ff3b9d6012a3ada8b215f79eec4e844c3b
2021-06-04 20:39:39 +00:00
Chloris Kuo
f9bde76ab9 Merge "Fix NotificationAssistantPreferenceController constructor" into sc-dev 2021-06-04 20:27:46 +00:00
Kevin Chyn
47257c05c8 Remove SUW-specific fingerprint enroll description
Bug: b/187460696
Test: adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity
Change-Id: I5db49dd27439445aae9819dbdd0728ac5c02f0cd
2021-06-04 12:47:35 -07:00
TreeHugger Robot
f436f855c0 Merge "Fix LifecycleObserver implementation in SmartAutoRotateBatterySaverController" into sc-dev am: 8d9d889a8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14628750

Change-Id: If23049d5758d7e2c87ead1c903d1fef36a577b5c
2021-06-04 18:42:16 +00:00
Chloris Kuo
5028e6e6a6 Fix NotificationAssistantPreferenceController constructor
Fix flaky test due to the constructor must either only take Context, or
(Context, String).

Bug: 187998873
Test: CodeInspectionTest, NotificationAssistantPreferenceControllerTest
Change-Id: Ie383ea6773afda05adfb7aa9d7de9e27676f6b29
2021-06-04 11:39:36 -07:00
TreeHugger Robot
8d9d889a8e Merge "Fix LifecycleObserver implementation in SmartAutoRotateBatterySaverController" into sc-dev 2021-06-04 18:31:03 +00:00
TreeHugger Robot
017de20112 Merge "Storage Settings hides categories when loading" into sc-dev am: 03d4644673
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14772155

Change-Id: Ic8a5886cd19213cc4fe54157fa441b107e1db15c
2021-06-04 11:26:14 +00:00
TreeHugger Robot
03d4644673 Merge "Storage Settings hides categories when loading" into sc-dev 2021-06-04 11:09:01 +00:00
Stanley Wang
7e462377b9 Merge "Fix NPE in SettingsMainSwitchPreference." into sc-dev am: d9aa0b070f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14831309

Change-Id: Ic1eb86fc571e27b0f26714db4d419dd5751e51c1
2021-06-04 10:10:11 +00:00
TreeHugger Robot
6ad33a5d97 Merge "Apply sliding transition to biometric settings" into sc-dev am: 7f13b83ef1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14819341

Change-Id: I96f538cdd948d4b368267376119906c702a9fd49
2021-06-04 10:09:56 +00:00
Stanley Wang
d9aa0b070f Merge "Fix NPE in SettingsMainSwitchPreference." into sc-dev 2021-06-04 10:06:32 +00:00
TreeHugger Robot
7f13b83ef1 Merge "Apply sliding transition to biometric settings" into sc-dev 2021-06-04 09:57:37 +00:00
Arc Wang
10e549ac37 Set storage volume spinner invsible when only 1 volume am: 1beae1bf91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14831304

Change-Id: I8751d6f4c84dd1e02989932acf64803c40cebbdb
2021-06-04 09:11:50 +00:00
Stanley Wang
481b3abe0d Fix NPE in SettingsMainSwitchPreference.
- Check if the RestrictedPreferenceHelper is null to avoid NPE.

Fix: 190135868
Test: run robotest and manually test that page.
Change-Id: I746099260d8f53dc30513ccbb30aec5cbe3657e7
2021-06-04 16:15:04 +08:00
Yi-Ling Chuang
9312dc83fa Apply sliding transition to biometric settings
Bug: 187542491
Test: rebuild
Change-Id: Ife645785a37c4ac838204d0613dffd5a5911a47e
2021-06-04 15:49:43 +08:00
Arc Wang
1beae1bf91 Set storage volume spinner invsible when only 1 volume
Bug: 189390166
Test: atest StorageSelectionPreferenceControllerTest
Change-Id: I93e5fbf50153580ec60c146959d21e61f556c18c
2021-06-04 07:25:30 +00:00
TreeHugger Robot
da161056df Merge "Fix phishing attacks over Bluetooth due to unclear warning message" into sc-dev am: 367fe0eae0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14809886

Change-Id: I04e4a269da323bbf06a2ecca565113f1468a6c36
2021-06-04 06:25:15 +00:00
TreeHugger Robot
367fe0eae0 Merge "Fix phishing attacks over Bluetooth due to unclear warning message" into sc-dev 2021-06-04 06:17:01 +00:00
Arc Wang
51b3e7a093 Storage Settings hides categories when loading
To hide sorting animation.

- Storage Settings always loads cache and updates UI, then
  loads storage size and updates UI.
  Remove the chche design because storage category preferences
  will hide during loading, it no meaning to load from cache
  and update UI.

- Hides loading circle before storage category preferences
  become visible, it prevents flickers.

- Remove Calculating... summary of StorageItemPreference.

- Private storage category preferences and secondary user
  preference become visible at
  StorageItemPreferenceController#onLoadFinished.

Bug: 188731179
Bug: 185547228
Bug: 188615591
Test: atest com.android.settings.deviceinfo
      atest com.android.settings.deviceinfo.storage
      make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.deviceinfo
      make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.deviceinfo.storage
      manual visual
Change-Id: I3ebef5829ef4f806add07f58fa02520804768be5
2021-06-04 11:50:12 +08:00
TreeHugger Robot
a00244929c Merge "Disable RecyclerView animation to fix the broken UI" into sc-dev am: 3d94997425
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14819331

Change-Id: I85cf80bd2d966dce3287baabbad96431ff0435ff
2021-06-04 02:30:19 +00:00
Kevin Han
8df22e7cd9 Move unused apps count calculation to bg thread
Move the somewhat expensive calculation of the "Unused apps" count to
the background thread

Initially, the "Unused apps" preference is unavailable. When the bg work
finishes and we see we have a non-zero number of unused apps, we display
the preference and update the summary text.

Bug: 187996287
Test: atest HibernatedAppsPreferenceControllerTest
Test: measure latency of displaying preferences w/ custom trace points

Change-Id: Idb0d836fd8f4bcdd2605a7d59703a7ed53bcd6d4
2021-06-03 19:14:25 -07:00
TreeHugger Robot
3d94997425 Merge "Disable RecyclerView animation to fix the broken UI" into sc-dev 2021-06-04 01:56:54 +00:00
Abel Tesfaye
09ed6e8e29 Merge "Use list+ toggle on devices without face detection" into sc-dev am: 040e5ef894
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14040065

Change-Id: Ia50dc8db66f913e916bc43a82ce010d0be0793c7
2021-06-03 16:52:43 +00:00
Abel Tesfaye
040e5ef894 Merge "Use list+ toggle on devices without face detection" into sc-dev 2021-06-03 16:40:58 +00:00
Les Lee
0c4c0e5e33 Merge "wifi direct: Close the channel after leaving the Setting page" into sc-dev am: c48cf5ee37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14786728

Change-Id: If754ac8946aa0e6faf3fba705b15b4fe1519c3ae
2021-06-03 14:22:10 +00:00
Les Lee
c48cf5ee37 Merge "wifi direct: Close the channel after leaving the Setting page" into sc-dev 2021-06-03 14:08:51 +00:00
Yi-Ling Chuang
5b219a34ab Disable RecyclerView animation to fix the broken UI
RecyclerView has item animation by default. In this bug, RV animation
seems to be interrupted by the page transitions(Shared Axis), and so
items could not finish sliding to its position.

Hence, disable RV animation to fix it.

Fixes: 189720797
Test: Navigate to Mobile & Wifi usage page and see the normal UI.
Change-Id: I52920715ae4b63ef78a73fcb9c76c6d20f80e012
2021-06-03 18:12:07 +08:00
Hugh Chen
10e4599219 Fix phishing attacks over Bluetooth due to unclear warning message
This CL add more prompts presented for users to avoid phishing attacks.

Screenshot:
https://screenshot.googleplex.com/p5PZbphN46ddPFV.png
https://screenshot.googleplex.com/6Q2wKfPbNQmTtx8.png
https://screenshot.googleplex.com/987VpYgNUZL2K4T.png
https://screenshot.googleplex.com/9eVg6SAGScVXU8U.png

Bug: 167403112
Test: manually test
Change-Id: Iadec059b662fd91754ad573bbe688702cdd3c9af
2021-06-03 16:42:09 +08:00
Les Lee
5294e3f9ab wifi direct: Close the channel after leaving the Setting page
Bug: 188375791
Bug: 184504089
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiP2pSettingsTest
Change-Id: I4eff0472fd3cb12e006b5e85f5cdb6b979c93fe5
2021-06-03 15:31:28 +08:00
Betty Chang
d18caf8fa8 Merge "Remove Connect to public network for Network Rating Provider" into sc-dev am: f4fafb97ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14809873

Change-Id: I4d23766f6fa93033b2490cdf1edeff58c4ee16d6
2021-06-03 07:25:50 +00:00
Betty Chang
f4fafb97ff Merge "Remove Connect to public network for Network Rating Provider" into sc-dev 2021-06-03 07:21:04 +00:00
Yanting Yang
4dadee105a Merge "Deprecate silky flag for official release" into sc-dev am: 09666f9ef4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14800152

Change-Id: I9bb58d58df5d9ba6938952b88d4bdec7985a81f9
2021-06-03 04:22:57 +00:00
Yanting Yang
09666f9ef4 Merge "Deprecate silky flag for official release" into sc-dev 2021-06-03 04:05:26 +00:00
Jason Chiu
cbb49b6f3f Merge "Revise homepage colors" into sc-dev am: 132cc2127b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14797776

Change-Id: I045d589aa0593e1bd33fe0724f6456fcd00020a5
2021-06-03 03:57:24 +00:00
Jason Chiu
132cc2127b Merge "Revise homepage colors" into sc-dev 2021-06-03 03:31:06 +00:00
changbetty
de57c12412 Remove Connect to public network for Network Rating Provider
According we remove the Network Rating Provider in ag/14675092, and the
Connect to public network item is tied to the Network Rating Provider.
So need to remove together.

Bug: 187119482
Test: Manaul test
      make RunSettingsRoboTests ROBOTEST_FILTER=ConfigureWifiSettingsTest
Change-Id: Ie8a8d5c8d9f2c5db11d6c9e6f84af7864e78814f
2021-06-03 11:22:19 +08:00
Bonian Chen
4cf2c2b10f Merge "[Settings] Connected carrier should not be forbidden ones" into sc-dev am: b71dd1efd2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14788603

Change-Id: Iac562f776c021db8f8a59a29504f45fa96778b07
2021-06-03 02:33:32 +00:00
Bonian Chen
b71dd1efd2 Merge "[Settings] Connected carrier should not be forbidden ones" into sc-dev 2021-06-03 02:17:06 +00:00
Kevin Chyn
924105b7d8 Merge "Fix array out of bounds in BiometricEnrollActivity" into sc-dev am: ef963fe079
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14801930

Change-Id: Ia28780a2596557e4e8028f6564734162f69d0086
2021-06-02 20:22:27 +00:00
Kevin Chyn
ef963fe079 Merge "Fix array out of bounds in BiometricEnrollActivity" into sc-dev 2021-06-02 20:03:38 +00:00
Abel Tesfaye
faaf8d5af1 Use list+ toggle on devices without face detection
Test: verified intended behavior on crosshatch and no regression on flame, make RunSettingsRoboTests -j$(nproc) ROBOTEST_FILTER=SmartAutoRotatePreferenceFragmentTest

Bug: 181299673
Change-Id: Ic9f44091e95915bc78bc70b86d7f132ba6e159ed
2021-06-02 19:25:59 +00:00
Trevor Black
220f6d734a Merge "Remove extra app info setting under specific condition" into sc-dev am: 6c0a701540
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/14788858

Change-Id: I8dd53d4e08b465acf7272c6c91338b2acd1f575f
2021-06-02 18:20:38 +00:00
Trevor Black
6c0a701540 Merge "Remove extra app info setting under specific condition" into sc-dev 2021-06-02 18:13:01 +00:00