Commit Graph

33 Commits

Author SHA1 Message Date
Fan Zhang
89d7bca166 When click conditional's title, expand/collapse content.
Bug: 30200101

It used to lead user to detailed setting for that conditional. This
leaves some confusion about which click target goes to where.

Change-Id: Ic9525ace65ca488f4e709576fb1ec96a1cb99938
(cherry picked from commit a2db2ca8fa)
2016-08-22 18:30:16 +00:00
Fan Zhang
0aebaf1556 Set correct flag when enabling listener for conditions.
Bug: 30551655

Without this flag Settings app will close whenever listener is
enabled/disabled.

Change-Id: I99102308ada3897cf44917e96015c71b926e5fb5
2016-08-01 13:58:57 -07:00
Fan Zhang
bebba4478d Never disable DnD receiver to dislay condition correctly.
Bug: 30360853
Change-Id: I3e470c2955d7f066970442e281f9d66b153b8d10
2016-07-27 11:08:29 -07:00
Fan Zhang
a0ebd1a9f0 Refresh state after loading conditions from xml.
Fixes: 30330909

When start Settings, conditions is loaded from a xml with potentially
stale state. ConditionLoader needs to refresh states after reading xml
to make sure they are up to date.

Change-Id: Ice1b8bacb0486c5dd230b83670c1494710d1c061
2016-07-25 13:58:39 -07:00
Jason Monk
bd6a4f9066 Merge "Protect against work conditional crash" into nyc-mr1-dev 2016-07-20 13:28:13 +00:00
Justin Klaassen
d60f09edaf Add Night display settings conditional
Bug: 30043281
Change-Id: I2464cd90f1f7f379aabf123f602e6150a87120cf
2016-07-19 14:31:46 -07:00
Jason Monk
31678f14e9 Protect against work conditional crash
Change-Id: Iba6e7281c622e3ba34fa6bd4672b2380b0329808
Fixes: 30014085
2016-07-19 14:22:14 -04:00
Christopher Wiley
9d251279ca Do not use TetherUtil.setWifiTethering
This functionality is replaced by ConnectivityManager.startTethering()
and ConnectivityManager.stopTethering().

Bug: 30147602
Test: Can toggle tethering on/off via all of settings, quick settings,
      and quick quick settings.
Change-Id: I4d190185c473237982b988f898e76d4997dc401c
2016-07-18 11:17:14 -07:00
Jason Monk
095d9e3d3f Fix DND conditional null state
Persist all of the data it needs to produce the UI.

Change-Id: Ifb143b2cd3fef075cd77feaf53051eb8b7153a51
Fixes: 27664882
2016-06-27 12:29:47 -04:00
Jason Monk
e4d0ed502d Fix crash from battery saver switch
Turns out most things expect the conditions to be loaded immediately
so if the dashboard hasn't been hit, they crash.  Instead load
immediately for everything but the dashboard.

Change-Id: Iaa1114c88b3766e2ac513acb417ef2a55a0f4e7f
Fixes: 28952354
2016-05-26 11:07:53 -04:00
Jason Monk
6cb280d146 Don't update conditions on background threads
Instead build a list and set it on the main thread to avoid
concurrent modification crashes.

Change-Id: I936fbeb70359583e55ae8ddcb0ea46b5753cb3b0
Fixes: 28794277
2016-05-25 12:53:34 -04:00
Jason Monk
2386dfc18d Dashboard performance work
Push more stuff to backround threads (this will cause conditions/suggestions
to load slightly slower than normal content) and cache more info.

Fixes: 28613950
Bug: 28435146
Change-Id: I1080930e8f31c7f12a2d89f266bfd3236979cf40
2016-05-06 13:17:47 -04:00
Clara Bayarri
58440b2801 Fix Settings Condition expand button a11y label
Bug: 27276008
Change-Id: Ie62ed8a73b300948f053b5d35f344bce3b63869a
2016-04-27 16:54:22 +01:00
Zoltan Szatmary-Ban
295f1060e9 Merge "Apply policy transparency to HotspotCondition and WiFi settings..." into nyc-dev 2016-04-19 13:25:22 +00:00
Zoltan Szatmary-Ban
3f6208170d Apply policy transparency to HotspotCondition and WiFi settings...
...when there is an active hotspot and user restriction for disallowing
tether config is in effect. This is to avoid getting security exceptions
from WifiManager when engaging with HotspotCondition or Wifi enable switch.

Bug:27936528
Change-Id: Ib3324e853277c177966b55668758d349ffe6ecf5
2016-04-15 16:13:27 +01:00
Benjamin Franz
89726fd952 Merge "Only try disabling quiet mode" into nyc-dev 2016-04-15 14:53:16 +00:00
Jason Monk
d49a846a39 Don't debug log on ConditionManager
Change-Id: I383c8ca4cfea732ace8213a17df375babad5f793
2016-04-13 15:30:07 -04:00
Benjamin Franz
e00cd80a1e Only try disabling quiet mode
The underlying API has slightly changed to require the profile
challenge if the profile that we're trying to enable hasn't been
unlocked yet.

Bug: 27764124
Change-Id: I9efb3d3ed49034b573abb4c18119ffadcccfe947
2016-04-13 19:14:37 +01:00
Jason Monk
5673ced93c Work on settings startup speed
- Cut down on amount stored in conditions xml
 - Remove extra work from dashboard startup
 - Move summary to min priority

Change-Id: I51ca3828e4446632d6faa60dcfbab3446d19d335
Fixes: 28134360
2016-04-12 15:19:50 -04:00
Fan Zhang
905002a01d Fix animation when expand conditional notices in Settings.
Bug: 28017593
Change-Id: I8275cb2050f79d26e58c02ffd91cb1a3e32a5ff2
2016-04-06 10:07:03 -07:00
Jason Monk
f20c718f19 Add metrics for settings conditionals
Bug: 27851236
Change-Id: I400716457d3f628419410a02c2a457d41d19a067
2016-03-30 15:46:26 -04:00
Jason Monk
ef6671b0b7 Fix clickability of conditionals
Bug: 27700081
Change-Id: If991419541dd021197ea641f8b2caee5cc16af36
2016-03-16 16:25:09 -04:00
Jeremy Klein
c69f2be466 Merge "Remove TetherUtil functions which are no longer needed." 2016-02-05 18:15:30 +00:00
Jeremy Klein
3a14416d55 Remove TetherUtil functions which are no longer needed.
Change-Id: I8559a2aaffa44e165d4e5e9070a85f23ed02b58b
2016-02-04 18:58:14 -08:00
Jason Monk
6fdf1669e1 Add animation for condition card height change.
Change-Id: If648914426cf6db5b039114cf593915c3b2e6c8c
2016-02-04 15:44:50 -05:00
Jason Monk
764f45db91 Add data saver to settings
Bug: 22817899

Change-Id: Ic3055aa6a5baae1653db350313366f180c049cc7
2016-01-25 15:24:29 -05:00
Mahaver Chopra
d39995b7c4 Work mode conditional switch in main settings
Bug: 26533692
Change-Id: Ifa235bc54c2c6e904cb1cf4fab06d727cde2492a
2016-01-19 17:41:36 +00:00
Jason Monk
aca0f1cf8a Fix airplane mode conditional primary click
Change-Id: Iacd83b53be224ad8fd55fe176f66a0d724576247
2015-12-16 15:58:59 -05:00
Jason Monk
c685853bb8 Add background data off conditional
Change-Id: If51fdaecc880560c4a0cd8d320b06804cfe98388
2015-12-16 12:58:39 -05:00
Jason Monk
70ecea2207 Add cellular data off conditional
Change-Id: I34980f3fc09bf5dd47eb296c5b1c5fccc87b5c90
2015-12-16 12:42:22 -05:00
Jason Monk
af24b6377e Add battery saver conditional
Change-Id: If80b749185537f252dae88230f80b29bcf321fdf
2015-12-16 12:38:32 -05:00
Jason Monk
ffb4535d3a Add dnd conditional
Change-Id: I81eabf274bde05358c60bb63e1ed6d1bd447ce55
2015-12-14 15:34:12 +00:00
Jason Monk
db4ed191de Add conditionals to Settings
Also add Airplane Mode and Hotspot conditionals (more to come soon)

Change-Id: I11f206db59f7c715f416fb5852b8f0fcb857a247
2015-12-14 10:29:12 -05:00