Commit Graph

136 Commits

Author SHA1 Message Date
Pavel Grafov
b49eb4348a Make work challenge pattern resizeable.
Currently in split-screen mode if work challenge window is made too narrow,
the dots of the pattern will go beyond window/screen boundaries. This change
makes pattern behave in the same way as primary profile pattern does, see
confirm_lock_pattern_normal.xml

Fixes: 133135598
Test: manual, resizing work challenge in portrait and landscape.
Change-Id: I40649911c2b7c587bf0b7e4a5c0449a5c2b7abb0
2019-05-29 14:41:33 +01:00
Arc Wang
386318dbea Fix view overlap in landscape wifi dpp enrollment.
Bug: 132813855
Test: manual
Change-Id: I961dcc88e044dc1ba6dc3d87d9820a2ced5196ee
2019-05-20 13:17:14 +08:00
Arc Wang
10371fd3a5 Add margin 24dp to the error message of Wi-Fi QR code scanner
Bug: 131628073
Test: manual
Change-Id: I8eaf461efbc8e3c44952d92b151ca621c4640bc1
2019-05-08 09:53:15 +08:00
pastychang
f8409db196 Set description textview to fixed id
Modify to fixed id for landscape Glif layout and non-glif layout

Test: Manual
Bug: 130707943
Change-Id: I6346817e582c2aac26753b3a985038cb0ca421bc
2019-04-18 07:43:30 +00:00
Arc Wang
3f2298c4fd Merge "Fix Wi-Fi Easy Connect QR code scanner problems" 2019-03-29 01:57:35 +00:00
Maurice Lam
9c2fae83a3 Fix fingerprint icon on pattern screen
Test: atest [...]/ChooseLockPatternTest.java
Bug: 129342100
Change-Id: I4e670b6265fe4a77ecbd8ede9a703fa0762f7504
2019-03-26 18:50:21 -07:00
Arc Wang
8ae9717226 Fix Wi-Fi Easy Connect QR code scanner problems
1. When camera area overlaps display cutout, it's onLayout size is 0/0.
   To fix it, use ConstraintLayout to specify width and height in layout file.

2. When scanned a QR code and there is an error, set camera area frame line
   back to unfocused color.

Bug: 124399763
Test: manual test
Change-Id: I7575efd0ccfb58d114acc3dcca6978d68b801f91
2019-03-26 16:07:02 +08:00
Arc Wang
abfd8ab726 Improve Wi-Fi Easy Connect lock screen UI information
1. Change lock screen title and remove description
2. In QR code generator screen, change summary and show password under QR code picture

Bug: 128920152
Bug: 128576809
Test: manual test
Change-Id: Id096d7f417308df14ffe50c618644750aa991df8
2019-03-21 14:09:22 +08:00
Matthew Fritze
cafeaadaa6 UX Fixes for Settings Panels
UI Fixes include:
- Fix height of bottom bar
- Fix start / end padding of See More and Done buttons
- Remove scroll shadow in recycler view
- Consolidate most layout code into a single file, only
separating the distinguished elements into the landscape file.

I cannot fix b/126731930 until a Slice bug is fixed, where the top
padding is applied to the bottom of sliceview instead.

Fixes: 126720235
Fixes: 126720220
Fixes: 126720167
Test: manual inspection & layout inspector

Change-Id: I6e3434aabe221134e7278f92bab34122719c179a
2019-02-28 16:16:10 -08:00
Matthew Fritze
db7fe5e5f7 Fix panel bugs
Add unique task affinity so the panel activity
always opens alone. Apparently the launchMode="singleTop" was
insufficient.

Test: manual app
Fixes: 126385021
Fixes: 126386586
Fixes: 126326438
Change-Id: I775e84701d006cfbe0d9ddfff83669b3f8487b33
2019-02-26 14:14:56 -08:00
Arc Wang
8826721803 Add progress bar for Wi-Fi DPP handshaking
Bug: 124127483
Test: manual test
Change-Id: I1c3da5bab98da57ca8cf10509f339e99b01ebdbf
2019-02-22 11:42:08 +08:00
Arc Wang
7bdcadbe72 Handle different error codes in DPP
Show error message for corresponding Wi-Fi DPP error code. And

1. To update error message only from each fragment,
   remove some callbacks which calls from fragment to activity.
2. After clicking 'Share Wi-Fi' button, hide it before Wi-Fi DPP handshake completes.
3. Show 'Done' button for some error codes.
4. Use ViewModel to call startEasyConnectAsConfiguratorInitiator and
   startEasyConnectAsEnrolleeInitiator because a lifecycle object
   does not receive an Executor callback after configurator change.
5. In WifiDppQrCodeScannerFragment, show an error message for 10s instead of 2s
   since new added error messages may carry more information.
6. Show a different error message for enrollee handshake success but Wi-Fi
   connection fail case.
7. stop camera when scanned a Wi-Fi DPP QR code for enrollee.
8. In QR code scanner fragment, support to show error message after
    configuration change.

Bug: 124247872
Bug: 124491247
Test: manual test
      atest WifiQrCodeTest
      atest WifiDppConfiguratorActivityTest
      atest WifiDppEnrolleeActivityTest
      atest WifiDppQrCodeGeneratorFragmentTest
      atest WifiDppQrCodeScannerFragmentTest
      atest WifiNetworkListFragmentTest
      atest WifiDppChooseSavedWifiNetworkFragmentTest

Change-Id: Id130215e9ddafac8bc4c68238deda48ce99b4255
2019-02-20 14:28:52 +08:00
Fan Zhang
bcefbf288c Remove weird background color on stroage donut in dark mode
Bug: 124313940
Test: visual
Change-Id: Ie95c98c23bb67570418e49a1c6677d4b6809b5d2
2019-02-13 14:17:47 -08:00
Kevin Chyn
43626165e3 Remove extra button from fingerprint enroll layout
The button doesn't even respond due to other code changes.
Buttons are now created in java using SUW library

Change-Id: I96943c973e23a06fe5f07c074f2c35f4bcc05dd3
Fixes: 122371369
Test: Only footer button shows
2019-01-11 14:03:46 -08:00
Pasty Chang
43bb34e15c Merge "Rename prefix from suw to sud" 2019-01-10 06:56:20 +00:00
Arc Wang
8eda83d071 Add more Wi-Fi DPP UI features.
1. Use ConstraintLayout to fix footer buttons at bottom
2. ScrollViews have all other UI components excepts footer buttons
3. Use style/SuwGlifButton for buttons
4. Fix scan fragment crash when rotating screen

Bug: 118794978
Test: manual test
Change-Id: I509b0156c4835c75da75fb7ac4c82f55a0b506a1
2019-01-09 18:25:31 +08:00
pastychang
79614823cb Rename prefix from suw to sud
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: I44a399b586671c100cb9d85c97effbfb1a379413
2019-01-04 10:46:20 +08:00
Johnson Lu
f0c2cc4466 Merge "Adjust landscape layout of QR code scanner/generator" 2019-01-03 05:49:22 +00:00
Johnson Lu
cb36eb394c Adjust landscape layout of QR code scanner/generator
Bug: 118794858
Test: RunSettingsRoboTests
Change-Id: Ifaef7c5fe02abbb377efeb0ab345976ab439aeb0
2019-01-03 11:41:26 +08:00
Amin Shaikh
a5e8bddc46 Update Settings text styles to use DeviceDefault.
- Replace all TextAppearance.Material styles with the equivalent
TextAppearance.DeviceDefault style
- Reparent Theme.Settings.HomeBase to inherit from Theme.Settings. This
ensures that the correct textAppearance theme attributes are applied
throughout the Settings application.

Bug: 121211932
Test: manually opening Settings and enabling/disabling HotDogOverlay
Change-Id: Ibe4873ed0294de79dbb6aeca464d14c291239c4b
2019-01-02 16:08:19 -05:00
Raff Tsai
f6d42a99d1 Clean up styles and aliases
- Remove unused style
- Remove identical style declaration

Test: Manual, Robolectric
Change-Id: Ia98ed82e6ccd4a25af6abbc66709eda1867581ee
2018-12-26 12:56:48 +08:00
Cn Chen
8428d04677 Merge "Change layout prefix of setupdesign from suw to sud" 2018-12-24 03:52:00 +00:00
pastychang
8d2dc16d7f Change layout prefix of setupdesign from suw to sud
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: Icd24f0336191c4575838cb1b9d131c885304b527
2018-12-24 10:13:54 +08:00
pastychang
1b1666855e Migrating to new footer button for fingerprint and face enrolling pages.
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: I89a5e3674b8ba9ec66945c03c9b783664eee214f
2018-12-19 23:24:48 +08:00
Arc Wang
9dbc040510 Merge "Fine tune UI layout files of WifiDppQrCodeScannerFragment & WifiDppQrCodeGeneratorFragment" 2018-12-18 07:26:47 +00:00
Arc Wang
fb0a081848 Fine tune UI layout files of WifiDppQrCodeScannerFragment &
WifiDppQrCodeGeneratorFragment

    1. Remove footer in landscape QR code scanner fragment
    2. Move header icon from activity layout file to header layout file
    3. Fine tune header layout file
    4. set icons for the 2 fragments

Bug: 118797380
Bug: 118794858
Test: atest WifiDppConfiguratorActivityTest
      atest WifiDppQrCodeScannerFragmentTest
      atest WifiDppQrCodeGeneratorFragmentTest
      atest RunSettingsRoboTests

Change-Id: I7e547d7c29dd947a890e902e61b8244fec399354
2018-12-18 02:23:22 +00:00
Johnson Lu
ebbb0bc563 Adjust camera preview area to square
1.Choose the smaller size of both dimensions as its size.
2.Set transform matrix to crop and center the preview picture.

Bug: 118797380
Test: make RunSettingsRoboTests
Change-Id: Ic65fb1fe0c5082995d6903f50dda48eec16c3fb1
2018-12-15 16:07:02 +08:00
Pasty Chang
c1f8600d9f Change to use setupcompat and setupdesign for suw pages
1. remove the dependence of setupwizardlib.
2. add to use setupcompat and setupdesign.
3. modify new footer button in following up cl.

Bug: 120805516
Bug: 120872944
Test: RunSettingsRoboTests
Change-Id: I463dd35b799d4250b2aabce0cb0b8102cf9dd7d6
2018-12-12 03:16:29 +00:00
TreeHugger Robot
830e6d4f13 Merge "Update SettingsPanel UI" 2018-12-01 06:51:53 +00:00
Johnson Lu
a558c01696 Integrate QrCode Camera with WifiDppQrCodeScannerFragment
Bug: 118797380
Test: RunSettingsRoboTests
Change-Id: I328bebbbcf44136df2c18ca1929a5da377a0cf6b
2018-12-01 09:03:39 +08:00
Matthew Fritze
c14316c4a9 Update SettingsPanel UI
UI changes include:
- RecyclerView to host slices
- Font family to headline font
- Title is now centered
- Added SeeMore & Done buttons
- Horizontal Dividers between slices
- Indented Slices
- Landscape layout is fullscreen

Change-Id: I3549c847fc88edd81f670ddfa2907dd3741441e0
Screenshot: https://screenshot.googleplex.com/RzWktzOZJkc
Test: Robolectric
Test: Manual app
Bug: 118622007
2018-11-30 13:26:50 -08:00
Stanley Wang
1ed36d8b23 Layout updated for file size text wrapping with largest display
This solution will change the portrait layout for
large, larger, and largest of Display size.

Change-Id: Ib00b23553c34c1e69cb84e446f409c38ea7544ef
Fixes: 69074097
Test: manual
2018-11-14 16:31:53 +08:00
Kevin Chyn
e5a016e076 1/n: Prepare ConfirmDeviceCredentials to use BiometricPrompt
CDC is going to use BiometricPrompt instead. This change
removes FingerprintManager from CDC. BiometricPrompt
will show before pin/pattern/pass is shown.

Bug: 111461540

Test: modified BiometricPromptDemo to use
      KeyguardManager#createConfirmDeviceCredentialIntent,
Test: Fingerprint is gone from CDC, rotation works
Test: atest SettingsRoboTests

Change-Id: I9ce2aad71961af8a0d5ee636600e2fbdb6154e47
2018-11-01 14:11:57 -07:00
TreeHugger Robot
20bb2edda7 Merge "Update fingerprint illustration" into pi-dev 2018-04-14 01:36:27 +00:00
Maurice Lam
a0248df148 Update fingerprint illustration
Test: Manual
Bug: 74410378
Bug: 74410267
Change-Id: I8ef052ea7f1cd6406001d383cab5825ed8f6d5f5
2018-04-11 11:03:36 -07:00
Maurice Lam
8ca084e62b Fix landscape pattern enroll crash
Test: atest SetupChooseLockPatternTest.java
Bug: 77878150
Change-Id: Ie54286765ea0d766bcc9e2c8e56cfbda919d5fd7
2018-04-10 19:53:41 -07:00
Maurice Lam
3e3b8a9618 Make GLIF theme default for confirm lock screen
Use GLIF theme as the default for confirm lock screen, even for
"external" launches of the screen. Renamed the theme from "internal"
to "normal" to reflect this change.
Dark theme code will be cleaned up later.

Test: Existing tests pass
Bug: 62573742
Change-Id: I86958eb3a440d7274807f1cf453c3e53c16c23e7
2018-03-21 18:21:04 -07:00
Ajay Nadathur
6f6a7c6412 Fix NPE in SetupChooseLockpattern screen
bug: 71807569
Test: Manually tested and verified no longer crash
Change-Id: I9b6a20377f2cf7ffb9be12de7bfa59f8b1063625
2018-01-10 14:01:21 -08:00
Maurice Lam
733b7c3c16 Make sure FP error text is visible in landscape
Use layout_weight in the enrolling progress bar to make sure it
there is space left for the error text.

Test: Manual
Bug: 69686380
Change-Id: Idd3d4c4ac376e721f15b8c9871c56e0619def305
2017-11-22 16:17:37 -08:00
TreeHugger Robot
aad3b1cef2 Merge "Use ButtonBarLayout to stack buttons" 2017-10-13 20:12:49 +00:00
TreeHugger Robot
909df8b966 Merge "There is no NEXT button in find sensor screen of fingerprint." 2017-10-13 20:11:09 +00:00
Maurice Lam
bb31c01f87 Use ButtonBarLayout to stack buttons
In fingerprint-enroll-finish landscape, if there is not enough space
to display the buttons, stack them by using ButtonBarLayout.

Bug: 67370165
Test: Manual
Change-Id: I482b811d6a2af545c4783a1cdd50b566c34b60c3
2017-10-13 01:21:31 +00:00
Kevin Chyn
caa78af159 Fingerprint enrolling icon should not overlap text
Fixes: 67369609

Test: manual test of enrolling with combinations of multi-window
      and text/display sizes

Change-Id: I163af87c69a51b0c91778611afa9e80960231c6a
2017-10-09 12:03:31 -07:00
Maurice Lam
d2e50c3c2b There is no NEXT button in find sensor screen of fingerprint.
Precondition: set the Font size and Display size to largest
Enter into the find sensor screen and the NEXT button is missing.
Test: manual - Enter into the find sensor screen -
and can find the NEXT button after sliding the screen.

Change-Id: I8f6219ab22abad98111f016d633bf100dc3222ce
2017-10-06 18:21:58 -07:00
Maurice Lam
7f5e1960f6 Update strings for pattern screens
Test: Manual
Bug: 64339681
Change-Id: I8c68b80a000988734c13cb40e2c049a83a787f2e
2017-09-11 15:35:18 -07:00
Maurice Lam
7efcc35d85 Fix sizing of pattern view
Align the size of pattern view in ChooseLockPattern,
ConfirmLockPattern, and keyguard as much as possible.
In rare cases they may still be inconsistent because
the screens have different content outside of the
pattern view (e.g. header text, navigation buttons etc)

Test: Manual
Bug: 64339681
Change-Id: Ie07ae211340967a3cdf9c6c28f9818f207dbd2c9
2017-09-11 20:07:17 +00:00
Ajay Nadathur
c13273687a Fingerprint added graphic is bigger than enrolling progressbar
bug: 63714762
Test: Manually tested
Change-Id: I415ab41bb985eb52146693091d61152b51ecfd6c
2017-08-02 20:32:03 +00:00
Ajay Nadathur
5eca3a64ea Add another fingerprint button not visible in landscape mode
bug:63067568
Test: Manually tested and verified
Change-Id: I172bbf4c4db6cebb2cc96874f3d8d29e859b07d1
2017-07-11 16:58:12 -07:00
Ajay Kumar Nadathur Sreenivasan
56787e3e54 Merge "Overlapping text over fingerprint animation" into oc-dr1-dev 2017-07-07 21:29:07 +00:00
Ajay Nadathur
715713d524 Overlapping text over fingerprint animation
bug: 63122688
Test: Manually tested and verified using smallest & largest display
settings

Change-Id: I03a6ab380c8d611b69f0b817788ff1f34b47e19d
2017-07-07 12:10:45 -07:00