Commit Graph

4991 Commits

Author SHA1 Message Date
MiltonWu
96591ed001 Refine FaceEnrollEducation UI
Update switch button style and adjust the margin for head motion swith
button on the end of FaceEnrollEducation page

Bug: 293274664
Test: Manually check UI
Change-Id: Ifff42364c75bc7c0a83a0211743dcd1e50f04aac
2023-11-08 16:10:53 +08:00
Joshua Mccloskey
114fabf79d Adding back screenshot test to Settings.
Test: atest SettingsScreenshotTests
Fixes: 307356833
Change-Id: I80b32cd40155d56e38d41d5f6d52e4c5d5ef715c
2023-11-06 19:40:58 +00:00
Chaohui Wang
c744aaabae Fix IMEI is not selectable
By settings textIsSelectable = true

Also unify all the similar logic into @style/device_info_dialog_value

Fix: 305248578
Test: manual - on About phone page
Change-Id: Iaa6b4ab45067a01106367de3b8d81d5df51bd6dc
2023-11-06 11:01:18 +08:00
josephpv
380ac9a48e Adds Google account login during private space setup
This has the following changes:
1. On profile creation starts intent to add google account to the private profile for Pixel only devices.
2. On accout sign in failed show an error screen with message to try again.
3. Moves the lock setup fragment from private to main user which now calls the helper Activity as a private user which helps to setup lock. This activity can now also be called from the planned Secondary Auth settings page to set up private profile lock.
4. On set up complete use SHOW_WORK_APPS intent as a workaroud to start launcher.

Bug: 308397617
Test: Manual setup
Change-Id: I19b95375409f015b2a5d30fdad766c2f6baa634b
2023-11-03 13:50:55 +00:00
Yiyi Shen
ed94c4eaa2 Merge "[Audiosharing] Add audio sharing stream name preference." into main 2023-11-02 04:51:40 +00:00
Joshua Mccloskey
ff69c0ca2d Merge "Rear Fingerprint Enrollment" into main 2023-11-01 21:10:47 +00:00
Yiyi Shen
1af86c34af [Audiosharing] Add audio sharing stream name preference.
Flagged with enable_le_audio_sharing

Bug: 305620450
Test: Manual
Change-Id: I1502fb824bcf612d069ee24d7af67afda5e997bb
2023-11-01 13:32:09 +00:00
Yiyi Shen
d624b575a6 Merge "[Audiosharing] Add audio sharing dialog." into main 2023-11-01 03:54:45 +00:00
Yiyi Shen
738962fb28 [Audiosharing] Add audio sharing dialog.
Open the dialog when audio sharing main switch on.

Flagged with enable_le_audio_sharing

Bug: 305620450
Test: Manual
Change-Id: I5b7cf655782a1da8b4fbd42eca11b473bac339b0
2023-10-31 17:04:52 +08:00
Chaohui Wang
13150d922c Merge "Migrate to Material3 Switch" into main 2023-10-31 08:26:43 +00:00
Chaohui Wang
8501293f07 Migrate to Material3 Switch
UI changed in this cl.

Bug: 306658346
Test: manual - on Settings pages
Change-Id: Ic72a49e978eb3308f561d24a16be26504297e05c
2023-10-31 13:33:44 +08:00
Joshua McCloskey
a98dc8d4b5 Rear Fingerprint Enrollment
Bug: 297083009
Test: atest RFPSIconTouchViewModelTest FingerprintEnrollEnrollingViewModelTest FingerprintManagerInteractorTest
Change-Id: Icc072e7d7815070087ccb50ea5937c386b06fb11
2023-10-30 22:18:56 +00:00
Chaohui Wang
019be1b687 Migrate ShortcutPreference to SwitchCompat
Settings use SwitchCompat instead of Switch in the future, for new
Material 3 UI.

Bug: 306658427
Test: manual - on Accessibility pages
Change-Id: Idf87eb6fcf1a57bd98a6fd0eca3c8c325127ce17
2023-10-28 20:04:31 +08:00
josephpv
84944ba6f0 Add auto advancing screens for private space setup
This includes changes for
1. To add auto avancing screens to PS setup
2. Screen to set a different Private profile lock or use existing lock
3. Success screen on setup completion
4. Shows Error screen if profile creation failed for some reason
5. Send intent towards launcher, show a Toast message to access PS from bottom of All apps and exit.

Bug: 299069146
Test: Manual setup
Change-Id: If4e5dd5a42abb11259bc40506189c7c750324139
2023-10-27 12:32:12 +00:00
Roy Chou
149a36a4df Merge "chore(text reading settings): increase preview block left/right padding when landscape mode for easier scrolling" into main 2023-10-27 08:57:32 +00:00
Jean Chen
198ae8901b Merge "feat(MultiFingerMultiTap): Add two-finger triple-tap shortcut on magnification dialog" into main 2023-10-27 03:43:51 +00:00
Chaohui Wang
f20a6d0ea6 Merge "Migrate SyncStateSwitchPreference to SwitchPreferenceCompat" into main 2023-10-26 22:51:23 +00:00
Wa Gao
c80dfbccb6 Add the new content protection preference option and subpage in Settings -> Security & privacy -> More security & privacy settings.
Bug: 302189945
Test: robotests
m -j256 Settings
atest SettingsRoboTests:ContentProtectionPreferenceControllerTest
atest SettingsRoboTests:ContentProtectionPreferenceFragmentTest

Change-Id: I620d73f8674c1340f9b11cd910620f1d5afb0ec1
2023-10-26 19:34:58 +00:00
Roy Chou
b3fb8e0154 chore(text reading settings): increase preview block left/right padding when landscape mode for easier scrolling
When the device is in landscape mode, In the text reading preference page, users have difficulty scrolling the RecyclerView because the preview block is almost full-screen. To scroll the preference list, users typically try to pan the preview block, but the block consumes the scroll gesture, preventing the list from scrolling. Users can successfully scroll the list content by panning outside the preview block. As a quick workaround, we increase the left/right padding of the preview block for landscape mode to make it easier for users to pan outside the block and scroll the preference list.

Bug: 301683714
Flag: NA
Test: manually - attach screenshot in bug
Change-Id: I1dba6e4d83ee1cd2f30163de05dfd7b42f829e42
2023-10-26 13:28:50 +00:00
Chaohui Wang
b547927d26 Migrate SyncStateSwitchPreference to SwitchPreferenceCompat
UI not changed in this cl, this cl helps UI switch in the future.

Bug: 306658427
Test: manual - on "Account sync" page
Test: manual - on "Turn screen on" detail page
Change-Id: Icd91bb69fdce302d9b9e92f501d1b1eaf2051960
2023-10-26 13:37:22 +08:00
josephpv
ee5e1ceb03 Start private space setup when there is no private space set
This change handles as below based on if private space already exists on device:
1. If PS doesn't exist then start the setup flow which shows a PS education screen. On setup button creates the private space.
2. If PS already exists on device then display PS settings page.

Bug: 299069146
Test: atest PrivateSpaceSettingsAuthenticatorTest
Change-Id: I46bdbaeb0210fd5b41a426f852e3f455b62c1c29
2023-10-25 21:17:33 +00:00
Jean Chen
48d73aa3f3 feat(MultiFingerMultiTap): Add two-finger triple-tap shortcut on magnification dialog
The shortcut is separate from single-finger triple-tap. It’s under hardware shortcut and above/outside of Advanced section.

Bug: 297805269
Test: manual
Test: atest ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: Id74cf3e457c04e167f3100d977b6c70c5d601026
2023-10-25 13:30:27 +00:00
Chaohui Wang
e752f7214b Remove unused SwitchBar
Only used in tests, so also migrate the tests.

Bug: 306658346
Test: manual - on bluetooth
Test: m RunSettingsRoboTests
Change-Id: Id2b010c1d9c32abe21dcc8765e9446fc4f7a5b25
2023-10-25 12:17:49 +08:00
Jim Shargo
da2c46d926 Merge "Revert "Adding back screenshot test to Settings."" into main 2023-10-24 00:06:03 +00:00
Jim Shargo
0d67f55cba Revert "Adding back screenshot test to Settings."
This reverts commit 4dc4e1c02a.

Reason for revert: broke the build

Change-Id: I3037248a5df06d6f92dfa9c5666625f23230646a
Bug: 307406217
2023-10-24 00:05:48 +00:00
Joshua Mccloskey
29c9e4c0b6 Merge "Adding back screenshot test to Settings." into main 2023-10-23 21:16:42 +00:00
Joshua Mccloskey
4dc4e1c02a Adding back screenshot test to Settings.
Test: atest SettingsScreenshotTests
Fixes: 307356833

Change-Id: I9e168010d6c83aad44969c60deaef8e61a10ddd1
2023-10-23 20:08:29 +00:00
Chaohui Wang
82a9a9e47d Remove Settings preference_widget_primary_switch
File content same as SettingsLib's preference_widget_primary_switch

Bug: 285231003
Test: m Settings
Change-Id: I4b9f92435ffb5c253241e294c4680025fe0447fc
2023-10-20 12:55:22 +08:00
Sebastian Pickl
1d7e0057f7 Merge "Revert "Adding screenshot tests to settings"" into main 2023-10-18 10:20:42 +00:00
Sebastian Pickl
edbeacce4a Revert "Adding screenshot tests to settings"
This reverts commit cdc3bf0d00.

Reason for revert: possibly breaking builds b/305851039

Bug: 305851039
Change-Id: I1a67323b3617700707d5b677bb6102b0bf396c4a
2023-10-18 08:48:14 +00:00
Joshua Mccloskey
91db1f1a7c Merge "Adding screenshot tests to settings" into main 2023-10-17 15:01:57 +00:00
Chaohui Wang
f80f42ac71 New ComposePreference
And ComposePreferenceController.

So we can use Spa in Preferences based UI.

Bug: 280864229
Test: unit test
Change-Id: Ida6dc62b54de9513d014ad899a65876d3499a02c
2023-10-16 19:05:10 +08:00
Joshua McCloskey
cdc3bf0d00 Adding screenshot tests to settings
Test: atest SettingsScreenshotTests
Change-Id: I2d22df2e233561e44b233b8ebdfc0291e37aef6b
2023-10-13 19:20:47 +00:00
Becca Hughes
4951641ddb Merge "Fix icon UX bug" into main 2023-10-11 23:50:29 +00:00
Joshua Mccloskey
c320afa70d Merge "Added UI tests for FingerprintEnrollIntro" into main 2023-10-11 18:53:38 +00:00
Becca Hughes
6a57e6d28b Fix icon UX bug
This makes all icons on the page the same size.

Test: ondevice flash
Bug: 302757616
Change-Id: I07c98011a31ae0f168db8c843d48b512d4eb9899
2023-10-10 14:16:13 -07:00
Joshua McCloskey
b7021c8e0b Added UI tests for FingerprintEnrollIntro
Test: m -j40 RunSettingsRoboTests ROBOTEST_FILTER=FingerprintEnrollmentIntroFragmentTest
Bug: 295206367
Change-Id: I70f6b50dd2604e01805df04ffb1c07a9134ba065
2023-10-02 22:05:16 +00:00
mxyyiyi
1b9eb170dd Refactor Power Usage Time Page.
- Show use time category

Screenshot:
[Screen time with hint] https://screenshot.googleplex.com/3cRLrwevzw4iytb
[Background time with hint] https://screenshot.googleplex.com/zEf8PcWopCVCRZR
[without hint] https://screenshot.googleplex.com/9bao9sVd8s7VRwM
[enter from app info (without category)] https://screenshot.googleplex.com/8sozxMrq8ojadiF

Bug: 302063050
Test: Manual
Change-Id: Ic967d05a173afa76c2a958e1332dedd9f83cd687
2023-10-02 02:34:35 +08:00
Daniel Norman
9eb7ab195d Remove importantForA11y=no from a11y activity launch preference.
Due to how Preferences create a single node for their content, this was
causing that node to lack the ACTION_CLICK action and clickable
attribute.

Removing this attribute properly exposes the click action which means
that TalkBack will now speak "double tap to activate" and Switch Access
will highlight the button while scanning.
See http://recall/-/bznujeSAo20YqWFB1N28dO/gVdpAXoD3BroEkUeJBTUWq

Flag: RESOURCES_ONLY
Bug: 301528206
Test: Open Settings > Accessibility > Sound Notifications;
      Use TalkBack to highlight and speak the "Open Sound Notifications"
      button; observe "double tap to activate".
      Repeat with Switch Access; observe button is highlighted while
      scanning and can be selected.
Change-Id: Ie747e19fe149d015cf92fbe07fd71cfaf183d795
2023-09-27 23:53:58 +00:00
Xinyi Mao
8d91b3116b Merge "App anomaly tips on PowerUsage App list" into udc-qpr-dev am: 821ed07099
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24677374

Change-Id: I15dad922e0942175e56370a7001ada1afe2c19b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 03:36:03 +00:00
mxyyiyi
56ba1c09d9 App anomaly tips on PowerUsage App list
Screenshots:
[in bg - banner] https://screenshot.googleplex.com/MzLC6LfX93TkkYf
[in bg - hints] https://screenshot.googleplex.com/9JLXNsRiVG8arAU
[in fg - banner] https://screenshot.googleplex.com/9oYbwUkeeLbQX2t
[in fg - hints] https://screenshot.googleplex.com/53DTTUCUnf8rsoE
[apps anomaly highlight hint + settings anomaly banner]
https://screenshot.googleplex.com/8NdS2VMrSzwv2DM

Bug: 291689643
Bug: 291689623
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:bfd0f5859b6e5ffef4727ee562009f2050de7a58)
Change-Id: Ic02db49cb3794ef134759d9dcec5f5ef32454a95
2023-09-18 10:41:27 +00:00
mxyyiyi
e9378d27f7 App anomaly tips on PowerUsage App list
Screenshots:
[in bg - banner] https://screenshot.googleplex.com/MzLC6LfX93TkkYf
[in bg - hints] https://screenshot.googleplex.com/9JLXNsRiVG8arAU
[in fg - banner] https://screenshot.googleplex.com/9oYbwUkeeLbQX2t
[in fg - hints] https://screenshot.googleplex.com/53DTTUCUnf8rsoE
[apps anomaly highlight hint + settings anomaly banner]
https://screenshot.googleplex.com/8NdS2VMrSzwv2DM

Bug: 291689643
Bug: 291689623
Bug: 284893240
Test: manual
Change-Id: Ic02db49cb3794ef134759d9dcec5f5ef32454a95
Merged-In: Ic02db49cb3794ef134759d9dcec5f5ef32454a95
Merged-In: I7015cdf5a96d518febb160934d780ae84fe14427
2023-09-18 18:28:20 +08:00
mxyyiyi
6b8daefd54 Impl highlight effect on BatteryChartView slots. am: 6750634259 am: 9e4fed1b62
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24498956

Change-Id: I9a38284ab828c149ca06a51fbad7f3fcb2ac33de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-13 08:54:29 +00:00
mxyyiyi
9e4fed1b62 Impl highlight effect on BatteryChartView slots. am: 6750634259
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24498956

Change-Id: Iff96ebb33e50b2c2bddbe44eada5bf35f7118531
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-13 07:57:45 +00:00
mxyyiyi
6750634259 Impl highlight effect on BatteryChartView slots.
Screenshot: https://screenshot.googleplex.com/F5VrGjj5kdNHMV6

Bug: 284893240
Bug: 291689623
Test: manual
Change-Id: I846d95d31e8bb839481b86a94d5191ff205f8328
2023-09-13 13:29:32 +08:00
Chaohui Wang
4b686147b6 Clean up WifiDataUsageSummaryPreferenceController
Which is legacy and not finished implemented.

Bug: 295260929
Test: unit test
Test: robo test
Test: manual - on Mobile Settings page
Test: manual - on Network details page
Change-Id: I30ac639c1ba285a74038d5413b63e2c31c6cc8ba
2023-09-06 17:37:02 +08:00
Chaohui Wang
0d129f77f0 Remove duplicated metered & privacy spinner
From Wi-Fi dialog when there are already same settings in the Wi-Fi
detail page.
This makes simpler for the user and help fix the inconsistent issue.

Fix: 297036035
Test: manual - open Wi-Fi dialog from Wi-Fi detail page
Test: robo test
Change-Id: Ic02658d91938db78b91e867a923260aa2610ae49
2023-09-04 17:10:17 +08:00
Justin McClain
b675bb6d3a Merge "Remote authenticator enrollment navigation." into main 2023-09-01 11:48:35 +00:00
Xinyi Mao
5bad30b3db Merge "Impl app anomlay preference" into udc-qpr-dev am: c51a3da148 am: 428b124bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24404174

Change-Id: I147d8496db00a770d8de45229813ae146e1e87cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-01 09:54:53 +00:00
Xinyi Mao
428b124bea Merge "Impl app anomlay preference" into udc-qpr-dev am: c51a3da148
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24404174

Change-Id: I7068d880ab644f01dba523132dbccd2cc6ceff60
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-01 08:59:18 +00:00