Commit Graph

8 Commits

Author SHA1 Message Date
Tsung-Mao Fang
4470faa175 Tweak spacing for private DNS mode dialog
Test: See the screen
Fix: 186499972
Change-Id: Iaae7d625ef2931b9ba22e6edbd414ebe14cfdc3f
2021-04-27 17:59:01 +08:00
timhypeng
456285ca5b Refactor common layout
- reuse preference_widget_dialog_radiobutton

Bug: 144746899
Test: manual
Change-Id: Icfba629eb05b9db1dc6802e26c087b30f0fe88ed
2019-11-21 10:42:26 +08:00
Marc Plano-Lesay
fcb000cf0c Make the private DNS mode dialog entries full width.
Using wrap_content requires to tap on the text specifically, while the
full width usually works for this kind of dialogs.

Change-Id: I95035202c1a3b3bdcbd91a4ff0e60f42392a3ba5
Fixes: 132914632
Test: Screenshot
2019-05-16 23:38:25 +00:00
jackqdyulei
c7867c80d4 Add scrollview for dns dialog
Also update dialog to appcompat to avoid the crash

Change-Id: Ide6483f1160713dae8111de533a8b3345a3420c2
Fixes: 111351793
Test: Manual
2018-07-17 10:47:32 -07:00
jackqdyulei
66c2aec611 Update dialog to pass accessibiliity scanner
Change-Id: I6b982a2416e46143a254db6d6c234897fa547ac9
Fixes: 110236135
Test: Screenshot
2018-06-19 11:17:42 -07:00
jackqdyulei
fd69cd4c33 Add help info at the bottom of the dialog
It contains a link to help center

Bug: 68030013
Test: RunSettingsRoboTest
Change-Id: I79260eff35e604fa97cf21c62f58c02f3bbe5cfb
2018-01-05 14:39:16 -08:00
jackqdyulei
05cb931a31 Add private dns dialog in wifi settings
This option lives in menu. A dialog will show up once this menu
is clicked.

We reuse most of the logic in go/aog/524415 with the following
updates:
1. Use radioGroup instead of directly control radioButton
2. remove bunch of methods if they are only used once.

Following cl will:
1. Remove this feature in development page
2. Add the help link at the bottom of the dialog
3. Disable "Save" button when hostname is invalid.

Bug: 68030013
Test: add for later

Change-Id: I4c6d359dc9c55675858c20e47953ef677b31c3b5
2017-11-13 14:53:14 -08:00
Erik Kline
1ea5dd05c3 Replace dns_tls with private_dns_mode setting
Also includes:
    - new layout fragment for private DNS configuration
    - PrivateDnsModeDialogPreference handler class

Test: as follows
    - built
    - flashed
    - booted
    - runtest frameworks-net passes
    - manual interaction with private dns developer option works
Bug: 34953048
Bug: 6413396
Change-Id: I3a5490c21f7f3b3e523a247c287f213d19b75a8b
2017-11-07 12:28:48 +09:00