Commit Graph

282 Commits

Author SHA1 Message Date
Eric Biggers
43616ed3b6 Remove CryptKeeper
Since Android 10, new devices have been required to use FBE (File Based
Encryption) instead of FDE (Full Disk Encryption).  FDE support was
already removed from system components such as init and vold.
Therefore, the CryptKeeper activity is no longer needed.  Remove it.

Note: this CL only removes CryptKeeper itself, i.e. the activity which
runs at boot time on devices that are using FDE or are being encrypted
with FDE in-place.  Later CLs will remove FDE-specific code from the
Settings app.

Bug: 208476087
Change-Id: I4aaf795e8cee1ff3cdd55a41c975273c8faeefa9
2022-01-11 18:19:22 -08:00
SongFerng Wang
fdfb0bcf44 Merge changes I5c6ad4b3,Icb00b3fc
* changes:
  [MEP] renew the default data selection UI
  [MEP] renew the sim confirm dialog UI
2021-12-21 15:53:21 +00:00
SongFerngWang
4780be49f3 [MEP] renew the sim confirm dialog UI
- renew the sim confirm dialog

Bug: 199902896
Test: build pass and local UI test
Change-Id: Icb00b3fc32066e21d22cbeca1fdf50e5d7dbef20
2021-12-21 12:51:16 +08:00
Jason Chiu
bb46bb79bf Disable animations of deep link homepages to reduce the shortcut flicker
Bug: 203744424
Test: manual
Change-Id: I7806d732be99425e98db615474bdd83e42dc072e
2021-11-19 12:44:41 +08:00
Matt Pietal
c4aa3b4ac5 Pattern view - Use new theme colors
For both SUW and general settings use, colors should match what is
already is use for the systemui bouncer.

Bug: 195272825
Test: SUW pattern view && settings pattern view
Change-Id: I374c904e65aac9a29b5ff5635c9db39f4f7ca8d5
2021-10-14 09:23:54 -04:00
TreeHugger Robot
3d5fd19e9f Merge "Consistent color between status bar and app bar" into sc-dev 2021-06-28 04:25:09 +00:00
Tsung-Mao Fang
df00a3bc69 Consistent color between status bar and app bar
In Android S, we add the transparent color to navigation bar
and status bar for consistent color between status bar and
app bar. So, we should add this change for oveall setting
theme since most pages should apply new app bar now.

Thus, we don't need to override the subsetting style for different
activities one by one.

Homepage doesn't have new Android S tool bar, so we shouldn't adopt it.

Test: Try to launch all the pages as many as possible.
Fix: 190797935
Change-Id: Ic4083de5477371f1d0eea2d66f020e4469fa3f86
2021-06-23 17:53:59 +08:00
Tsung-Mao Fang
53f94d3289 Clean up unused code
Test: Rebuilt apk
Fix: 190142194
Change-Id: I16d18c538b612c6049f561bb524ee1e056255714
2021-06-21 18:17:27 +08:00
Tsung-Mao Fang
1e8a907d91 Fix dialog color problem in night mode.
Assign the suface light and dark color for Dialog.

Test: Rebuilt apk, and see color works well on wifi dialog.
Fix: 190142194
Change-Id: I43d010c70e22639a29a571bfadb4351f41e1a240
2021-06-17 10:08:32 +00:00
Edgar Wang
a0a7ff6d76 Moving progressBarHorizontalStyle to SettingsLib
Bug: 190467533
Test: rebuild & manual
Change-Id: I5f7f493b7c100c06ff5328706906bf33bae34e56
2021-06-09 04:23:13 +00:00
Tsung-Mao Fang
6b8a5d1eb3 Fix GAR color constrast issue on dialog
Based on the UX definition, assign correct error color
for dialog

Test: A11y scanner tool confirms again and no color constrast issue.
Fix: 187396623
Change-Id: I338570b38c6fc5fa32ea1becd069084bf2d631a6
2021-05-31 20:00:20 +08:00
Tsung-Mao Fang
732ff78505 Fix GAR color constrast issue on dialog
Based on the UX definition, we use color surface
for the background color of dialog.

Test: A11y scanner tool confirms again and no color constrast issue.
Fix: 187396623
Change-Id: I2f89193f7c584e8fc468aa035ce329c22e2ad7f1
2021-05-27 23:00:14 +08:00
Arc Wang
4a2acd2e20 Fix UnsupportedOperationException in Display Settings
Remove android:textColorHint from Theme.Settings to fix the regression.

This is a quick fix, each EditText should set its hintTextColor
attribute before there is a fix to apply the attribute globally in
Settings APP.

Bug: 188405076
Test: manually launch 'Font size' and 'Display size'.
Change-Id: If3313be47e0c3e8ce9d41a6e87cdf2e7067ce54b
2021-05-20 01:01:21 +00:00
Arc Wang
b61388d1f5 Fix hint text color contrast problem in LocalePickerWithRegionActivity
Set android:textColorHint textColorSecondary in Theme.Settings.

Bug: 147637981
Test: accessibility scanner
Change-Id: Ie3ef7e86909b75366c427ac5c6a90a9a02f0f660
2021-05-14 16:34:39 +08:00
Mill Chen
2918626258 Update the theme for Notification history page
Fix: 187241188
Test: visual verified
1) Enable the light theme
2) Settings > Notifications > Notification history
3) See if the color of icon in the status bar is white

Change-Id: I2f198a10b71d0d0f7c92db0feab2154a1c8f25c6
2021-05-06 01:18:01 +08:00
TreeHugger Robot
ea7b64a96d Merge "Fix background inconsistency of the font size page in SUW" into sc-dev 2021-04-23 09:21:28 +00:00
Sunny Shao
2ba1ab2222 Fix background inconsistency of the font size page in SUW
- Apply to SUW provided theme.
- Use isSetupWizardDayNightEnabled to decide which device's SUW supports dark mode.

Fixes: 184901818
Bug: 186076332
Test: manual test
Change-Id: I44c5f8ee19dac58dea7f5543840659c08aad4a39
2021-04-23 15:12:11 +08:00
TreeHugger Robot
ea2a359561 Merge "Update the style for collapsing toolbar" into sc-dev 2021-04-22 06:40:23 +00:00
TreeHugger Robot
7f065adfcb Merge "Fix background inconsistency of the Settings page in SUW" into sc-dev 2021-04-21 13:06:45 +00:00
Arc Wang
3486b95fd7 Merge "Update progress bar UI" into sc-dev 2021-04-21 09:01:35 +00:00
Alex Johnston
4a4e2bae61 Merge "RequestManageCredentials dark theme" into sc-dev 2021-04-21 08:45:06 +00:00
Sunny Shao
c361e3426f Fix background inconsistency of the Settings page in SUW
- Pass the extra arguments to target page from vision settings.
- Add the android:colorBackground to LightTheme.SubSettings.SetupWizard.

Fixes: 185873105
Bug: 184901818
Test: manual test
Change-Id: I063a8df875b727aa0e119b03dfb782c2b95dc1b5
2021-04-21 13:35:45 +08:00
Alex Johnston
dce68bf7a5 RequestManageCredentials dark theme
Manual testing steps
* Enable dark theme via Settings > display
* Install TestDPC and select 'Request to manage credentials'
* Verify dark theme is displayed (including light text)

Bug: 177901172
Test: atest com.android.settings.security.RequestManageCredentialsTest
      manual testing
Change-Id: I6db1361ffcbf1e193673eb5ca7ef3f403d5023b1
2021-04-20 15:21:14 +00:00
Arc Wang
5383f11ec9 Update progress bar UI
Apply android:progressDrawable to Settings theme,
the drawable shows round corners and different colors.

Bug: 174964885
Test: manual visual
Change-Id: I0447231200d12953f4527866d537ee605009f8a4
2021-04-20 20:31:30 +08:00
Mill Chen
86fd923d6f Update the style for collapsing toolbar
The new version of collapsing toolbar has been updated and it needs
the edge-to-edge configruation to work smoothly. Added the configuration
for Notification history and removed useless styles.

This change is also trying to reuse the layout that is from SettingsLib
and remove the one from Settings.

Bug: 183496853
Test: visual verified
Change-Id: Iecfb96fe5ead91b0421050c3dfc1c1ab456aafff
2021-04-19 20:48:03 +08:00
Edgar Wang
9d14071637 Merge "Apply SettingsPreferenceTheme in Settings" into sc-dev 2021-04-15 05:27:22 +00:00
Julia Reynolds
98b8716e0a Only one action bar needed
And it's provided by the Activity.

Test: notification history does not crash
Bug: 184695659
Change-Id: I5a4c882c42b894601306826006152684bb499b51
2021-04-14 16:16:36 -04:00
Edgar Wang
817a167416 Apply SettingsPreferenceTheme in Settings
- Set all of preference style inherit from SettingsPreferenceTheme
- Apply to Theme.Settings and Theme.Settings.Home
- Fix robotest failed in ScreenTimeoutSettingsTest

Bug: 185206291
Test: manual & robotest
Change-Id: I855d003b10348569903855fcbf235bc00265658b
2021-04-14 16:36:14 +08:00
Mill Chen
23d3eccfa3 Integrate new version of MDC-android release
1. Add color fill on scroll
2. Add collapsing title fading

Bug: 183496853
Test: visual verified
Change-Id: I5d0ae0b10d9f0eae843cd4935c075488a960d3f3
2021-04-06 13:23:05 +08:00
Edgar Wang
a4982b658b Update Preference style
- remove reserved icon space

Bug: 182374464
Test: visual
Change-Id: I382ed04b0b873b5ee64d3982306df496244e76f3
2021-03-17 13:36:33 +00:00
Jason Chiu
530bee333b Fix the scrolling problems in homepage
- Remove the deprecated API and parameter usages of setting system ui
  visibility, which make the app bar scrolling behavior abnormal when
  the navigation bar is enabled.
- Remove the duplicate navigationBarColor of the homepage theme since
  Theme.Settings has configured it.
- Remove the unused scroll flags in search bar layout since its parent
  is no longer AppBarLayout.

Test: visual, robotest
Fixes: 178497625
Fixes: 179122861
Change-Id: I91537cff4f3d98e4bc31e6e42d23895df312fbd4
2021-02-05 02:52:43 +00:00
Yi-Ling Chuang
a386cb27fc Fix the background color of the homepage.
- Remove the windowBackground override.

Fixes: 177715172
Test: open the homepage and see its color.
Change-Id: If8f6f789eef49caabf6d0f04eee33850e1c98e19
2021-01-29 17:19:40 +08:00
Mill Chen
14cfd2f2ca Add CollapsingToolbarLayout for sub settings
Settings app is planning to make toolbar collapsible for next
Android release. This CL is to add a new layout for
CollapsingToolbarLayout in the Settings app and to update the theme
correspondly. This feature will be controlled by feature flag, which
makes Settings app compacitible with the existing layout.

Bug: 174451673
Test: manul test and visual verification
1) Enable the feature and open Settings app
2) Navigate to each sub page and check if toolbar is collapsible

Change-Id: Ibef524bbaa7ae3f0a43db7e40e599f42e009437f
2021-01-11 18:30:20 +08:00
Alex Johnston
580b7af1a4 Add request manage credentials to Settings
Background
* This is part of the work to support
  a credential management app on
  unmanaged devices.

Changes
* Add new activity to Settings to display
  a screen to the user requesting whether
  the calling app can manage their
  KeyChain credentials.
* Display the authentication policy

Manual Testing
* Verify screen is not displayed if intent
  action is not android.security.MANAGE_CREDENTIALS
* Verify screen is not displayed if authentication
  policy is not valid
* Verify button panel is visible if all items in the
  authentication policy are displayed
* Verify button panel is not visible if not all items
  in the authentication policy are displayed. Verify
  that scrolling to the bottom of the item list, the
  button panel becomes visible.

Bug: 165641221
Test: Manual testing
      make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.security.RequestManageCredentialsTest
Change-Id: Ie23b226f1a285b3de6ec3e91b8880d9144bb24a3
2020-11-27 20:43:38 +00:00
Jason Chiu
4b6a1a53ac Change the font weight of the slice title to medium
Test: visual
Fixes: 139017680
Change-Id: I347239f2c164c871eced2fbda1b2faaa38e16ca9
2020-02-11 16:36:35 +08:00
Raff Tsai
41435ad0ea Fix layout issues
- Add fontFamily in TextAppearance.Tab to support change font style
- Overwrite TabTheme to change overscroll effect color

Fixes: 147134904
Fixes: 147136108
Test: manual
Change-Id: Iebb2dea658a295f3c6ece900680f42fb3a772cb4
2020-01-13 03:07:00 +08:00
Sunny Shao
b1c4b0215b Fix UI display abnormal of DatePickerDialog in landscape mode
Update the themes.xml and styles.xml.

Fixes: 141577901
Test: manual view
Change-Id: I24cadcc972bdc0ee1f6601e3b496d0f69bb5089c
2019-09-30 16:29:17 +08:00
Salvador Martinez
a2e7357535 Change switch text color to black in dark mode
It seems that the attribute values that are used to text color
in the switch bar are selectors which leads to problems because
they include an alpha value when the switch is "off". This would
cause the contrast between the text and the background to be too
low for GAR. This CL simply makes it so that in dark mode the text
for the switch bar is just true black since adjusting the
attributes would have wide scale implications for all UIs using
device default themes.

Test: visual inspection
Bug: 132755745
Change-Id: I309db82e9bf020fb654e0b93f6ec84380ae092f7
2019-05-30 14:16:52 -07:00
Mill Chen
fb72f38c58 Fix overlapping problem in AlertDialog
Because clipChildren and clipToPadding by default are set to false in
the Settings, this will cause the strings overlapping with the title
of AlertDialog. These 2 attributes in the Theme.AlertDialog are set to
true to fix this problem.

Fixes: 133731437
Test: visual
Change-Id: I57ea48ac97c64dac6dfeec711daf4f40dc131ff6
2019-05-28 16:31:56 +00:00
Mill Chen
9862f8632a Revert "Revert "Update dialog background color for dark theme""
This reverts commit 77259dc9bb.

Previously, using a general attribute to change the background color
for alert dialog. It will also impact on the background of other
components. To fix it, we used another attribute to change the dialog
background.

Bug: 132753127
Bug: 132623454
Bug: 129993336
Test: visual
Change-Id: I09091ee8fb45238d0ea94760f2fca5c206299a57
2019-05-17 16:26:10 +08:00
Mill Chen
77259dc9bb Revert "Update dialog background color for dark theme"
This reverts commit 3032628269.

Reason for revert: This will also change the background color of other components within dialog.

Bug: 132753127
Bug: 132623454
Test: visual
Change-Id: I59d4731e84e8d516a01780c4cce70b2d86208098
2019-05-16 14:46:52 +08:00
Fan Zhang
b4b7725937 Revert "Revert "Make subsettings display edge-to-edge""
This reverts commit 9e98b8cf0f.

We have to set clipToPadding false on scrollView to make it extend below
navbar. But the side effect is it stops clipping to padding. So it
overlaps with sibling views. In this case anything pinned on top of
screen (switchbar, pinned header for most UIs, and preview indicator for
font size page).

To fix them:
1. in preview pages, just revert back to clipTo*. Their UI doesn't scroll
   so it they don't need to special clip flag to begin with.
2. For pinned to top headers, we need to change the "z-order" by setting
   elevation and make sure background is not transparent.

Fixes: 132182711
Fixes: 132672399
Test: visually on normal screen, font size scree, wifi main setting UI,
      wifi data usage screen

Reason for revert: Rollforward with fix.

Change-Id: Ib6f7c4167b9a680a336f2a7310d82340094d3aac
2019-05-14 13:48:12 -07:00
Fan Zhang
9a51ede665 Merge "Revert "Make subsettings display edge-to-edge"" into qt-dev 2019-05-14 17:17:26 +00:00
Fan Zhang
9e98b8cf0f Revert "Make subsettings display edge-to-edge"
This reverts commit c2a85a374d.

Bug: 132672399
Bug: 132182711
Test: n/a

Reason for revert: b/132672399

Change-Id: Icb34ae5b16b7a32215fe2c1a5f0d0d028c91b2ca
2019-05-14 16:31:08 +00:00
Cn Chen
421a05a6a9 Merge "Font size page support light theme in deferred setup" into qt-dev 2019-05-14 07:18:03 +00:00
cnchen
3eee5cf02e Font size page support light theme in deferred setup
Bug:124470158
Test: atest & manually test
Change-Id: I41e1e98a9a64e516a294c4a94c8b5f335434078f
Merged-In: I41e1e98a9a64e516a294c4a94c8b5f335434078f
2019-05-14 14:01:14 +08:00
Fan Zhang
c2a85a374d Make subsettings display edge-to-edge
Fixes: 132182711
Test: visual
Change-Id: I3b0635cba359f74d463c2360323d80c5c9533228
2019-05-13 10:07:13 -07:00
Fan Zhang
3e14383a28 Display settings homepage content fully edge-to-edge
This is needed to support fully gesture navigation.

Bug: 132182711
Test: visual
Change-Id: Ifaf15ecec73b974356355a74e73754f95b84ad3e
2019-05-08 11:43:58 -07:00
Amin Shaikh
3f1de20c7e Fix themed settings icons.
- Added android prefix for homeAsUpIndicator attribute
- Override ic_arrow_down_24dp from androidx
- Remove ic_lock drawable overlay
- Update date and time icon
- Dedupe ic_menu_add and ic_add_24dp

Bug: 131346125
Test: mp settings;
Change-Id: I7223249f2adccc5569a37e8b68cae5499e7c7620
2019-05-03 17:02:46 +00:00
Pasty Chang
54cddc70e5 Merge "Set QR scan activity to light theme in setup flow" into qt-dev 2019-04-29 01:52:11 +00:00