Commit Graph

60289 Commits

Author SHA1 Message Date
Arc Wang
c707a93d00 Merge "[Wi-Fi] Index Wi-Fi preferences." into rvc-dev 2020-04-07 07:16:26 +00:00
Jason Chiu
4edb83b260 Merge "Refine metrics log in infrastructure" into rvc-dev 2020-04-07 06:33:30 +00:00
Jason Hsu
dfa6cf0d05 Merge "Add accessibility color inversion help resources to link to existing help page." into rvc-dev 2020-04-07 06:28:10 +00:00
Jason Chiu
819abf7f87 Refine metrics log in infrastructure
- Add interfaces to set/get metrics category in BasePreferenceController
  for descendants having a chance to get it.
- Set metrics category in DashboardFragment
- Automatically log metrics in onPreferenceChange of
  TogglePreferenceController
- Add support for TwoStateButtonPreference in TogglePreferenceController
  to make the preference generic

Bug: 137559984
Test: robotest
Change-Id: Ia7e0d24a3db1991b18e0286d9894570fa71247a3
2020-04-07 14:08:39 +08:00
Bonian Chen
1e5cf6525a Merge "[Settings] Core refactor" into rvc-dev 2020-04-07 05:57:28 +00:00
Menghan Li
6c59995503 Merge "Revise Q behavior migration of accessibility edit dialog" into rvc-dev 2020-04-07 05:54:56 +00:00
Menghan Li
c0c522d999 Merge "Support caption second UI structure (5/n)" into rvc-dev 2020-04-07 04:24:20 +00:00
Menghan Li
47b01403ee Merge "Support autoclick secondary action (8/n)" into rvc-dev 2020-04-07 04:23:56 +00:00
Bonian Chen
b1c7e21066 [Settings] Core refactor
Remove empty lines, and maintain the comments.

Bug: 150352656
Test: build pass
Change-Id: If0552d7ce20de5941667aa64e682202aaf32c597
2020-04-07 12:09:51 +08:00
jasonwshsu
7c073c4c40 Add accessibility color inversion help resources to link to existing help page.
Bug: 151604096
Bug: 150873532
Test: manual test
Change-Id: Ie042d822de3ff5017548b8d92c74b208ee1f3a02
2020-04-07 12:06:03 +08:00
Varun Shah
2aeedcde21 Update display logic for no shared data.
When there is no shared data, instead of showing an empty list view,
the developer option's summary is updated.

Additionally, for the two shared data screens, added the back button to
the action bar so that it matches the other screens in the Settings app.

Also, implemented PreferenceControllerMixin for the
SharedDataPreferenceController so that the dev option shows up in
settings search.

Bug: 153079829
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: I6ec5c35fc262dc27a383af8e2593be5b349ee85f
2020-04-06 20:58:11 -07:00
TreeHugger Robot
76b55e0b0a Merge "Add a developer setting for conversation enforcement" into rvc-dev 2020-04-07 03:47:02 +00:00
Julia Reynolds
94ad6a1959 Adjust tap targets in history
- Fix a crash if an app couldn't be launched
- Fix the height of tap targets and overlap of text

Fixes: 152977855
Fixes: 153199215
Change-Id: Id623f942c7663c977c61df3d1188fe498cab8acc
2020-04-06 19:44:40 +00:00
Zhen Zhang
b1d19a8b35 Fix advanced preferences behavior in AllInOneTetherSettings
In AllInOneTetherSettings, advanced preferences should not be hidden
again after user have expanded them.

Bug: 151954343
Test: CodeInspectionTest; AllInOneTetherSettingsTest; manually test oberved advanced preferences won't be hidden.
Change-Id: If2c7d99b7dcac4149f065eca73022a582924c90b
2020-04-06 19:14:41 +00:00
Fabian Kozynski
83df54b007 Added settings screens for Power Menu
This CL adds a new Preference in Gestures (Power Menu), moves Global
Actions to it (now renamed Cards & passes) and adds a new Preference for
Device controls.

Missing:
* Explanation video for Device controls
* Privacy settings

Test: robotests
Test: manual change settings
Bug: 152212779
Bug: 152329723
Change-Id: Ia8f69565307a5961c8435bc1f441abeb389acf8b
2020-04-06 13:06:52 -04:00
TreeHugger Robot
df338dd652 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-04-06 16:38:44 +00:00
TreeHugger Robot
293f7ce88c Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-04-06 16:33:27 +00:00
Julia Reynolds
ae9060246b Add a developer setting for conversation enforcement
Test: Robo tests
Fixes: 152907434
Change-Id: I4e16faf817349993a98955601829d1ad22fa3921
2020-04-06 09:53:31 -04:00
Julia Reynolds
cb7fbe0faa Merge "Update history flow" into rvc-dev 2020-04-06 13:37:33 +00:00
Bill Yi
a03995505f Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I0ee248806b1d77ca266c5ee47cc1420adfa465e6
2020-04-06 05:48:37 -07:00
Bill Yi
3aacc4e59a Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: If158e0aa6e1832b4d72901bb3fead8e1db4272c4
2020-04-06 05:16:34 -07:00
TreeHugger Robot
8efea18ca2 Merge "[Wi-Fi] Fix EntityHeader signal strength icon invisible problem" into rvc-dev 2020-04-06 11:29:05 +00:00
Arc Wang
62e3a8276e [Wi-Fi] Fix EntityHeader signal strength icon invisible problem
WifiDetailPreferenceController2#onUpdated() triggers each controller
to displayPreference(PreferenceScreen screen) for visibility
updating. However, WifiDetailPreferenceController2 is a much
complex controller which should controll it's components visibility
by itself.

Bug: 152886237
Test: manual visual
      Observe EntityHeader signal strength icon UI display.
Change-Id: I80a8341ae051f21410070a81e01716eb49d2c8da
2020-04-06 17:24:01 +08:00
Toby Chuang
36b00c5e4f Merge "[NFC] Add a picture under NFC settings to show NFC detection point." into rvc-dev 2020-04-06 07:28:00 +00:00
tim peng
75c84f8e64 Merge "No feedback when attempting to transfer to an unpowered BT device" into rvc-dev 2020-04-06 07:06:03 +00:00
Jason Hsu
eb11b5113c Merge "Add accessibility timeout help resources to link to existing help page." into rvc-dev 2020-04-06 05:56:18 +00:00
Toby Chuang
204fa8a420 [NFC] Add a picture under NFC settings to show NFC detection point.
Each smartphone has a different NFC antenna detection point,
users would confuse where the NFC antenna is and how to place the
smartphone close to the card reader/equipment.

Starting from Android R device, we move NFC antenna position from
top area to middle center of the phone.

From the OEMs perspective, they could implement their own picture
to indicate the best NFC detection point.Hence, we propose to
show NFC antenna position under NFC setting.

Bug: 142230563
Test: build pass
Change-Id: Ib3cd7fc3ea299be1667aba0aeebaa148fb49015f
2020-04-06 13:37:31 +08:00
TreeHugger Robot
d81224b7d4 Merge "Update permission summary when permission changing." into rvc-dev 2020-04-06 05:22:01 +00:00
ChenJean
aa87e024d5 Support caption second UI structure (5/n)
Update constants

Bug: 143502915
Test: manual
Merged-In: I7d27bc255f4f5fa8d8a34e6ced533b61ea827ef1
Change-Id: I7d27bc255f4f5fa8d8a34e6ced533b61ea827ef1
(cherry picked from commit ba7eb47823)
2020-04-06 04:20:05 +00:00
ChenJean
9e1bb0def1 Support autoclick secondary action (8/n)
Modify options description logic from 5 types to 3 types.

Bug: 149884746
Test: manual
Merged-In: I714db2a450e34d33e5728cf355136d26bef77e11
Change-Id: I714db2a450e34d33e5728cf355136d26bef77e11
(cherry picked from commit b6d6d9da46)
2020-04-06 04:19:16 +00:00
TreeHugger Robot
f1418dc437 [automerger skipped] Merge "Hide unprovisioned MDN (phone number) at select profile dialog" into qt-qpr1-dev am: 9643b9c727 -s ours
am skip reason: Change-Id If84600cc426fefcdd219c4a44a5510b8db5c0a89 with SHA-1 2fa2d083c7 is in history

Change-Id: Ided4107a507bbdea0c6fd9941a793f413d0068c2
2020-04-06 04:07:20 +00:00
Mark Chien
e0399b18ba Merge "Ethernet tethering: change char limit to NONE" into rvc-dev 2020-04-06 04:04:07 +00:00
TreeHugger Robot
9643b9c727 Merge "Hide unprovisioned MDN (phone number) at select profile dialog" into qt-qpr1-dev 2020-04-06 03:49:07 +00:00
Tim Peng
85055801fe No feedback when attempting to transfer to an unpowered BT device
-Set title and subtitle when connecting state changes
-Add test cases

Bug: 152606143
Test: make -j42 RunSettingsRoboTests
Change-Id: I1c482e8f45752d658d7898de760594fd3ec7164d
2020-04-06 01:19:28 +00:00
Howard Chen
9266fe32f7 Add security patch level check in DSULoader
There's an enforced check enabled in locked devices. It requires
the installed DSU to have a security patch level equal or higher
than the device. This CL adds the SPL check in the DSULoader.

Bug: 151790609
Test: Developer Settings -> DSULoader
Change-Id: Ifef4175e846f58d8033cf161d7fec8481dc0532b
2020-04-05 06:21:09 +00:00
PO HUNG CHEN
9ba7fa975b Merge "Hide the DSULoader when DSU is running" into rvc-dev 2020-04-05 06:20:36 +00:00
Howard Chen
01871ab415 Hide the DSULoader when DSU is running
Bug: 151792130
Test: open developer settings and check the DSULoader
    make -j32 RunSettingsRoboTests
Change-Id: I8f82e0f7ddbfd2c50ac6e2a2d3f61f7715ba452c
2020-04-05 11:42:20 +08:00
Jason Hsu
68084f39d0 Merge "Show empty options in shortcut chooser dialog if shortPreference is unchecked." into rvc-dev 2020-04-04 14:44:17 +00:00
Bill Yi
8c858cf56e [automerger skipped] Import translations. DO NOT MERGE am: 9f8e7a90d8 -s ours
am skip reason: subject contains skip directive

Change-Id: I56faa3d75fa435afdd997c01e8ad45716c7dabc4
2020-04-04 06:56:15 +00:00
Bill Yi
9f8e7a90d8 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: Iced480939d3fa27302bdbe2a6701220c61e9511f
2020-04-03 21:52:12 -07:00
Julia Reynolds
c7a77f6065 Update history flow
So the screens are more clear when you don't have history
items yet

Test: manual
Fixes: 150211282
Change-Id: Icf1dded3e92ed2121e18bf9a35d570f9efcfda62
2020-04-03 21:00:58 +00:00
TreeHugger Robot
0367ab9c1f Merge "[Wi-Fi] Rename 'open network' to 'public network'" into rvc-dev 2020-04-03 13:20:06 +00:00
Arc Wang
e3199b8c11 Merge "[Wi-Fi] Fix exception when 'Add device' with a Wi-Fi suggestion network" into rvc-dev 2020-04-03 12:52:14 +00:00
kholoud mohamed
a8bd1bea4e Add metrics for the cross profile settings page
Also changed the install banner to not say "Tap to
install" if the intent to redirect to Play is missing.

Bug: 149774826
Test: tested manually that the metrics are being reported by running
./out/host/linux-x86/bin/statsd_testdrive 103

Change-Id: Ieebda237748b5dbff8e974465c5d67b147d92077
2020-04-03 11:21:10 +00:00
TreeHugger Robot
710fd22f81 Merge "Turn on location dialog when using twilight scheduling" into rvc-dev 2020-04-03 08:03:41 +00:00
Peter Wang
6758ca661e Hide unprovisioned MDN (phone number) at select profile dialog
Bug: 151773922
Fix: 151773922
Test: Build
Change-Id: If84600cc426fefcdd219c4a44a5510b8db5c0a89
Merged-In: If84600cc426fefcdd219c4a44a5510b8db5c0a89
2020-04-03 00:09:39 -07:00
Peter Wang
14c5ea7b15 Merge "Hide unprovisioned MDN (phone number) at select profile dialog" into rvc-dev 2020-04-03 03:49:49 +00:00
Jay Aliomer
59c03c23b7 Turn on location dialog when using twilight scheduling
Night light and Dark theme scheduling does not work when in
twiligth mode. For the reason, we added a dialog to inform the user
that they need to turn on location services first.

Fixes: 153115618
Fixes: 153115261
Test: manual
Change-Id: Iea51018a7caba5c0ec93e058ee047d067bc03867
2020-04-03 03:45:20 +00:00
TreeHugger Robot
5acd959e9e Merge "Add a new developer options screen for shared data." into rvc-dev 2020-04-02 20:13:28 +00:00
Varun Shah
7efe9315ba Add a new developer options screen for shared data.
Add a new Storage section in the developer options menu which has a
new Shared Data preference. This preference screen shows all shared data
blobs on the device. There is also a new screen for each data blob which
shows all of the packages which currently have a leases on it. This
screen also has a button to delete the shared data blob.

Bug: 150626561
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: Id84a33dc7eeac493b2f81d3996ad24ee70557a07
2020-04-02 10:07:47 -07:00