Commit Graph

4081 Commits

Author SHA1 Message Date
Bonian Chen
d7e52888b4 Merge "[Settings] Manual network select without aggregate" 2019-11-05 05:33:53 +00:00
Bonian Chen
ef1481f589 [Settings] Manual network select without aggregate
Remove the feature of aggregation when performing manual network
selection.

Bug: 141287649
Test: Manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=NetworkSelectSettingsTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=NetworkOperatorPreferenceTest

Change-Id: I813ad31f9d5cf310877442f5558e236671ab5d23
2019-11-05 04:19:30 +00:00
Kevin Chyn
7bd69425ab Merge "Revert "Remove attention controller"" into qt-qpr1-dev am: 1876b8c6dd
am: ca51533d56

Change-Id: I7f1e7b3ddc83ce806d826bfd2ff40b89c44bc386
2019-11-01 10:14:32 -07:00
Kevin Chyn
ca51533d56 Merge "Revert "Remove attention controller"" into qt-qpr1-dev
am: 1876b8c6dd

Change-Id: I5282deec73015da2920c0b429e1e23c5f97d4fbe
2019-11-01 10:06:20 -07:00
Raff Tsai
68927639ee Remove mVideoPaused from VideoPreference
- We destoryed the MediaPlayer when VideoPreference is onPause().
When VideoPreference is onResumed, MediaPlayer always start from
pause state, we don't need a data save/restore current video state.

Bug: 143270527
Test: robolectric, manual
Change-Id: I544e933e4237f6d92aeff8a7eb04b52e89d74a4a
2019-11-01 10:44:47 +08:00
Kevin Chyn
eac6fcff2d Revert "Remove attention controller"
Bug: 142979808

This reverts commit 8e1d1ca3ab.

Change-Id: I78b7572bcb384de2984f4d81946aceb03aec6758
2019-10-31 20:50:35 +00:00
Xin Li
c73fd84126 DO NOT MERGE - qt-qpr1-dev-plus-aosp-without-vendor@5915889 into stage-aosp-master
Bug: 142003500
Change-Id: Ibae6b218a616a93cfda05dd77a5ea6f3a2dc4cea
2019-10-30 11:49:56 -07:00
TreeHugger Robot
fe5b2d9624 Merge "Remove permission bar chart in Privacy setting" 2019-10-30 02:20:23 +00:00
Josh Hou
0fe6fc26ad Merge changes Ibec13fbe,If89c67c0 am: 27bf33e053 am: e8a6c02fd2
am: 03c9ec1223

Change-Id: I8dc1754d631ac16a99e1c92776a2756ca5b8269e
2019-10-28 05:43:11 -07:00
Josh Hou
e2cdd74174 Fix ViLTE is not available when WiFi Calling is disabled
Bug: 141831293
Test: 1. Set carrier config carrier_wfc_ims_available_bool to false,
then verify Wi-Fi calling option is not shown.
      2. Set carrier config carrier_vt_available_bool to false, then
      verify video calling option is not shown.
      3. Set both carrier_wfc_ims_available_bool and
      carrier_vt_available_bool to false, then verify calling category
      is not shown.

Change-Id: Ibec13fbeb5acf1d62342286687b2ba969beb4e14
Merged-In: Ibec13fbeb5acf1d62342286687b2ba969beb4e14
2019-10-28 11:12:49 +00:00
Tsung-Mao Fang
ab914adc00 Remove permission bar chart in Privacy setting
- Because permission hub is already postponed,
we don't need to show this UI in privacy settings.

Test: Rebuild, visual, robotest
Change-Id: I51aca52bc605a3c6b0cafc084e8e491c280d770f
Fix: 143447873
2019-10-28 19:00:44 +08:00
Tsung-Mao Fang
327dba2488 Fix UI janky in privacy settings
Set a summary holder for initial preference at the biginning.
If there is no any permission granted, then set a string for it.

Test: Rebuild, visual
Fixes: 140783222
Change-Id: Ic5f2730123110bad5fbc08fcd22b1df564b8637d
2019-10-28 18:39:11 +08:00
Alex Johnston
8ec3dbe1ea Merge "Added a warning dialog when installing a CA certificate" 2019-10-25 09:34:41 +00:00
Josh Hou
ad4895f9db Merge "Fix ViLTE is not available when WiFi Calling is disabled" 2019-10-25 05:40:08 +00:00
Alex Johnston
c0c75a3e96 Added a warning dialog when installing a CA certificate
This is part of the changes to improve the UX and language for installing certificates.
Previously, the different types of certificate used the same installation flow.
Due to concerns around users installing CA certificates without understanding the conseqences,
this CL introduces a new warning dialog when a CA certificate is installed from settings.

Bug: 139173976
Test: Atest com.android.settings.security
      manual testing from Settings by selecting the certificate type
	preference and ensuring the installation flow still worked as expected.

Screenshot of the screen: https://hsv.googleplex.com/5046848484016128

Change-Id: If95bffd1e68f14734fb20e8cc4b60eeb1c372358
2019-10-24 15:25:52 +01:00
Josh Hou
c101faeb2b Fix ViLTE is not available when WiFi Calling is disabled
Bug: 141831293
Test: 1. Set carrier config carrier_wfc_ims_available_bool to false,
then verify Wi-Fi calling option is not shown.
      2. Set carrier config carrier_vt_available_bool to false, then
      verify video calling option is not shown.
      3. Set both carrier_wfc_ims_available_bool and
      carrier_vt_available_bool to false, then verify calling category
      is not shown.

Change-Id: Ibec13fbeb5acf1d62342286687b2ba969beb4e14
2019-10-24 18:25:37 +08:00
Alex Johnston
7659e53a94 Added functionality to select type of certificate to be installed from the Settings app
This is part of the changes to improve the UX and language for installing certificates.
Previously, the different types of certificate used the same installation flow. This CL
introduces a new settings page, where the type of certificate to be installed can be selected.

Bug: 139173976
Test: Atest com.android.settings.security
      manual testing from Settings by selecting the certificate type
	preference and ensuring the installation flow still worked as expected.

Change-Id: Iea7c91aa3801e429f0e22d29469958f4151b3cba
2019-10-24 10:37:21 +01:00
govenliu
6a9afea52e [Wi-Fi] Update "Factory MAC" to "Device MAC" in strings.
As a follow-up to b/133466540, we should change "Factory MAC" to "Device MAC" in the strings to align with the language that we used for Q.

Sol: change the string naming.

Bug: 143151237
Test: Manual visual test to check if the strings changed correctly or not.
Change-Id: I0bba14d12d5d0ab2fa0c137e4576dd46878df031
2019-10-23 10:23:35 +08:00
Bonian Chen
5cc9aad7a8 [Setting] Cleanup Unused SimSettings
There's no entry to access SimSettings.
Remove this unused UI.

Bug: 131324863
Test: manual
Change-Id: I3f50e528eb409215371a125184502d3531bad0a8
2019-10-20 09:01:30 +00:00
TreeHugger Robot
5302874d6b Merge "[Wi-Fi] Fix Wi-Fi hotspot two line summary UI problem" 2019-10-16 08:44:32 +00:00
TreeHugger Robot
56aa5f831d Merge "Update string" 2019-10-16 08:43:50 +00:00
Arc Wang
7a21676938 [Wi-Fi] Fix Wi-Fi hotspot two line summary UI problem
Use summary_placeholder instead of summary_two_lines_placeholder.

Bug: 131985486
Test: visual
Change-Id: I7ebac1fcbcbe23dec0c624a75a7cb4fecf537a57
2019-10-16 07:53:27 +00:00
Raff Tsai
65866290ce Add tablayout for work/personal profile
- Add Tablayout in ProfileSelectFragment
- Add AccountWorkProfileDashboardFragment inherited from
ProfileSelectFragment
- Add ProfileFragmentBridge to convert AccountDashboardFragment
to AccountProfileSelectFragment
- Use flag settings_work_profile to guard the new fragment

Bug: 141601408
Test: Settings->developer options->feature flags->
turn settings_work_profile on/off, then go to settings->account
to see if UI is changed.

Change-Id: Ifb32c22cdeab69c51517664081cacf4a401c46a1
2019-10-15 18:01:08 +08:00
hughchen
946c6f0dfe Update string
Change the headers from:
"Available media devices" → "Media devices"
"Available call devices" → "Call devices"
"Currently connected" → "Other devices"

Bug: 110920548
Test: manually
Change-Id: Idf283576353c9f65caa15ba8beca39f24721caa5
2019-10-14 16:16:24 +08:00
Bonian Chen
fb8eca412d [a11y] Set "Settings version" as non-double-tap
Disable the selectable configuration on preference
to avoid TalkBack read "double-tap to activate".

Bug: 141588828
Test: Manual test
Change-Id: Icd666792e6d86998d11168b62ab99e3c3412d747
2019-10-09 14:29:26 +08:00
Bonian Chen
c625f62122 Merge "[RadioInfo] Remove from Settings (into Telephony)" 2019-10-08 10:20:34 +00:00
Bonian Chen
b7633cc59d [RadioInfo] Remove from Settings (into Telephony)
Moving RadioInfo and BandMode to Telephony app.

Bug: 123598192
Test: Manual test
Change-Id: Id62a2bf4b2c44efcd48319734d1cab6ed969ee06
2019-10-08 06:49:18 +00:00
Julia Reynolds
3ecbafd8fc Allow settings title to wrap
Test: manual
Fixes: 141290268
Change-Id: I4e64b693fa213aca6cab6307c4a9177bfa7d7bdd
2019-10-07 10:42:29 -04:00
TreeHugger Robot
4fd6f5c7a1 Merge "Fix a11y issue for the Preferences in the "Android version" Talkback should not speak "double-tap to activate"." 2019-10-05 03:40:34 +00:00
Stanley Wang
9d3f8c435f Fix a11y issue for the Preferences in the "Android version"
Talkback should not speak "double-tap to activate".

Set the preference selectable attribute to false.

Test: manual
Fixes: 139709914
Change-Id: If4d6dd480740f4225b1e2932e7838c14a01cf8e5
2019-10-04 17:18:29 +08:00
Goven Liu
834c301139 Merge "[Wi-Fi] Wrong MAC address shown in Settings." 2019-10-04 01:13:03 +00:00
Raff Tsai
a80a7c16f2 Merge "Remove summary provider" 2019-10-03 15:23:21 +00:00
govenliu
228cf200ae [Wi-Fi] Wrong MAC address shown in Settings.
The MAC addresses in "About phone" and "Saved networks" may be different
because of new Randomized MAC mechanism.

1.Add new UIs to guide users to saved network and use different titles to
show different conditions.
2.Remove MAC address and IP fields in WifiPreference by new design.

Bug: 133466540
Test: add test case to check if the title changed according to the
privacy level.

Change-Id: Idb5972dc2565f6fe58a83f6aa7124abbc035888f
2019-10-03 19:36:58 +08:00
Stanley Wang
73a36b1704 Merge "Fix a11y issue for the Preferences in the "Model & hardware" Talkback should not speak "double-tap to activate"." 2019-10-03 10:00:11 +00:00
Raff Tsai
6db277ebb7 Remove summary provider
- use SummaryProvider to provide the summary of UserSettings
- use WifiDisplayPreferenceController to replace the summary loader
in WifiDisplaySettings
- use ConfigureNotificationPreferernceController to replace the
sumary load in ConfigureNotificationSettings

Fixes: 141653158
Test: robolectric
Change-Id: Id5f5ed645707caa0b25ecae5252174cbf017651c
2019-10-03 15:04:36 +08:00
Stanley Wang
fb2d059c6d Fix a11y issue for the Preferences in the "Model & hardware"
Talkback should not speak "double-tap to activate".

Set the preference selectable attribute to false.

Test: manual
Fixes: 139709361
Change-Id: Ifc3dfcb25fa7aa74f71c79d182668bcfbae31bee
2019-10-03 13:13:58 +08:00
TreeHugger Robot
616707f486 Merge "Fix talkback issue of Caption preference" 2019-10-02 08:03:41 +00:00
Raff Tsai
9e3a9fd255 Add fragment in xml instead of using injected way
- It can improve performance because we use less injected item
- Also remove summary provider from those fragments

Bug: 141653158
Test: robolectric
Change-Id: I6255f71b3b8300aea064a4fefd6711c1ff59e08a
2019-10-02 11:49:51 +08:00
Mill Chen
0a8fca1ee1 Fix talkback issue of Caption preference
Talkback speaks "double-tap to activate" on the LayoutPreference in the
Caption preference page, but it doesn't have any action after double
tap. So it should be set to unclickable. Set android:selectable to
false to fix it.

Fixes: 141900530
Fixes: 141901515
Test: launch TB and test it by manually
Change-Id: I82720dc46085b84d188730545061269d110f9a7c
2019-10-02 11:29:07 +08:00
Felipe Leon
e42ab42c5c Settings: fix apn_editor carrier_enabled summaryOff string
Change-Id: I44ccec73601806dc8facad122f1ab16ff3aca484
Signed-off-by: Felipe Leon <fglfgl27@gmail.com>
2019-09-25 00:43:17 +03:00
TreeHugger Robot
2ced8d8f00 Merge "Use FooterPreference in xml to replace the header" 2019-09-24 01:51:46 +00:00
Sunny Shao
2c4827be08 Use FooterPreference in xml to replace the header
Fixes: 141450664
Test: manual test
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.enterprise
Change-Id: Ia6ec0e363b9a472ff104ffbc529856a21840af27
2019-09-23 17:29:06 +08:00
TreeHugger Robot
93343d0ccd Merge "Add search key word for Profile HWUI rendering" 2019-09-23 07:08:42 +00:00
Tsung-Mao Fang
a257ca8a07 Add search key word for Profile HWUI rendering
Test: Rebuild, and see the search result
Fixes: 141096384
Change-Id: Ic25eb9f4b7bbffd33323eabbb80092d620d8da17
2019-09-23 14:06:37 +08:00
Tsung-Mao Fang
fcefb143f3 Show "Display over other apps" in search
Since there're same two keys in settings app,
search indexes this preference fail.

Test: Rebuild, and see search result again.
Bug: 141096384
Change-Id: I8b1edfe1728b44d98d59ba2e790b29e33901308a
2019-09-23 13:44:51 +08:00
Stanley Wang
9cbca4bcee Fix can't find the search result by input "4G Calling"
Add indexable raw data for type 4G_CALLING or ADVANCED_CALL and
set the volte to non-indexable if current type is not volte.

Fixes: 137155154
Test: manual

Change-Id: I0992f9fb95e0b1cc23fb4f38f356ee0569f3b5b1
2019-09-19 19:21:16 +08:00
Sunny Shao
bf4349733d Clean FooterPreferenceMixin and FooterPreferenceMixinCompat
Fixes: 124129485
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.core
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.SettingsPreferenceFragmentTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.bluetooth
Change-Id: I920d0de403b9c7109de0e2e53be7ed99bc8e7390
2019-09-04 13:54:19 +08:00
Sunny Shao
b34eeffd94 Remove the unused file
Remove the unused file power_usage_details.xml.
This xml was used in the PowerUsageDetail.java but PowerUsageDetail was removed now.

Fixes: 140403988
Test: Compilation
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.fuelgauge
Change-Id: I11577585eb31aa6f373bef85635f2b87d1636e0c
2019-09-03 10:09:31 +00:00
Sunny Shao
b47cccf6a0 Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the DeviceAdminSettings page.

Fixes: 140015273
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.applications
Change-Id: I91c10946ae35f9a5cde30399e231dbc8a1481b23
2019-08-27 10:41:13 +08:00
Sunny Shao
7687e0b17d Use FooterPreference in xml explicitly
Removed the FooterPreferenceMixin from the UserSettings page.

Fixes: 140008560
Test: manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.users
Change-Id: If6da2bd2f6a72d8e61b8c8bca9e3179cfdee05e6
2019-08-26 17:08:31 +08:00