Commit Graph

8 Commits

Author SHA1 Message Date
Sunny Shao
b7734a754b Add the checkstyle_hook into PREUPLOAD.cfg
Check the unused import and the sequence of import before submitting.

Fixes: 142160947
Test: Manual test
Change-Id: I846f4ab5f349f0017163cf9d35b4d44e85597bbc
2019-10-14 21:03:17 +08:00
Fan Zhang
4b2c171288 Add string linter preupload check
Bug: 76097999
Test: repo upload
Change-Id: Ieb31c931d73a4325f605963b374ca7a2d568e08c
2018-03-26 21:38:34 -07:00
Fan Zhang
2edbaa7062 Change print setting from a dynamic tile to static pref
...because dynamic tile is a lot harder to index correctly.

- Removed metadata that makes PrintSettings a dynamic tile.
- Added PrintSettings into connected_device xml.
- Added a new PreferenceController - all summary updating logic is
  copied from PrintSettingsFragment

Change-Id: I41e7c9d23e97ecd5a043ac7c33f2d404260c92e7
Fixes: 73128944
Test: robotests
2018-02-12 15:19:43 -08:00
jackqdyulei
01c13b7abd Enable the color lint check
We disabled color check because the error message was
ambiguous when the android environment hadn't been set
up.

Since the error mesage has been updated, we can turn it
back on.

Bug: 65850237
Test: repo upload .
Change-Id: I9517192b8b7d8131014e3ac44e3edb2d97134bb6
2017-09-18 17:01:23 -07:00
jackqdyulei
965a22d569 Disable the color lint check
Bug: 65850237
Test: Manual
Change-Id: If92b6490d92463d65302408e0288e6af93b97cbe
2017-09-18 15:15:08 -07:00
jackqdyulei
5024a38965 Hook up lint color check to settings
After this cl, settings will run hardcoded color check
(go/color-check-guideline) for all the cls in pre-upload.

This check will prompt error message if cl contains hardcoded color.

Bug: 32750778
Test: repo upload .
Change-Id: Id35ded5199094a14fcc4eeebc470164d052e278e
2017-09-15 11:45:21 -07:00
Aurimas Liutikas
7764709ca6 Point to the new checkstyle location for packages/apps/Settings PREUPLOAD hook.
This change depends on r.android.com/314437

Bug: 33666900
Test: None
Change-Id: Ibcf177186e64e7e34493301f109ea9d4454fa3a2
2016-12-15 15:06:04 -08:00
Philip P. Moltmann
50b3488d0d Add preupload to Settings.
Test: Uploaded
Change-Id: I454df2797ac7314060646c66c6caf2538d36b1d0
2016-10-20 17:22:33 -07:00