Commit Graph

144161 Commits

Author SHA1 Message Date
Yiyi Shen
d375984779 Merge "[Audiosharing] Use DialogFragment instead of raw AlertDialog" into main 2024-09-26 02:49:38 +00:00
Abdelrahman Daim
996afd17a1 Protect the Settings application from potential null pointer exceptions.
Summary: The app bar is not available, causing a null pointer exception.

Test: Successful Build on master branch

Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-25 17:02:37 -07:00
Treehugger Robot
e3bc83b7b0 Merge "Fixed elapsed_time_millis in SettingsUIChanged event" into main 2024-09-25 23:55:49 +00:00
Yi-an Chen
781cbcdbf0 Merge "Correct behavior on Google Location History preference click" into main 2024-09-25 20:27:33 +00:00
David Liu
2f39a808fc Fixed elapsed_time_millis in SettingsUIChanged event
This change stores timestamp when received com.google.android.setupwizard.SETUP_WIZARD_FINISHED. This timestamp will be used to calculate elapsed_time_millis for SettingsUIChanged event after SUW complete. This enables to analyze how the user uses Settings in a specific time span after setup.

Bug: 344466251
Test: metrics related change only
Flag: EXEMPT metrics change only

Change-Id: I85b15f1eb5e5a4502a27d8588bb01e59b7ad83b5
2024-09-25 18:44:26 +00:00
Treehugger Robot
d6f73f35b6 Merge "Update titles and summaries of the Date and time settings page" into main 2024-09-25 16:54:05 +00:00
Geoffrey Boullanger
8b7399a8d9 Update titles and summaries of the Date and time settings page
Design doc: go/dd-android-settings-time-2024

This change covers Part 1, which consists of adding user-friendly summary under each toggle and rewording titles.

Bug: 296835792
Test: on-device and atest
Flag: EXEMPT resource only update
Change-Id: I0b685743599880fc1c4ad680eca9c36e4e64d0ff
2024-09-25 15:19:10 +00:00
Jason Chang
91dd9af87f Fix Fingerprint setup complete - illustration is just slightly cut off
Due to the sufficient space between sub-description and illustration,
modify the layout_marginTop to avoid the cut off problem.

Flag: NONE bug-fixing

Bug: 336981217

Test: build ABTD ROM and perform a visual inspection.
Change-Id: Id69549968341ee59e3cb7ee8838a90fda7a78b3a
2024-09-25 15:01:24 +00:00
Haijie Hong
9b36ed51a2 Merge "Add icon for more settings preference" into main 2024-09-25 10:37:04 +00:00
Haijie Hong
684ec23cad Merge "Add metrics category for more settings fragment" into main 2024-09-25 10:36:29 +00:00
Yiyi Shen
54b0d18a04 [Audiosharing] Use DialogFragment instead of raw AlertDialog
FragmentManager can help manage the state of the dialog and automatically restore the dialog when a configuration change occurs

Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858921
Change-Id: If63c7891cfb92e06c457e37eb5556f3eaf3f6121
2024-09-25 17:31:14 +08:00
Yiyi Shen
57355a0743 [Audiosharing] Show dialogs when lifecycle isAtLeast STARTED
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 305620450
Change-Id: I34f4f46b9377f1e3ec1a4cd27687c14d674f6da4
2024-09-25 17:13:19 +08:00
Haijie Hong
63ecd2781f Add icon for more settings preference
BUG: 343317785
Test: atest DeviceSettingRepositoryTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Id7c272edce5ff8166f03b7162ac9ba5ff1f15097
2024-09-25 09:02:07 +00:00
Haijie Hong
fc27dcccde Add metrics category for more settings fragment
BUG: 343317785
Test: local tested
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I21a3ca0deea516765f1af2f5d7117b6c3c1763a7
2024-09-25 16:17:48 +08:00
Haijie Hong
7e7530bfd1 Merge "Fix two-panel issue in tablet" into main 2024-09-25 07:36:43 +00:00
Jacky Wang
09289058d1 Merge "Avoid potential ActivityNotFoundException" into main 2024-09-25 06:27:26 +00:00
Haijie Hong
1020e7132d Fix two-panel issue in tablet
Keep the logic same as BlockingPrefWithSliceController.

BUG: 343317785
Test: atest BluetoothDeviceDetailsViewModelTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I77e62479def433869ae5e93987ec7069cc61173a
2024-09-25 13:48:33 +08:00
Yiyi Shen
28d1551870 Merge "[Audiosharing] Apply new string resid" into main 2024-09-25 05:19:49 +00:00
Treehugger Robot
fc2ccb61fd Merge "Use hasScrollAction in ApnEditPageProviderTest" into main 2024-09-25 04:00:01 +00:00
Jacky Wang
1c486036ef Avoid potential ActivityNotFoundException
Bug: 332202168
Flag: com.android.settings.flags.catalyst
Test: Manual
Change-Id: I74d7bbc9eb34e0f8d04cfb663b04393a3432e784
2024-09-25 11:58:10 +08:00
Treehugger Robot
00c90b0e6f Merge "Migrate Android version preference" into main 2024-09-25 03:30:59 +00:00
Chaohui Wang
0b530fd405 Use hasScrollAction in ApnEditPageProviderTest
Instead of assuming a fixed tree structure in testing.

Fix: 369416630
Flag: EXEMPT gradle only
Test: atest ApnEditPageProviderTest
Change-Id: I0a50e7665d9049e089b5a0877f17d1f736ee3332
2024-09-25 10:26:47 +08:00
Menghan Li
26392847f0 Merge "refactor(brightness suw): decouple auto brightness initialization logic for setup flow" into main 2024-09-25 01:23:55 +00:00
Yi-an Chen
73ab82f52f Correct behavior on Google Location History preference click
Fixes: 366060896
Bug: 360240563
Flag: EXEMPT bugfix
Test: Manually and RecentLocationAccessPreferenceControllerTest
Change-Id: Ibe3c49c3060bcc0967f93a3a88aa45b04ab8a41d
2024-09-25 01:23:52 +00:00
Treehugger Robot
adb3d1f1d4 Merge "Migrate the Legal Info page to Catalyst" into main 2024-09-25 00:39:10 +00:00
Dongzhuo Zhang
c51a76014a Merge "Add contacts storage setting entry in app settings page." into main 2024-09-25 00:20:32 +00:00
Jacky Wang
4329d8371e Migrate Android version preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I0a15cd460543a7dd84edc5c3a5a2ff900aeba13f
2024-09-25 07:28:52 +08:00
Dongzhuo Zhang
6231453e91 Add contacts storage setting entry in app settings page.
Test: atest SettingsRoboTests:com.android.settings.applications.contacts.ContactsStoragePreferenceControllerTest

Bug: 368641291
Flag: com.android.settings.flags.enable_contacts_default_account_in_settings

Change-Id: I8da16f24b17e44dc0ea417cffabd85c36d7edc5f
2024-09-24 22:28:22 +00:00
Treehugger Robot
b0081ba478 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-24 21:11:00 +00:00
Treehugger Robot
35740d2542 Merge "Fix for GestureShortcutOptionControllerTest" into main 2024-09-24 20:19:20 +00:00
Julia Reynolds
2fe4cb6393 Merge "Make legacy DND pages not searchable" into main 2024-09-24 20:19:17 +00:00
Abdelrahman Daim
3be2314fac Add a check to ensure that intent data is available before proceeding.
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.

Test: Successful Build on master branch

Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-24 12:21:22 -07:00
Riley Jones
214af3c7d2 Fix for GestureShortcutOptionControllerTest
Flag: android.provider.a11y_standalone_gesture_enabled
Bug: 368704597
Test: atest GestureShortcutOptionControllerTest
Change-Id: I8736fe5f79ea527702640087de1f9b7fcc9a046a
2024-09-24 18:36:30 +00:00
Julia Reynolds
0c5eb711a9 Make legacy DND pages not searchable
Flag: EXEMPT unflaggable
Fixes: 341726633
Test: manual, searching in settings
Change-Id: I592a1775a890711086db1099fb333c1dc1a11e0b
2024-09-24 15:18:16 +00:00
Sunny Shao
e060aeb1e1 Migrate the Legal Info page to Catalyst
Test: atest LegalPreferenceTest
Test: atest LegalSettingsScreenTest
Test: atest WallpaperAttributionsPreferenceTest
Bug: 360061554
Flag: com.android.settings.flags.catalyst_legal_information
Change-Id: Ic15384e853584b72a847e1a10713a0c3c29273a7
2024-09-24 23:15:27 +08:00
Jacky Wang
d8c0c543bf Merge changes from topic "catalyst-firmware-version" into main
* changes:
  Migrate Android security update preference
  Migrate mainline module version preference
2024-09-24 12:25:38 +00:00
Jacky Wang
84d31c2ad9 Migrate Android security update preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I745358d8dfc17b68535336653a149c334b266c91
2024-09-24 17:49:30 +08:00
Yiyi Shen
82154a15e2 Merge "Revert^2 "Fix text alignment in RTL mode for volume sliders"" into main 2024-09-24 09:28:01 +00:00
Jacky Wang
b8d2bc12b1 Migrate mainline module version preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I1f3f69b08fe22c66d1b1c6786f9cd7e7ff413529
2024-09-24 16:52:13 +08:00
Andreea Costinas
a4b2757458 Merge "[Settings] Fix color contrast on alert dialogs" into main 2024-09-24 07:42:07 +00:00
Menghan Li
e0f734526d refactor(brightness suw): decouple auto brightness initialization logic for setup flow
The AccessibilitySettingsForSetupWizard class should not be responsible for managing the initial
logic of controllers, such as determining which controllers need to be dynamically added or updated
using setInSetupWizard APIs. This logic should be handled directly by the controllers themselves.

Bug: 311093618
Flag: EXEMPT bugfix
Test: atest AccessibilitySettingsForSetupWizardTest
            AutoBrightnessPreferenceControllerForSetupWizardTest
            AutoBrightnessPreferenceControllerTest
            BrightnessLevelPreferenceControllerForSetupWizardTest
            BrightnessLevelPreferenceControllerTest

Change-Id: I6065a10e72d002981c0f514543e6933d79c2aa1b
2024-09-24 05:41:23 +00:00
Treehugger Robot
658459de9b Merge "Fix for broken tests in Accessibility Settings" into main 2024-09-24 02:58:07 +00:00
Bill Yi
316d69ddc9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I342e197f2cc9977b7c82a63cd24740015c957c9b
2024-09-23 18:46:03 -07:00
Riley Jones
62449dd61b Fix for broken tests in Accessibility Settings
Updates tests that were broken by the rollout of the standalone_a11y_gesture_enabled flag

Test: atest com.android.settings.accessibility
Bug: 368704597
Flag: android.provider.a11y_standalone_gesture_enabled
Change-Id: Ie90e7495dd4a134538bae6e3e08eea0d02134b14
2024-09-23 23:24:25 +00:00
Maryam Dehaini
6a6a3efe57 Merge "Change "Open by default" setting page selection to radio buttons" into main 2024-09-23 22:45:07 +00:00
Maryam Dehaini
11825b0bc7 Change "Open by default" setting page selection to radio buttons
Selection to open page in app or browser needs to be displayed via radio
buttons as discussed here: http://b/346622495#comment14

Bug: 359262490
Test: Open links in app and browser
Flag: EXEMPT small UI change
Change-Id: Ib23084bcc7f899b97b59019775584807e5b70d7e
2024-09-23 14:32:08 -07:00
Jacky Wang
9cdd1108c3 Merge changes from topic "catalyst-firmware-version" into main
* changes:
  Migrate "Build number" preference
  Migrate "Kernel version" preference
  Migrate "Baseband version" preference
2024-09-23 15:44:09 +00:00
Adam Bookatz
072d0d84ec Merge "OnDeviceRecognition shows only profile group" into main 2024-09-23 15:41:41 +00:00
Andreea Costinas
d9f36f94f7 [Settings] Fix color contrast on alert dialogs
This change updates the light theme color roles for alert dialogs.

Bug: b/338311586
Test: emulator
Flag: EXEMPT resource only update
Change-Id: Ie4bd5accd9a775d49d8559b10124f81486c72b8e
2024-09-23 15:16:47 +00:00
Zoey Chen
bedfb69f67 Merge "[Settings] Fix crash" into main 2024-09-23 13:02:59 +00:00